I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
* Made nullptr checks consistent (the plurality of the changes are of this type)
* Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
* Removed unused variables
* Removed redundant initializations
* WidgetNavigationCustomization.cpp was fixed by the owner
* integers converted to floats where result was stored in a float
* Removed redundent null checks (e.g. before delete statements)
* Renamed variables to prevent non-obvious shadowing
* Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
* Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)
[CL 2498053 by Dan Oconnor in Main branch]
* Multicast delegate Add* calls now return FDelegateHandles, and Remove* calls are now all deprecated, except for a new Remove function which takes a FDelegateHandle.
* New FConsoleManager::RegisterConsoleVariableSink_Handle and UnregisterConsoleVariableSink_Handle functions which work in terms of FConsoleVariableSinkHandle.
* Timer calls which don't take FTimerHandles are deprecated.
* FTicker::AddTicker now returns an FDelegateHandle and is removed by an overloaded Remove function.
* DEFINE_ONLINE_DELEGATE* macros now define _Handle variants of the Add/Remove functions which return/take handles.
* Various other handle-based registration changes.
* Some unity build fixes.
* Some simplification of delegate code.
* Fixes for lots of existing code to use handle-based registration and unregistration.
#codereview robert.manuszewski
[CL 2400883 by Steve Robb in Main branch]
- Misc tweaks to make profiler more base on the new stats system
- Added a new view mode to the data graph, for the regular stats file it will be LineIndexBased, for the raw stats file it will be ThreadViewTimeBased
- Added profiler stream, a new class that will hold all data read from the raw stats file, hopefully will replace the current profiler data provider/ data source later
- Added basic support for the second profiler view mode
[CL 2054275 by Jaroslaw Surowiec in Main branch]
- Fixed profiler
- Increased stack size used to generate the profiler event graph
- Fixed a problem with tracking default stats when the metadata is not ready
#codereview Robert.Manuszewski
[CL 2048708 by Jaroslaw Surowiec in Main branch]
- Added first version of the profiler mini-view
- Switched to SCOPE_LOG_TIME when measuring profiler's performance
- Misc fixed how the stats metadata is handled by the profiler
- Game thread is tracked by default
#codereview Robert.Manuszewski
[CL 2046766 by Jaroslaw Surowiec in Main branch]
Jaroslaw Surowiec
PaulEremeeff
Marc Audy
Steve Robb
Ben Marsh
UnrealBot
Tim Sweeney