Commit Graph

872 Commits

Author SHA1 Message Date
Rolando Caloca
5b82f15def Copying //UE4/Dev-RenderPlat-Staging@11388153 to //UE4/Main
#rb none
#rnx

[CL 11388545 by Rolando Caloca in Main branch]
2020-02-12 13:27:19 -05:00
dave belanger
e81e86fb8d Remove TEXT_STYLE_NDC logs
#rb none
[FYI] Bob.Telez


#ROBOMERGE-SOURCE: CL 11307498 via CL 11307502
#ROBOMERGE-BOT: (v653-11302973)

[CL 11307504 by dave belanger in Main branch]
2020-02-10 13:21:44 -05:00
dave belanger
bf3aeb9c14 Logging to track text style NDC issue.
#rb Nick.Darnell


#ROBOMERGE-SOURCE: CL 11299792 via CL 11299795
#ROBOMERGE-BOT: (v647-11244347)

[CL 11299796 by dave belanger in Main branch]
2020-02-07 21:56:02 -05:00
josh gross
871052a863 Wiget::SetUserFocus: If we're able to set focus immediately, cancel any focus request that's waiting to be processed in the LocalPlayer's SlateOperations.
#rb [at]Dan.Hertzka



#ROBOMERGE-SOURCE: CL 11294962 via CL 11294963 via CL 11296120 via CL 11296175
#ROBOMERGE-BOT: (v647-11244347)

[CL 11296220 by josh gross in Main branch]
2020-02-07 16:36:51 -05:00
nick darnell
eaf38dd043 Slate - When prepassing children, if a child is collapsed we invalidate its prepass (so that we know we need to do it later), and we give that child its new scale, so that when it does prepass it prepasses when it becomes visible, with the new layout scale it missed because it was collapsed, this corrects issues with layout scale changing and collapsed text fields missing out on the new scale for prepass/CDS purposes - usually revealing themselves in rich text now correctly laying out, large gaps between blocks, or several overlapping blocks.
Slate - Deprecating float GetRelativeLayoutScale(const FSlotBase& Child, float LayoutScaleMultiplier), Long Live float GetRelativeLayoutScale(const int32 ChildIndex, float LayoutScaleMultiplier), you must also set bHasRelativeLayoutScale to true in your constructor for your SWidget if you need this function called.  This removes 2 virtual calls from almost every widget's prepass, and only now requires 1 for every widget that needs to implement GetRelativeLayoutScale, which very few actually do.

Matt.Kuhlenschmidt


#ROBOMERGE-SOURCE: CL 11291134 via CL 11291179 via CL 11291189 via CL 11291196
#ROBOMERGE-BOT: (v647-11244347)

[CL 11291217 by nick darnell in Main branch]
2020-02-07 09:51:26 -05:00
marc audy
ee7b1c0410 Allow slate events to bind lambdas which take additional parameters.
Add a move function for assigning a delegate to a slate event.
#jira
#rb Matt.Kuhlenschmidt, Steve.Robb


#ROBOMERGE-SOURCE: CL 11219715 via CL 11219751
#ROBOMERGE-BOT: (v644-11213502)

[CL 11241060 by marc audy in Main branch]
2020-02-04 22:20:51 -05:00
Chris Gagnon
c3f9a18841 Merge from Main in prep for Dev-Tools-Staging Copy up
#rb none

[CL 11221539 by Chris Gagnon in Dev-Tools-Staging branch]
2020-02-04 17:00:31 -05:00
Rolando Caloca
f63a3e857e Merging //UE4/Main@11178322 to Dev-RenderPlat-Staging
#rnx
#rb none

[CL 11195678 by Rolando Caloca in Dev-RenderPlat-Staging branch]
2020-01-31 10:34:10 -05:00
Jason Stasik
ed4ac80586 Revert 10883777, clamping negative scales in Slate layouts
#jira UE-87712
#rb none
#fyi vincent.gauthier

[CL 11189019 by Jason Stasik in Dev-Tools-Staging branch]
2020-01-30 18:00:40 -05:00
Chris Gagnon
76c6bcbfeb UE4 Main merged to Dev-Tools-Staging at CL 11164391
#rb none

[CL 11171981 by Chris Gagnon in Dev-Tools-Staging branch]
2020-01-29 20:39:37 -05:00
jordan cristiano
a3aa978f36 Changed spammy "Resetting cached element data" from a normal log to Verbose.
#rb andrew.ladenberger


#ROBOMERGE-SOURCE: CL 11162764 via CL 11162767 via CL 11162770
#ROBOMERGE-BOT: (v640-11091645)

[CL 11164921 by jordan cristiano in Main branch]
2020-01-29 14:14:26 -05:00
Max Chen
b4881d8bf8 Copying //UE4/Dev-Editor to Dev-Tools-Staging (//UE4/Dev-Tools-Staging) @11123875
#rb none
#jira none

[CL 11123880 by Max Chen in Dev-Tools-Staging branch]
2020-01-27 20:11:15 -05:00
nick darnell
12f10b22eb Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
Improved CSV stats we're tracking for cached elements.  This version should fix the issue with weakptrs getting corrupted.

Removing memstacks and using inline allocators with enough slack, the memstacks don't work as expected over multiple frames.

Cleaning up cached lists from the new array when the corresponding widget's handle is cleaned up.

#author Matt.Kuhlenschmidt
#editor Nick.Darnell
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt, Andrew.Ladenberger




#ROBOMERGE-SOURCE: CL 11068394 via CL 11068413 via CL 11068420
#ROBOMERGE-BOT: (v637-11041722)

[CL 11068429 by nick darnell in Main branch]
2020-01-20 16:30:39 -05:00
JeanMichel Dignard
7130d293f2 Merging main @ cl 11028482
#rb none
#rnx

[CL 11029060 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-16 10:24:38 -05:00
bob tellez
2f797bdf39 Back out changelist 10981122. Client crash
[FYI] Nick.Darnell


#ROBOMERGE-SOURCE: CL 11025062 via CL 11025214 via CL 11025315
#ROBOMERGE-BOT: (v633-10983880)

[CL 11025423 by bob tellez in Main branch]
2020-01-16 00:43:13 -05:00
jamie dale
0e7bcbbe75 Fixed fonts that contain both scalable and bitmap font data incorrectly applying extra scale to advance and kerning data
#jira UE-86704
#rb Matt.Kuhlenschmidt
#lockdown Cristina.Riveron

#ROBOMERGE-SOURCE: CL 10985791 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v632-10940481)

[CL 10985793 by jamie dale in Main branch]
2020-01-14 15:06:26 -05:00
JeanMichel Dignard
99b55fb883 Merged main @ cl 10981486
#rb none
#rnx

[CL 10985598 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-14 14:45:07 -05:00
nick darnell
2c5c6f23d5 Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
Improved CSV stats we're tracking for cached elements.  This version should fix the issue with weakptrs getting corrupted.

Removing memstacks and using inline allocators with enough slack, the memstacks don't work as expected over multiple frames.

#author Matt.Kuhlenschmidt
#editor Nick.Darnell
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt, Andrew.Ladenberger




#ROBOMERGE-SOURCE: CL 10981122 via CL 10981129 via CL 10981131
#ROBOMERGE-BOT: (v632-10940481)

[CL 10981133 by nick darnell in Main branch]
2020-01-14 09:34:05 -05:00
nick darnell
0b72677a36 Slate - Simplify the SWidget scope to just use anon variables.
#ROBOMERGE-SOURCE: CL 10951215 via CL 10951231 via CL 10951232
#ROBOMERGE-BOT: (v632-10940481)

[CL 10951234 by nick darnell in Main branch]
2020-01-13 09:37:47 -05:00
nick darnell
cf563e8faa Undo changelist 10949647
#ROBOMERGE-SOURCE: CL 10949682 via CL 10949683 via CL 10949684
#ROBOMERGE-BOT: (v632-10940481)

[CL 10949685 by nick darnell in Main branch]
2020-01-12 17:47:35 -05:00
nick darnell
0259841247 Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
Improved CSV stats we're tracking for cached elements.  This version should fix the issue with weakptrs getting corrupted.

Additional changes to try and solve issues with tests.

#author Matt.Kuhlenschmidt
#editor Nick.Darnell
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt, Andrew.Ladenberger




#ROBOMERGE-SOURCE: CL 10949647 via CL 10949648 via CL 10949649
#ROBOMERGE-BOT: (v632-10940481)

[CL 10949650 by nick darnell in Main branch]
2020-01-12 16:28:32 -05:00
jamie dale
c36736f346 Insert a substitute glyph for narrow nbsp and thin space if the font doesn't support them
This uses 2/3rd the width of a normal space, and also moves the handling of zwsp into a common point rather than duplicate it between the kerning a HarfBuzz shaping paths, as well as giving the composite font first refusal at handling all whitespace as it may have better metrics than our own approximation.

#jira UE-85612
#rb Lauren.Barnes
#lockdown Cristina.Riveron

#ROBOMERGE-SOURCE: CL 10927041 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v626-10872990)

[CL 10927044 by jamie dale in Main branch]
2020-01-09 10:40:50 -05:00
bob tellez
11b418ce16 Back out changelist 10906690. EdTest crash
[FYI] Nick.Darnell


#ROBOMERGE-SOURCE: CL 10911488 via CL 10911491 via CL 10911494
#ROBOMERGE-BOT: (v626-10872990)

[CL 10911496 by bob tellez in Main branch]
2020-01-08 18:03:44 -05:00
nick darnell
48a61ce08d Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
Improved CSV stats we're tracking for cached elements.  This version should fix the issue with weakptrs getting corrupted.

#author Matt.Kuhlenschmidt
#editor Nick.Darnell
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt, Andrew.Ladenberger



#ROBOMERGE-SOURCE: CL 10906690 via CL 10906695 via CL 10906699
#ROBOMERGE-BOT: (v626-10872990)

[CL 10906703 by nick darnell in Main branch]
2020-01-08 13:59:18 -05:00
JeanMichel Dignard
70d074639f Merging //UE4/Dev-Main @ 10886849 to Dev-Tools-Staging (//UE4/Dev-Tools-Staging)
#rb none
#rnx

[CL 10906274 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-08 13:26:18 -05:00