Commit Graph

2972 Commits

Author SHA1 Message Date
Phillip Kavan
4ec8250381 Fix BP nativization dependency gathering to collect script objects referenced by an FProperty.
#rnx
#jira UE-88714
#rb Dan.OConnor, Robert.Manuszewski

[CL 11636405 by Phillip Kavan in 4.25 branch]
2020-02-26 12:58:29 -05:00
Fred Kimberley
9dc7c2269a Back out changelist 11604440. This change is redundant due to CL 11317919.
#jira none
#fyi Robert.Manuszewski
#rb Ben.Hoffman

[CL 11605559 by Fred Kimberley in 4.25 branch]
2020-02-25 11:13:59 -05:00
Fred Kimberley
3e84c79f53 Fixes a bug where FieldPathProperties did not clear the old field path info before adding the new info. This resulted in bad data in the property and could result in lost work.
#rb Michael.Noland
#fyi Robert.Manuszewski
#jira UE-89468

[CL 11604440 by Fred Kimberley in 4.25 branch]
2020-02-25 10:51:17 -05:00
Robert Manuszewski
161be6608e FReferencerFinder will now properly find GGCObjectReferencer as one of the referencing objects
#jira none
#rb Steve.Robb
#fyi Dan.OConnor

[CL 11603753 by Robert Manuszewski in 4.25 branch]
2020-02-25 10:31:37 -05:00
phillip kavan
c86d61af68 Fix Find-in-Blueprint search thread deadlock caused by improper handling of unloaded LevelScript Blueprint assets.
#rnx
#jira UE-88780
#rb Ben.Hoffman

#ROBOMERGE-OWNER: phillip.kavan
#ROBOMERGE-AUTHOR: phillip.kavan
#ROBOMERGE-SOURCE: CL 11577288 via CL 11577289 via CL 11577291
#ROBOMERGE-BOT: RELEASE (Main -> Release-4.25Plus) (v654-11333218)
#ROBOMERGE[RELEASE]: Release-4.25

[CL 11577340 by phillip kavan in 4.25-Plus branch]
2020-02-21 13:51:50 -05:00
jamie dale
dd2af9acb9 Fixed incorrect behavior of FField::GetFullGroupName
This was inconsistent with the old behavior of the UField version.

#jira
[FYI] Robert.Manuszewski
#rb Robert.Manuszewski
#rnx

#ROBOMERGE-SOURCE: CL 11577105 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11577115 by jamie dale in 4.25-Plus branch]
2020-02-21 13:28:56 -05:00
johan torp
1d46dbd040 Make StaticFindObject handle nested subobjects when searching for any package without a package pointer
This has the exact same semantics as the original 4.22 implementation based on EndsWith(GetPathName()), except this implementation ignores the exact delimiter being used, i.e. dots  and colons can be swapped. Nobody should be searching for object paths with wrong delimiters though.

#rb robert.manuszewski
#jira UE-86055
#robomerge[core] -core
#ushell-cherrypick of 11279462 by Johan.Torp

#ROBOMERGE-SOURCE: CL 11575470 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11575677 by johan torp in 4.25-Plus branch]
2020-02-21 09:42:12 -05:00
jon nabozny
ccaaa2f566 Fix regression in UEnum Net Serialization
#jira UE-88913
[at]Mattias.Hornlund, [at]Ryan.Gerleve
#lockdown james.golding
#rb Ryan.Gerleve

#ROBOMERGE-SOURCE: CL 11516651 in //UE4/Release-4.24/... via CL 11516725
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11516751 by jon nabozny in 4.25-Plus branch]
2020-02-18 16:16:42 -05:00
dan oconnor
be6c291bb2 Mirror 11461555
Add missing property wrapper type for blueprint event dispatcher's details customizations
#rb Phillip.Kavan
#jira UE-88800

#ROBOMERGE-SOURCE: CL 11461572 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11461585 by dan oconnor in 4.25-Plus branch]
2020-02-17 13:37:44 -05:00
sebastien lussier
1dcdb05a0e Integrate CL 11418990 from Dev-Editor
PostEditChange should not be called on unchanged archetype instances
#jira UE-87829
#rb marc.audy

#ROBOMERGE-SOURCE: CL 11458955 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11458957 by sebastien lussier in 4.25-Plus branch]
2020-02-17 07:05:43 -05:00
dan oconnor
f2ff5520cb Mirror 11452607
Fix crash when compiling blueprints when other blueprints reference the properties of that blueprint
#rb Ethan.Geller, Joe.Conley
#rnx
#jira UE-88820

#ROBOMERGE-SOURCE: CL 11452936 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11452948 by dan oconnor in 4.25-Plus branch]
2020-02-14 19:30:52 -05:00
Rolando Caloca
5b82f15def Copying //UE4/Dev-RenderPlat-Staging@11388153 to //UE4/Main
#rb none
#rnx

[CL 11388545 by Rolando Caloca in Main branch]
2020-02-12 13:27:19 -05:00
robert manuszewski
a3d79a6bb5 Workaround for Static Analysis false warnings
#rb none


#ROBOMERGE-SOURCE: CL 11374486 via CL 11374498
#ROBOMERGE-BOT: (v654-11333218)

[CL 11374506 by robert manuszewski in Main branch]
2020-02-12 03:59:34 -05:00
carlmagnus nordin
0f242a77c2 Guard against recursive calls to FTaskGraphInterface::ProcessThreadUntilIdle during async loading
#rb per.larsson
#ushell-cherrypick of 11327342 by CarlMagnus.Nordin


#ROBOMERGE-SOURCE: CL 11373304 via CL 11373313 via CL 11373318
#ROBOMERGE-BOT: (v654-11333218)

[CL 11373323 by carlmagnus nordin in Main branch]
2020-02-12 02:28:06 -05:00
zousar shaker
a51516d88a Avoid calling FixPackageNameCase in GetPackageLinker if the package already exists. This causes FixPackageNameCase to go from 5m8s total time in a large dataset cook to 22s total time for a total time savings of 4m46s.
#rb devin.doucette


#ROBOMERGE-OWNER: zousar.shaker
#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 11358823 via CL 11358846 via CL 11358863
#ROBOMERGE-BOT: (v654-11333218)

[CL 11358970 by zousar shaker in Main branch]
2020-02-11 16:51:55 -05:00
nick darnell
cdd3165da9 Editor - Giving the details panel the ability to filter the values as well (before we only filtered based on the name of properties and any custom filter strings coming from the customization. Now the values themselves are considered when filtering so that if you've referenced an asset or have some text property, you can search for specific text, or the asset name to see where it has been set.
#rb Matt.Kuhlenschmidt
[FYI] Matt.Kuhlenschmidt


#ROBOMERGE-OWNER: nick.darnell
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 11358089 via CL 11358143 via CL 11358189
#ROBOMERGE-BOT: (v654-11333218)

[CL 11358651 by nick darnell in Main branch]
2020-02-11 16:46:12 -05:00
graeme thornton
bccff5663b Allowing nested struct properties to be resolved with FProperties in linker placeholder classes (required for cooked bluerprints in the editor)
[FYI] robert.manuszewski
#rnx


#ROBOMERGE-SOURCE: CL 11341706 via CL 11350710 via CL 11350968
#ROBOMERGE-BOT: (v654-11333218)

[CL 11351181 by graeme thornton in Main branch]
2020-02-11 14:40:21 -05:00
Stefan Boberg
e42662ddbe Fixed some SA annotations
#jira UE-88514
#rb robert.manuszewski

#ushell-cherrypick of 11341708 by Stefan.Boberg

[CL 11341718 by Stefan Boberg in Main branch]
2020-02-11 12:28:56 -05:00
Robert Manuszewski
b3162ad373 Reimplementing CL #11341031
Fixing TFieldPaths resolving themselves against the provided struct too aggresively (the behavior changed in CL #11315165)

#rb Steve.Robb
#jira UE-88519

[CL 11341318 by Robert Manuszewski in Main branch]
2020-02-11 11:15:34 -05:00
robert manuszewski
1d98180074 Making sure FFieldPath is reset before generating a path from a string
#rb none


#ROBOMERGE-SOURCE: CL 11315642 via CL 11316722 via CL 11317038
#ROBOMERGE-BOT: (v653-11302973)

[CL 11317919 by robert manuszewski in Main branch]
2020-02-10 19:37:18 -05:00
bob tellez
34ca31b23a Merging CL#11315165
Making sure UAnimBlueprintGeneratedClass::EvaluateGraphExposedInputs' ValueHandlerNodeProperties are properly resolved against their class which can be in a renamed package when loading.

+ TFieldPaths will now always try and use the provided struct when resolving themselves and update its path with the resolved package if it's different to the existting (serialized) value so that when they are re-resolved next time they will still point to the class in renamed package

#rb Dan.OConnor


#ROBOMERGE-AUTHOR: Robert.Manuszewski
#ROBOMERGE-SOURCE: CL 11315207 via CL 11316246
#ROBOMERGE-BOT: (v653-11302973)

[CL 11316418 by bob tellez in Main branch]
2020-02-10 19:21:35 -05:00
jon nabozny
51ec2bd5e8 Don't add multiple entries for the same c-style array property in the Class Net Cache.
[at]Ryan.Gerleve, [at]Brian.Bekich
#rb Brian.Bekich


#ROBOMERGE-SOURCE: CL 11314025 via CL 11316181
#ROBOMERGE-BOT: (v653-11302973)

[CL 11316330 by jon nabozny in Main branch]
2020-02-10 19:20:30 -05:00
Ben Marsh
ac9404784c Fix for warning after upgrading to PVS-Studio 7.0.4:
V501: There are identical sub-expressions 'TPointerIsConvertibleFromTo < T, TOther >::Value' to the left and to the right of the '||' operator.

#codereview Robert.Manuszewski
#rb none
#rnx

[CL 11311592 by Ben Marsh in Main branch]
2020-02-10 16:19:26 -05:00
Ben Marsh
0d1505957f Fix for warning after upgrading to PVS-Studio 7.0.4:
V501: There are identical sub-expressions 'TPointerIsConvertibleFromTo < PropertyType, OtherPropertyType >::Value' to the left and to the right of the '||' operator.

#codereview Robert.Manuszewski
#rb none
#rnx

[CL 11311580 by Ben Marsh in Main branch]
2020-02-10 16:17:28 -05:00
robert manuszewski
b938e59c9b Reimplementing FProperty changes from //UE4/Main
+ Reimplemented FProperty related fixed from //UE4/Main:
CL#10791312, 10804850, 10851666, 10855122, 10855198, 10942138, 11030611, 11030639, 11032261, 11061515, 11136964,11138881, 11214238, 11214865

#rb none (previously reviewed in Dev-Core)
[FYI] Chris.Bunnner, Daniel.Lamb


#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 11302985 via CL 11303011 via CL 11303019
#ROBOMERGE-BOT: (v0-11244347)

[CL 11303183 by robert manuszewski in Main branch]
2020-02-10 08:06:56 -05:00