Commit Graph

8921 Commits

Author SHA1 Message Date
Ben Marsh
2ce3554952 Fix manifest error linking UnrealVersionSelector.
#rb none
#jira

[CL 11640359 by Ben Marsh in 4.25 branch]
2020-02-26 14:20:14 -05:00
Ben Marsh
f65fd6a6bc UBT: Produce an error if any output path is longer than MAX_PATH on Windows.
#rb none
#jira UE-75445

[CL 11638471 by Ben Marsh in 4.25 branch]
2020-02-26 13:43:57 -05:00
Brice Criswell
50790aec9e HeadlessChaos :
-Comment out clustering tests until the api is working again.

#rb none
#jira nojira

[CL 11637934 by Brice Criswell in 4.25 branch]
2020-02-26 13:33:13 -05:00
Ben Marsh
b2f70012a7 Don't allow UBT to try and compile engine modules when the engine is already running.
#rb none
#jira UE-88824

[CL 11637884 by Ben Marsh in 4.25 branch]
2020-02-26 13:32:38 -05:00
Patrick Laflamme
7f03785783 #jira UE-87927 - Disaster Recovery doesn't restore a crash from a restored session
- Added the ability to copy and restore a live session, preventing the need to archive it in first place, making the server exist fast (releasing the session lock very quickly) before showing the crash UI and before the next Editor instance could starts.

Details:

This bug could manifest if various ways. An issue causing this bug was fixed in 11252374. This bug can also be observed if the crash reporting process doesn't release its lock on the crashed session quickly. Archiving a session may takes several minutes (depending on the session size) and while a session is archiving, its database is locked and cannot be restored until the archiving process complets. When the Editor reboots after a crash, it searches for a session to recover, but skip over any session that is mounted/locked assuming the session is concurrently used by a concurrent Editor process, potentially preventing it from restoring. The optimal way to work around this problem  is to skip the archiving step. Instead, the live session is never archived (saving a copy), which allows the recovery service to shutdown and release the session lock very quickly ensuring that the session will be unlocked when the Editor restarts. On Editor start, it a crashed session is found and the user decides to restore it, the live session is copied into a new live session.

This changelist also affect those other jira in the following ways:

#jira UE-87899 - Disaster recovery prevents showing the crash reporting UI in a timely manner if the session is large
  - This CL changes execution order to shut down the recovery service ASAP to release the lock, but the optimization above make it super fast, so the UI should always be shown in a timely manner.

#jira UE-87927 - Disaster Recovery doesn't restore a crash from a restored session
  - This CL ensures the recovery service release the session lock faster than the next instance of the Editor can start.

#jira UE-87900 - Disaster Recovery stops recording transactions if the UDP transport layer restarts or auto-repair
#jira UE-88517 - Concert Log Spam - (ConcertKeepAlive) discarded
  - This CL fixes an issues with endpoints timeout logic.

#jira UE-81049 - Clean up the DisasterRecovery Intermediate directory
  - This CL added code to clean up the intermediate directory left over by crashed client.

#rb Francis.Hurteau

[CL 11632069 by Patrick Laflamme in 4.25 branch]
2020-02-26 11:17:23 -05:00
Ben Marsh
ad7d75fa07 Fix error attempting to embed manifest into executable.
#rb none
#jira UE-89552

[CL 11632049 by Ben Marsh in 4.25 branch]
2020-02-26 11:16:31 -05:00
Ben Marsh
2bd587e62d Remove debug code.
#rb none
#rnx
#jira

[CL 11631935 by Ben Marsh in 4.25 branch]
2020-02-26 11:05:06 -05:00
Ben Marsh
b49030bb94 Fix incorrect force included files in intellisense data.
#rb none
#jira UE-89364

[CL 11631903 by Ben Marsh in 4.25 branch]
2020-02-26 11:02:44 -05:00
Ben Marsh
6ed79a2a1b UBT: Remove read-only files when cleaning a target.
#rb none
#jira UE-89548

[CL 11631033 by Ben Marsh in 4.25 branch]
2020-02-26 09:55:03 -05:00
Ben Marsh
e237192c93 Ignore check for active Live Coding session if the -NoHotReloadFromIDE argument is present. Allows creating a new C++ project while Live Coding is active.
#rb none
#jira UE-82398

[CL 11630897 by Ben Marsh in 4.25 branch]
2020-02-26 09:49:08 -05:00
Ben Marsh
21d99caf97 Output a warning if the root path is longer than 50 characters.
#rb none
#jira UE-88446
#fyi Martin.Sevigny

[CL 11625250 by Ben Marsh in 4.25 branch]
2020-02-25 21:05:31 -05:00
Ben Marsh
f0d3dbda4a UBT: Output a warning if any intermediate path is > 200 characters under the UE root directory.
#rb none
#jira UE-88446
#fyi Martin.Sevigny

[CL 11624846 by Ben Marsh in 4.25 branch]
2020-02-25 20:48:25 -05:00
Ben Marsh
bf6a8a4e13 Fix UBT always writing logs to user folder, rather than just in installed builds.
#rb none
#rnx
#jira

[CL 11624709 by Ben Marsh in 4.25 branch]
2020-02-25 20:43:24 -05:00
Ben Marsh
e9a6093dba Prevent writing compiled assemblies to installed engine directory. Write them to the AppData folder instead.
#jira
#rb none

[CL 11619452 by Ben Marsh in 4.25 branch]
2020-02-25 16:48:49 -05:00
Ben Marsh
b714512d84 UBT: Always embed an application manifest during linking, rather than relying on the resource file to include one. This ensures that projects that have a custom resource file for icons, versioning metadata, etc... still operate correctly with manifested OS versions.
To embed a custom manifest, set the WindowsPlatform.ManifestFile to a vaild path in a *.Target.cs file. To disable the embedding of the default manifest, set it to null.

#rb none
#jira UE-88825, UE-87398

[CL 11619014 by Ben Marsh in 4.25 branch]
2020-02-25 16:32:16 -05:00
Ben Marsh
e69c7a698e Fix enumeration of UAT build products.
#rb none
#rnx
#jira

[CL 11617356 by Ben Marsh in 4.25 branch]
2020-02-25 15:56:24 -05:00
Ben Marsh
9b37eb1ee9 Use original location when determining which files to copy for UAT.
#rb none
#rnx
#jira

[CL 11616044 by Ben Marsh in 4.25 branch]
2020-02-25 15:17:51 -05:00
Ben Marsh
23f531ee40 Fix copying of automation DLLs to output directory. Now may exist within any subfolders.
#rb none
#rnx
#jira UE-89493

[CL 11611464 by Ben Marsh in 4.25 branch]
2020-02-25 14:07:54 -05:00
Andrew Grant
8618ee22b4 Fixes Gauntlet support for 32-bit Android builds.
- Now use utils to pull build information instead of a custom regex.
- 32-bit builds are considered, but discarded if 64-bit versions are also present

#review-11610011 @josh.engebretson
#jira nojira #rb na

[CL 11610010 by Andrew Grant in 4.25 branch]
2020-02-25 13:04:20 -05:00
Ben Marsh
612bd490f3 Add support for content plugins in content-only projects. These were not being staged due to a unique target receipt for the project being generated.
#rb none
#jira UE-87672

[CL 11608583 by Ben Marsh in 4.25 branch]
2020-02-25 12:09:00 -05:00
Johan Duparc
f1a6b9d68e Copy of 11271391 from //UE4/Dev-Enterprise:
Revit: Fix export time field in exported datasmith scene

#jira UE-88083
#rb none

[CL 11604300 by Johan Duparc in 4.25 branch]
2020-02-25 10:48:22 -05:00
Benn Gallagher
9e1b696deb Reimplemented solver actors for Chaos geometry collections.
- Reimplemented TaskGraph tick mode to correctly handle multiple worlds (this involves ticking global command queues outside of world tick and mapping worlds to solver lists for each world tick so we can correctly handle multiple worlds)
 - Audited global commands that had an explicit solver capture and moved them to solver commands
 - Updated headless tests to new API for solver flags
#rb
#jira

[CL 11604093 by Benn Gallagher in 4.25 branch]
2020-02-25 10:41:34 -05:00
Ben Marsh
3236f0389a Add support for UAT script projects using foreign engine builds, and for game projects to output binaries under their own project directory.
* UAT will now read each *.Automation.csproj file to determine the output path, and load from there rather than just loading anything under Engine\Binaries\AutomationScripts.
* When compiling *.Automation.csproj files, UAT will set the $(EngineDir) directory to the current engine directory, allowing the project to resolve assembly references to the correct location.
* When generating project files, UBT will create an *.Automation.csproj.props file next to the project containing the path to the engine directory, allowing the assembly to be compiled correctly from Visual Studio.

#rb none
#jira UE-77934

[CL 11601626 by Ben Marsh in 4.25 branch]
2020-02-25 09:25:10 -05:00
Anthony Bills
b61f1badc0 Add BuildCMakeLib UAT automation script for building third party libraries that use CMake.
- This is based off BuildPhysx.Automation.cs and could be unified with this in the future.
- Update some CMakeLists.txt to support this.
- Convert ICU CMakeLists.txt to support cmake 3.5.2 that ships with the engine.
- Fix up some whitespace in BuildPhysX.

#review-11538204 @brian.white
#jira UE-81798
#rb david.harvey

[CL 11597283 by Anthony Bills in 4.25 branch]
2020-02-25 07:22:40 -05:00
Ben Marsh
d6b0a59a7c Remove usages of "var"
#rb none
#rnx
#jira

[CL 11595098 by Ben Marsh in 4.25 branch]
2020-02-24 22:28:27 -05:00