Commit Graph

38 Commits

Author SHA1 Message Date
Matt Hoffman
fca7eebcf0 MoviePipeline: Set up the Output Merger to collect all of the data created each frame before passing it onto the actual output step, implement a basic temporary jpeg writer, and track files written to disk so they can be provided in a post-render structure.
#jira UE-180524
#rb Chad.Williams
#preflight 641b676076461c460b6203ce

[CL 24753966 by Matt Hoffman in ue5-main branch]
2023-03-22 16:46:58 -04:00
elizabeth baumel
fbb9012762 Fix redundant file writes and overwrites when saving high-res screenshots. GIsHighResScreenshot was being set to true too early, so images would be repeatedly generated, saved, and overwritten. Sometimes ImageWriteTask workers would try to delete a file while it was still being written, giving an error that was kind of vague about the actual cause. Setting GIsHighResScreenshot to true on the last frame of the frame delay only schedules ImageWriteTasks for the final frame so redundant images aren't written. Also improve error message when overwriting a file fails.
#rb mihnea.balta
#jira UE-174560
#preflight 640b8501363e9b40abd7f5f9
#rnx
#lockdown mihnea.balta

[CL 24617948 by elizabeth baumel in ue5-main branch]
2023-03-13 14:37:48 -04:00
christopher waters
fa2ebfe998 Adding includes to rendering cpp files in preparation for header changes.
#preflight 6387bd29fa053c489ad45427

[CL 23343615 by christopher waters in ue5-main branch]
2022-11-30 18:29:09 -05:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
max chen
5b81f65c2d Sequencer: Fix signess issue. GetSizeX and GetSizeY() are unsigned integers.
#jira UE-166526
#rb matt.hoffman, andrew.rodham
#preflight 63484672fd22d1fbde5ef255

[CL 22514754 by max chen in ue5-main branch]
2022-10-13 18:55:53 -04:00
marc audy
311f7464bf Updated ../Engine/Source/Runtime/... to inline gen.cpp files
Before:
3648 unity files
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

After:
3548 unity files
Total CPU Time: 46643.828125 s
Total time in Parallel executor: 486.06 seconds

#jira
#preflight

[CL 22173263 by marc audy in ue5-main branch]
2022-09-24 13:57:58 -04:00
Bryan sefcik
b4a6e947d8 Ran IWYU on Public headers under Engine/Source/Runtime/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira

#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf

[CL 21181076 by Bryan sefcik in ue5-main branch]
2022-07-20 11:31:36 -04:00
Steve Robb
b67083a0bd Fix for aggregates being initialized with braced syntax but are no longer aggregates in C++20.
#rb devin.doucette
#jira none
#preflight 62a29b93ff22b2aef9d2d146

[CL 20602862 by Steve Robb in ue5-main branch]
2022-06-10 17:21:34 -04:00
charles bloom
6dd0a22ef5 nop fix comments
#rb none
#preflight none

[CL 19495502 by charles bloom in ue5-main branch]
2022-03-24 10:45:24 -04:00
charles bloom
04ffabc485 ImageWrapper and import/export refactor
FImage is now the standard preferred type for a bag of pixels
FImageView can point at pixels without owning an allocation
ERawImageFormat (FImage) converts to ETextureSourceFormat
FImageUtils provides generic load/save and get/set from FImage
major cleanup in the ImageWrappers
new preferred API is through ImageWrapperModule Compress/Decompress
SetRaw/GetRaw functions cleaned up to not have undefined behavior on unexpected formats
ImageWrapper output added for HDR,BMP,TGA
RGBA32F format added and supported throughout import/export
EditorFactories import/export made more generic, most image types handled the same way using FImage now
Deprecate old TSF RGBA order pixel formats
Fix many crashes or bad handling of unusual pixel formats
Pixel access functions should be used instead of switches on pixel type

#preflight 6230ade7e65a7e65d68a187c
#rb julien.stjean,martins.mozeiko,dan.thompson,fabian.giesen

[CL 19397199 by charles bloom in ue5-main branch]
2022-03-15 18:29:37 -04:00
matt hoffman
7fc9eccdfa MoviePipeline: Fixed a regression in jpeg/png file writing times that significantly slowed down large resolution renders.
#preflight 621565adbd3bdd90869bfa76

#ushell-cherrypick of 19055883 by Matt.Hoffman

#ROBOMERGE-AUTHOR: matt.hoffman
#ROBOMERGE-SOURCE: CL 19098667 via CL 19100916 via CL 19105693 via CL 19105778 via CL 19110096
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19148365 by matt hoffman in ue5-main branch]
2022-02-25 10:58:31 -05:00
danny couture
9332b64809 Prepare for the deprecation of direct access to the Resource member of UTexture in favor of the GetResource() accessor.
#rb Francis.Hurteau
#preflight 609e5182ef86d30001ad0a18
#rnx

[CL 16328103 by danny couture in ue5-main branch]
2021-05-14 07:17:32 -04:00
aurel cordonnier
50944fd712 Merge UE5/RES @ 16162155 to UE5/Main
This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156

[CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
Julien StJean
547c7f160d Optimisation to the legacy texture import and improvement to texture wrapper
Minor change to FImageWrapperBase. GetRaw and GetCompressed now consume the array with the same name instead of having to do a copy of it.
I changed the api IImageWrapper::GetCompressed to return a TArray64<uint8> instead of returning a const TArray64<uint8>&.
Added the format RGBAF to the struct ERGBFormat. Changed the engine code using the EXR image wrapper to reflect that.
The EXR image wrapper now avoid doing an unessary copy of the compressed image when calling compress.

Improvement to the performence of the function UTextureFactory::ImportImage. We now use the magic bytes of the file for certains format to skip some tests.

Here is some performance metrics I captured on my desktop (6 core, 12 threads XEON)

Importing a folder of tiff files (22 files, 4.16 GB Total)
Before: 66.152738 seconds
After: 43.609245 seconds

#jira UEENT-3822
#rb Alexis.Matte

[CL 16128765 by Julien StJean in ue5-main branch]
2021-04-27 11:59:02 -04:00
danny couture
eb29381a3a Reuse ThreadPool for ImageWriteQueue to get rid of another set of threads
#rb Francis.Hurteau

[CL 15568141 by danny couture in ue5-main branch]
2021-03-02 07:42:03 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
Matt Kuhlenschmidt
603a4119c5 Fix HAL/PlatformFileManager.h non-portable casing CIS issues
#rb none

[CL 13214257 by Matt Kuhlenschmidt in ue5-main branch]
2020-05-06 17:58:18 -04:00
john hable
e185ef38f2 Adding debug information for movie render pipeline when data is not well formed.
#rb matt.hoffman
#jira ue-90363

#ROBOMERGE-SOURCE: CL 12158153 in //UE4/Release-4.25/... via CL 12158154
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v659-12123632)

[CL 12158160 by john hable in Main branch]
2020-03-12 20:27:31 -04:00
dmitriy dyomin
da160a036b Better fix for: Avoid spawning 6 extra threads on mobile for saving HighResScreenshots
#rb none


#ROBOMERGE-OWNER: dmitriy.dyomin
#ROBOMERGE-AUTHOR: dmitriy.dyomin
#ROBOMERGE-SOURCE: CL 11574730 via CL 11574734 via CL 11574739 via CL 11574741
#ROBOMERGE-BOT: (v654-11333218)

[CL 11574774 by dmitriy dyomin in Main branch]
2020-02-21 04:23:16 -05:00
Rolando Caloca
5b82f15def Copying //UE4/Dev-RenderPlat-Staging@11388153 to //UE4/Main
#rb none
#rnx

[CL 11388545 by Rolando Caloca in Main branch]
2020-02-12 13:27:19 -05:00
Max Chen
b4881d8bf8 Copying //UE4/Dev-Editor to Dev-Tools-Staging (//UE4/Dev-Tools-Staging) @11123875
#rb none
#jira none

[CL 11123880 by Max Chen in Dev-Tools-Staging branch]
2020-01-27 20:11:15 -05:00
Juan Canada
f396f56a0b Merging //UE4/Dev-Main@11042002 to Dev-RenderPlat-Staging(//UE4/Dev-Rendering)
#rnx
#rb none

[CL 11075443 by Juan Canada in Dev-RenderPlat-Staging branch]
2020-01-21 14:54:20 -05:00
JeanMichel Dignard
70d074639f Merging //UE4/Dev-Main @ 10886849 to Dev-Tools-Staging (//UE4/Dev-Tools-Staging)
#rb none
#rnx

[CL 10906274 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-08 13:26:18 -05:00
Juan Canada
2ecf4f9708 Merging //UE4/Dev-Main@10877709 to Dev-RenderPlat-Staging(//UE4/Dev-Rendering)
#rnx
#rb none

[CL 10895568 by Juan Canada in Dev-RenderPlat-Staging branch]
2020-01-07 13:45:01 -05:00