Commit Graph

56 Commits

Author SHA1 Message Date
rob gay
3c751fa7b9 Fix for corrupt builder access when caching ticked attribute getter
#rb helen.yang
#rnx

[CL 34434156 by rob gay in ue5-main branch]
2024-06-17 14:50:21 -04:00
rob gay
09f4a23362 - Protect against invalid builder or MetaSound object in MetaSound Asset Editor
- Clean-up multiple ways MetaSound is tracked in Asset Editor (ex. FGCObject in ToolKit overload, internal to ToolKit, StrongObjectPtr, etc.)
    - Now just uses EditingObject and GetMetasoundObject() wraps it safely
- Reordered & cleaned asset editor Init logic to accomidate condensing references
#jira UE-216533
#rb helen.yang
[FYI] sondra.moyls
#rnx

[CL 34245283 by rob gay in ue5-main branch]
2024-06-10 13:41:25 -04:00
helen yang
f8ccdfd534 Unhide Advanced category in MetaSound source details panel
#jira UE-214645
#rb Aaron.McLeran, Rob.Gay

[CL 33564847 by helen yang in ue5-main branch]
2024-05-09 20:00:44 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
rob gay
d4dff4a19d - Avoid creating MetaSound builder at all if already up to date (transaction stack when undo/redo is inacted can attempt to call versioning code via serialize call even though its up-to-date spawning unnecessary errors regarding multiple builders being active)
- Avoid creating additional builder when swapping interfaces
#rb helen.yang
[FYI] sondra.moyls
#tests verified listed jira repros resolved locally in editor
#jira UE-212740, UE-209838
#rnx

[CL 33116482 by rob gay in ue5-main branch]
2024-04-19 16:52:14 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
pete bliss
61a52b2d5e Fix for metering widgets freezing when changing Output Format of MetaSound Source - No longer destroying analyzers when changing Output Format.
The FAudioMeter etc were being deleted and recreated when Output Format changed, but their corresponding slate widget instances were kept in use. When the new FAudioMeter instances were created, their new slate widgets were not used.
Now also stopping active preview when changing Output Format, as when the analyzers are reinitialized with a different channel count they recreate their audio buses.
#jira UE-202950, UE-205217
#rb Rob.Gay

[CL 31209662 by pete bliss in ue5-main branch]
2024-02-06 06:26:24 -05:00
helen yang
4028689c51 Show source or MetaSound settings by default in MetaSound details panel, autoexpand graph member menu by default
#jira UE-200298
#rb rob.gay

[CL 29696653 by helen yang in ue5-main branch]
2023-11-13 17:11:15 -05:00
rob gay
d3e70524dc - Migrate and deprecate modify interfaces transform to frontend document builder with broken up, useful functionality available now to the API (ex. SwapInput/Output)
- New version no longer uses expensive controller system
- Fix-up & condense asset/builder initialization logic that utilizes modify interface transform functionality
- Misc clean-up
#rb helen.yang
#jira UE-120184
#rnx
#preflight 645bfd468e01daf0e5b92c30

[CL 25420172 by rob gay in ue5-main branch]
2023-05-10 20:28:39 -04:00
rob gay
1de499ef8e More MetaSound Interface registry clean-up
- Move bIsDefault/bCanEdit(renamed bIsModifiable) from InterfaceRegistryEntry to Interface data definition
- Add checks in builder to disallow mutation of interfaces that shouldn't be via editor or document builder (ex. SourceInterface which is default and then never changed)
- Optimize SearchEngine query for finding default interfaces
- Tweak MetaSoundUObjectRegistry to support non MetasoundAssetBase classes and add UMetaSoundBuilderDocument. Update iterator w/optional param to only return asset types (true by default for back compat)
- Move FName class name comparitors to use new TopLevelAssetPath
#rb phil.popp
#jira UE-181360
#rnx
#p4v-preflight-copy 24658328
#preflight 642b10834d26bcd1eb0e566c

[CL 24920763 by rob gay in ue5-main branch]
2023-04-04 19:14:26 -04:00
rob gay
cff304e9da Interface Registry Tidying
1.) Move Bindings to own registry
2.) Nuke source files & left over cruft relating to archetypes
3.) Move deprecated interface registration next to respective interfaces for clarity
4.) Rename "FMetasoundFrontendInterfaceBindingConnections" to "FMetasoundFrontendInterfaceVertexBindings"
#rb phil.popp
#preflight 640f6852d778f889752a5bd1

[CL 24622079 by rob gay in ue5-main branch]
2023-03-13 17:23:05 -04:00
rob gay
aeb25bb49d - Add Runtime MetaSound Builder support
- Add MetaSound Patch Interface support
- Add MetaSound Interface Bindings
#rb phil.popp
#preflight 640783bd5515f4f57b4b1268
[FYI] Sondra.Moyls
[FYI] Dan.Reynolds

[CL 24548617 by rob gay in ue5-main branch]
2023-03-07 17:01:52 -05:00
bryan sefcik
117472780d Fixed include paths.
#jira
#preflight 634ee62fe746026e48eb077e

[CL 22621687 by bryan sefcik in ue5-main branch]
2022-10-19 06:39:08 -04:00
igor dallavanzi
961a19f4a2 [Waveform Transformations] Add Tooltip and category to waveform transformations property on USoundWave and make it show up only if the relevant plugin module is loaded
#rb miles.flanagan
#jira UE-166513
#preflight 634676ba8a0a7b2adc660fe5

[CL 22511726 by igor dallavanzi in ue5-main branch]
2022-10-13 16:42:33 -04:00
rob gay
9dbc0c6693 [MetaSounds] Editor Graph Syncronization Upgrade
- Move synchronize/details panel flag to more generic ModifyContext
- Do not use MarkAsGarbage as means of enforcing not to show object in details panel to avoid leaving objects in invalid state if undo called. Check ed graph membership instead
- Get rid of leaky namechanged delegates
    - Allows for migration to isolated synchronization in the future
    - Removes conflation of having to synchronize and update views when modifying frontend document
    - Decouples concept of a specific view to update from generic frontend graph modifications
#rb helen.yang
#jira UE-151448
#preflight 632b7afdc7791417aa44126f

[CL 22142063 by rob gay in ue5-main branch]
2022-09-22 15:02:24 -04:00
rob gay
7a7c3aa235 Fix adding/removing interfaces in editor transaction construction not being cached for duration of scope
- Add interface name to scoped transaction display text
#rb helen.yang
#jira UE-151448
#preflight 631a6112354826f8b381f6ab

[CL 21910559 by rob gay in ue5-main branch]
2022-09-08 21:30:48 -04:00
alfaroh corneyiii
228c580a44 Allow Attenuation Visualization for MetaSounds
#jira UE-124030
#rb rob.gay
#preflight 631a228d354826f8b36fd583

[CL 21897461 by alfaroh corneyiii in ue5-main branch]
2022-09-08 13:29:35 -04:00
helen yang
c89bb29047 Update MetaSound presets when an interface is deleted from the original MetaSound
#jira UE-156249
#rb rob.gay
#preflight 62a232981a21ec565ca23e88

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 20585969 in //UE5/Release-5.0/... via CL 20586638
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20588092 by helen yang in ue5-main branch]
2022-06-09 20:28:06 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
rob gay
e8fb5fcd0b - Fix sort order not propagating to presets
- Fix for interfaces not updating/some manipulators being incorrectly editable on MetaSound Presets
- Clarify Set vs Synchronize location on MSEdGraphNodes
- Split up RefreshDetails to RefreshDetails/Interfaces & move RefreshInterface to RefreshGraphMemberMenu
#rb helen.yang
#rnx
#jira UE-144184, UE-144358
#preflight 621ff6b9901d830f366e5369

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19235508 in //UE5/Release-5.0/... via CL 19236719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19237376 by rob gay in ue5-main branch]
2022-03-02 22:11:18 -05:00
helen yang
b351362644 Fix missing MetaSound interface warning and interfaces not updating referencing graphs properly
#jira UE-144323
#jira UE-144366

#rb phil.popp, rob.gay
#preflight 621faa4b31454c90cc013cff
#rnx


#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19223899 via CL 19226239 via CL 19226369 via CL 19226572 via CL 19226733
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19230244 by helen yang in ue5-main branch]
2022-03-02 16:52:01 -05:00
helen yang
9b0ed29b45 MetaSound interfaces menu changes
- Add right click menu and actions for graph members
- Move add/remove interfaces menu to a new details tab

#jira UE-143470
#jira UE-143471

#rb rob.gay
#preflight 6218507a8849a7424f6d4ff9

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19177650 in //UE5/Release-5.0/... via CL 19180025
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19203596 by helen yang in ue5-main branch]
2022-03-01 14:29:17 -05:00
aaron mcleran
f4fca67476 Fixing duplicate loc keys in audio
#jira UE-141419
#rb Rob.Gay
#preflight 61fd68d2a6165e53567bb1ed
#lockdown Cristina.Riveron

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18868877 in //UE5/Release-5.0/... via CL 18868922 via CL 18869617
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18869700 by aaron mcleran in ue5-main branch]
2022-02-04 14:18:45 -05:00