Commit Graph

128 Commits

Author SHA1 Message Date
jeanfrancois dube
80c211f5b4 Data Layers: fix crash when destructing the data layers editor subsystem.
#rb sebastien.lussier
#preflight none
#rnx


#ROBOMERGE-OWNER: jeanfrancois.dube
#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 20737062 via CL 20737110 via CL 21316937 via CL 21316994
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21318683 by jeanfrancois dube in ue5-main branch]
2022-08-10 11:02:12 -04:00
philippe deseve
40b5740834 Fix crash occuring when adding actors to a deprecated datalayer
#rb patrick.enfedaque

#ROBOMERGE-AUTHOR: philippe.deseve
#ROBOMERGE-SOURCE: CL 21116051 via CL 21116056 via CL 21116059
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21142445 by philippe deseve in ue5-main branch]
2022-07-17 22:43:39 -04:00
jeanfrancois dube
c1e07a2cfc Fix crash when exiting editor in FDataLayersBroadcast::Deinitialize.
#rb patrick.enfedaque
#preflight none
#rnx

#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 21069240 via CL 21083569 via CL 21083921 via CL 21084190
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21086526 by jeanfrancois dube in ue5-main branch]
2022-07-13 21:24:50 -04:00
Richard Malo
3eafd1b873 Optimized editor when modifying actors with Data Layers : DataLayer outliner and actor visibility updates are deferred at next DataLayerEditorSubsystem::Tick.
#rb philippe.deseve
#robomerge EngineMerge
#preflight 62c345545d53ca5bce1f01d0

[CL 20937317 by Richard Malo in ue5-main branch]
2022-07-04 16:54:04 -04:00
philippe deseve
8227dee6aa Allow a world to contains multiple WorldDataLayers
Calls to retrieve data layers from the subsystem are now forwarded to a collection of WorldDataLayers
The collection forwards the call to the relevent WorldDataLayers

#rb richard.malo
#preflight 62bd9255b024a2608c311344
#test AncientGame, CitySample, Cook, PIE, -Game, Hlods

#ROBOMERGE-AUTHOR: philippe.deseve
#ROBOMERGE-SOURCE: CL 20894852 via CL 20894903 via CL 20894926
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20898599 by philippe deseve in ue5-main branch]
2022-06-30 13:21:53 -04:00
richard malo
295ea8f36c Added detail customization for DataLayerInstance to hide Runtime parameters when it's not a Runtime Data Layer.
#rb philippe.deseve
#preflight 62b38447044266c6677e73f6

#ROBOMERGE-AUTHOR: richard.malo
#ROBOMERGE-SOURCE: CL 20792363 via CL 20798340 via CL 20800118
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20802223 by richard malo in ue5-main branch]
2022-06-23 17:08:58 -04:00
dave belanger
0f4f6fe3dc Fix crash on editor exit
#rb Rex.Hill
#preflight skip

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 20737130 via CL 20737154 via CL 20737198 via CL 20737224 via CL 20737247
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v970-20704180)

[CL 20739714 by dave belanger in ue5-main branch]
2022-06-20 12:42:08 -04:00
JeanFrancois Dube
ef1dd68952 Data Layers: fix crash when destructing the data layers editor subsystem.
#rb sebastien.lussier
#preflight none
#rnx

[CL 20737062 by JeanFrancois Dube in ue5-main branch]
2022-06-20 10:15:44 -04:00
Richard Malo
f800706498 Remove prompt to choose Data Layer asset when world has deprecated Data Layers.
Remove option to import Data Layer assets from Level Instance if world has deprecated Data Layers.
#rb philippe.deseve
#preflight 62acb5515c69124c40cbea70

[CL 20706115 by Richard Malo in ue5-main branch]
2022-06-17 13:34:04 -04:00
Richard Malo
b4a735799e Fixed FDataLayerMode::RegisterContextMenu to be static as it is registered once : use USceneOutlinerMenuContext to get the associated FDataLayerMode instance.
#rb patrick.enfedaque
#preflight 62acab4a5d5264997e206ece

[CL 20705535 by Richard Malo in ue5-main branch]
2022-06-17 13:03:41 -04:00
Richard Malo
f4221f17a7 Asset Actions "Replace Selected Actors" now transfers more properties : Actor Folder, Data Layers, IsSpatiallyLoaded flag and RuntimeGrid.
#rb jeanfrancois.dube, patrick.enfedaque
#jira UE-155925
#preflight 62a212411a21ec565c964e0d

[CL 20578595 by Richard Malo in ue5-main branch]
2022-06-09 12:13:16 -04:00
JeanFrancois Dube
f59630be43 Data Layers: fix "Iterating over Data Layers without a World Partition" when trying to refresh the data layers outliner for non-partitioned maps.
#rb richard.malo
#preflight none
#rnx

[CL 20574099 by JeanFrancois Dube in ue5-main branch]
2022-06-09 07:59:49 -04:00
JeanFrancois Dube
e3c08e960c Data Layer: fix old data layer assets debug color when loading.
#rb richard.malo
#preflight 629fe378f73a9b013ddf953a
#rnx

[CL 20554448 by JeanFrancois Dube in ue5-main branch]
2022-06-08 07:11:02 -04:00
Richard Malo
431ed26a54 Dissallow Level Instance Pivot actor to have Data Layers
#rb patrick.enfedaque
#preflight 629f453e580328634383ca63
#rnx

[CL 20535984 by Richard Malo in ue5-main branch]
2022-06-07 08:38:14 -04:00
richard malo
155d762e1e Removed AActor::IsValidForDataLayer in favor of always using AActor::SupportsDataLayer().
#rb jeanfrancois.dube
#preflight 62964d659d75300f41b38413

#ROBOMERGE-AUTHOR: richard.malo
#ROBOMERGE-SOURCE: CL 20452745 via CL 20452751 via CL 20452755
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v952-20449836)

[CL 20460646 by richard malo in ue5-main branch]
2022-06-01 18:08:22 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Richard Malo
0a9e1df30b UDataLayerEditorSubsystem now passes the DataLayerInstance when broadcasting the EDataLayerAction::Delete action.
#rb jeanfrancois.dube
#jira UE-155204
#preflight 6294a9276601713a4f75718a

[CL 20429857 by Richard Malo in ue5-main branch]
2022-05-30 07:29:56 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
Richard Malo
223c790fef ActorFolder Improvements :
- Optimized FFolder resolving to UActorFolder : now uses and maintains an acceleration table
- Favor creation of FFolder using ActorFolderGuid when available
- FFolder creation now always passes a Root Object to facilitate Root Object ptr resolving (even when it's the main world)
- Fixed Duplicate Hierarchy when using Actor Folders and target level is different
- Fixed copy/paste actor from Persistent to LevelInstance not loosing actor folder
- Fixed mark for delete of an Actor Folder that could generate duplicates
- Modified fix of duplicate Actor Folders in a level : instead of renaming duplicates, mark for delete all duplicates except one and redirect children to the one we keep

#jira UE-150566
#rb patrick.enfedaque, jeanfrancois.dube
#preflight 6284101f486700b561a555ff

[CL 20346124 by Richard Malo in ue5-main branch]
2022-05-24 06:58:06 -04:00
Richard Malo
4a2f9db058 Fixed rare crash in UDataLayerEditorSubsystem when loading another world partition map.
#rb philippe.deseve
#preflight 628561c1890768f0e93bbbcf
#rnx

[CL 20269417 by Richard Malo in ue5-main branch]
2022-05-18 18:02:22 -04:00
JeanFrancois Dube
285e40444b Data Layers: replaced FScopedDataLayerTransaction by FScopedTransaction.
#rb richard.malo
#preflight 62824179c57a894cf66e3541
#rnx

[CL 20222410 by JeanFrancois Dube in ue5-main branch]
2022-05-16 08:48:27 -04:00
JeanFrancois Dube
13ea13eb8f World Partition Editor Hash:
- Unbound octree now stores hierarchical editor cells instead of leaves, this greatly reduce the number of needed editor cells for very large worlds.
- Implemented loading regions support to replace editor cells loading, in preparation for bookmark regions.

Tested against a 2000KMx2000km world + various internal projects and demos.

#rb patrick.enfedaque, richard.malo
#preflight 628239b5cf7e4667a97e3fe0

[CL 20222133 by JeanFrancois Dube in ue5-main branch]
2022-05-16 08:08:40 -04:00
Richard Malo
bbfa7b024e Fixed static analysis
#jira UE-151771
#rb patrick.enfedaque
#preflight 627e48205d0fe3ffef3c57ac
#rnx

[CL 20180106 by Richard Malo in ue5-main branch]
2022-05-13 08:40:05 -04:00
Richard Malo
e2b73feab9 Fixed assert in UDataLayerEditorSubsystem happening in Simulate.
#rb patrick.enfedaque
#jira UE-151604
#preflight 627ba9630a5817c9d9428048

[CL 20137623 by Richard Malo in ue5-main branch]
2022-05-11 08:44:11 -04:00
richard malo
879c5c42c6 Added support of Data Layers inside Level Instances.
#rb jeanfrancois.dube, patrick.enfedaque, philippe.deseve
#jira UE-151266
#preflight 62796854a35fb5cb3f55e9e6

#ROBOMERGE-OWNER: richard.malo
#ROBOMERGE-AUTHOR: richard.malo
#ROBOMERGE-SOURCE: CL 20121141 via CL 20121608 via CL 20121618
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20122781 by richard malo in ue5-main branch]
2022-05-10 10:22:54 -04:00