Commit Graph

11525 Commits

Author SHA1 Message Date
ionut matasaru
51453da7e6 [Insights]
- Session Browser: Added user notifications for Rename and Delete trace actions.
  - Session Browser: Fixed rename to not replace an existing file anymore, but to warn user instead.

#jira UE-155294
#rb Catalin.Dragoiu
#preflight 63033aa9c744dac96792ec46

[CL 21481094 by ionut matasaru in ue5-main branch]
2022-08-22 05:29:58 -04:00
ionut matasaru
b7a9d7654c [Insights] Updated description of some memory rules to avoid some confusions (i.e. "freed after time T" --> "not freed until at least time T").
#rb none
#preflight skip

[CL 21480463 by ionut matasaru in ue5-main branch]
2022-08-22 02:51:27 -04:00
sara schvartzman
2751278ee4 Control Rig: Fix local variables nodes not dealing with constant values
#jira UE-161265
#rb jack.cai
#preflight 62ff66799835a27d8d9c4bc9

[CL 21468244 by sara schvartzman in ue5-main branch]
2022-08-19 19:38:13 -04:00
paul chipchase
7969987c39 Improve the logging of VA profiling data at the end of a cook.
#rb Per.Larsson
#jira UE-161408
#rnx
#preflight 62ff43f35344ca3df4962ec8

- If there was no VA activity we explicitly log that there was no profile data to show
- Only log the operations that had activity, there is no point writing out a bunch of zeros for an operation to show nothing happened.

[CL 21468200 by paul chipchase in ue5-main branch]
2022-08-19 19:36:58 -04:00
jack cai
f72bcf15df ControlRig: Rename exposed pin should also rename the display name in addition to the name of the pin object
#jira UE-160796
#rb sara.schvartzman, benoit.gadreau, helge.mathee
#preflight skip

[CL 21467698 by jack cai in ue5-main branch]
2022-08-19 19:19:45 -04:00
dmytro vovk
5bad8f37b7 Removed legacy Android Project Settings
#rb Chris.Babcock

[CL 21467626 by dmytro vovk in ue5-main branch]
2022-08-19 19:18:13 -04:00
paul chipchase
fc827406e2 Add a number of ways for the VA system to be changed to lazy initialize on first use.
#rb Per.Larsson
#jira UE-161296
#rnx
#preflight 62fe3ce73d3fb466b229bcc0

- There are some usecases that require the VA system to initialize the first time it is accessed (usually the first time we attempt to pull a virtualized payload) rather than be initialized in the program start up. This change provides three different methods to achieve this:
-- Setting the define 'UE_VIRTUALIZATION_SYSTEM_LAZY_INIT' to 1 in a programs .target.cs
-- Setting [Core.ContentVirtualization]LazyInit=true in the Engine ini file
-- Running with the commandline option -VA-LazyInit

- If we detect that the source control backend is being initialized on a background thread we do not try to run the FConnect operation. The backend will still work but this does reduce the potential error checking on initialization. This is done because the FConnect operation currently only works on the main thread and to change this would be a bigger work item than we can schedule at the moment.
- UE::Virtualization::Initialize functions now take a EInitializationFlags enum as a parameter. This enum allows the call to ignore all lazy init settings and force the initialization immediately. This is useful for programs like the Virtualization standalone tool which just needs to start the system when needed.
-- The call to ::Initialize in LaunchEngineLoop passes in None and does not ignore lazy initialization.
-- Calls to ::Initialize in the UnrealVirtualizationTool however all use EInitializationFlags::ForceInitialize and ignore lazy initialization settings.
- Fixed an odd bug in UE::Virtualization::Initialize where the error path (if the config file cannot be found) was using a different start up code path.
- Add asserts when assigning to GVirtualizationSystem to make sure that it is null. This is not 100% safe but should catch some potential threading issues, if any.
- Add an assert after lazy initialization (IVirtualizationSystem::Get) to make sure that GVirtualizationSystem was assigned a valid object.
- Improve how we check for legacy values in [Core.ContentVirtualization]. We now support multiple allowed values.
- Added a way to poll if a VA system has been initialize yet or not, this allows us to avoid initializing a VA system if one has not yet been created and we try to:
-- Dump VA profiling stats after cooking
-- Send VA stats to studio analytics
- Note that currently using lazy init loading will probably cause the VA statistics panel not to work, this will be fixed in future work where we will allow the panel to register for a callback when the system is initialized.

[CL 21467510 by paul chipchase in ue5-main branch]
2022-08-19 19:15:42 -04:00
Devin Doucette
bd378f5441 LowLevelTests: Use Unreal logging functionality instead of LocalPrint
#preflight 62ffef1cd642db47d8d52c90
#preflight 62feb1fb3c4417dcec1aaabb
#rb Chris.Constantinescu

[CL 21464557 by Devin Doucette in ue5-main branch]
2022-08-19 16:28:57 -04:00
Devin Doucette
1225bdd006 CoreUObject: Disable the FObjectHandle::Resolve test until its warnings and errors are fixed
#preflight 62ffed75904ba3bd264adf8d
#rb Zousar.Shaker
#rnx
#fyi Chris.Constantinescu

[CL 21464067 by Devin Doucette in ue5-main branch]
2022-08-19 16:12:42 -04:00
Jerome Delattre
c6c0e9a2a5 Support individual test exclusion for different RHI when parent suite does not exclude all RHI
+ enhanced management of RHI through the UI: If a RHI is specify, any child test can be excluded on an additional RHI by clicking on edit exclusion
+ disable exclusion editing on remote session

#jira UE-147020
#preflight 62ff9c99086f90bbc401a999
#rb Chris.Constantinescu

[CL 21462884 by Jerome Delattre in ue5-main branch]
2022-08-19 15:29:47 -04:00
ionut matasaru
196d6a6912 [Insights]
- Moved the Import Table as first item in main Menu. Also changed its icon.
  - Renamed "Package" view (Cooking profiler) to "Packages" and set the generic table icon.

#rb Catalin.Dragoiu
#preflight 62ff9b5f3c4417dcec5544f1

[CL 21457110 by ionut matasaru in ue5-main branch]
2022-08-19 10:23:21 -04:00
Joakim Lindqvist
767e76dbb0 OidcToken - Fixed issue running interactive login on mac and linux. Also fixed issue were asking to wait for login caused a crash as well as tweaking the error message when a user decided to not finish the interactive login.
#jira UE-161335, UE-161369
#preflight https://horde.devtools.epicgames.com/job/62ff679e3c4417dcec499e53

[CL 21455420 by Joakim Lindqvist in ue5-main branch]
2022-08-19 06:53:53 -04:00
Catalin Dragoiu
c0cd745413 [Insights] Fix Linux crash when double clicking on a Task in the Task Table.
#jira UE-160371
#rb Ionut.Matasaru
#preflight 62fe66533c4417dcec0e895a

[CL 21454778 by Catalin Dragoiu in ue5-main branch]
2022-08-19 04:38:34 -04:00
paul chipchase
ae267db067 Fix some typos in error messages for the DumpPackagePayloadInfo command
#rb trivial
#rnx
#preflight 62ff3322086f90bbc4f59142

[CL 21454585 by paul chipchase in ue5-main branch]
2022-08-19 03:11:43 -04:00
Guillaume Abadie
14c7c688e5 Adds a CompileDXC.bat to vulkan's ShaderDebugInfo
This allows to iterate to compile the USF file to SPIRV and translate to GLSL to verify the sanity of the SPIRV assembly.

#rb jeannoe.morissette
#jira UE-161125
#preflight 62fe8a8157316140a8fa226a
#fyi laura.hermanns

[CL 21449988 by Guillaume Abadie in ue5-main branch]
2022-08-18 17:07:23 -04:00
devin doucette
9b905880aa DDC: Fixed UserData value returned by the cache hierarchy
#rb trivial
#rnx

[CL 21449943 by devin doucette in ue5-main branch]
2022-08-18 17:04:23 -04:00
luc eygasier
0cda7fc8ed Modifies revert operations in source control window to also reload packages.
Adds Source Control Helper method to perform a modular source control operation and reload the concerned packages

#rb Patrick.Enfedaque
#preflight 62fd4e63e64b1a510937890b
#changelist validated

[CL 21444877 by luc eygasier in ue5-main branch]
2022-08-18 13:03:11 -04:00
ionut matasaru
d7534d0516 [Insights] Fixed crash in analysis of timing events (analyzing traces with "pending" events (ones with metadata) emitted just before EndThread trace event).
#jira UE-161324
#rb Catalin.Dragoiu
#preflight 62fe625caa546d5e9dfe1ca3

[CL 21443654 by ionut matasaru in ue5-main branch]
2022-08-18 12:05:24 -04:00
Devin Doucette
055ba32b38 DDC: Added partial cache record propagation to the hierarchy, with tests
#jira UE-156058
#preflight 62fd59d5e64b1a51093918f8
#rb Zousar.Shaker

[CL 21441390 by Devin Doucette in ue5-main branch]
2022-08-18 09:51:07 -04:00
Catalin Dragoiu
8962accddc [Insights] Add filter for branch to the session list
#rb Ionut.Matasaru
#preflight 62fd1022aa546d5e9dbcbade

[CL 21439123 by Catalin Dragoiu in ue5-main branch]
2022-08-18 04:33:10 -04:00
dmitriy dyomin
8edf003c00 Invalidate GL and Vulkan shaders
#ROBOMERGE-AUTHOR: dmitriy.dyomin
#ROBOMERGE-SOURCE: CL 21438408 via CL 21438416 via CL 21438418 via CL 21438420
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v981-21435820)

[CL 21438584 by dmitriy dyomin in ue5-main branch]
2022-08-18 02:04:03 -04:00
halfdan ingvarsson
19ae9b947b Control Rig: Sync UpdateTemplateNodePinTypes from UE5Main
#jira UE-161067
#rb benoit.gadreau
#preflight 62fd05fa200ff87e0781a086

#ROBOMERGE-OWNER: halfdan.ingvarsson
#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 21426542 via CL 21430788 via CL 21432247 via CL 21432263
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v980-21429816)

[CL 21434647 by halfdan ingvarsson in ue5-main branch]
2022-08-17 19:07:31 -04:00
jack cai
bd96706d1f RigVM: 1. Added missing execute context type patching during argument type registration.The same patching process was already in place for when arguments were initially created using FRigVMTemplateArgument 2. fixed a typo in Array node
#jira UE-161021 UE-160890
#rb Sara.Schvartzman, Helge.mathee, benoit.gadreau
#preflight tbd

#ROBOMERGE-OWNER: jack.cai
#ROBOMERGE-AUTHOR: jack.cai
#ROBOMERGE-SOURCE: CL 21425787 via CL 21430778 via CL 21431948 via CL 21432077
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v980-21429816)

[CL 21434623 by jack cai in ue5-main branch]
2022-08-17 19:07:05 -04:00
Devin Doucette
30886eda76 More workarounds for issues with /Zc:lambda in MSVC 14.33
#preflight 62fd28c30f2aefc97abbe0ee
#preflight 62fd2940aa546d5e9dc15245
#rb trivial
#rnx
#fyi Joe.Kirchoff

[CL 21427854 by Devin Doucette in ue5-main branch]
2022-08-17 14:04:36 -04:00
Tim Smith
6441d21065 Removed duplicated code from a 5.0 patch fix.
#rb devin.doucette
#rnx
#preflight 62fd04183f75602b2fba9a03

[CL 21425650 by Tim Smith in ue5-main branch]
2022-08-17 11:18:31 -04:00