Commit Graph

211 Commits

Author SHA1 Message Date
halfdan ingvarsson
19ae9b947b Control Rig: Sync UpdateTemplateNodePinTypes from UE5Main
#jira UE-161067
#rb benoit.gadreau
#preflight 62fd05fa200ff87e0781a086

#ROBOMERGE-OWNER: halfdan.ingvarsson
#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 21426542 via CL 21430788 via CL 21432247 via CL 21432263
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v980-21429816)

[CL 21434647 by halfdan ingvarsson in ue5-main branch]
2022-08-17 19:07:31 -04:00
benoit gadreau
5202250140 localizable text
#rb sara.schvartzman
#jira UE-160519
#preflight 62fba6f4ad3bd8ad64530bc8

#robomerge FNMain

[CL 21422223 by benoit gadreau in ue5-main branch]
2022-08-17 04:19:12 -04:00
rex hill
421ff22fb1 Fix several check() that should be verify() must still run in shipping
#preflight 62f8f9d7b66d5d9313536c06

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 21382837 via CL 21387149 via CL 21390143 via CL 21390737
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)

[CL 21392618 by rex hill in ue5-main branch]
2022-08-15 15:52:39 -04:00
Matt Peters
89927c6e00 AssetRegistry updates for Niagara/ControlRig: Call AssetTagsFinalized after asynchronous operations that modify the data that contributes to tags.
#rb Zousar.Shaker
#rnx
#preflight 62f6a38f153b17e74679345f

[CL 21361229 by Matt Peters in ue5-main branch]
2022-08-12 15:17:18 -04:00
jamie dale
cd2c04fbed Adding additional includes in preparation for removing a global include
#preflight skip
#rb none
#rnx

#ROBOMERGE-OWNER: jamie.dale
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21283042 via CL 21286016 via CL 21286060 via CL 21286134
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21291490 by jamie dale in ue5-main branch]
2022-08-09 12:54:53 -04:00
jack cai
bb42153dc6 Control Rig: Remove an unnecessary check during reattach link. Previously it was checking if template is initialized on library node, which by design should happen after rettach link. So there is no need to check for it during reattach link. Invalid links will be broken by a call to RecomputeAllTemplateFilteredPermutations() later in RefreshAllModels()
#jira UE-159787
#rb Sara.schvartzman, Helge.mathee
#preflight skip

[CL 21201877 by jack cai in ue5-main branch]
2022-07-21 11:53:21 -04:00
jamie dale
31a66a1325 Removed suspect use of GenerateDiff
#jira
#rb Thomas.Sarkanen
#rnx

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21180075 via CL 21181732 via CL 21182426
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21192626 by jamie dale in ue5-main branch]
2022-07-20 18:33:03 -04:00
sara schvartzman
7e0bf1b762 Control Rig: Fix crash when running Run CitySampleWin64EditorPerf Incr1
#jira UE-159763
#rb helge.mathee
#preflight 62d69d6fd76ea4b5032271be

[CL 21162171 by sara schvartzman in ue5-main branch]
2022-07-19 10:28:07 -04:00
sara schvartzman
075fe3c245 Control Rig: Fix crash when opening CR_Quinn_Example in ControlRigExample
#jira na
#rb helge.mathee
#preflight 62d016296f385a5639a7654c

[CL 21089919 by sara schvartzman in ue5-main branch]
2022-07-14 09:16:13 -04:00
sara schvartzman
eec59437e9 Control Rig: Collapse nodes with templates
#jira UE-146929
#rb helge.mathee
#preflight 62ced5dbd00f3c208e47c183

[CL 21089290 by sara schvartzman in ue5-main branch]
2022-07-14 06:53:37 -04:00
helge mathee
b3573a03b0 Control Rig: Remove strong dependencies from User interface on data model - use TWeakObejctPtr
#rb rob.millar
#preflight https://horde.devtools.epicgames.com/job/62c6e9bb2823f28cf21e5f45

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 20988142 via CL 20988169 via CL 20988205
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 20992713 by helge mathee in ue5-main branch]
2022-07-07 17:00:35 -04:00
Helge Mathee
ac50c45e04 Control Rig: Maintain control names in UI as valid until re-chosen
#rb na
#jira UE-157955
#preflight https://horde.devtools.epicgames.com/job/62c6eb598558075f424d256b

[CL 20983875 by Helge Mathee in ue5-main branch]
2022-07-07 10:33:32 -04:00
Helge Mathee
5ed1ec94c8 Control Rig: Increase default node run count
#rb na
#jira na
#preflight skip

[CL 20964523 by Helge Mathee in ue5-main branch]
2022-07-06 06:34:53 -04:00
Helge Mathee
e4e72bc031 Control Rig: Ensure to full preferred types for template nodes
#rb sara.schvartzman
#jira UE-158285 UE-157648
#preflight https://horde.devtools.epicgames.com/job/62c2fca6a3568e30666bac1e

[CL 20935067 by Helge Mathee in ue5-main branch]
2022-07-04 11:03:53 -04:00
Helge Mathee
3d20407084 RigVM: Refactor template type system to rely on integers rather than string comparisons
* Switching the FRigVMTemplateArgumentType to be backed up by FName instead of FString for faster comparison
* Adding a "Types" storage under the RigVMRegistry of all of the known supported types
* Have the FRigVMTemplateArgument refer to type indices rather than full type structures
* Have the resolval comparison code rely on comparing type indices rather than type structures
* Store relationship between the bool and the TArray<bool> type as an array / element lookup within the registry - to avoid string operations when doing lookups from element to array to 2 dimensional array for a type.
* The preferred types list on the template node is now stored as pairs of argument name and type index <FName, int32> rather than FString.
* Also we no longer support all types for the untyped nodes (such as reroute, select, if etc) - but instead we support all user defined types (non-native structs and enums) as well as all types ever used as a template argument. The reasoning here is that supporting a type that's not used by any node is pointless. This reduced the type set from 9876 to 237.

#rb halfdan.ingvarsson
#jira na
#preflight https://horde.devtools.epicgames.com/job/62b9c666ba62f4498a345be2

[CL 20861728 by Helge Mathee in ue5-main branch]
2022-06-28 13:41:23 -04:00
halfdan ingvarsson
0189d41649 Control Rig: Use TChunkedArray to guarantee stability of the location of the array elements in memory.
#jira UE-157444
#fyi helge.mathee, sara.schvartzman
#preflight 62b4dc28be326a8b04f9773d
#rnx

[CL 20803360 by halfdan ingvarsson in ue5-main branch]
2022-06-23 17:54:23 -04:00
Helge Mathee
f3fa15514f Control Rig: Follow up fixes for introduction of RigVMClient
#rb na
#jira na
#preflight https://horde.devtools.epicgames.com/job/62b3204bc603be6148012bcb

[CL 20773900 by Helge Mathee in ue5-main branch]
2022-06-22 10:06:31 -04:00
Helge Mathee
555783edcb Control Rig / RigVM: Improve asset loading performance
- Overall Loading time went from 21.439 seconds to 7.521 seconds
 - Improved Postload from 6.643 seconds to 0.915 seconds
 - Improved InitControlRigEditor from 13.422 seconds to 4.842 seconds

#jira UE-155783
#rb benoit.gadreau
#preflight https://horde.devtools.epicgames.com/job/62b2fe202c753858830d4b11

[CL 20773015 by Helge Mathee in ue5-main branch]
2022-06-22 08:37:48 -04:00
jaime cifuentes
78267bdbb5 Fix for Control Rig exported vectors not working when used on AnimBP
Pin default value is now generated using FBlueprintEditorUtils::PropertyValueToString, which generates a valid default string for anim graph pin editors

#review @helge.mathee @thomas.sarkanen
#jira UE-147767
#preflight 62b19ba4c400b5ee2f4313bc

[CL 20755422 by jaime cifuentes in ue5-main branch]
2022-06-21 06:47:54 -04:00
Helge Mathee
f6e4dd586e Control Rig: Export aggregate node properly
#rb benoit.gadreau
#jira UE-151729
#preflight https://horde.devtools.epicgames.com/job/62b189ce27718d2d48106113

[CL 20755316 by Helge Mathee in ue5-main branch]
2022-06-21 06:29:33 -04:00
Helge Mathee
5847f56cd7 Control Rig: Fix null ptr issue inside of Graph model
#rb na
#jira na
#preflight skip

[CL 20755244 by Helge Mathee in ue5-main branch]
2022-06-21 06:14:52 -04:00
Helge Mathee
e9be530476 Control Rig: Restore backwards compat for python API
#rb benoit.gadreau
#jira UE-157167
#preflight https://horde.devtools.epicgames.com/job/62b18158d05709efcd9e78c0

[CL 20754916 by Helge Mathee in ue5-main branch]
2022-06-21 04:51:02 -04:00
Helge Mathee
5409f37548 Control Rig: Construction Event
Changes include
* renamed setup event to construction event
* new nodes to spawn bones, nulls, controls etc
* class settings to limit how many elements can be created procedurally
* lookup from procedural element to spawner node (who created this?)

#preflight https://horde.devtools.epicgames.com/job/62b0d9c62405b4ac9e774bf4
#jira UE-153500
#rb audit

[CL 20754666 by Helge Mathee in ue5-main branch]
2022-06-21 04:15:34 -04:00
benoit gadreau
786eeaff04 follow up to CL19360468 and CL19387103: update bPropagateToChildren default value for some nodes saved in previous versions
the "Space" element type is changed to "Null" after we apply the PropagateToChildren patch thus leaving old tranform nodes using a bPropagateToChildren to false.

#jira MH-6790
#rb helge.mathee
#preflight 62a9efb6634e82e5d1e9b02c

#ROBOMERGE-AUTHOR: benoit.gadreau
#ROBOMERGE-SOURCE: CL 20672738 in //UE5/Release-5.0/... via CL 20674321
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20676077 by benoit gadreau in ue5-main branch]
2022-06-15 16:00:03 -04:00
Helge Mathee
f340a4f6ad Control Rig: Fix to run backwards compat code
#rb sara.schvartzman
#jira UE-155436
#preflight https://horde.devtools.epicgames.com/job/62a34936ec7332a25c9597a0

[CL 20594878 by Helge Mathee in ue5-main branch]
2022-06-10 10:03:01 -04:00