Commit Graph

43 Commits

Author SHA1 Message Date
sebastian nordgren
3a3f846e36 MVVM: Setting a conversion function with multiple arguments now generates a FunctionGraph in the widget blueprint that is used to call the function, which allows us to bind multiple properties to conversion functions.
Removed IFieldPathHelper. The functionality was moved to the editor subsystem, which made the abstraction unnecessary and unavailable to blueprint.

FBindingSource no longer contains the IsSelected member. This was very context-specific, and doesn't really make sense in the general case.

[REVIEW] [at]patrick.boutot
#jira UE-145128
#rnx
#preflight 62b9c947e77151e5996f3f36

#ROBOMERGE-OWNER: sebastian.nordgren
#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20833893 via CL 20836430 via CL 20836446
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20838757 by sebastian nordgren in ue5-main branch]
2022-06-27 16:24:02 -04:00
sebastian nordgren
9f275cd39c MVVM - You can only add bindings to a widget blueprint that already has viewmodels assigned to it.
It's impossible to create a valid binding without it, so there's not really any reason to allow it.

[REVIEW] [at]patrick.boutot
#rnx

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20830806 via CL 20830812 via CL 20830822
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20833385 by sebastian nordgren in ue5-main branch]
2022-06-27 12:33:58 -04:00
sebastian nordgren
5be4619ba2 Backing out changelist 20830654 due to missing files.
#rnx

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20830793 via CL 20830797 via CL 20830803
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20833376 by sebastian nordgren in ue5-main branch]
2022-06-27 12:33:46 -04:00
sebastian nordgren
9dded13186 MVVM - Removed IFieldPathHelper. The functionality was moved to the editor subsystem, which made the abstraction unnecessary and unavailable to blueprint. SMVVMFieldSelector, SMVVMSourceSelector and SMVVMPropertyPath all now reference FMVVMBlueprintPropertyPath instead.
FBindingSource no longer contains the IsSelected member. This was very context-specific, and doesn't really make sense in the general case.

[REVIEW] [at]patrick.boutot
#rnx

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20830654 via CL 20830665 via CL 20830673
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20833348 by sebastian nordgren in ue5-main branch]
2022-06-27 12:33:11 -04:00
hilda cruz
1fb89ec92b Back out changelist 20791814 to address NonUnity error.
#rnx
[FYI] sebastian.nordgren

#ROBOMERGE-AUTHOR: hilda.cruz
#ROBOMERGE-SOURCE: CL 20792871 via CL 20792928 via CL 20793025
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20794043 by hilda cruz in ue5-main branch]
2022-06-23 10:04:38 -04:00
sebastian nordgren
b162fd506f MVVM - You can only add bindings to a widget blueprint that already has viewmodels assigned to it.
It's impossible to create a valid binding without it, so there's not really any reason to allow it.

[REVIEW] [at]patrick.boutot
#rnx

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20791814 via CL 20791846 via CL 20791861
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20794026 by sebastian nordgren in ue5-main branch]
2022-06-23 10:04:01 -04:00
sebastian nordgren
38a082543e MVVM - Removed references to unused styles that were causing warnings on load.
#jira UE-155778
[REVIEW] [at]patrick.boutot
#rnx

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20572789 via CL 20572792 via CL 20572795
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20573125 by sebastian nordgren in ue5-main branch]
2022-06-09 05:58:22 -04:00
sebastian nordgren
f034b4cf33 MVVM - FMVVMBlueprintPropertyPath can now be stored in containers due to added GetTypeHash() and list type traits override.
[REVIEW] [at]patrick.boutot
#rnx
#preflight 62a07b8f3f2a47521b7c46e5

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20554699 via CL 20554714 via CL 20554735
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20559549 by sebastian nordgren in ue5-main branch]
2022-06-08 13:19:34 -04:00
patrick boutot
37fce7d953 MVVM: First draft of the viewmodel panel.
#rb sebastian.nordren

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20488825 via CL 20488833 via CL 20488842
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20490633 by patrick boutot in ue5-main branch]
2022-06-03 14:47:48 -04:00
patrick boutot
7d1f250e2e Change the Blueprint's OnExtensionAdded and OnExtensionRemoved to use raw pointer.
#rb daren.cheng

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20474504 via CL 20474689 via CL 20476272
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20478345 by patrick boutot in ue5-main branch]
2022-06-02 19:15:42 -04:00
sebastian nordgren
f3a922cc74 MVVM details view extension no longer crashes when given a row without an outer class.
This is fallout from the change to UStruct::IsChildOf() when called with this == nullptr.

#jira UE-154841
#rb paul.chipchase
#rnx
#preflight 62977a80e809e387be1f8882

[CL 20452664 by sebastian nordgren in ue5-main branch]
2022-06-01 10:56:01 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
sebastian nordgren
2f859c8d1d MVVM - Child viewmodel properties are no longer duplicated in the Manage ViewModels available bindings list. They were already returned by UMVVMSubsystem::GetAvailableBindings.
[REVIEW] [at]patrick.boutot
#jira UE-149560
#rnx
#preflight 628e26ddc511f67c9fc1d69d

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20364531 via CL 20364538 via CL 20364542
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20366755 by sebastian nordgren in ue5-main branch]
2022-05-25 12:27:38 -04:00
patrick boutot
2a32b857cc MVVM: Add message when no path exist to get a viewmodel at runtime
#rb sebastian.nordgren

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20351864 via CL 20351899 via CL 20351918
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20353879 by patrick boutot in ue5-main branch]
2022-05-24 15:35:08 -04:00
sebastian nordgren
35fe208abe MVVM: Added transactions and property chain notifications to SMVVMViewBindingListEntryRow.
#jira UE-145128
[REVIEW] [at]patrick.boutot, [at]vincent.gauthier
#rnx
#preflight 62877376286cf1867a460c97

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20294192 via CL 20294679 via CL 20294841
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20305133 by sebastian nordgren in ue5-main branch]
2022-05-20 18:54:53 -04:00
sebastian nordgren
15e617f2aa MVVM: Removed FMVVMViewModelPropertyPath and FMVVMWidgetPropertyPath in favour of FMVVMBlueprintPropertyPath.
[REVIEW] [at]patrick.boutot
#jira UE-145128
#rnx
#preflight 6287737b1e478b95c703f783

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20293477 via CL 20293498 via CL 20293511
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20305090 by sebastian nordgren in ue5-main branch]
2022-05-20 18:54:05 -04:00
patrick boutot
d176be730b MVVM: Checkbox is now to remove the binding from being compiled.
[REVIEW] vincent.gauthier

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20283782 via CL 20284105 via CL 20284220
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20304664 by patrick boutot in ue5-main branch]
2022-05-20 18:44:49 -04:00
sebastian nordgren
6a50bc56bd MVVM: SMVVMFieldSelector now has an optional IsFieldValid delegate, instead of passing in CounterpartHelpers.
[REVIEW] [at]patrick.boutot
#jira UE-145128
#rnx
#preflight 62862f702b53e2be4c9480a8

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20279867 via CL 20279892 via CL 20279906
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20282199 by sebastian nordgren in ue5-main branch]
2022-05-19 12:23:37 -04:00
patrick boutot
38b2f19b88 MVVM: Blueprint Path can now support long path. A deprecation path exist. The compiler was modified to support long path. A ViewModelCreator is generated for Manual, this allow the setter to works in standalone.
#rb sebastian.nordgren

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20259322 via CL 20259326 via CL 20259331
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20262972 by patrick boutot in ue5-main branch]
2022-05-18 12:54:12 -04:00
sebastian nordgren
da39e2e8f6 MVVM: Moved assignment of OnPropertyChanged to avoid selection change event from triggering during initialization.
#rb paul.chipchase
[FYI] patrick.boutot
#rnx
#preflight 6284a7c7614041edb75bc306

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20258485 via CL 20258501 via CL 20258506
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20262899 by sebastian nordgren in ue5-main branch]
2022-05-18 12:52:25 -04:00
sebastian nordgren
5bae3b8437 Reverting support for multiple argument conversion function, added in CL20180539, since parts of the feature are not yet fully supported.
[REVIEW] [at]patrick.boutot
#rnx
#preflight 62825d9e046b81bf93bd1eab

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20225765 via CL 20226030 via CL 20226046
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20228100 by sebastian nordgren in ue5-main branch]
2022-05-16 14:07:25 -04:00
sebastian nordgren
33fa385c27 MVVM - Conversion function selection now filters the list to just UBlueprintFunctionLibraries and the UUserWidget itself.
Conversion functions can now have multiple arguments as long as one of them is compatible.

[REVIEW] [at]vincent.gauthier, [at]patrick.boutot
#jira UE-141133
#rnx

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20180539 via CL 20180556 via CL 20180560
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20181301 by sebastian nordgren in ue5-main branch]
2022-05-13 10:47:00 -04:00
sebastian nordgren
0d25aeb634 SMVVMFieldSelector can now be used without a BindingMode set.
[REVIEW] [at]editor-ux-systems
#rnx
#preflight 627d12999f7ad2a14be3ec18

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20166243 via CL 20166397 via CL 20166462
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20167893 by sebastian nordgren in ue5-main branch]
2022-05-12 14:16:14 -04:00
patrick boutot
99e021c9de MVVM: Add add EMVVMBlueprintViewModelContextCreationType::Manual. An option for how to create/select a view model.
Rename a graph temporary function when the compiler didn't requested a GC at the end of the compilation.
#rb sebastian.nordgren

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20106550 via CL 20107643 via CL 20108182
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20110552 by patrick boutot in ue5-main branch]
2022-05-09 16:35:28 -04:00
sebastian nordgren
fc1eadd511 MVVM - The Getter dropdown in Manage ViewModels when the mode is set to Get From Property Path list no longer includes the viewmodel entry itself.
Removed unnecessarily duplicated widget code taken from SMVVMFieldEntry in favor of just using that.

#jira UE-147743
[REVIEW] [at]vincent.gauthier, [at]patrick.boutot
#rnx

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 20100774 via CL 20100789 via CL 20100796
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20108574 by sebastian nordgren in ue5-main branch]
2022-05-09 15:11:47 -04:00