Commit Graph

59 Commits

Author SHA1 Message Date
Joakim Lindqvist
c159fac11a Adding command line override for Jupiter Host in ShooterGame, DDCHttpHost
Changed the Dev toggle for CookCompare to use this.
This can also be used to locally toggle Jupiter to run against a local deployment.

[CL 15527157 by Joakim Lindqvist in ue5-main branch]
2021-02-25 06:12:30 -04:00
Marcus Wassmer
3b81cf8201 Merging using //UE5/Main_to_//UE5/Release-Engine-Staging @14384769
autoresolved files
#rb none

[CL 14384911 by Marcus Wassmer in ue5-main branch]
2020-09-24 00:43:27 -04:00
danny couture
0655582bd0 Fix stutters in the game-thread while streaming texture mips from DDC.
This will fix a good bunch of ForceRebuildPlatformData in UTexture2D::UpdateStreamingStatus because of the Boot DDC telling it has some mips cached effectively preventing other cache layers from receiving them.
When the Boot DDC is disabled after the editor boot, all the mips will go into oblivion, and nobody will have them anymore, causing stutters in the game-thread while streaming because a second full rebuild is now required.

Any DDC that plans on disappearing should never be alone in the cache hierarchy and should give other levels the opportunity to properly cache data before its disapperance.

#rb Francis.Hurteau, Devin.Doucette, Andrew.Grant

[CL 14268431 by danny couture in ue5-main branch]
2020-09-08 10:50:47 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
Matt Kuhlenschmidt
603a4119c5 Fix HAL/PlatformFileManager.h non-portable casing CIS issues
#rb none

[CL 13214257 by Matt Kuhlenschmidt in ue5-main branch]
2020-05-06 17:58:18 -04:00
andrew grant
c580697c24 Made the pop-up warning at startup about the shared DDC path being missing optional.
- The engine ships by default with a shared entry in the graph that doesn't exist so this prevents it showing for projects that haven't yet set it up.
- The value in this prompt is situational. It's beneficial on Fortnite where a huge amount of DDC content is needed to get into the game and WFH (and Mac) users may be missing a mounted drive, but less important on smaller projects.

Also documented the "UE-EnvVar=None" trick in the ini file where the DDC behavior is described.


#tests Ran with PromptIfMissing=true and verified the prompt occurred when the path didn't exist. Ran with PromptIfMissing=false and verified there was no prompt but still a warning.

[REVIEW] [at]brandon.schaefer [at]devin.doucette
[FYI] stefan.boberg


#ROBOMERGE-SOURCE: CL 13187183 via CL 13187231 via CL 13187280
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v688-13145358)

[CL 13187317 by andrew grant in Main branch]
2020-05-05 15:50:08 -04:00
andrew grant
7c2df5fb70 Editgrate fix for warning about -ddc=default not being a valid backend
[FYI] marc.audy

#ROBOMERGE-SOURCE: CL 13043962 via CL 13043963 via CL 13043964
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v683-13008971)

[CL 13043965 by andrew grant in Main branch]
2020-04-24 20:11:55 -04:00
andrew grant
835b997f53 Edit-grated improved DDC behavior logging from Main to get better info around failing cooked tests
Temporarily turning on verbose DDC logging for EngineTest project

[FYI] zabir.hoque ben.ingram
#jira #rb na
#lockdown cristina.riveron

#ROBOMERGE-OWNER: andrew.grant
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 12911373 in //UE4/Release-4.25/... via CL 12911375 via CL 12911433
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12911435 by andrew grant in Main branch]
2020-04-19 14:32:34 -04:00
andrew grant
c0c327ac48 Fix for shader compilers showing message about unmapped drives
[FYI] chance.ivey
#rb swarm

#ROBOMERGE-SOURCE: CL 12678563 via CL 12678843 via CL 12678861 via CL 12678882
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12678920 by andrew grant in Main branch]
2020-04-08 16:41:08 -04:00
ben marsh
538ac728ad Allow disabling the S3 backend by setting the UE-S3DataCachePath environment variable to "None"
#rb none
#jira

#ROBOMERGE-SOURCE: CL 12486037 via CL 12486375 via CL 12486409 via CL 12486440
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12487544 by ben marsh in Main branch]
2020-03-30 12:12:06 -04:00
andrew grant
963ad0c629 Allow users to customise S3 path by setting an UE-S3DataCachePath environment variable. If not set the default of ProjectDir/Saved/S3DDC is still used
#rb swarm
[at]devin.doucette [at]ben.marsh
[FYI] antoine.guilbaud
#tests Booted editor and PIE'd into AthenaTest with UE-S3DataCachePath set to a different drive. Verified data is there.

#ROBOMERGE-SOURCE: CL 12474206 via CL 12474221 via CL 12474232 via CL 12474240
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12474252 by andrew grant in Main branch]
2020-03-27 15:57:11 -04:00
andrew grant
14d1b683f8 Moved some DDC debug options into a common class that can be provided to a backend to simulate certain behavior.
E.g.

'-ddc-local-missrate=50' simulates a 50% miss rate of keys on the local backend,
'-ddc-shared-misstypes=AnimSeq' simulates misses for any AnimSeq key. Use + to combine keys. E.g. AnimSeq+Audio

Memory DDC, FileSystemDDC and S3DDC support these options as do the classes that wrap other backends (e.g. AsyncPut).

#tests lots of warm and cold DDC
#swarm https://p4-swarm.epicgames.net/reviews/12458696

#ROBOMERGE-SOURCE: CL 12466119 via CL 12466177
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12466179 by andrew grant in Main branch]
2020-03-27 08:12:16 -04:00
andrew grant
e224300cc3 Moved some DDC debug options into a common class that can be provided to a backend to simulate certain behavior.
E.g.

'-ddc-local-missrate=50' simulates a 50% miss rate of keys on the local backend,
'-ddc-shared-misstypes=AnimSeq' simulates misses for any AnimSeq key. Use + to combine keys. E.g. AnimSeq+Audio

Memory DDC, FileSystemDDC and S3DDC support these options as do the classes that wrap other backends (e.g. AsyncPut).

#tests lots of warm and cold DDC
[at]ben.marsh [at]josh.engebretson [at]devin.doucette

#ROBOMERGE-SOURCE: CL 12458693 via CL 12462167 via CL 12464485 via CL 12464606
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12464717 by andrew grant in Main branch]
2020-03-26 20:55:39 -04:00
ben marsh
a4c0ecd2eb Suppressing errors about S3DDC if disabled.
#jira

#ROBOMERGE-SOURCE: CL 12455905 via CL 12455924 via CL 12455926 via CL 12460993 via CL 12461148
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12461272 by ben marsh in Main branch]
2020-03-26 17:59:17 -04:00
andrew grant
3cc86b3d2f Optimizations for DDC access on remote / slow drives.
If a filesystem node is not available not prompt the user and optionally retry incase they need to mount a drive or start VPN

Fiilesystem nodes now perform a speed test using a selection of 'DDC sized' files to determine a classification (local, fast, ok, slow).

Add a new 'ConsiderSlowAt' property to the 'Filesystem' DDC node type. If latency to the node is >= this value then the node will be marked as slow which disables touch'ing and reduces file stats

Interface Changes

- Add the concept of a speed class to nodes
- Add GetName to nodes for better debugging / logging
- WouldCache query that allows caches to opt of of consideration early and avoid async tasks being created.
- Create a new 'FileBackedDerivedDataBackend' class that's the for the memory/boot backend and future classes
- TryToPrefetch interface functions for future use

Behavior Changes

- Moved parameter parsing into FileSysteDerivedDataBackend as things were getting out of hand
- FileSystemDerivedDataBackend now performs a speed test using 'DDC sized' files in separate directories and applies a classification
- Slow locations turn off touching of data on read
- Slow locations always return true for CachedDataProbablyExists. It's faster just to try to read and fail
- If the shared DDC is not available the user is prompted incase they need to mount it.

[at]ben.marsh [at]josh.engebretson
#rb swarm
#tests lots of PIE runs with / without this option


#ROBOMERGE-SOURCE: CL 12387516 via CL 12387517 via CL 12396622
#ROBOMERGE-BOT: (v671-12333473)

[CL 12396757 by andrew grant in Release-Engine-Staging branch]
2020-03-24 19:12:36 -04:00
devin doucette
77c43f6842 Improved DDC error when no backends are available
#jira UE-90680
#rb Zousar.Shaker
[RN] fix Core/Cooker

#ROBOMERGE-SOURCE: CL 12247507 in //UE4/Release-4.25/... via CL 12247524
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v668-12245121)

[CL 12247553 by devin doucette in Main branch]
2020-03-18 11:14:04 -04:00
ben marsh
31934e0cc1 Add an optional parameter to the filesystem DDC backend that logs any accesses to a particular key, so we can extract data for uploading to S3.
#jira
[FYI] Josh.Engebretson


#ROBOMERGE-SOURCE: CL 12166421 via CL 12166427 via CL 12166431
#ROBOMERGE-BOT: (v661-12148976)

[CL 12166433 by ben marsh in Main branch]
2020-03-13 15:35:22 -04:00
ben marsh
ff74b40543 Disable S3 DDC backend on Mac due to missing libcurl implementation causing link errors.
#jira


#ROBOMERGE-SOURCE: CL 12154529 via CL 12155941 via CL 12156003
#ROBOMERGE-BOT: (v659-12123632)

[CL 12156082 by ben marsh in Main branch]
2020-03-12 18:00:07 -04:00
ben marsh
7d6083104f Add experimental DDC backend which fetches objects from an S3 bucket. Bucket is populated by a job running periodically on build machines, and generates a JSON manifest used to determine files to download.
#rb none
#rnx
#jira


#ROBOMERGE-SOURCE: CL 12147942 via CL 12147943 via CL 12149500
#ROBOMERGE-BOT: (v659-12123632)

[CL 12149604 by ben marsh in Main branch]
2020-03-12 13:29:21 -04:00
ryan durand
471d972e62 Updating copyright for Engine Developer.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870584 by ryan durand in Main branch]
2019-12-26 15:32:37 -05:00
ben marsh
102b2a4930 Allow overriding the shared DDC path via a command line option (-SharedDataCachePath=...).
#jira


#ROBOMERGE-SOURCE: CL 8498023 via CL 8501495
#ROBOMERGE-BOT: (v406-8472469)

[CL 8505402 by ben marsh in Main branch]
2019-09-05 11:42:07 -04:00
Ben Marsh
7598af0532 Update copyright notices to 2019.
#rb none
#lockdown Nick.Penwarden

[CL 4662404 by Ben Marsh in Main branch]
2018-12-14 13:41:00 -05:00
Ben Marsh
2d3ea5e946 Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 4285612)
#lockdown Nick.Penwarden

============================
  MAJOR FEATURES & CHANGES
============================

Change 3836829 by Ben.Marsh

	UBT: Fix ability to precompile plugins from installed engine builds.

Change 3839519 by Ben.Marsh

	UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data.

Change 4042043 by Steve.Robb

	GitHub #4705 : Added weak lambda's for delegates and multicast delegates.

Change 4042056 by Robert.Manuszewski

	Optimized Mark Phase of GC by up to 10ms by making it run in parallel and removing a huge array presize which we didn't need.

Change 4042104 by Robert.Manuszewski

	Set the minimum GC cluster size to 5 so that GC doesn't have to process micro clusters which are more expensive than processing individual objects

	+ Exposed the minimum cluster size to ini and project settings as gc.MinGCClusterSize
	+ Added the ability to sort clusters by name/object count/mutable object count/referenced clusters count when dumping them with gc.ListClusters command

Change 4042377 by Robert.Manuszewski

	Reworked how GC and other threads (ALT specifically) interact - GC will now notify the ALT it wants to run and ALT will immediately try to finish its current work to allow that. Also the entire ALT tick is now protected against GC running at the same time to improve ALT stability.

	+ added gc.ForceCollectGarbageEveryFrame console variable that triggers a forced GC every frame

Change 4042427 by Robert.Manuszewski

	Changed FGCCSyncObject to use events when waiting for GC to finish so that it doesn't spin on non-game threads when GC is running

Change 4042482 by Robert.Manuszewski

	Unhashing unreachable objects (ConditionalBeginDestroy) will now also be done incrementally, just like the purge phase of Garbage Collection

Change 4042635 by Robert.Manuszewski

	Fix for a potential assert when incremental purge garbage is pending and something forces a full purge

Change 4044092 by Steve.Robb

	Fix for forward declared CoreUObject weakobject types in delegates when building in Clang.

Change 4044102 by Robert.Manuszewski

	Fix for a possible hang when worker threads are preventing GC from running and something is later trying to FlushAsyncLoading with the Async Loading Thread enabled

Change 4044113 by Steve.Robb

	Another Clang fix.

Change 4044160 by Robert.Manuszewski

	Disregard For GC pool will now be enabled by default in cooked builds

Change 4044287 by Steve.Robb

	Typo fix.

Change 4047723 by Graeme.Thornton

	TBA: Fixes for import/export name cache and object resolving

Change 4048015 by Graeme.Thornton

	TBA: Weak/Soft/Lazy pointer serialization changes

	* Remove FWeakObjectPtr::Serialize, move it's logic into, and replace usages of with calls to, FArchiveUObject::SerializeWeakObjectPtr(). Ensures that something is always sent to the archive so that structured archives can be kept happy in the future.
	* Added Weak/Soft/Lazy pointer handling to the structured archive slot interface and all the formatters. Binary formatters just forward the call onto their inner and text archives store as a string path reference.
	* FArchiveUObjectFromStructuredArchive caches all these pointer types and stores indices in the binary block, same as with a UObject*. All pointers are then forwarded to the underlying formatter in one go on finalization.

Change 4048021 by Steve.Robb

	Fix for binding an unbound TFunction to another TFunction with a different signature.  Also all null pointers now count as unbindings, not just nullptr.
	TIsMemberPointer added.
	TIsATFunction and TIsATFunctionRef renamed to remove the 'A's.

Change 4048544 by Robert.Manuszewski

	Fixing ConditionalBeginDestroy profiling after changes to incremental CBD.

Change 4051028 by Graeme.Thornton

	TBA: ArchiveFromStructuredArchive adapter uses Inner to determine if it is outputting to text, and sets it's own ArIsTextFormat to false

Change 4051056 by Graeme.Thornton

	TBA: High level tagged property / UObject base class text serialization
	 - UObject serialize converted to structured archive
	 - Properties written to text individually with text tags, and then binary adapted values
	 - Only saves, doesn't load

Change 4051111 by Graeme.Thornton

	TBA: Temporarily disable loading of text assets until tagged property serialization path is fixed up

Change 4051154 by Graeme.Thornton

	TBA: Convert a few uobject serializers to structured archive format for example purposes

Change 4051181 by Graeme.Thornton

	TBA: Added default structured archive implementation of SerializeItem to UProperty, which just calls the FArchive version on an FArchiveUObjectFromStructuredArchive adapter. Implemented structured archive SerializeItem for UArrayProperty

Change 4051197 by Graeme.Thornton

	TBA: ObjectProperty text serialization

Change 4051216 by Graeme.Thornton

	Restored a modified FWeakObjectPtr::Serialize function to keep backwards compatibility in code I don't have access to.

Change 4051261 by Graeme.Thornton

	TBA: Convert UMetaData to structured archive

Change 4051374 by Steve.Robb

	Incorrect assert removed.

Change 4051562 by Robert.Manuszewski

	Adding stats for the new GC internal functions

Change 4051614 by Graeme.Thornton

	TBA: Removed UProperty::SerializeItem(FArchive, ...) and replaced with UProperty::SerializeItem(FStructuredArchive::FSlot, ...). Fixed up most of them to work properly and added adapters in for any that were non-trivial.

Change 4052512 by Graeme.Thornton

	TBA: Temporary workaround for softobjectptr and lazyobjectptr uproperties not serialization anything when they know the archive is a reference collector. They should always be serializing their pointers and letting the underlying archive itself ignore them.

Change 4053917 by Robert.Manuszewski

	Clustered objects from clusters that are no longer reachable will now be marked as unreachable immediately when gathering unreachable objects

Change 4053919 by Robert.Manuszewski

	Added the ability to disable incremental BeginDestroy in ini/project settings

Change 4055518 by Daniel.Lamb

	Fixup for deterministic audio generation issue.
	Submitted on behalf of Rich.Whitehouse

	#jira nojira
	#test prefilght automated test.

Change 4056854 by Graeme.Thornton

	TBA: Added a test asset to EngineTest which contains all the different property types and test cases.

Change 4056858 by Graeme.Thornton

	TBA: Updated USetProperty to proper structured archive usage

Change 4056872 by Graeme.Thornton

	TBA: Add map property field to test object

Change 4056873 by Graeme.Thornton

	TBA: Convert UMapProperty to full structured archive

Change 4056994 by Graeme.Thornton

	TBA: Converted FText over to structured archive. Implemented saving, but not loading.

Change 4059728 by Ben.Marsh

	UBT: Add support for using adaptive non-unity builds when the engine and project are in separate repositories.

Change 4059805 by Graeme.Thornton

	Fixed typo in text serialization. Fixes CIS automation test errors

Change 4060007 by Graeme.Thornton

	TBA: FArchiveFromStructuredArchive will now access it's host slot lazily, i.e. only when a value is actually written to the archive.

Change 4060092 by Stefan.Boberg

	Added optimized Windows console window output path to GenericConsoleOutput since this slowed down cooking considerably (2 minutes spent in wprintf alone for one large dataset)

	When stdout is attached to a console we use the WriteConsoleW function instead of wprintf since the latter is very slow especially in unbuffered mode which the engine currently configures for stdout (see setvbuf call in LaunchEngineLoop.cpp).

	At some point we should reconsider this buffering policy since it's likely to slow down other platforms as well but I wanted to do a safe change for now as I don't yet fully understand why the setvbuf call is there in the first place.

Change 4060108 by Stefan.Boberg

	Introduced some additional target platform utilities to help with asset cook optimizations

	* We now assign each ITargetPlatform a zero-based ordinal value
	* Introduced FTargetPlatform and FTargetPlatformSet types to help store platform references and platform sets efficiently.

	These are not currently used in the engine but are designed to replace the existing ITargetPlatform/string/FName representations in the cooking data structures.

Change 4060143 by Graeme.Thornton

	Undo //UE4/Dev-Core/Engine/Source/Runtime/... changelist 4060007

	Needs some other changes that I haven't checked in yet...

Change 4062432 by Ben.Marsh

	Fix error message when enumerating P4 changes.

Change 4062648 by Ben.Marsh

	Add missing p4 integration action.

Change 4063620 by Graeme.Thornton

	Integrated a fix from UDN where the engine would crash when trying to load a very small encrypted file (<16bytes) from a pak file, where the read address wasn't already aligned to the AES block size.

	(https://udn.unrealengine.com/questions/431989/crash-while-reading-a-very-small-file-in-encrypted.html)

Change 4066963 by Robert.Manuszewski

	Fixing GC cluster verification code reporting false positives when a cluster is referencing another cluster through 'mutable' objects list.

Change 4067133 by Robert.Manuszewski

	Changed log verbosity when reporting individual cases of GC cluster assumption violations as they are followed by an asser anyway and this way we get the chance to see all issues before we assert at the end of these checks.

Change 4067443 by Steve.Robb

	FString can now be constructed from any char pointer type and length.

Change 4068156 by Steve.Robb

	Fix necessary because of FString constructor change in CL# 4067443.

Change 4070258 by Graeme.Thornton

	Fixes for VSCode

Change 4070372 by Graeme.Thornton

	TBA: Script struct serialization to structured archives

Change 4071913 by Ben.Marsh

	Move bulk of the code for UnrealPak into an engine developer module, so it can be used in the editor.

Change 4071914 by Ben.Marsh

	Missing files.

Change 4071937 by Ben.Marsh

	Missing header.

Change 4072015 by Ben.Marsh

	Fixes for compiling PakFileUtilities as part of the editor.

Change 4072826 by Steve.Robb

	TBitArray::Reserve() added.
	TBitArray::Add() overloaded to allow adding multiple bits.
	TSparseArray::Reserve() optimized to call the overloaded Add().

Change 4073271 by Daniel.Lamb

	Fixed add patch tier in project launcher passing the wrong commandline option to UAT.

	#test none

Change 4074708 by James.Hopkin

	#core Removed redundant Casts

Change 4074763 by Steve.Robb

	Fix for TSparseArray::Reserve() size.

Change 4076063 by Ben.Marsh

	Add an "UnrealPak" commandlet with the same functionality as the standalone UnrealPak program. Invoke by running the editor with -run=UnrealPak and the standard UnrealPak commandline options.

Change 4077064 by Robert.Manuszewski

	Fixing compile error in PakFileUtilities

Change 4077144 by Graeme.Thornton

	TBA: TextAssetCommandlet improvements

	* Collect lists of broken assets during roundtrip tests and print a summary of packages that failed each phase at the end
	* After resaving as text, load the file back as a plain JSON hierarchy to ensure the output was valid

Change 4077412 by Ben.Marsh

	Set the correct exit code for UnrealPak. Should return 0 on success, not 1.

Change 4077760 by Graeme.Thornton

	TBA: Loading fixed for tagged property serialization

	Includes conversion of all UProperty::ConvertFromType() and SerializeFromMismatchedTag() functions to use structured archives

	Lazy initialization of FArchiveFromStructruredArchive when loading, to support the possibility of an adapter being create around an object property serialize call to its inner UStruct, which then decides not to do anything and return false. Stops the ArchiveFromStructuredArchive from consuming the slot and getting upset later on when we try to serialize normal tagged properties from it.

	Disabled lazy bulk data loading from text assets. Requires a bigger change to make it work.

	Added some debug checks to json input formatter which track the current value stack size when a new object is pushed onto the stack, and makes sure that the stack has returned to the same size when the object is popped. Catches cases where we unpack an array/stream to the value stack but then don't consume all the items.

Change 4078800 by Ben.Marsh

	Change UAT to using the editor's UnrealPak commandlet rather than invoking the standalone UnrealPak executable. To improve performance when building several PAK files, also add a new -batch=<file> command which reads commands to execute in parallel from a text file.

Change 4079745 by Graeme.Thornton

	TBA: Migrated a couple of UObject Serialize functions to FStructuredArchive (SoundCue / MaterialExpressions / Editor strip flags)

Change 4079847 by Graeme.Thornton

	TBA: Add 'FindMismatchedSerializers' mode to text asset commandlet, which dumps out a list of all UClasses which don't have the CLASS_MatchedSerializers flag, meaning we can't guarantee the have Serialize functions for FArchive AND FStructuredArchive, therefore we can't use the new structured archive based serialize path. Should only ever be native instrinsic classes as UHT takes care of all other cases.

Change 4079925 by Ben.Marsh

	Fix incorrect assignment when deriving name for chunked pak file.

Change 4080214 by Ben.Marsh

	Move the ThreadPoolWorkQueue class into DotNETUtilities so it can be used by other projects.

Change 4082394 by Graeme.Thornton

	CIS fix for variable shadowing warning

Change 4082583 by Ben.Marsh

	Add a IBinarySerializable interface for types that support reading from a BinaryReader and writing to a BinaryWriter. Implementing IBinarySerializable implies a constructor taking a BinaryReader argument is available for deserializing.

Change 4082652 by Ben.Marsh

	Fix FileReference.Directory not returning a directory with a trailing backslash for files in the root directory.

Change 4082755 by Graeme.Thornton

	Fixed an erroneous usage of TUniquePtr<uint8>as a pointer to a uint8 array when creating pak files. Caused a crash when compression was enabled, and has probably surfaced because pak generation is now done by an editor commandlet rather than a standalone program.

Change 4082756 by Graeme.Thornton

	Fixed some incorrect documentation for pakfile compressed chunk headers

Change 4082883 by Graeme.Thornton

	Static analysis warning fix

Change 4082912 by Ben.Marsh

	Move ExceptionUtils into DotNETUtilities.

Change 4085291 by Graeme.Thornton

	TBA: In the Json output formatter, write float and double values out with enough precision for successful roundtripping. Added some debug only code which will immediately reconvert the string back to its original value and compare the the input

Change 4085523 by Graeme.Thornton

	TBA: Remove only explicit usage of DECLARE_FSTRUCTUREDARCHIVE_SERIALIZER. Should only be used from UHT generated code.

Change 4086037 by Robert.Manuszewski

	Fix for a potential race condition when two threads want to acquire GC lock

Change 4088655 by Graeme.Thornton

	Pak creation now uses the bEnablePakSigning setting from the crypto config json file

Change 4091474 by Steve.Robb

	Fix for TStaticBitArray::FindFirstSetBit() and TStaticBitArray::FindFirstClearBit().
	Unused variables removed.

Change 4093632 by Steve.Robb

	CIS fixes.

Change 4093656 by Graeme.Thornton

	Build fix

Change 4093744 by Ben.Marsh

	Allow per-chunk settings for whether to enable compression in UnrealPak.

Change 4099712 by Gil.Gribb

	UE4 - Fixed rare case where insufficient space was preallocated for cooldown ticks.

	#jira UE-59686

Change 4099912 by Stefan.Boberg

	Cooking timer optimizations:

	- Replaced data structures for FScopeTimer and FHierarchicalTimerInfo. Previous implementation used FString for many things and caused *lots* of heap and string concatenation activity. Replaced with a compile-time node id (using __COUNTER__) and raw string literals.
	- Removed PERPACKAGE_TIMER support (was disabled by default and was difficult to test)
	- Made it possible to toggle OUTPUT_TIMING and ENABLE_COOK_STATS independently
	- Removed some extremely tight timers because the overhead from calling QPC significantly exceeded the measured code

	This change shaved some 15% off a clean cook of Fortnite WindowsClient (en) with fully populated local DDC

Change 4100519 by Stefan.Boberg

	Quick fix for Linux build issue introduced in 4099927

Change 4105327 by Stefan.Boberg

	Cooker: Changed FHierarchicalTimerInfo so it uses a linked list for tracking child nodes, to be able to deal with any child count. Previously we assumed there would never be more than 9 children but it turns out there are cooker modes that need more.

	Fixes check when using -FullLoadAndSave to cook

Change 4105448 by Stefan.Boberg

	- Fixed Linux build warning re: member initialization order
	- Also eliminated OUTPUT_HIERARCHYTIMERS/CLEAR_HIEARCHYTIMERS macros (plain functions are fine)
	- Moved finishing-up code for FullLoadAndSave() to TickCookOnTheSide() call site to improve timer output. Previously some of the scopes would not have been closed before printing and thus the output was misleading.

Change 4109031 by Ben.Marsh

	Attribute-driven Perforce wrapper (old Epic Friday project). Offers a more complete implementation than the current P4 wrapper in UAT without requiring any platform-specific libraries. Uses the Python binary output for parsing.

Change 4109588 by Ben.Marsh

	UBT: Add extension methods for serializing a nullable type to a BinaryReader/BinaryWriter.

Change 4109595 by Ben.Marsh

	Missing project file for DotNETUtilities.

Change 4110724 by Stefan.Boberg

	Removed annotation map locking in UObjectMarks, eliminating around one minute (~3.5%) from Fortnite cook time.

	The locking was redundant since the annotation maps are managed per thread anyway.

Change 4111304 by Ben.Marsh

	UAT: Add support for setting a status message through the log class. Allows writing transient messages (eg. progress messages) which will be cleared out before writing other messages. Best used through the LogStatusScope class, which can set a status message for the duration of a using() block.

	As part of this change, the console no longer has to be added as a dedicated trace listener. Since we already special-case this listener when formatting log output, it's easier to just keep the implementation separate to the other trace listeners.

Change 4112708 by Steve.Robb

	Fix for TBitArray::MaxBits in assignment.

Change 4114133 by Stefan.Boberg

	Tweaked how low-level memory (LLM) tracker is implemented to reduce overheads.

	Previously FMemory functions would acquire the LLM singleton and call OnLowLevelFree/OnLowLevelAlloc etc which would check the bIsDisabled flag and early out if it was set. Due to how frequently these functions were called this ended up costing quite a bit.

	- This change makes the flag a static member variable instead of a member variable and therefore enables a simpler early-out to be implemented.
	- The singleton getter is also simplified to avoid hitting the threadsafe singleton construction path on every call.
	- The enable flag is no longer TAtomic - this also incurs extra overhead for no clear benefit

	Shaves approximately 3.5% (one minute) off a Fortnite cook test scenario (using -FullLoadAndSave)

Change 4115010 by Robert.Manuszewski

	Fixing CIS

Change 4115249 by Robert.Manuszewski

	Fixing async loading code asserts when exiting game very early due to an error

	#jira UE-56267

Change 4117091 by Ben.Marsh

	Prevent doubled-up lines when writing status updates with console log verbosity.

Change 4117207 by Ben.Marsh

	UGS: Do not include executables in diagnostics zip file, and ignore "no such files" error when cleaning workspace.

Change 4119175 by Ben.Marsh

	UGS: Fix crash writing version files when directory does not already exist.

Change 4119987 by Ben.Marsh

	UGS: Show a dialog box while the launcher is updating executables from Perforce, which allows cancelling the operation if necessary. Allow setting the username on the settings window, and prompt for login credentials if necessary. Should prevent situations where users have to update settings from the command prompt.

	Holding down shift during launch now shows the settings dialog rather than an immediate prompt to launch the unstable version (unstable version is shown as a checkbox on this dialog).

Change 4119991 by Ben.Marsh

	Update version number for UGS launcher to 1.13.

Change 4121943 by Robert.Manuszewski

	Don't use FArchiveAsync2 for reading packages with non-async path in editor builds as its performance is worse than the standard archive's (saves about 1 minute when doing larger cooks and 7 seconds when loading into PIE)

Change 4122592 by Steve.Robb

	GitHub #4762 : Improve wording and grammar of Math comments
	Also includes improved accuracy in FMath::ComputeBoundingSphereForCone().

Change 4122819 by Stefan.Boberg

	Don't call CreateDirectory redundantly when opening files for writing using FFileManagerGeneric::CreateFileWriter

	This change avoids calling IPlatformFile::CreateDirectoryTree if possible since this is a very expensive function especially for deep hierarchies as it performs directory creation from the root directory onwards instead of from the leaf downwards. That function should also be fixed but this change improves performance in the meantime.

Change 4122872 by Stefan.Boberg

	CreateDirectoryTree now creates directories leaf-to-root instead of the other way around. This is much more efficient since we don't spend time on system API calls for directories which already exist. This accounted for a very large amount of CPU time in cooking as the full target file directory hierarchy would be "created" for every single output file.

Change 4123109 by Stefan.Boberg

	- Disable overlapped I/O in editor / cooker. Synchronous I/O reduces the number of syscalls and Windows performs prefetching on our behalf anyway for sequential reads
	- Eliminated syscall which was issued for every write to update cached file size -- since we're the only writers to the file (file access allows read sharing at most) we can authoritatively update the file size on write completion

Change 4123455 by Ben.Marsh

	PR #4775: New build param PCHMemoryAllocationFactor to set /Zm VS build param. (Contributed by lucaswall)


Change 4124207 by Ben.Marsh

	UBT: Remove some unnecessary indirection for generated code paths.

Change 4124217 by Ben.Marsh

	UBT: Remove another unused variable from UEBuildModuleCPP.

Change 4124377 by Stefan.Boberg

	In IPlatformFile::DeleteDirectoryRecursively, attempt to delete file first and if it fails clear the readonly flag and try again

	Previously there was a call to clear the readonly flag for every deleted file and this is a waste of resources 99% of the time. The SetFileAttributes call accounted for a significant amount of time during cooker sandbox directory deletion

Change 4125071 by Stefan.Boberg

	Some tweaks to FQueuedThreadPoolBase scheduling and memory management

	- Explicitly pass in false for TArray::RemoveAt(..., bool bAllowShrinking) argument to prevent memory reallocation when arrays are drained and inevitably repopulated shortly afterwards
	- Use a MRU strategy instead of LRU when picking a thread to wake up. The MRU thread is the most likely to have a 'hot' cache for the stack etc. Picking from the back of the array also happens to be cheaper since
	no memory movement is necessary when RemoveAt is called. (This was the strategy in place before CL2600362 which seems to have changed it unintentionally)
	- Release lock as soon as a thread has been chosen, before asking the worker thread to wake up and do the work

Change 4126132 by Ben.Marsh

	UAT: Detect when stdout is redirected and prevent using backspace characters to move the cursor.

Change 4126867 by Graeme.Thornton

	TBA: Fix tagged binary formatter

Change 4127010 by Robert.Manuszewski

	AnimScriptInstances created at runtime will now also be added to the owning omponent's cluster to avoid GC issues.

Change 4127932 by Ben.Marsh

	WorkspaceTool: Reduce unnecessary logging of status messages when console output is not redirected.

Change 4129050 by Ben.Marsh

	UGS: Check for NET Framework 4.5 being installed before running the installer. Also fix warning trying to kill existing UGS instances before upgrade.

Change 4129459 by Graeme.Thornton

	TBA: TextAssetCommandlet - When outputting converted assets to an output path, replicate the workspace relative path in the output directory

Change 4129515 by Graeme.Thornton

	TBA: Add EnterRecord overload that allows outputting of available field names when loading.

Change 4129517 by Graeme.Thornton

	TBA: Tagged properties are written out as named fields on the "Properties" record, rather than as a stream with a null tag at the end

Change 4129518 by Graeme.Thornton

	TBA: Added a local const bool to allow easy hacking out of text asset loading support

Change 4129558 by Graeme.Thornton

	TBA: Build fix for textasset-less configs

Change 4129614 by Ben.Marsh

	UGS: Main window is now restored to normal size when activated by clicking on the tray icon.

	#jira UE-60490

Change 4129618 by Ben.Marsh

	UGS: Speculative fix for unreproduced exception accessing disposed window while shutting down.

Change 4131936 by Robert.Manuszewski

	Removing some WIP code accidentally checked in with CL #4121943

Change 4133490 by Ben.Marsh

	UGS: Allow the $(Change) variable to be used in more places than just the context menu.

	#jira UE-60573

Change 4133550 by Ben.Marsh

	UGS: Setting for whether or not to use incremental builds is now exposed through the variable "$(UseIncrementalBuilds)" for use by custom build steps.

	#jira UE-60554

Change 4133681 by Ben.Marsh

	UGS: A per-project list of folders and extensions to be deleted by default when running the 'clean workspace' tool can now be specified through the <ProjectDir>/Build/UnrealGameSync.ini file. Settings may be specified for an individual branch (via a category with the depot path to the project) or for wherever the project is currently open (via the [Default] category).

	The SafeToDeleteFolders list specifies a substring that will be checked against folder paths. Anything containing this folder will be marked as safe for delete by default.

	The SafeToDeleteExtensions list specifies a list of extensions for files that can always be deleted.

	Example:

	 [Default]
	+SafeToDeleteFolders=/MyGame/Test/
	+SafeToDeleteFolders=/DataService/
	+SafeToDeleteExtensions=.xx1
	+SafeToDeleteExtensions=.xx2

	#jira UE-60575

Change 4135449 by Ben.Marsh

	Fix allowing use of Job objects on Windows platforms (debug code submitted by mistake)

Change 4135730 by Ben.Marsh

	UBT: Plugins can now be enabled and disabled from the .target.cs file (for targets that do not use the shared compile environment), by compiling the list of enabled/disabled plugin names into the Projects module.

Change 4135823 by Ben.Marsh

	UBT: Remove legacy code to handle disabling optional plugins; now that this is compiled into the target, it will work for any plugins we choose.

Change 4135945 by Ben.Marsh

	UBT: Fix error running programs with no explicitly enabled or disabled plugins.

Change 4137207 by Ben.Marsh

	UGS: Align all badges with the same name, to make it easier to see which CIS steps are being run. Allow overriding the slot taken by a particular badge by calling it "SlotName:LabelName".

Change 4137311 by Stefan.Boberg

	Removed child cooker support.

	In practice it is not a useful feature as it provides no performance improvement (quite the opposite in fact) and adds testing and maintenance complexity.

Change 4137393 by Ben.Marsh

	UGS: Fix display of multiline errors in the status panel.

Change 4141708 by Steve.Robb

	GitHub #3631 : Incorrect default argument in WeakObjectPtrTemplate

	#jira UE-45490

Change 4146655 by Stefan.Boberg

	Removed FullGCAssetClasses logic - no longer necessary nor useful

Change 4147318 by Ben.Marsh

	UGS: Compress build badges in a column if it shrinks below the size that they would be visible.

Change 4148207 by Ben.Marsh

	UGS: Added support for showing the latest completed build from a specific list of badges in the status panel. To declare a badge as one that should appear in the status panel rather than the CIS column, add it to the project's UnrealGameSync.ini in the project or [Default] section like so:

	+ServiceBadges=RoboMerge

Change 4148282 by Stefan.Boberg

	Fixed bug in UCookOnTheFlyServer::GetCookOnTheFlyUnsolicitedFiles - UnsolicitedFiles should be passed by reference not by value

Change 4148344 by Stefan.Boberg

	Fixed minor indentation error (most likely caused by sloppy merge)

Change 4148521 by Stefan.Boberg

	Removed accidentally checked in PRAGMA_DISABLE_OPTIMIZATION from CookOnTheFlyServer.cpp

Change 4148639 by Ben.Marsh

	UGS: Fix tooltips not showing for changes that have description badges.

Change 4149373 by Ben.Marsh

	UGS: Allow adding additional columns to display particular badges by adding entries from the project config file. Example syntax:

	+Columns=(Name="Desktop",MinWidth=50,DesiredWidth=100,Weight=3,Badges="Editor")
	+Columns=(Name="Mobile",MinWidth=50,DesiredWidth=100,Weight=3,Badges="IOS,Android")

	Same form can be used to control how default columns are displayed (though badge settings are ignored). Also allow PerforceMonitor to detect local changes to project config files and update settings automatically.

Change 4149399 by Ben.Marsh

	UGS: Update version to 1.143.

Change 4155660 by Steve.Robb

	PROJECTION and PROJECTION_MEMBER macros which provide the correct behavior when creating projections using functions which are overloaded or use default arguments.

Change 4157117 by Ben.Marsh

	Fix warning due to plugins disabled in .target.cs file.

Change 4158011 by Ben.Marsh

	UBT: Add a check that the UnrealHeaderTool target file exists, rather than throwing an exception when reading it fails.

Change 4158646 by Ben.Marsh

	UGS: Fix exception when login is discovered to have expired during a workspace update.

Change 4158678 by Ben.Marsh

	UGS: Fix an exception on shutdown due to the icon being hidden after it's already been disposed.

Change 4158683 by Ben.Marsh

	UGS: Add an unhandled exception filter which sends the exception data to the backend.

Change 4159131 by Ben.Marsh

	UGS: Reduce the number of characters displayed for build badges based on the available space.

Change 4159194 by Graeme.Thornton

	TBA: Fix incorrect map property conversion code when converting an old property that contains a map with different key/value types

Change 4159239 by Steve.Robb

	Improved readability and compliance with coding standards.

Change 4159246 by Ben.Marsh

	UGS: Allow syncing projects where source code is not available (and various version files don't exist).

	#jira UE-60985

Change 4159286 by Ben.Marsh

	UGS: Remove requirement for UE4Editor.target.cs to be visible in the depot in order to open a project.

	#jira UE-60986

Change 4159302 by Ben.Marsh

	UGS: Update version to 1.144.

Change 4160308 by Ben.Marsh

	All staging client executables for blueprint projects.

	#jira UE-60983

Change 4161567 by Steve.Robb

	GitHub #4816 : UE-60771: Handle escaped double quote in FParse::LineExtended

Change 4162641 by Ben.Marsh

	UGS: Allow customizing the position of custom columns, via the Index=N attribute.

Change 4162647 by Ben.Marsh

	UGS: Update version to 1.145.

Change 4165319 by Robert.Manuszewski

	PR #4812: Fix inconsistent command-line argument handling under Windows (Contributed by adamrehn)


Change 4166150 by Ben.Marsh

	UGS: Include *.inl when looking for code changes.

Change 4166551 by Steve.Robb

	Whitespace fixes caused by a bad merge.

Change 4168483 by Ben.Marsh

	UGS: Add a more useful error if a file to be synced exceeds the max allowed path length.

Change 4168490 by Ben.Marsh

	UGS: Update version to 1.146.

Change 4168551 by Ben.Marsh

	UBT: Move bBuildLargeAddressAwareBinary into an exposed setting.

Change 4168560 by Ben.Marsh

	UBT: Remove static config variable for controlling which configuration of UHT to use.

Change 4171296 by Ben.Marsh

	UGS: Move the check for overlong paths earlier.

Change 4171531 by Ben.Marsh

	UBT: Fix exception if BuildConfiguration.xml contains an unknown category.

Change 4183371 by Robert.Manuszewski

	Fix for a crash in Async Loading Graph's CheckCycles when GC kicks in on the game thread and forces ALT to exit early

Change 4184312 by Ben.Marsh

	UGS: Update version to 1.148

Change 4184480 by Robert.Manuszewski

	Removing unused async loading stat

Change 4186390 by Ben.Marsh

	UBT: Format XML validation errors in a format that allows double-clicking on the message in Visual Studio.

Change 4188644 by Ben.Marsh

	UBT: Add the MakePathSafeToUseWithCommandLine() function to UBT.

Change 4188647 by Ben.Marsh

	UBT: Fix exception in target receipt when architecture is null.

Change 4189617 by Ben.Marsh

	Change FileSystemReference, FileReference and DirectoryReference objects to use OrdinalIgnoreCase comparisons without creating a separate copy of the string to compare. The filesystem does not use the invariant culture, and it can produce the wrong results in some cases (the ordinal comparison is faster, too).

Change 4189740 by Ben.Marsh

	UAT: Remote code to build UnrealPak when packaging; we use the editor now.

Change 4189860 by Ben.Marsh

	UGS: Make the filter for excluding automated lighting rebuilds more explicit.

Change 4190082 by Ben.Marsh

	Fixes to allow enabling edit and continue for Windows builds. Have experienced quite a few VS crashes when testing it in editor; not yet recommended for general use.

	- Allow edit and continue for any configuration, not just debug.
	- Fixed PDB errors compiling files that use a shared PCH with edit and continue enabled. Path to the generated PDB file was using the wrong directory.
	- Removed code that tracks PDB output files, since they're modified multiple times during a build.
	- Enable debug information when compiling generated CPP files, since it causes errors if the shared PCH PDB doesn't have the same option.
	- Disable support for remote execution of steps that modify the PDB, since the same file has to be modified many times. Remote execution causes the PDB files to be corrupted. Unfortunately, this makes E&C builds significantly slower.

	#jira

Change 4192949 by Ben.Marsh

	UBT: Minor tidy-up (merging UEBuildBinary.Build and UEBuildBinary.SetupOutputFiles)

Change 4193218 by Ben.Marsh

	Fix formatting.

Change 4197252 by Mike.Erwin

	UAT: Fix log output w/ correct count of non-code projects.

	#jira none

Change 4197941 by Ben.Marsh

	UGS: Add support for DebugGame editors that have an executable with a DebugGame suffix.

Change 4197964 by Ben.Marsh

	UGS: Prevent attempts to automatically reopen projects while a modal dialog is up, or the workspace is syncing.

Change 4198144 by Ben.Marsh

	UGS: Prevent modal dialogs when login expires in P4, and prompt for password when hitting "retry".

Change 4198413 by Ben.Marsh

	UGS: Always show the main window when launched manually, and run with -RestoreState when launched at startup. Also add a couple more places that save the visibility state, since logging off seems like it can terminate the process abrubtly.

Change 4198779 by Ben.Marsh

	UBT: Allow generating manifests to any arbitrary locations with the -Manifest=<Path> argument.

Change 4198825 by Ben.Marsh

	UBT: Move code to enumerate Slate runtime dependencies into the Slate module. Doesn't need to be done inside core UBT.

Change 4199341 by Ben.Marsh

	UGS: Update version to 1.149

Change 4199642 by Chad.Garyet

	- Deprecate CISController
	- Add BuildController to replace CIS GET/POST for builds
	- Add LatestController, GET does what CIS/GET used to do
	- Change Latest/GET to return the last 25 builds filtered by project, rather than the last 5000 individual Ids
	- Latest/GET now returns "LatestData" object instead of array of longs
	- Updated EventMonitor to match all API changes
	- Fixed bug where IDs were getting reset to initial startup values every update loop

Change 4199663 by Chad.Garyet

	CIS controller still needs to return an array of longs
	#jira none

Change 4199680 by Ben.Marsh

	UGS: Update version to 1.150

Change 4200457 by Ben.Marsh

	Merging CIS fix for non-development configurations.

Change 4200472 by Mike.Erwin

	UAT: fix -skipbuildclient param default

	It was defaulting to skipbuildeditor's value, likely a copy-paste error.

	#jira none

Change 4202595 by Ben.Marsh

	Fix static analysis warning due to constant comparison against macro.

Change 4203250 by Ben.Marsh

	UGS: Always show the "Sync Precompiled Editor" option, but disable it and show a tooltip explaining why if it is not available.

Change 4206191 by Ben.Marsh

	Exclude editor target files from installed builds, since they leak info about DLLs that have been stripped out.

Change 4213011 by Ben.Marsh

	UBT: Include contents of modified intermediate files in the log, to make it easier to debug hidden dependencies.

Change 4213487 by Ben.Marsh

	UBT: Fix assumption that bPrecompile is equivalent to bBuildAllModules. This is no longer the case; they are now controlled by separate options. Should fix CIS errors building the editor.

Change 4213609 by Ben.Marsh

	Ensure that strings formatted using FMicrosoftPlatformString::GetVarArgs() are always null terminated, whether we use the secure CRT or not.

Change 4215971 by Ben.Marsh

	UBT: Remove action graph visualization code; no longer used.

Change 4215996 by Ben.Marsh

	UBT: Remove unqiue id from all actions in the action graph. This is only used for printing debug info in the case of a (rare) cycle in the action graph, so just look it up when needed.

Change 4216022 by Ben.Marsh

	UBT: Rename Crypto.cs to EncryptionAndSigning.cs to match the name of the class inside it, and move it under the System folder.

Change 4216031 by Ben.Marsh

	UBT: Move all the action executors into their own folder in the project.

Change 4216526 by Ben.Marsh

	Fix CIS warnings.

Change 4216544 by Ben.Marsh

	Replace custom code to ensure FMicrosoftPlatformString::GetVarArgs() null terminates its buffer with Microsoft's standards-compliant implementation.

Change 4216633 by Ben.Marsh

	Add support for UnrealPak plugins.

	* Project and plugin modules can now specify an array of supported programs in the "WhitelistPrograms" field of their module descriptors, to allow modules to be loaded by programs.
	* Programs can now load any runtime modules, as long as they are whitelisted.
	* Programs under the engine directory can now use a shared build environment, so that building with a project file does not cause output binaries to be output to the project directory.
	* UnrealPak is now always built by default when packaging
	* Convert UnrealPak to a modular configuration

Change 4216736 by Ben.Marsh

	UnrealPak: Move "ExportDependencies" command into an editor commandlet, since it relies on the UObject system, asset registry, etc...

Change 4217447 by Ben.Marsh

	Back out revision 50 from //UE4/Dev-Core/Engine/Build/InstalledEngineBuild.xml

Change 4217451 by Ben.Marsh

	Back out revision 11 from //UE4/Dev-Core/Engine/Plugins/Developer/VisualStudioSourceCodeAccess/Source/VisualStudioSourceCodeAccess/VisualStudioSourceCodeAccess.Build.cs

Change 4217617 by Ben.Marsh

	Back out changelist 4217451

Change 4222552 by Ben.Marsh

	Don't use #import <TypeLib> for VS source code accessor when building with Clang; it's not supported.

Change 4222630 by Ben.Marsh

	UBT: Fix spam while generating project files if Clang isn't installed.

Change 4223316 by Ben.Marsh

	UBT: Change the order in which Visual C++ toolchains are enumerated to prefer full releases over preview releases.

Change 4223318 by Ben.Marsh

	UBT: Add a build setting which allows creating a dedicated PCH for every file that's excluded from the unity working set (disabled by default). Improves iteration times when working on individual cpp files, but slows down iterating on header changes (and can take a lot of disk space for large changes).

	Dedicated PCH contains all includes scraped from the top of each cpp file, until a non-#include directive is encountered.

Change 4223401 by Ben.Marsh

	UBT: Add an option to automatically enable edit and continue for files in the adaptive non-unity working set. E&C doesn't seem very useful for UE4 projects right now; compile time is comparable to regular build times, but it can take several minutes to apply code changes for large projects.

Change 4223899 by Ben.Marsh

	UBT: Fix loading XML config files on Mono; Type.GetField(Name) does not seem to return values unless binding flags are specified.

Change 4224637 by Ben.Marsh

	Add a "SupportedPrograms" field to plugin descriptors, which allows plugins to declare which plugins they support independently of individual modules. Programs now respect the "bEnabledByDefault" setting in plugins.

	Plugins that are compatible with a program now need to list that program in the SupportedPrograms list, and whitelist any modules that should load for that program.

Change 4224710 by Ben.Marsh

	UBT: Don't add import libraries as final build products unless the target is being precompiled. Prevents the need for building them for leaf nodes in the action graph.

Change 4224715 by Ben.Marsh

	UBT: Remove hack to allow Stats2.cpp to not follow IWYU convention.

Change 4224726 by Ben.Marsh

	Remove commented out line.

Change 4224903 by Ben.Marsh

	Fix non-unity compile error in Stats2.h.

Change 4225051 by Ben.Marsh

	Back out changelist 4224710; causing CIS errors due to receipts not matching.

Change 4225134 by Ben.Marsh

	Fixing non-unity errors.

Change 4225203 by Ben.Marsh

	Another non-unity fix.

Change 4225249 by Ben.Marsh

	Fix Linux dependencies being copied for the Windows editor; they can be added as requirements for the Linux target platform on Windows instead, so it respects the user's chosen platforms.

	#jira UE-62001

Change 4225512 by Ben.Marsh

	BuildGraph: Allow setting the target to build when using the <CsCompile> task.

Change 4228815 by Ben.Marsh

	UBT: Always add the generated code directory to the list of include paths when generating project files. It may only be created after UHT has been run.

Change 4228944 by Ben.Marsh

	UBT: Remove legacy CppCompileEnvironment and LinkEnvironment wrappers from TargetRules that were deprecated in 4.19.

Change 4229028 by Ben.Marsh

	UBT: Fix editor targets with unique build environment having the wrong executable path in generated project files. Move move logic to configure target rules post-construction by the rules assembly to ensure it's valid.

Change 4229065 by Ben.Marsh

	UBT: Move another target setting into the rules assembly.

Change 4229105 by Ben.Marsh

	Fix BPT exception when generating project files.

Change 4229311 by Ben.Marsh

	UBT: Store the module rules file location on the ModuleRules instance, as well as the plugin that it was created from. Also expose the plugin directory as a property on the ModuleRules instance.

Change 4229421 by Ben.Marsh

	UBT: Consolidate functionality for UHT module setup in ExternalExecution.cs.

Change 4229817 by Ben.Marsh

	UBT: Modules must now explicitly specify the path to the header used to generate a PCH if one is desired, rather than the header being determined automatically by attempting to parse the source code. Now that PCHs are force-included anyway, this removes a lot of dependencies inside UBT.

Change 4229824 by Ben.Marsh

	UBT: Remove unused lists inside UEBuildModuleCPP.SourceFilesClass.

Change 4229841 by Ben.Marsh

	UBT: Remove some legacy code from auto-detecting PCHs.

Change 4230521 by Ben.Marsh

	UBT: Add utility functions to the log class to allow formatting errors and warnings in Visual Studio output format (eg. File(Line): warning: Message)

Change 4230871 by Ben.Marsh

	UAT: Remove StreamUtilis utility class; there is a simpler way to implement the one place it's used.

Change 4230882 by Ben.Marsh

	UAT: Add StreamUtils back into UAT, seems like it's still used there.

Change 4230896 by Ben.Marsh

	UBT: Remove some redundant parameters from UEBuildModule/UEBuildModuleCPP/UEBuildModuleExternal constructors.

Change 4231014 by Ben.Marsh

	WorkspaceTool: Include a dump of raw bytes when garbage is read from the P4 process, for diagnostic purposes.

Change 4231032 by Ben.Marsh

	Fix CIS.

Change 4231096 by Ben.Marsh

	Bump the FlatCPPIncludeDependencyCache version, to prevent errors trying to load old files.

Change 4231446 by Ben.Marsh

	UBT: Added support for expanding UE-specific variables in include paths and library paths: $(EngineDir), $(ProjectDir), $(PluginDir), $(ModuleDir).

Change 4231460 by Ben.Marsh

	Modules may now explicitly specify rpaths on Linux via the PublicRuntimeLibraryPaths and PrivateRuntimeLibraryPaths properties.

Change 4233909 by Robert.Manuszewski

	PR #4779: Reason fails as the supplied variable is incorrect (Contributed by projectgheist)


Change 4233910 by Ben.Marsh

	Enable PCHs on IOS. Reduces build time by ~25%.

Change 4234176 by Ben.Marsh

	UBT: Add better messaging for modules that need to have a private PCH set. Now detects the likely PCH using the same method as legacy code and includes it as a suggestion.

Change 4234193 by Ben.Marsh

	Add the Delete command to Perforce wrapper in DotNETUtilities.

Change 4234688 by Ben.Marsh

	UBT: Simplify handling of installed/precompiled builds. Settings for whether a folder is installed/read-only or not is now stored on the RulesAssembly instance, allowing multiple things to be configured separately and stacked together (eg. engine/enterprise/project). RulesAssembly.IsReadOnly() allows determining if a flie can be modified or not and replaces many previous IsXXXInstalledCalls(), and traverses the chain of assemblies.

Change 4234711 by Ben.Marsh

	UBT: Runtime dependencies can now be copied to output directories as part of the build. When adding a runtime dependency, an optional source location can be specified to copy from. Both the source and target paths can use variables can be used as part of the path, eg. $(OutputDir), $(ModuleDir), $(PluginDir).

	Example usage (from a .build.cs file):

	RuntimeDependencies.Add("$(OutputDir)/Foo.dll", "$(PluginDir)/Source/ThirdParty/Foo.dll", StagedFileType.NonUFS);

Change 4234872 by Ben.Marsh

	Expose a flag for whether the engine is installed, to fix issues generating project files.

Change 4234929 by Ben.Marsh

	Fix null reference generating receipts when UBT makefiles are active.

Change 4235883 by Chad.Garyet

	Merging 4231245 to core

	Giving Coordinator its own sln. This should fix what 4158155 was supposed to.
	#jira UE-61955

Change 4236075 by Ben.Marsh

	CIS fix

Change 4237066 by Robert.Manuszewski

	Fix for a potential crash when terminating the engine while it's being initialized

	#jira UE-60545

Change 4237078 by Robert.Manuszewski

	The engine will no longer be resetting all linkers causing massive load times when renaming the world package when entering Play In Editor

Change 4237116 by Ben.Marsh

	Rewrite some Windows utility functions to support paths longer than MAX_PATH.

Change 4237158 by Ben.Marsh

	Add const TCHAR* overloads of FString::RemoveFromStart() and FString::RemoveFromEnd().

Change 4237159 by Ben.Marsh

	Fix FWindowsPlatformFile::GetFilenameOnDisk() support for paths longer than MAX_PATH, and simplify some of the other long path functions to avoid copying string buffers.

Change 4239050 by Ben.Marsh

	Missing file

Change 4239318 by Ben.Marsh

	Linux CIS fix.

Change 4239685 by Ben.Marsh

	Static analysis CIS fix.

Change 4240800 by Ben.Marsh

	WorkspaceTool: Include the full command line in the log for any P4 commands.

Change 4240903 by Ben.Marsh

	PR #4909: Update copyright notices to 2018 (Contributed by projectgheist)


Change 4241025 by Ben.Marsh

	UBT: Exclude mobile pipeline caches from generated project files. Causes huge slowdown when using 'Find in Files' through the IDE.

Change 4241770 by Ben.Marsh

	UBT: Include action number in parallel executor output.

	#jira UE-62032

Change 4243469 by Ben.Marsh

	TBA: Merge FAnnotatedStructuredArchiveFormatter with FStructuredArchiveFormatter. Any functions that are only implemented for text archives now have a _TextOnly suffix, and are exposed through the FStructuredArchive interface.

Change 4245723 by Robert.Manuszewski

	Fixing another creash when terminating the engine while initializing.

	#jira UE-60545

Change 4245862 by Steve.Robb

	VectorLoadFloat2(Ptr) added, which loads { Ptr[0], Ptr[1], Ptr[0], Ptr[1] } into a VectorRegister.

Change 4246412 by Robert.Manuszewski

	The warning 'Calling StaticLoadObject during PostLoad may result in hitches during streaming' will now also report the object which had the PostLoad called on it when StaticLoadObject call happened.

Change 4246612 by Ben.Marsh

	UBT: Fix spelling of "Intellisense".

Change 4249454 by Robert.Manuszewski

	Added extra checks to catch scenarios where the EDL Precache Buffer is flushed before a package header is fully read

Change 4249513 by Robert.Manuszewski

	Made sure the Async Loading Thread doesn't continue running after creating new async packages when garbage collector wants to run on the game thread

Change 4255207 by Ben.Marsh

	UGS: Add additional logging whenever a P4 command fails, and when the user is logged out.

Change 4255288 by Ben.Marsh

	PR #4921: Honor ModuleRules' bEnableExceptions flag when creating precompiled h. (Contributed by surakin)


Change 4256422 by Ben.Marsh

	UBT: Add an error if a module referenced by a plugin descriptor doesn't exist.

Change 4257385 by Robert.Manuszewski

	Creating new objects from within ForEachObjectWithOuter will now result in a fatal error as it's unsafe to change internal UObject hash tables when iterating over them.

Change 4257454 by Robert.Manuszewski

	Added the option to filter clusters listed with gc.ListClusters by objects within them.

	Usage:

	gc.ListClusters Hierachy With=ObjectName1,ObjectName2...

Change 4257526 by Robert.Manuszewski

	It's now possible to filter clusters that get logged with verbose cluster logging enabled (UE_GCCLUSTER_VERBOSE_LOGGING=1) by objects within them by specifying -DumpClustersWithObjects=ObjectName1,ObjectName2 in the command line

Change 4257822 by Ben.Marsh

	Fixes for PlatformShowcase compile errors.

Change 4258771 by Ben.Marsh

	UBT: Fix project files not being generated for foreign projects when creating .stub files.

	#jira UE-62462

Change 4258790 by Ben.Marsh

	UBT: Clean up the logic around generating project files before creating a stub IPA, so that it fails loudly if project files do not exist, and can accept target names not matching project names.

Change 4259276 by Ben.Marsh

	UBT: Make it an error if a framework doesn't exist, rather than failing silently. Also remove some remote toolchain stuff that's no longer necessary.

Change 4259280 by Ben.Marsh

	UBT: Fix embedded framework zips not being uploaded for plugins.

	#jira UE-62485

Change 4260236 by Ben.Marsh

	UBT: Fix path to generated engine project file.

Change 4260334 by Ben.Marsh

	UGS: Fix custom build steps dialog inadvertantly modifying config file settings in-place.

Change 4260361 by Ben.Marsh

	UGS: Allow for p4 login commands to fail, even though the user is logged in (due to a bad connection, etc...)

Change 4260559 by Ben.Marsh

	UGS: Update version.

Change 4261160 by Robert.Manuszewski

	MediaPlaylist will now be added to root set if the owning MediaPlayer is in the disregard for GC set (fixes GC assumption violation crash)

	#jira UE-62495

Change 4261421 by Ben.Marsh

	Force-sync files for building documentation, to fix issues with files not being updated.

	#jira UE-62413

Change 4261425 by Ben.Marsh

	UBT: Remove some leftover functions for handling the remote toolchain.

Change 4261530 by Ben.Marsh

	UBT: Speculative fix (and better error reporting) for IOS mobile provision not being found in CIS.

Change 4261611 by Ben.Marsh

	UBT: Downgrade warning to a log message, since it appears when generating project files.

Change 4261710 by Ben.Marsh

	Remove assert that GLogConsole is set; it won't be for command line utilities that don't depend on ApplicationCore.

	#jira UE-62545

Change 4261831 by Ben.Marsh

	Fix compile errors due to missing include path when hot-reloading a module from the editor. There are not necessarily source files to compile when -modulewithsuffix is specified on the command line, which was results in GeneratedCodeWildcard not being set.

	#jira UE-62463, UE-62384

Change 4262723 by Ben.Marsh

	Whitelist plugins that need to be loaded by UFE.

	#jira UE-62564

Change 4265444 by Ben.Marsh

	Fix incorrect executable name for DebugGame configurations in Xcode.

	#jira UE-62574

Change 4265892 by Ben.Marsh

	Fix incremental compile failures due to dependency checking for unity files. CachedIncludePaths was not correctly being set on file items, so dependencies were being ignored.

	#jira UE-62575, UE-62603, UE-62597

Change 4266019 by Josh.Adams

	- Fixed the CopyAction for runtime dependencies that need to be copied to different location, on non-XGE

Change 4266264 by Ben.Marsh

	Remove override for the __IPHONE_OS_VERSION_MIN_REQUIRED macro on TVOS.

	This macro is already defined by system headers (in <AvailabilityInternal.h>). Now that we support PCHs on IOS and TVOS, manually defining this macro results in it being defined three times (once for the PCH, once by AvailabilityInternal.h, and once by the force-included list of definitions for the source file being built). The errors for redefining the macro in AvailabilityInternal.h are suppressed due to it being a system header, but the error for redefining it for the source file being compiled are not.

	#jira UE-62578

Change 4266273 by Ben.Marsh

	Fixes incremental build failure when compile arguments for PCH have changed on IOS/TVOS. Compile action needs to have a dependency on PCH build action.

Change 4266614 by Graeme.Thornton

	Fix crash when cooking nativized blueprints due to removal of child cooker system.

Change 4266763 by Ben.Marsh

	Always build UnrealPak when building client targets. The ProjectParams.Pak option is not reliable, because it can be forced on later by the target platform.

	#jira UE-62584

Change 4267985 by Robert.Manuszewski

	When iterating with ForEachObjectWithouter, don't lock the entire has table but only the hash bucket that is currently being iterated

	#jira UE-62600

Change 4268558 by Robert.Manuszewski

	PurgeLegacyBlueprints will no longer be called from within ForEachObjectWithOuter is it renames objects that reside in hash tables that are being iterated over which may lead to undefined behavior.

	#jira UE-62600

Change 4269011 by Chad.Garyet

	- Fixing Wildcard match issue, the change to ugsapi sends projects as //Depot/Stream instead of //Depot/Stream/
	  Wildcard match was only substringing to 3 chars.
	- Checking in the change a while back that increases the number of queried jobs up to 432 based on some maths from Bob about how many builds we want to grab
	Published to ugsapi server 8/8/17
	#jira none

Change 4270788 by Ben.Marsh

	Fix IOS provisioning data being using when remote compiling on TVOS.

	#jira UE-62705

Change 4271916 by Ben.Marsh

	Tag the XGEControlWorker executable as a build product after compiling SCW, to make sure it's included in the UGS zip file.

Change 4271934 by Ben.Marsh

	Upload all static libraries in plugin folders as part of remote builds.

	#jira UE-62694

Change 4273368 by Ben.Marsh

	Fix Slate dependencies not being enumerated, and rules assembly not being rebuilt when building remotely.

	#jira UE-62705

Change 4274049 by Ben.Marsh

	Always parse the team UUID out of the mobile provision when doing a remote compile. The provision installed on the remote Mac (and selected for signing) may be different.

	#jira UE-62751

Change 4274823 by Ben.Marsh

	Add the -VersionCookedContent argument to disable the -unversioned parameter on the cooker command line.

Change 4275838 by Ben.Marsh

	Fix BuildVersion string not being passed through from <SetVersion> task. Also add a -BuildVersion command line argument to UBT to override it for a particular build.

Change 4275913 by Ben.Marsh

	Add a dummy exported symbol to the XGEController module, to fix build errors due to missing .lib file when it's built with WITH_XGE_CONTROLLER = 0.

Change 4284161 by Ben.Marsh

	Allow mirroring Oodle files to remote Mac.

Change 4074774 by Steve.Robb

	Vast simplification of TFunction, making it smaller in footprint, easier to follow and extend, and more correct.
	TUniqueFunction added, which is a move-only TFunction which can hold move-only functors.
	Fix for UWidgetBlueprint::ForEachSourceWidget() which should never have compiled but did.
	FFunctionGraphTask and TFuture<> updated to use TUniqueFunction to make them more general.
	TArray::HeapPop() made to work with move-only types.

Change 4082591 by Ben.Marsh

	Move the Log class from UBT to DotNetUtilities.

Change 4083236 by Ben.Marsh

	Add a Log.WriteException() method to dump an exception message to the console (and write the exception trace to the log)

Change 4084107 by Ben.Marsh

	UAT: Remove the unused -SkipHeader argument to UE4Build.

Change 4089771 by Steve.Robb

	GitHub #4743 : modified VirtualAlloc function flag

	https://blogs.msdn.microsoft.com/oldnewthing/20151008-00/?p=91411

Change 4091456 by Steve.Robb

	Unification of all platforms' FMath::CountTrailingZeros() and FMath::CountLeadingZeros() for both 32-bit and 64-bit.

Change 4156437 by Ben.Marsh

	Lots and lots of fixes compiling for Clang on Windows.

	Editor now compiles cleanly without warnings, but crashes on startup due to error in intrinsics test. Disabling that runs further, but crashes accessing freed memory. Switching to the ANSI allocator runs further, but crashes in Slate after the splash screen and before the editor window opens. // TODO!

	* Switching between Clang/ICL/VS2015/VS2017 is now supported through the same mechanism as switching Visual Studio versions, without requiring any source level changes. To use Clang, set WindowsPlatform.Compiler = WindowsCompiler.Clang from a .target.cs file, or set <WindowsPlatform><Compiler>Clang</Compiler></WindowsPlatform> from BuildConfiguration.xml. To pick a specific toolchain version, set WindowsPlatform.CompilerVersion.
	* Clang is now supported through AutoSDKs; will be added to CIS.
	* The Samples/Sandbox/Clang project forces Clang to be used from its target.cs file, and allows easily building all editor modules and plugins with Clang on Windows.
	* UnrealMathSSE intrinsics have been re-enabled for Clang due to missing functions from the UnrealMathFPU implementation, but causes failure in tests at startup.
	* SSE4_CRC32() is disabled in D3D12Pipelinestate.cpp, since intrinsics are only allowed if enabled for the whole target (rather than being used in specific functions due to runtime checks)

Change 4157389 by Ben.Marsh

	Few more fixes for compiling the editor with Clang.

Change 4183911 by Ben.Marsh

	Fixes to support incremental linking on Windows. Does not seem to have any net benefit right now; may improve once minimal rebuild is enabled.

	* Incremental linking no longer forces PDB files to be enabled for source files.
	* Actions can specify specific files to be deleted before each build. Code to forcibly delete PDB files has been moved to the MSVC toolchain.
	* Unused libraries produced by the cross-referenced link are no longer added as build products, since (a) deleting them breaks dependency checking for incremental linking and causes a full link, and (b) not deleting them breaks UBT dependency checking and causes actions to be run over and over again.
	* Icon update is disabled for Windows when incremental linking is enabled.
	* Removed rarely-used setting to always delete produced items before each build.

Change 4184311 by Ben.Marsh

	UGS: Added a dialog which shows all the required platform SDKs for a branch, linked from the status panel in UGS.

	The llist is configured via the UGS config file submitted to Engine/Programs/UnrealGameSync/UnrealGameSync.ini (and may be overridden by the project config file if necessary):

	    [Default]
	    ; Set this to a network share which contains the SDK installers for your site
	    SdkInstallerDir=

	    ; All the required SDKs for the current version of the engine
	    +SdkInfo=(Category="Android", Description="NDK r21", Browse="$(SdkInstallerDir)\\Android")
	    +SdkInfo=(Category="Windows", Description="Visual Studio 2017")
	    +SdkInfo=(Category="Windows", Description="Visual C++ Toolchain 14.13.26128")
	    +SdkInfo=(Category="Windows", Description="Windows SDK 10.0.16299.0")

	Similar entries for console platforms are added in console subdirectories. Each entry may contain an Install="Foo.exe" and/or Browse="C:\Foo" style attribute, specifying the path to an installer to run or directory to open in explorer respectively.

	The SdkInstallerDir setting is used as a base directory for the default installers, seen above for Android. Licensees may override this with a network path specific to the site that UGS is being deployed to (either in this file, in a project specific config file, or in a Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini file).

Change 4200452 by Ben.Marsh

	UBT: Change DebugGame configurations to output a separate executable rather than requiring a -Debug argument at runtime. Previous behavior was a common source of errors.

	Engine modules are still shared between Development and DebugGame, but the launch module sets a flag in Core on startup indicating the game configuration.

Change 4206189 by Ben.Marsh

	UBT: Simplify logic for precompiling binaries.

	* Target no longer has separate list of "precompile only" binaries or modules. New -AllModules option allows adding every module to a target, which can be used with -Precompile and -NoLink to precompile object files for monolithic builds.
	* Precompiled file lists have been removed from target receipts.
	* The manifest now includes all generated headers and precompiled files when run with the -Precompile option.
	* Separate -DependencyList=Foo.txt has been added to write a list of all dependencies required to use precompiled binaries. This file list can be read using the <Tag> task in buildgraph.

Change 4215466 by Ben.Marsh

	UBT: Remove indirect calls to determine extensions for object files and precompiled headers. The toolchain knows the correct convention for the platform.

Change 4215975 by Ben.Marsh

	UBT: Remove telemetry code. This has never proved useful for analyzing performance due to the number of incidental factors that affect build times (eg. number of files being compiled).

Change 4220154 by Ben.Marsh

	Move text-only implementations of FOutputDeviceError back into Core, so we can build command-line applications that don't depend on ApplicationCore.

Change 4224708 by Ben.Marsh

	Add a bCompileAgainstApplicationCore setting to the target rules, which allows compiling out references to the ApplicationCore module (which should only be necessary for applications with a GUI). Removed ApplicationCore from several engine tools and utilities.

Change 4224958 by Ben.Marsh

	Remove CoreMinimal.h includes from Core.

Change 4229059 by Ben.Marsh

	UBT: Remove the UEBuildPlatform.ShouldNotBuildEditor() hook for target platforms. We shouldn't be modifying a target's build environment to disable the editor; it is invalid to build the editor for these target platforms at all, and this is already enforced by the GetSupportedPlatforms() function.

Change 4230508 by Ben.Marsh

	Fixup precompiled header setting for samples and games.

Change 4231457 by Ben.Marsh

	Fix exceptions in log messages having trailing newlines.

Change 4232406 by Ben.Marsh

	UBT: Always force include a PCH for generated code if there's one set; the code may depend on it to compile.

Change 4234177 by Ben.Marsh

	Set up private PCH files everywhere that previously used them.

Change 4235973 by Ben.Marsh

	Change FPlatformMisc::GetEnvironmentVariable() to return an FString() rather than requiring a fixed size buffer to be passed in. Removes references to MAX_PATH.

Change 4238842 by Ben.Marsh

	Add support for paths longer than MAX_PATH in the editor. Requires Windows 10 version 1607, and the functionality to be enabled via a registry key or group policy (see https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file).

	Only a subset of Win32 functions support long paths (executables can only be started from paths shorter than MAX_PATH, for example).

	* Added a FPlatformMisc::GetMaxPathLength() function to return the maximum length of a path on the current system. On Windows, this returns a different value for systems with long paths enabled to those without.
	* The MAX_PATH define is no longer set by non-Windows platforms. Instead, there is a MAC_MAX_PATH, UNIX_MAX_PATH, etc... for any platform-specific code that still relies on the previous macro.
	* The MAX_UNREAL_FILENAME_LENGTH macro has been renamed to MAX_UNREAL_FILENAME_LENGTH_DEPRECATED
	* The PLATFORM_MAX_FILEPATH_LENGTH macro has been renamed to PLATFORM_MAX_FILEPATH_LENGTH_DEPRECATED.
	* Removed custom resource files for programs, since they are just copies of the base UE4 one (which is used by default anyway). The base UE4 manifest declares support for long paths.
	* Fix 512 character maximum length on editor commands.

	260 character limit remains in place for cooking at the moment (see ContentBrowserUtils.h), until C# staging code supports long paths.

Change 4255042 by Ben.Marsh

	UBT: Remote compilation now uploads the entire workspace to the remote Mac and executes a separate remote instance of UBT rather than synchronizing individual actions. This makes the remote compile codepath much simpler, and removes a lot of special cases that exist to support it previously.

	The list of files to be transferred to the remote are listed as rsync filter rules in Engine/Build/Rsync/RsyncEngine.txt and RsyncProject.txt, which are applied to the root engine directory and project directory respectively. Projects that need to customize which files are uploaded can add their own <ProjectDir>/Build/Rsync/RsyncProject.txt file, which will be included in the filter before the default version.

Change 4260567 by Ben.Marsh

	UAT: Rename CommandUtils.Log to CommandUtils.LogInformation, to avoid conflicts with the underlying Tools.DotNETCommon.Log class.

#rb none

[CL 4285673 by Ben Marsh in Main branch]
2018-08-14 18:32:34 -04:00
Ben Marsh
78856db678 Copying //UE4/Release-Staging-4.19 to //UE4/Dev-Main (Source: //UE4/Release-4.19 @ 3944462)
#lockdown Nick.Penwarden

============================
  MAJOR FEATURES & CHANGES
============================

Change 3944462 by Jack.Porter

	Prevent TVOS packaging from PC from attempting to build an asset catalog
	#jira UE-56114

Change 3943602 by Leslie.Nivison

	Adding licenses for additional TPS

	#jira none

Change 3943597 by Leslie.Nivison

	Adding Enterprise licenses; licenses for additional TPS.

	#jira none

Change 3941962 by Leslie.Nivison

	Updating 4.19 credit list
	#jira none

Change 3941865 by Mark.Satterthwaite

	Fix the incorrect landscape rendering and the incorrect render-to-texture from blueprint bugs with MetalRHI.

	- Track outstanding AsyncCopyBufferFromBufferToBuffer operations to identify attempts to modify overlapping ranges within the same prologue command-buffer. This doesn't work and requires that we break the current render-pass and issue on the current command-buffer. A log warning will be emitted  when this occurs.

	- Don't attempt to alias private memory buffers the moment they are released from the RHI resource because that can lead to incorrect sharing of the memory when used by AsyncCopyBufferFromBufferToBuffer.

	#jira UE-56021

Change 3940993 by Marc.Audy

	Do not return the last column if the specified column does not exist.
	Allow display names to be used when looking for a property if the table is backed by a user defined struct.
	Do not crash if a property with the given name is not found.

	#jira UE-56017

Change 3939179 by Ben.Marsh

	Revert change to not poison memory in development configuration. Making a tradeoff that editor stability and consistency is more important than performance.

	#jira

Change 3938566 by Aaron.McLeran

	#jira UE-55940  Fix for wavetable synth

	Missed a case.

Change 3938533 by Dan.Oconnor

	Fix uninitialized variable exposed by recent MallocTBB change

	#jira UE-56013

Change 3938508 by Aaron.McLeran

	Fixing CIS error, init order issues.

	#jira UE-55940

Change 3938490 by Aaron.McLeran

	#jira UE-55940  Fix for wavetable synth

Change 3938352 by josh.jensen

	Show an error message for Windows iOS builds when packaging/launching and icons are present but no remote Mac is specified

	#jira UE-55987

Change 3938345 by Peter.Sauerbrei

	fix to Icons not being built on Mac
	#jira UE-53492

Change 3938305 by Mark.Satterthwaite

	For whatever reason moving the buffer initialisation into the prologue command buffer doesn't work - this make absolutely no sense to me. I suspect that this is *merely* moving a render pass boundary around somewhere and forcing raster-state to be reapplied.

	#jira UE-56005

Change 3937968 by Ben.Marsh

	Disable the boot DDC if we're not in the editor. Fixes access violations when multiple SCW instances attempt to read/write to the same file.

	#jira UE-56003

Change 3937573 by Mitchell.Wilson

	Saving asset to resolve empty asset warning.
	#jira UE-56004

Change 3937561 by Max.Preussner

	ImgMedia: Added support for single-threaded platforms

	Copied from Dev-Sequencer CL# 3937516

	#jira UE-55986

Change 3937305 by Mike.Beach

	Resaving google VR model content with UGS build to fix the empty file version error.

	#jira UE-55984

Change 3935595 by Arne.Schober

	Fix missing UV precission on BSP surfaces
	#jira UE-54014

Change 3935411 by josh.jensen

	Fixed Windows iOS remote Mac build issue where the user icons were considered remote Mac compilation targets coming solely from the Engine directory

	#jira UE-55899

Change 3934982 by Marc.Audy

	Fix shadow variable issue

	#jira UE-55957

Change 3934892 by Mark.Satterthwaite

	In MetalRHI treat BUF_Volatile buffers as Shared or Managed memory in all circumstances so that multiple updates within a render pass are respected even though this will hurt CPU performance. This fixes GPU particles on macOS. Also push initialisation upload into the async. command buffer to avoid it overwriting a later Lock/Unlock! Only read-back and copy-buffer operations should be on the 'current' command buffer as they need to be inline with all outstanding commands.

	#jira UE-55956

Change 3934421 by Arciel.Rekman

	Fix lockup/OOM when setting audio sources to 2 (UE-53968).

	#jira UE-53968

Change 3934156 by Peter.Sauerbrei

	fix for backgrounding problems on iOS and tvOS
	this will re-open UE-50979 as the fix for that was not correct and would have caused crashes when backgrounding during startup
	#jira UE4-55609

Change 3933547 by Aaron.McLeran

	#jira UE-55940 Fix for wavetable sample duration and seek

Change 3933544 by Aaron.McLeran

	#jira UE-55939 Hiding channel format
	Submix channel format is an experimental feature and shouldn't be exposed to the submix editor for 4.19.

Change 3933540 by Aaron.McLeran

	#jira UE-55718 Fix for playback progress.

Change 3933280 by Ethan.Geller

	[Release-4.19] #jira UE-55810 Ensure AudioComponent is created before we start using it. #rb Aaron.McLeran

Change 3933079 by Ryan.Vance

	#jira UE-55936
	Fixed missing referenced uniform bindings on AR pass-through camera shaders.

Change 3932319 by Ben.Zeigler

	#jira UE-55885 Fix corruption of packages when starting and then cancelling an async load of a package that already exists, or attempting to async load a script package
	It now keeps track of which packages were created by the async load system and will only throw those away on cancel
	Copy of CL #3932312

Change 3932287 by Matt.Kuhlenschmidt

	Updated substance texture

	#jira UE-55081

Change 3931729 by josh.jensen

	Ensure the tvOS and iOS Assets.car is always produced as part of a regular remote/local build

	#jira UE-55899

Change 3929723 by josh.jensen

	Removed packaging requirement on Windows of a remote Mac after setting an app icon to default

	#jira UE-53495

Change 3929722 by josh.jensen

	Fixed iOS asset catalog generation issues when swapping out/resetting to default app icons for both code- and BP-projects

	#jira UE-53492, UE-51879
	#robomerge

Change 3929350 by Mike.Erwin

	"Save As" support for
	#jira UE-55732

Change 3927829 by Steve.Robb

	Out-of-memory handler for MallocStomp.

	#jira UE-55550

Change 3926404 by Mike.Erwin

	#jira UE-55732

Change 3926394 by Dan.Oconnor

	Recompile bytecode dependencies when compiling an individual blueprint interface, this prevents crashes due to stale bytecode

	#jira UE-55813

Change 3926098 by Guillaume.Abadie

	Do not allow dynamic resolution to be enabled on unsupported platforms avoiding game breaker experience by security.

	#jira UE-55697

Change 3925927 by Guillaume.Abadie

	Enables TAA's AA_BORDER on all permutation for dynamic resolution.

	#jira UE-55353

Change 3925882 by Matt.Kuhlenschmidt

	Fix substance uri having one extra /
	Fix substance menu option showing up for github (incompatible with plugin)

	#jira UE-55766

Change 3925873 by Ben.Zeigler

	#jira UE-55783 Fix issue introduced in 4.18 where user structs did not handle converting AssetPtrs to SoftObjectPtrs properly
	Copy of CL #3925871

Change 3925163 by Guillaume.Abadie

	Fixes DFAO's temporal AA passes that was handling FViewInfo::ViewRect.Min wrongly.

	#jira UE-55788

Change 3924839 by Guillaume.Abadie

	Fixes a crash of LDR android preview with OS DPI scale != 0.

	#jira UE-43622

Change 3924542 by Cosmin.Sulea

	Merged fixes:
	UE-55299 - XGE Shader Compile Interferes with Remote Shader Compiling Causing Materials to Fail to Compile #7
	UE-51086 - No clear editor activity during remote shader compiling

	#jira UE-55299

Change 3922398 by Mark.Satterthwaite

	Compile fix for 3922273.

	#jira UE-53993

Change 3922273 by Mark.Satterthwaite

	Fix validation error caused by the game updating its orientation before the drawable system catches up. We need to drop drawables that are incorrectly sized until we get one with the correct size.

	#jira UE-53993

Change 3921127 by Ethan.Geller

	[Release-4.19] #jira UE-55744: Add OnTick virtual to IAudioPluginListener, fix thread safety issue in Resonance Audio. #rb aaron.mcleran

Change 3920632 by Lina.Halper

	Fix render thread crash when morphtarget is deleted or added

	#jira: UE-55521

Change 3920557 by Lauren.Ridge

	Fixing material editor resetting background to off
	#jira UE-55267

Change 3920519 by Phillip.Kavan

	Fix a regression in which elements would not be initialized when constructing the value assignment for UDS-typed container members in nativized Blueprint C++ code.

	Change summary:
	- Modified FEmitDefaultValueHelper::InnerGenerate() to remove UDS from the list of special cases that avoid calling InitializeStruct() as part of new element construction. Previously the conversion code assumed the compiler would perform value initialization of a nameless temporary, but that is no longer valid in 4.19, as UDS types have been changed to function more like native structs, and as such all converted UDS types will now emit an explicit default ctor which is now used to assign defaults that differ from the zero-initialized value.

	#jira UE-55628

Change 3920476 by Michael.Trepka

	Clean up Mac menu item cache at exit before SlateApplication is fully destroyed.

	#jira UE-55599

Change 3920336 by Ben.Marsh

	Ignore license warnings from PVS-Studio.

	#jira UE-55729

Change 3920134 by Jurre.deBaare

	Moving over:
	"HLOD: Building HLOD for P map with sublevels requires HLODSetupAsset when it should not
	#fix Ensure that we dynamically add HLOD level treeview items whenever they are required, rather than adding a static number of levels according to the worldsettings"

	#jira UE-55619

Change 3920126 by Max.Preussner

	MediaCompositing: Implemented media track for Sequencer

	Copied from Dev-Sequencer

	#jira UE-53974

Change 3920004 by Jack.Porter

	Disable Manual Vertex Fetch SRV creation when MVF is disabled.

	Made a single RHISupportsManualVertexFetch(EShaderPlatform) to control whether to use MVF. The Shader Platform (or alternatively, feature level) is the only thing that can decide whether or not to use MVF because we need to know when we compile the shaders if we're going to do MVF or not. Checking GSupportsResourceView at runtime is useless because the shaders can't change and so if GSupportsResourceView can ever be false for a platform, the shaders need to have been built without it.

	Creating SRVs without using them on mobile is not harmless because several devices don't support formats that are needed.

	#jira UE-54764
	#jira UE-55622

Change 3919069 by Aaron.McLeran

	#jira UE-55718 Fix for playback progress.

Change 3918942 by Graeme.Thornton

	Added "ProjectBuildMutatorFeature" modular feature, allowing plugins to register said feature and dictate whether the current project requires a code build. CryptoKeys plugin uses this feature to force a code build when encryption or signing is enabled.

	#jira UE-55686

Change 3918721 by Zak.Parrish

	Lighter version map for Gremlin + new Engine.ini - result is 60Hz #jira none

Change 3918236 by Joe.Graf

	Added a bFlipTrackedRotation to give a better result when mirroring the rotation of a tracked face

	#jira: UE-55531

Change 3917970 by Martin.Wilson

	Expose curve data in remap assets to blueprints

	#jira UE-55585

Change 3917740 by Olaf.Piesche

	Properly checking for presence of buffer SRV capability via GSupportsResourceView so ES3.1 and Metal devices don't crash using GPU particles (and possibly in other circumstances);

	#jira UE-55591

Change 3917713 by Cody.Albert

	Build fixes for Match3 on iOS

	#jira UE-53742

Change 3917472 by zak.parrish

	added mouthPressLeft and MouthPressRight back into debug screen #jira none

Change 3917244 by Michael.Dupuis

	#jira UE-35097: Fixed crash when creating a new landscape with 2x2 subsections and material containing grass spawning node

Change 3916775 by Ben.Marsh

	Add missing files for packaging IOS on Windows.

	#jira UE-53873

Change 3916293 by Joe.Graf

	Removed the redundant GetTransform() from UARFaceGeometry since GetLocalToWorldTransform() is exposed on a base class

	#jira: UE-55531

Change 3916011 by Joe.Graf

	Added an accessor to get the transform of the face mesh or a face mesh component

	#jira: UE-55531

Change 3915967 by Mark.Satterthwaite

	Place buffer updates into the prologue command-buffer in MetalRHI to avoid breaking the current command-encoder. This improves performance, though the semantics of Metal now differ subtly to other RHI implementations as the buffer updates happen prior to the SetRenderTargets call in the GPU's view of the world.

	#jira UE-54858

Change 3915751 by Nick.Atamas

	Merging CL 3913931 from //UE/Partner-Google-VR/... to //UE4/Release-4.19/...

	#jira UE-55639

Change 3915421 by Martin.Wilson

	Fix crash from live link message bus heartbeat manager

	#jira UE-55644

Change 3915326 by Dan.Oconnor

	Make compilation manager's skeleton class layout better match the old compilation path's skeleton class layout, fixes a crash when renaming blueprint functions

	#jira UE-55592

Change 3915250 by JeanLuc.Corenthin

	Can't add C++ code to Enterprise projects (when enterprise is installed)

	Root cause: When compiling a C++ project, Datasmith modules are included in the build process (with the wrong path)

	Fix:
	- Added two more Enterprise directories, Plugins and Intermediate, to the Enterprise directories to check against
	- Build the correct path for the Datasmith modules and plugins in FindOrCreateModuleByName. Added check to see if module is under one of the Enterprise directories.
	- Added modules to list of precompiled modeules in UEBuildTargets.AddPrecompiledModules if Engine and Enterprise are 'installed and the module is under Enterprise.

	#jira UEENT-1032

Change 3915240 by Ben.Marsh

	Reduce editor startup times by ~15s on Windows.

	Platform loading code recursively scans every module for dependent DLL modules to load first. Change to make it early-out as soon as it encounters a module which is already in memory (via a call to GetModuleHandle() from ResolveMissingLibraryImportsRecursive). Also use a TSet<> to store set of visited modules rather than an Array.

	Now spends <0.1s total in this function on editor startup.

	(Change looks larger than it is due to moving functions out of WindowsPlatformProcess.h to avoid introducing TSet dependency into this header).

	#jira UE-55642

Change 3914803 by Gil.Gribb

	UE4 - Removed memory track from the lock free list links. This is not safe and will sometimes assert in debug.

	#jira UE-49600

Change 3914616 by zak.parrish

	Adding Calibrate button #jira none

Change 3914599 by Andrew.Rodham

	Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified

	  - The following sequence of events exposes this issue:
	    - Create a master sequence with a single shot that spawns a cube
	    - Add this sequence to a level and set it to auto-play
	    - Save everything and restart
	    - Resave just the inner shot asset without opening it
	    - PIE
	    - The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template.

	#jira UE-55626

Change 3914479 by Krzysztof.Narkowicz

	Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
	#jira UE-53875

Change 3914347 by Martin.Wilson

	Stop anim preview instance from ever running in parallel

	#Jira UE-55577

Change 3914179 by Benn.Gallagher

	Fixed clothing sections not displaying in LOD section list in skeletal mesh editor, due to no longer duplicating clothing sections in the model data.

	#jira UE-55528

Change 3914122 by Steven.Barnett

	Fix perf regression in BSP queries by changing suppression of PhysX mesh cleaning failure message.

	#jira UE-54081

Change 3913950 by zak.parrish

	Clamping my normalization math #jira none

Change 3913926 by Zak.Parrish

	First pass at Gremlin Calibrate button. Also added shirt/backpack to boy so he's not a floating head. #jira none

Change 3913668 by Matt.Kuhlenschmidt

	Adding missing substance styling info
	#jira UE-55081

Change 3913667 by Nick.Atamas

	Merging CL 3912976 from //UE4/Partner-Google-VR/... //UE4/Release-4.19/...

	Upgrading to support ARCore 1.0 runtime.

	#jira UE-55602

Change 3913645 by Aaron.McLeran

	#jira UE-55618 fix for mono audio devices

Change 3913509 by Cody.Albert

	Removing PhsX build exclusion from Match3

	#jira UE-53742

Change 3913380 by Dan.Oconnor

	Preload Sequence Bindings node at proper time

	#jira UE-55412

Change 3913300 by Mitchell.Wilson

	Updating iOS default startup movie to H.264, 1280x720, 30 fps.
	#jira UE-55382

Change 3913291 by Cody.Albert

	More iOS build fixes for Match3

	#jira UE-53742

Change 3913169 by Cody.Albert

	Fixed iOS build issues for UnrealMatch3

	#jira UE-53742

Change 3913131 by Krzysztof.Narkowicz

	Fixed remaining quad overdraw viewmode contents on screen after switching to certain other viewmodes (e.g. light overlap or complexity)

	#jira UE-54580

Change 3912851 by Lina.Halper

	Fixed issue with pose asset blending additively multiple poses suming up to 1 weight.

	#jira: UE-55603

Change 3912629 by Guillaume.Abadie

	Fixes SSR that was computing vigneting according to PrevScreen that could let some outside viewport samples going through when rotating the camera.

	#jira UE-55353

Change 3912170 by Martin.Wilson

	Add logging for UE-55511 (NaN crash)

	#jira UE-55511

Change 3912161 by Phillip.Kavan

	Fix editor-only default subobjects inherited from a native C++ parent class not being handled correctly during nativized Blueprint class ctor generation.

	Change summary:
	- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to skip editor-only checks for instanced default subobjects. These will have already been created by a native parent class.
	- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert before creating a "dummy" component in place of an editor-only instance if we're not supposed to be creating it.

	#jira UE-55474

Change 3912100 by Luke.Thatcher

	[RELEASE] [^] Merging (as edit) fix for building pak patches (CL 3911754) from //UE4/Dev-Core to //UE4/Release-4.19

	#jira UE-55340

Change 3912072 by Mike.Beach

	Art cleanup pass on AR template icon.

	#jira UE-55587

Change 3912057 by Michael.Trepka

	Additional widget path validity check in FSlateUser::NotifyWindowDestroyed()

	#jira UE-55580

Change 3911592 by Jurre.deBaare

	Crash on merge actor when Use specific LOD Level
	#fix make sure we use the correct array to determine the number of components being merged
	#jira UE-55508

Change 3911466 by Cosmin.Sulea

	Mega change list for the following related issues:

	UEMOB-417 - Support Xcode automagical code signing
	UE-49829 - Remote build fails to use / sign distribution provisions coming from PC
	UE-39501 - Packaging for tvOS in Distribution fails to find valid provision
	UE-55334 - XCode managed provisions don╞t operate gracefully with manual provisions
	UE-55330 - Automatic signing doesn't work with tvOS
	UE-10969 - Remote build fails if there is no development provision provided

	#jira UEMOB-417

Change 3911454 by Luke.Thatcher

	[RELEASE] [!] Fix rendering thread memory leak in FLandscapeComponentSceneProxy::InitViewCustomData
	 - FViewCustomDataLOD is allocated on a memstack, but contains a TArray, so is not trivially destructible.
	 - The SubSections array is leaked when the memstack is popped.
	 - Fix replaces the TArray with a TStaticArray of max size MAX_SUBSECTION_COUNT (which is 4).

	(Merging as edit CL 3911422 from //Fortnite/Release-3.1/... to //UE4/Release-4.19/...)

	#jira UE-54835

Change 3911370 by Dragan.Jerosimovic

	changed browOuterLeft -> browOuterUpLeft, browOuterRight->browOuterUpRight
	updated KiteBoyHead_JointsAndBlends.fbx
	#jira none

Change 3910545 by Dan.Oconnor

	PR #4512: Fix FNetNameMapping::GetUniqueName regression (Contributed by dfb)


	#jira UE-55513

Change 3910449 by Michael.Trepka

	Fix for crash on exit on Mac when closing the root editor window with Cmd+W

	#jira UE-54973

Change 3909601 by Patrick.Boutot

	Expose to Blueprint GetProjectDirectory functions.
	#jira UE-55548, UEENT-999

Change 3909543 by Patrick.Boutot

	Rename ECollisionResponse to CollisionResponseType in script to prevent collision with FCollisionResponse.
	Python's help function now output the Python type instead of the cpp type.
	Do not export hidden enum entry from Python.
	#jira UE-55545, UEENT-961

Change 3909289 by Zak.Parrish

	Adding shirt/chest to faceAR sample #jira none

Change 3908808 by Dragan.Jerosimovic

	added combination shapes network
	#jira none

Change 3908788 by Mitchell.Wilson

	Updaing Match3Camera to resolve clipping issue on iPhone X
	#jira UE-54723

Change 3908374 by Jack.Porter

	Fix viewport offset problem for preview PIE window
	#jira UE-52583

Change 3907108 by Shane.Caudle

	#JIRA
	Added DefaultDeviceProfiles.ini to set the [IOS DeviceProfile]
	+CVars=r.ShadowQuality=4

Change 3907105 by Lauren.Ridge

	Fix for thumbnails not resetting when layers/blends reset and for them being incorrectly scaled when null
	#jira UETOOL-1303

Change 3907011 by Chris.Phillips

	UE-52667 Unable to package an Android DLC Using "Android APK" and "Android DLC" profiles in Project Launcher.

	#jira UE-52667

Change 3906792 by Lauren.Ridge

	When constructing the material editor viewport, use the direct method to set the environment visibility.

	#jira UE-55267

Change 3906734 by Chris.Babcock

	Fix issue with vertex fetch disable
	#jira UE-55475

Change 3906721 by Rolando.Caloca

	UE4.19 - Check if the results file from SCW is corrupt

	#jira UE-53124

Change 3906648 by Chris.Phillips

	UE-53184 Assertion when running mobile PIE in iPhone 5S mode.

	Updated the iPhone5s.json Metal settings.

	#jira UE-53184

Change 3906474 by David.Hibbitts

	Added default constructor for FLiveLinkWorldTime.

	#jira UEENT-879 #rb none

Change 3906467 by Lauren.Ridge

	Swapping sibling materials now correctly swaps the overridden parameters out
	#jira nojira demobug

Change 3906156 by Michael.Trepka

	Reverting CL 3728924 as it's causing problems with modal windows. A different, much more involved fix for UE-51711 will be needed.

	#jira UE-52492

Change 3906144 by Michael.Dupuis

	#jira UE-54547: Added guard to be sure that material is valid

Change 3905882 by Matt.Kuhlenschmidt

	Enable substance buttons again

	#jira UE-55081

Change 3905513 by Sorin.Gradinaru

	UE-55394 iOS crash exiting app during startup movie: SPRINGBOARD, process-exit watchdog transgression

	#jira UE-55394
	#jira UE-52328
	#iOS
	#4.19

	This is a particular case of UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression

	Found several issues on iOS if the game is forced closed when the startup movie is playing and "Wait for movies to complete" is enabled in Project Settings

	- the game thread is waiting for the movie to complete on game shutdown - more that 5 sec

	- crash on FDefaultGameMoviePlayer::Shutdown if the above is fixed

	- HTTP module no longer has time to wait for the requests to complete.

Change 3905506 by Michael.Dupuis

	Remove static mesh instancing async buffer filling, as with all the changes made, it's no longer necessary, the cost of loading very large buffer is negligable

	Rebuild the occlusion tree when using foliage.DensityScale with something other than 1.0

	#jira 0

Change 3905498 by Lina.Halper

	Fix multiple pose asset issue - fallout from CL 3903509

	- as for fullbody, went back to old mathod because in the fullbody, we want shortest path most of times and you don't blend more than 1 weight, so this is likely fine
	- as for additive, change to use blend from identity.

	#jira: UE-55439, UE-55448, UE-55250

Change 3905325 by Sorin.Gradinaru

	UE-54764 UnrealMatch3 spams Kindle device log with "Unsupported EPixelFormat"

	#jira UE-54764
	#4.19

	Also reproduced on Samsung Galaxy S5 Neo (SM-G903F, GPU Mali-T720).
	Check GMaxRHIFeatureLevel > ERHIFeatureLevel::ES3_1 (not mobile) before creating RSV params used with SupportsManualVertexFetch: (Positions, Tangents, TextureCoordinates, Color buffers)

Change 3905307 by Jack.Porter

	Removed iPhone5 PIE json file as it's not a supported device

	#jira UE-53184

Change 3905132 by Shane.Caudle

	#JIRA
	Pushed it a little more out of the yellow.

Change 3905117 by Shane.Caudle

	#JIRA
	Got SSS working and made some tweaks.

Change 3904936 by Max.Chen

	Fix editor only

	#jira UE-55459

Change 3904269 by Chris.Babcock

	Disable manual vertex fetch on mobile
	#jira UE-55389
	#ue4
	#android
	#ios

Change 3904186 by Lina.Halper

	Pose asset crash when skeleton not existing during serialization
	#jira: UE-55422

Change 3904063 by Max.Chen

	Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register.

	Copy from Dev-Sequencer

	#jira UE-55314

Change 3904060 by Lauren.Ridge

	Fix for saving a child out of a layer stack capturing the wrong parameters
	#jira UETOOL-1280

Change 3904050 by Luke.Thatcher

	[CONSOLE] [^] Added RHI Command List Enqueue Lambda method (merging as edit CL 3879722 from //Fortnite/Main to //UE4/Release-4.19)

	 - Can be used to enqueue arbitrary tasks on the RHI thread from the render thread (similar to how EURC works for GT -> RT tasks), without having to write lots of bolierplate FRHICommand functor classes.
	 - The first overload of EnqueueLambda method will check Bypass() to determine if it should run the lambda immediately or defer to the RHI thread.
	 - This can be overriden via the 2nd overload if you need to check additional things such as IsRunningRHIInSeparateThread.
	 - The function returns true if the lambda was enqueued and deferred to the RHI thread, otherwise false. This can be used to optionally add RHIThreadFences for unlock commands etc.

	#jira UE-55437

Change 3904004 by Lauren.Ridge

	Fix for material layer output nodes being able to be placed in other graphs
	#jira UE-54867

Change 3903931 by Aaron.McLeran

	#jira UE-55435 Crash in google resonance when toggling visualization
	fix for issue described here -- https://github.com/resonance-audio/resonance-audio-unreal-sdk/issues/1

Change 3903722 by David.Hill

	The ProxyLOD plugin is experimental:  don't load it by default.

	#jira: ue-55402

Change 3903583 by Ben.Marsh

	Include .version and .modules files in manifest. Should fix missing version information in precompiled binaries.

	#jira

Change 3903529 by Richard.Hinckley

	#jira UEDOC-7180
	4.19 API Documentation manual update.

Change 3903509 by Lina.Halper

	Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/

	#DUPE MERGE: Fix issue with pose blending with shortest path - causing additive to blend linearly between pose if the rotation is same direction.

	#jira: UE-55250

Change 3903501 by Michael.Dupuis

	#jira UE-55122: Fixed bad neighbors updating for mobile

Change 3903387 by Will.Fissler

	; r.XGEShaderCompile is now enabled by default in source. Uncomment to disable XGE shader compilation.
	;r.XGEShaderCompile = 0

	#jira UE-55286

Change 3903251 by Sungjin.Hong

	#JIRA UE-55349
	#loc added KO locallization for VR, Handheld AR templates

Change 3903219 by Adrian.Siminciuc

	https://jira.it.epicgames.net/browse/UE-54738
	removed redundant iOS warning when IOnlineIdentity::Login is called by FOnlineExternalUIIOS::ShowLoginUI

	#jira UE-54738
	#iOS

Change 3903130 by Cody.Albert

	Updated build configuration to resolve iOS build error on UnrealMatch3

	#jira UE-53742

Change 3903056 by Shane.Caudle

	#JIRA
	Latest tweaks to lighitng and rendering for boy.

Change 3903032 by Cody.Albert

	Added missing include that was preventing iOS builds from succeeding on TopDown template

	#jira UE-54341

Change 3902669 by Lauren.Ridge

	Fix for thumbnail crash after saving material instances that contain layers
	#jira crash

Change 3902581 by Mitchell.Wilson

	Updating Samples and Template Min iOS Version to iOS 9.
	#jira UE-55148

Change 3902448 by Lauren.Ridge

	Fix for crash due to unparented material instance
	#jira crash

Change 3902206 by Chris.Phillips

	UE-52612 External textures only work in pixel shaders.

	Sampling external textures are now only limited to pixel shaders when the shader model is < SM4.

	#jira UE-52612

Change 3902120 by Peter.Sauerbrei

	bvringing over the fix for backgrounding crash on iPhone X from Fortnite
	#jira UE-54883

Change 3902097 by Lina.Halper

	Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/
	#DUPE MERGE: CL 3901939

	#jira: UE-55401

Change 3902082 by Mike.Beach

	Fixing an issue with the fix from CL 3889470 - fully matching the old UEnum name check (checking both the value name and the typed name, for example: "Left" and "EControllerHand::Left").

	#jira UE-55153

Change 3901963 by Peter.Sauerbrei

	bring over the fix from Fortnite for Remote Shader Compilation not respecting settings in the passed in shader
	#jira UE-52797

Change 3901959 by Ethan.Geller

	[Release-4.19] #jira UE-55225: Stop RtAudio stream on StopRecording in sequence recorder. #rb Aaron.McLaren

Change 3901482 by Lauren.Ridge

	Fix for crash on opening materials due to array out of bounds
	#jira crash

Change 3901181 by Michael.Dupuis

	#jira UE-55313: To enable tessellation we MUST have 2 materials in the list

Change 3900935 by Nick.Bullard

	Updating Default_Startup.mp4 with more recent UE branding.
	This still requires another update for final version with audio

	#jira UE-55382

Change 3900660 by Aaron.McLeran

	#jira UE-55381 crash in sound submix

	Bringing fix from FN to 4.19 (CL 3890630)

Change 3900643 by Aaron.McLeran

	#jira UE-55380 fixing synth envelopes

Change 3900617 by Aaron.McLeran

	#jira UE-55151 Fixing crash w/ mic component

Change 3900544 by tim.gautier

	QAGame: Submitting asset for AsNumber fix submitted with UE-10310
	#jira UE-29618

Change 3900430 by Ryan.Brucks

	KismetRenderingLibrary: Applied a fix from FN to make it possible to create textures from BP created RTs. Without the fix the assets would be created but invisible to the user due to missing RF_Public and RF_Standalone.

	#JIRA none

Change 3900399 by Lauren.Ridge

	Fixing global parameters not working
	#jira UE-55242

Change 3900297 by Ben.Marsh

	Speculative fix for hot reload causing version files to be updated with a locally made installed build.

	#jira UE-55072

Change 3900116 by Chris.Bunner

	Removing outdated tests and test assets.

	#jira UETOOL-1298

Change 3900042 by Chris.Bunner

	Deleted SharedInputCollection and associated material graph nodes.

	#jira UETOOL-1298

Change 3899887 by Lauren.Ridge

	Fix for background checkbox stomping profile info for material editor. Note that you may have to delete Saved/Config/Windows/Editor.ini to get this to work.

	#jira UE-55267

Change 3899824 by Chris.Phillips

	UE-52813 Editor's mobile preview doesn't serialize the landscape's cooked heightmap data.

	Now only regenerating landscape pixel data when needed when using Mobile Preview Rendering Levels.

	#jira UE-52813

Change 3899775 by Lauren.Ridge

	Fix for crash on opening material layer material
	#jira crash

Change 3899673 by Jamie.Dale

	Fixed Functions sometimes being exposed to Python as if they were Structs

	#jira none

Change 3899487 by Chris.Bunner

	Duplicate [CL 3852020, 3896571] - Disabling non-performant code only required by experimental material layers feature. Users can opt-in per-project through experimental renderer settings, replacing the previous editor experimental flag.

	#jira UETOOL-1298

Change 3899156 by Phillip.Kavan

	Include address of object reference in persistent frame debug info.

	#jira UE-51952

Change 3899146 by Rolando.Caloca

	UE4.19 - hlslcc - Workaround for intrinsics with two output arguments

	#jira UE-52477

Change 3899060 by Bart.Hawthorne

	Add a null check for the game mode pointer in UWorld::SpawnPlayActor

	#jira UE-54461

Change 3899015 by Krzysztof.Narkowicz

	Fixed initialization of instancing random vertex stream.

	#jira UE-53605

Change 3899008 by Michael.Dupuis

	Fix issue with landscape mobile vertex factory accessing unbound LodTessellationParams when r.ShaderDevelopmentMode=1

	#jira 0

Change 3898994 by Phillip.Kavan

	More verbose debug logging if an invalid object reference is detected in the BP ubergraph frame during garbage collection.

	#jira UE-51952

Change 3898962 by Guillaume.Abadie

	Fixes wrong parameters about whether GPU timing may have CPU generated bubbles to the dynamic resolution heuristic.

	#jira UE-55352

Change 3898826 by Sorin.Gradinaru

	UE-54784 StrategyGame crashes entering game on KindleFire 7 - Assertion failed: ViewSize.GetMin

	 #4.19
	#Android
	#jira UE-54784

	Wrong code to make an integer even + operator precedence

Change 3898822 by Sorin.Gradinaru

	UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression
	FORT-70783 FHttpManager::Flush is immediately canceling all HTTP requests

	#jira UE-52328
	#jira FORT-70783

	#iOS
	#PC
	#4.19

	UE-52328 reopened because of FORT-70783
	iOS only: Delay Request->CancelRequest() on Http module shutdown - wait for 2 sec on FHttpManager::Flush to allow pending requests to be sent to the server.

Change 3898705 by Max.Chen

	Sequencer: Skip if the binding id's sequence can't be found.

	#jira UE-55337

Change 3898108 by Michael.Dupuis

	#jira UE-54547: Remove the FORCEINLINE so we get a proper callstack of what's happening

Change 3898076 by Max.Chen

	Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated.

	#jira UE-55328

Change 3897897 by Matt.Kuhlenschmidt

	Disable substance buttons for now
	#jira UE-55081

Change 3897742 by Aaron.McLeran

	Merging fix for UE-55223 to 4.19
	#jira UE-55223

Change 3897538 by Michael.Dupuis

	#jira UE-53787: Added guard if for some reason the material is null we should not try to draw using this material

Change 3897406 by Phillip.Kavan

	Back out local debug logs.

	#jira UE-51952

Change 3897400 by Phillip.Kavan

	Serializing object will now be passed to GC so that it can be logged in case the referenced objects is garbage.

	- Mirrored from //UE4/Dev-Core (3871863).

	#jira UE-51952

Change 3897391 by Max.Chen

	Sequencer: Don't update current time to be within the view range when stepping into a sequence.

	#jira UE-55322

Change 3897274 by Krzysztof.Narkowicz

	Fixed issues with loading shaders from DDC - hardcoded CustomAttributes initialization instead of filling them inside UObject costructors in order to properly initialize CustomAttributes before DDC key was created. Added an assert that CustomAttributes are initialized before the AttributeDDCString, so we won't run into this issue again in the future.

	#jira UE-54683

Change 3897148 by Adrian.Siminciuc

	https://jira.it.epicgames.net/browse/UE-55147

	#4.19
	#iOS

	#jira UE-55147

Change 3897138 by Max.Chen

	Sequencer: Fix crash when an actor factory is not found.

	Copy from Dev-Sequencer

	#jira UE-55309

Change 3897045 by Jack.Porter

	Fix for crash in ALandscapeProxy::UpdateGrass

	#jira UE-54362

Change 3897036 by Jack.Porter

	Fix InstancedStaticMesh crash with invalid lightmap coordinates
	#jira UE-54423

Change 3896801 by Dmitriy.Dyomin

	Fixed: Planar reflections does not handle origin rebasing
	#jira UE-52351

Change 3896743 by Dmitriy.Dyomin

	Discard CPU copy of vertex/index buffers in OpenGL RHI
	#jira UE-52133

Change 3896619 by Guillaume.Abadie

	Cherry-pick 3896598: Fixes after TAAU post process material that had wrong default buffer UV.

	#jira UE-55317

Change 3895718 by Max.Chen

	Sequencer: Null checks to prevent crash when saving the default state of a spawnable

	#jira UE-55304

Change 3895426 by Rolando.Caloca

	UE4.19 - Add an increased timeout for SCW to avoid OOM situations

	#jira UE-55306

Change 3895245 by tim.gautier

	QAGame: Submitting updated test assets. Broke ML_Base out into individual components
	#jira UE-29618

Change 3895194 by Marc.Audy

	Prevent crash due to a null entry in the linked to graph of the destination pin
	#jira UE-54606

Change 3894913 by Arne.Schober

	REL - Fix crash in Speedtree wind where Renderdata is unavailable
	#jira UE-54544

Change 3894625 by Arne.Schober

	REL - Fix assert not in RenderingThread from Triangle Renderer.
	#jira UE-55247

Change 3894464 by Martin.Wilson

	Extra debugging info for UE-54705 plus remove check so it is no longer fatal

	#jira UE-54705

Change 3894450 by Martin.Wilson

	Remove pinnable ness of retarget asset. Paves the way for exposing retarget asset properties on the node

	#jira none

Change 3893948 by Jostin.Bilyeu

	Adding default player start location to help with launch on testing within level TM-Materials_POM

	#jira UE-55063

Change 3893495 by Robert.Manuszewski

	Fixing a crash when running DDC commandlet

	#jira UE-54646

Change 3893451 by Jurre.deBaare

	Altered fix for actor merging with negative scaling to get correct normals
	#jira UE-54996
	#misc updated automated test to include this test-case

Change 3892913 by Ethan.Geller

	[Release-4.19] #jira UE-55151 Fix for Mic Component crashing on re-init. #rb aaron.mcleran

Change 3892871 by Ryan.Vance

	Multi-view requires the day dream compositor.

	#jira UE-55253

Change 3892785 by Arciel.Rekman

	Linux: fix inability to create a C++ project (UE-55222).

	- NullSourceCodeAccessor will unconditionally allow C++ project creation in source builds.
	- Installed build will check for more compilers in commonly found locations.

	#jira UE-55222

Change 3892687 by Jostin.Bilyeu

	Checking in replacement Built Data for map TM-Materials_POM

	#jira UE-55063

Change 3892674 by Jostin.Bilyeu

	Adding an invisible plane to TM-Materials_POM to help testing on mobile devices

	#jira UE-55063

Change 3892622 by Aaron.McLeran

	#jira none Fixing scope lock in phonon probe volume

Change 3892511 by Matt.Kuhlenschmidt

	Fix zero engine version warning

	#jira UE-55081

Change 3892211 by Yuriy.ODonnell

	Fix/workaround for inconsistent preprocessor definitions for NVAftermath that result in FD3D11DynamicRHI class layout mismatch. NVAftermath support is now enabled by default for Win64.

	NVAftermath is declared as a private dependency in D3D11RHI. It does not automatically propagate to modules that explicitly include private RHI headers (OculusHMD, OSVR, OSVRInput). This results in NV_AFTERMATH being defined while compiling RHI module and not defined when compiling other modules, causing memory corruption at runtime.

	The long-term solution for this and similar issues requires some mechanism for adding transitive module dependencies, so that anyone that depends on D3D11RHI module would automatically also get the NVAftermath. Additionally, private headers should *never* be included directly by external modules.

	The short-term solution is to explicitly add NVAftermath dependency to OculusHMD, OSVR and OSVRInput.

	Additionally, NV_AFTERMATH is no longer forced by D3D11RHIPrivate.h when it's not defined. This allows catching this kind of mismatch in the future through a compiler warning (C4668).

	#jira UE-53065

Change 3891732 by Brian.Zaugg

	Re-adding iPhoneX launch images with correct case.

	#JIRA UE-53541

Change 3891727 by Arne.Schober

	REL - Do not recreate one Frame Resource for dynamic draws

	#jira UE-55063

Change 3891716 by Ben.Marsh

	Fix buffer overrun when generating callstack.

	#jira

Change 3891697 by Brian.Zaugg

	Deleting iPhoneX launch images that have incorrect case.

	#jira UE-53541

Change 3891678 by Brian.Zaugg

	IPP binaries for iPhoneX support.

	#jira UE-53541

Change 3891525 by Lauren.Ridge

	Thumbnails now update correctly w/parameters
	#jira UETOOL-1333

Change 3891520 by Lauren.Ridge

	Fixing SA error in material editor
	#jira UE-55206

Change 3891495 by Jurre.deBaare

	Normal are different after Merge Actor on scaled objects
	#fix Make sure we do not apply scale when transform Normals/Tangents
	#jira UE-54996

Change 3891352 by Guillaume.Abadie

	Fixes ensure when visualizing HDR with TAAU.

	#jira UE-55019

Change 3891323 by Matt.Kuhlenschmidt

	Added substance buttons to content browser and material editor

	#jira UE-55081

Change 3891033 by David.Hibbitts

	#JIRA UE-55135

	Moved Message Bus Source heartbeats to their own thread using a new FHeartbeatManager singleton. This prevents sources from incorrectly being removed during Slate UI operations.

Change 3890642 by Arne.Schober

	REL - Better fix for Paper2d which honors batching

	#jira UE-55063

Change 3890593 by Arne.Schober

	REL - Fix Paper2d crash. When addMesh is called the Vertex and Indexbuffers are nulled out. re-create Dynamic Mesh builder for every Mesh instead.

	#jira UE-55063

Change 3890502 by Mike.Erwin

	Fix reported VRAM size on Metal

	We were getting correct value in MB from system but overflowing uint32 arithmetic when converting to bytes.

	This led 4GB and 8GB configs to report 0 total VRAM, 0 dedicated tex mem, and GTexturePoolSize = 0.
	Noticed the problem on my 6GB FirePro, which reported 2GB and set GTexturePoolSize to 70% of that.

	Also fixed log of texture pool size to show MB. Other platforms' RHIs already report this in MB.

	#jira none

Change 3890404 by Jostin.Bilyeu

	Updating Demo Display names to remove redundant spaces

	#jira UE-29618

Change 3890401 by Dan.Oconnor

	Fix for property table performance regression

	#jira UE-54984

Change 3890194 by Dan.Oconnor

	Make sure a CDO's subobjects are preloaded when running in -game

	#jira UE-54242

Change 3890182 by Krzysztof.Narkowicz

	Moving CL3867594 from Dev-Rendering to fix missing shaders in cooked Binary Editor DCC. USE_EDITOR_ONLY_DEFAULT_MATERIAL_FALLBACK generated default material shaders had no cooking code path.

	#jira UE-54683

Change 3890140 by Rob.Cannaday

	Merging cacert.pem from //UE4/Dev-Online to //UE4/Release-4.19
	Includes latest cacert.pem from https://curl.haxx.se/docs/caextract.html as of January 17, 2018
	#jira none

Change 3889850 by Shaun.Kime

	Now initializing Niagara scripts and emitters even if the config file isn't ready yet.

	#jira UE-54168
	#jira UE-54169

	#tests can create a blank emitter and all script sub-types

Change 3889833 by Michael.Trepka

	Disabled Clang's unused-lambda-capture warning added in Xcode 9.3

	#jira none

Change 3889696 by Patrick.Boutot

	Allow rename from AssetTool when there is no source control enabled.
	Fix crash when you rename an asset without an enabled source control.

	#jira UEENT-803

Change 3889470 by Mike.Beach

	Switching the source-name to legacy hand enum lookup functions to use a static table instead of finding a UEnum object and iterating over reflection data (to prevent a GC lockup with the UObject query).

	#jira UE-55153

Change 3889319 by Matt.Kuhlenschmidt

	Disable hardware survey on build machines.  They run windows server and lack the necessary win32 api functionality to execute it properly

	#jira UE-55166

Change 3889087 by Jostin.Bilyeu

	Minor adjustments TM-SceneTexture for better testing clarity. Minor adjustments to TM-MipLevels for test map clean up

	#jira UE-29618

Change 3889073 by Sorin.Gradinaru

	UE-55117 Android virtual keyboard can have text input hidden by software buttons

	#jira UE-55117
	#Android
	#4.19

	Adjusted x-coord and width for the native EditText

Change 3888841 by Jurre.deBaare

	Make FSkeletalMeshRenderData::GetMaxBonesPerSection an ENGINE_API exported function
	#jira none

Change 3888837 by Guillaume.Abadie

	Fixes a crash in dynamic resolution when doing UE4Editor -server

	#jira UE-55158

Change 3888831 by Dragan.Jerosimovic

	added fbx files
	#jira none

Change 3888340 by Ethan.Geller

	[Release-4.19] #jira UE-54787 edit settings for Strategy Game to prevent stuttering in AudioMixer on low performance Android Devices #rb Aaron.McLeran #fyi Aaron.McLeran #lockdown Cristina.Riveron

Change 3888133 by Michael.Karambelas

	QAGame: Adding a BP Actor to test the Mic component feature that AaronM implemented with UE-51471.

	#jira UE-29618

Change 3887957 by Krzysztof.Narkowicz

	"Fixed" Vulkan instancing in by doing Metal style set instance offset to 0 hack
	#jira UE-54367

Change 3887912 by Jostin.Bilyeu

	Adding content to TM-SceneTexture to verify Screen Positioning as well as Scene Color and Depth. Adding a new map (TM-MIPLevels) for testing custom mip levels

	#jira UE-29618

Change 3887571 by Zak.Parrish

	Adding FaceAR content and cleanup #jira none

Change 3887458 by Dan.Oconnor

	Fix 'Step Out' functionality for macro and collapsed graphs

	#jira UE-55000, UE-55002, UE-55022

Change 3886883 by zachary.wilson

	Add testing content to QAGame: Texture and material for testing mip levels. Postprocess material for testing scene buffer sampling.

	#jira UE-29618

Change 3886848 by Max.Preussner

	Engine: Workaround for uninitialized external textures causing white flashes in media playback

	Copied from Fortnite-Main and Dev-Sequencer

	#jira UE-53357

Change 3886720 by Matt.Kuhlenschmidt

	Guard against mac menus updating during slow tasks.

	#jira UE-55068

Change 3886657 by Guillaume.Abadie

	Cherry-pick 3886626: Cherry-pick 3886560: Fixes strong aliasing on TAAU's fast shader permutation.

	This adds a 6th neighbor sampling, and switch AA_TONE ON as TAA does for its fast shader permutation.

	#jira FORT-69961

Change 3886653 by Matt.Kuhlenschmidt

	Perforce Plugin: Removed all calls to methods that would update the P4PASSWD environment variable.  Perforce stores this as plain text so it is not safe and we do not want the editor to be responsible for this being set.  All users should be using ticket based p4 servers for the best security but if they are unable to then they can call p4 passwd on their own to set a slightly better hashed password directly.  They may also log in each time to the editor which prevents any password from being stored

	#jira UE-55111

Change 3886621 by Benn.Gallagher

	Fixed crash closing clothing tab if workflow centric application puts the tab spawners in a bad state due to incorrect handling of tab context menus.

	#JIRA UE-55067

Change 3886552 by Thomas.Sarkanen

	Fixed crash loading an anim instance with a re-instanced class

	Unable to repro, but in editor we dont need the optimization that this provides. Now we always re-initialize functions and properties in case the class has changed out from under us.

	#jira UE-55065 - [CrashReport] UE4Editor_Engine!FExposedValueHandler::Initialize() [animnodebase.cpp:521]

Change 3886442 by Cosmin.Sulea

	UE-53033 - Editor Rapidly Spawns Multiple Empty Windows Throughout Remote Shader Compiling
	#jira UE-53033

Change 3886441 by Cosmin.Sulea

	UE-54598 - Using an Invalid iOS Mobile Provision does not give descriptive error in Project Launcher, IPhonePackager
	#jira UE-54598

Change 3886427 by Sorin.Gradinaru

	UE-54139 Possible crash with new virtual keyboard on Android if suggestions not disabled - from //Dev-Mobile@CL3843552

	#4.19
	#Android
	#jira UE-54139

	S8 on 7.0 is not hiding suggestions and disabling predictive input.  There are cases with this that can cause a crash.

	Fix:  On text change, downgrade to simple suggestions all the easy correction spans that are not a spell check span (remove android.text.style.SuggestionSpan.FLAG_EASY_CORRECT flags)

Change 3886210 by Ethan.Geller

	[Release-4.19] #jira UE-53867 Ensure we don't read off into garbage memory for uncompressed PCM.

Change 3886005 by Zak.Parrish

	Checking in faceAR work on behalf of 3Lateral #jira none

Change 3885925 by Mike.Erwin

	Material preview label off-center on HiDPI screen

	#jira UE-52533

Change 3885778 by Dan.Oconnor

	Fix stepping over collapsed graph and macro nodes
	#jira UE-54950, UE-54955

Change 3885713 by Mike.Erwin

	glTF: fix material using wrong textures

	Imported material could plug the wrong textures into its inputs. The previous code tracked a material's textures based on image source index, corrected code uses texture (source + sampler) index. This is more general allowing an image to be referenced by multiple textures.

	Bug reported yesterday via email, demonstrated using the Khronos TextureSettingsTest sample model.

	#jira none

Change 3885603 by Ben.Marsh

	Fixes for compiler errors in nightly builds of VS2017 in /permissive- mode.

	#jira

Change 3885566 by Phillip.Kavan

	Fix a scoping issue related to inaccessible property reference caching in nativized Blueprint code.

	Change summary:
	- Modified FDefaultSubobjectData::EmitPropertyInitialization() to utilize the FScopeBlock utility to manage the inaccessible property cache during code generation for instanced subobject initialization.

	#jira UE-55061

Change 3885481 by Mark.Satterthwaite

	Attempt to workaround an Intel shader compiler bug without reopening a related AMD bug. This may cost performance unless function constants are available and the runtime compiler actually bothers to perform optimisation (AMD's did not in 10.12.6 and earlier).

	#jira UE-54333

Change 3885461 by Lauren.Ridge

	Fix for slot not being initialized to null

	#jira UE-55069

Change 3885455 by zak.parrish

	Adding initial files for FaceAR scene lookdev #jira none

Change 3885446 by Zak.Parrish

	Adding test assets for Gremlin look dev. May get removed later prior to release. #jira none

Change 3885424 by Krzysztof.Narkowicz

	Fixed skeletal mesh LODs inside editor. If skeletal mesh wasn't recently visible, code was incorrectly changing LOD settings without updating LOD data on render thread.

	#jira UE-53861

Change 3885406 by Zak.Parrish

	Rollback //UE4/Release-4.19/Samples/FaceARSample/Content/UI/FaceARDebugUI.uasset to revision 1 #jira UE-54639

Change 3885340 by Arne.Schober

	REL - Bitarray FindFromLast was masking incorrectly for the corner case where there is no slack

	#jira none

Change 3885143 by Marc.Audy

	Merge memory corruption fix in CL# 3884991 from Fortnite-Staging to Release-4.19

	#jira UE-54977
	#jira UE-54976
	#jira UE-54898

Change 3885093 by Mark.Satterthwaite

	Apple don't like testing for the validation layer in iOS App Store builds - it is unnecessary so we can disable this for shipping builds.

	#JIRA N/A

Change 3884622 by Jurre.deBaare

	Moving over missing file from changelist for UE-54508

	#jira UE-54508

Change 3883391 by Nick.Atamas

	Fix for UE-54622 : PIE in VR available when ARKit/ARCore plugins enabled.
	Only create ARKit/ARCore tracking systems on iOS/Android.

	#jira UE-54622

Change 3883257 by Phillip.Kavan

	Fix a Blueprint compile error for the GetClassDefaults node Map value outputs introduced by stronger type checking in 4.19 between Map pin types.

	#jira UE-55026

Change 3883024 by Lauren.Ridge

	Fixing static analysis warning
	#jira SA

Change 3882510 by Michael.Dupuis

	#jira none : Fixed screen size calculation to take aspect ratio into account correctly

Change 3882502 by Lauren.Ridge

	Fix for material layer parameters not rebuilding and adding save child button
	#jira UETOOL-1275

Change 3882458 by Krzysztof.Narkowicz

	Copying cached shadow map assert fix from Fortnite-Main (CL3802813)
	#jira UE-54747

Change 3882366 by Michael.Karambelas

	QAGame: made changes to QABP_Debugging, QABP_FunctionLib, and QA_TestHelper for Blueprint debugger tests.

	#jira UE-29618

Change 3881971 by andrew.porter

	QAGame: Removing actor from Shot_003

	#jira UE-29618

Change 3881795 by Krzysztof.Narkowicz

	Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
	#jira UE-53875

Change 3881550 by David.Hibbitts

	#JIRA UEENT-879
	Subject frames now store world time explictly as a double with optional scene timecode as MetaData. This allows for use cases such as posing a single frame in Maya where the world time would be changing but the scene timecode associated with the animation remains fixed.

	THIS IS A BREAKING CHANGE: Sources from before this change will no longer compile.

Change 3881339 by Jurre.deBaare

	Moving over:
	"Editor crashed when attempting to bake out all the material channels
	#jira UE-54508
	#misc small UDN Merge actor / bake material fixes

Change 3879557 by Dan.Oconnor

	Fix stepover behavior when no debug target is selected

	#jira UE-54978

Change 3879485 by Mike.Beach

	Limiting the number of stereo layers on Oculus android to 4 (otherwise, their lib crashes).

	#jira UE-54999

Change 3879438 by David.Hibbitts

	#JIRA UEENT-880 Added support for Subject level MetaData to LiveLink #rb martin.wilson #fyi james.golding, simon.tourangeau

Change 3879343 by Lina.Halper

	Last min change that skiped compiling

	#jira: none

Change 3879337 by Lina.Halper

	Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes.

	#jira: UE-54806

Change 3878968 by Phillip.Kavan

	Fix deprecation warnings in compiled stub class wrapper codegen for Blueprint class dependencies excluded from nativization.

	Change summary:
	- Modified FBlueprintCompilerCppBackendBase::GenerateWrapperForClass() to const-correct the assignment of cached weak pointers to referenced properties.

	#jira UE-54981

Change 3878962 by Adrian.Siminciuc

	https://jira.it.epicgames.net/browse/UE-54831 (No error occurs accepting if Android SDK license file cannot be written, but user cannot accept license)

	#4.19
	#jira UE-54831
	#android

	- shows an error message box informing that the license file could not be written.

Change 3878821 by Andrew.Rodham

	Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation

	  - The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field.
	  - The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field.
	  - The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges.

	#jira UE-54922

Change 3878171 by Chris.Phillips

	Android: Fixed crash after splash screen when using Vulkan.

	#jira UE-54299

Change 3877950 by Ethan.Geller

	Fix copyright information from previous CL #jira none #rb none #lockdown Cristina.Riveron

Change 3877859 by Nick.Shin

	rebuilt lighting for TM-ShaderModels and resaved the level

	#jira UE-53374  Client displays "lighting needs to be rebuilt (1 unbuilt object(s))" when launching TM-Shadermodels onto HTML5

Change 3877854 by tim.gautier

	Adding additional (temp) ML Test asset
	#jira UE-29318

Change 3877609 by Ethan.Geller

	[4.19] Change FWhiteNoise generate function to use SRand, due to weird distribution in FRandRange #jira UE-54965 #rb aaron.mcleran #lockdown cristina.riveron

Change 3877474 by Lauren.Ridge

	Adding WITH_EDITOR wrappers to editor-only section of code
	#jira fixingcompiles

Change 3877271 by Arne.Schober

	REL - Integrate 3872827 - The VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should not be neccessary

	#jira none

Change 3877260 by Lina.Halper

	If revision is too far away, ignore the request and send current buffer

	- this is exactly how it used to do and it is still required, but this means motion vector will be ignored when this happens

	#jira: UE-54398

Change 3876950 by Lauren.Ridge

	Renaming layers in a material instance - from 4.19 preview feedback
	#jira UETOOL-1296

Change 3876932 by Arciel.Rekman

	Linux: updated the link to the cross-toolchain (UE-54597).

	#jira UE-54597

Change 3876918 by Phillip.Kavan

	Fix a regression that could cause packaging to fail and/or data loss with Blueprint nativization enabled.

	Change summary:
	- Removed logic that attempted to avoid redundant assignments of instanced default subobject references. This was not compatible with editinline characteristics that can allow certain object reference values to be overridden by the Blueprint class.
	- Explicitly defer to ExportTextItem() when generating C++ code for UObjectProperty/UInterfaceProperty reference values in which the underlying object reference is NULL.

	#jira UE-54870

Change 3876759 by tim.gautier

	Updated Material Layer test assets to include Opacity and Emissive.
	#jira UE-29318

Change 3876575 by Michael.Karambelas

	Updating the QABP_Debugging asset in QAGame with a couple of interfaces and additional logic for testing purposes.

	#jira UE-29618

Change 3876406 by Robert.Manuszewski

	Fixed a crash when reporting linker errors

	#jira UE-51037

Change 3875891 by Nick.Atamas

	Fixed scenario where geometries were being updated once per pin, instead of just being updated once.
	Also fixes a scenario where there are no pins and geometries fail to update.

	#jira UE-54914

Change 3875880 by Aaron.McLeran

	#jira UE-54916
	Fixing up submix effect templates

Change 3875673 by Brandon.Schaefer

	Fix Apex dependencies

	Depend on static Apex libraries in Apex.Build.cs versus Physx.Build.cs

	#jira UE-54861

Change 3875498 by Lauren.Ridge

	PR #4477: 4.19 Fixed a crash caused by the layered material property widget of the material instance editor. (Contributed by mlaveaux)

	#jira UE-54862

Change 3875322 by tim.gautier

	Recreating Material Layer test assets (asset version has changed)
	#jira UE-29318

Change 3875157 by Aaron.McLeran

	#jira UE-54901 Synth components do not allow sends to buses

Change 3875103 by Brandon.Schaefer

	Need to use our bundled libc++.so not libstdc++.so when building Apex/PhysX/NvCloth libraries

	#jira UE-54815

Change 3875037 by Aaron.McLeran

	#jira UE-54896 Fixing up audio capture component to parameterize the delay

	Parameterize the jitter latency delay.

Change 3875026 by Aaron.McLeran

	#jira UE-54895 Filter frequency values don't update live with EQ effects and 0-frequency cutoff causes pops

Change 3874927 by Ryan.Vance

	#jira UE-54894

	Ensure we don't delete aliased texture resources, they are managed externally.

Change 3874925 by Martin.Wilson

	Remove XR post fix from live link code written during motion controller integration

	#jira none

Change 3874354 by Ben.Marsh

	Use the compiler matching the user's preferred IDE if they don't have a specific compiler selected in the project settings.

	#jira UE-54272

Change 3877545 by Ben.Marsh

	Replace FPlatformMisc::DebugBreak() with the UE_DEBUG_BREAK() macro. VS2017 is able to show force-inlined calls on the callstack, which makes debugging asserts and ensures annoying.

	Use similar logic for expanding ensure() macros in place.

	#jira UE-54961

[CL 3963579 by Ben Marsh in Main branch]
2018-03-24 09:22:20 -04:00