#rb ben.ingram
#preflight 611d23203a81b0000133853f
#ROBOMERGE-SOURCE: CL 17216210
#ROBOMERGE-BOT: (v855-17104924)
[CL 17216219 by jeremy moore in ue5-main branch]
FPreloadShaderTask takes the ShaderPreloadLock in FShaderCodeArchive::OnShaderPreloadFinished() and then issues an async read. Another task can be picked up by the thread while waiting on that read. If that new task is also a FPreloadShaderTask it will try to aquire the ShaderPreloadLock again and deadlock.
Introduce an EnsureReadNonBlocking method to IMemoryReadStream which can be called outside the lock to ensure the data is ready. We can then lock and copy out the data without incuring a wait and the potential for another FPreloadShaderTask being run while we hold the lock.
#rb Ben.Ingram, Michal.Valient
#ROBOMERGE-SOURCE: CL 16917416
#ROBOMERGE-BOT: (v836-16769935)
[CL 16924675 by eric mcdaniel in ue5-main branch]
Saves memory compared to allocating arrays for all lines.
#rb ben.ingram
#ROBOMERGE-SOURCE: CL 16680895
#ROBOMERGE-BOT: (v835-16672529)
[CL 16680907 by jeremy moore in ue5-main branch]
warning V1062: The 'XYZ' class defines a custom 'new' operator. The 'delete' operator must also be defined.
#rb steve.robb
#jira UE-91644
[CL 15019000 by Tim Smith in ue5-main branch]
#rb none
#ROBOMERGE-SOURCE: CL 13152458 via CL 13161669 via CL 13161725 via CL 13161836
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v688-13145358)
[CL 13161907 by ben ingram in Main branch]
Normal read requests have this behavior, but size requests were not respecting this, which caused problems when the constructor launches a callback on another thread and then immediately calls WaitCompletion, such as in the callback lambda inside FFileCacheHandle::FFileCacheHandle / PushCompletedRequest.
#rb rune.stubbe
#jira none
#rnx
#ROBOMERGE-SOURCE: CL 12974187 in //UE4/Release-4.25/... via CL 12974195 via CL 12974203
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)
[CL 12974208 by jeff newquist in Main branch]
- FileCache can dynamically allocate/release memory as needed
- Preloaded lines are locked in the cache. One the preloaded memory has been read, the line is unlocked. This prevents preloaded lines from being evicted before they're needed.
- Cache line size changed from 64k to 16k, reduce fragmentation due to locked preloaded lines
#rb none
#ROBOMERGE-SOURCE: CL 12491121 via CL 12491126 via CL 12491130
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)
[CL 12491133 by ben ingram in Main branch]
