aurel cordonnier
e3f7878676
Merge from Release-Engine-Test @ 17462327 to UE5/Main
...
This represents UE4/Main @17430120 and Dev-PerfTest @17437669
[CL 17463546 by aurel cordonnier in ue5-main branch]
2021-09-08 16:42:26 -04:00
ben hoffman
2fe2bdb404
Set the parent of non-scene components correctly when converting an instance to a blueprint
...
#jira UE-120632
#rb todo
#rnx
#p4v-preflight-copy 17105167
[CL 17107844 by ben hoffman in ue5-main branch]
2021-08-09 17:12:37 -04:00
ben hoffman
cf73c15be0
When pasting a subobject, check to see if the desired parent is a scene component before allowing it to be the target of the paste. This prevents the incorrect parenting to the Actor root in the case of copy/pasting the default scene root.
...
#jira UE-119104
#rb trivial
#rnx
[CL 16960122 by ben hoffman in ue5-main branch]
2021-07-26 15:37:36 -04:00
Jamie Dale
a82da56223
Fixed some more places incorrectly testing against NAME_SIZE (as it includes the null terminator)
...
#rb none
#rnx
[CL 16938866 by Jamie Dale in ue5-main branch]
2021-07-23 13:16:52 -04:00
ben hoffman
6e803aa366
Change the behavior when pasting subobjects to attach to the selected subobject's parent instead of the subobject itself. This makes the pasting behavior between the blueprint and level instance editor the same.
...
#jira UE-118256
#rb trivial
#rnx
[CL 16901336 by ben hoffman in ue5-main branch]
2021-07-20 15:59:06 -04:00
ben hoffman
a034d8253a
Only try to find a scene component target to attach to if the pasted component is a scene component. Non-Scene components can only be attached to the root actor. This solves an issue where a pasted non-scene component could be incorrectly attached to the default scene root.
...
#jira UE-117883
#jira UE-118250
#rb justin.hare
#rnx
[CL 16900194 by ben hoffman in ue5-main branch]
2021-07-20 15:06:37 -04:00
ben hoffman
1dbcb0df0c
Check if the old scene root was the default scene root that is generated by every BP to determine if it should be deleted or not. This makes the behavior consistent with the old SCS Editor
...
#jira UE-117876
#rb trivial
#rnx
[CL 16854709 by ben hoffman in ue5-main branch]
2021-07-14 16:24:16 -04:00
ben hoffman
5bd5f2561c
CIS fix. Remove ParentObjData from an if statement because there is already a "check" on the variable above. Having it in the if statement was causing other uses of it to flag PVS
...
#jira none
#rb trivial
#rnx
[CL 16854427 by ben hoffman in ue5-main branch]
2021-07-14 16:06:13 -04:00
ben hoffman
a38ca94c2d
Add a flag to force deletion on subobjects so that when making a new scene root the CanDelete check will be bypassed.
...
This is needed because when the user drags a new scene component over the existing one, the old one should be deleted but is still marked as the SceneRoot (and cannot be deleted because we have to update the instances of the archetypes)
#jira UE-119151
#rb trivial
#rnx
#preflight 60edf5d0ef22fa000176acdf
[CL 16843507 by ben hoffman in ue5-main branch]
2021-07-13 17:56:24 -04:00
ben hoffman
60c7ca432f
Replace an incorrect check for a child actor with a check for a child actor subtree object.
...
#jira none
#rb trivial
#rnx
[CL 16840124 by ben hoffman in ue5-main branch]
2021-07-13 14:22:17 -04:00
ben hoffman
188d3e325d
If the attachment point is a BP inherited subobject then find the correct archetype attachment point when adding subobjects to an instance
...
#rb marc.audy
#jira UE-117457
#jira UE-119112
#rnx
#preflight 60ec6955ef22fa000150f693
[CL 16837795 by ben hoffman in ue5-main branch]
2021-07-13 11:21:36 -04:00
ben hoffman
2d93fed50e
Instead of checking if something is a child actor component when attempting to maniuplate it, check if its owner is a CAC instead. If it's owner is a CAC, then it cannot be removed because it is determined by the owning CAC. Before, the code was incorrectly checking if something was just a plain old child actor component, resulting in being unable to delete, reparent, or attach to a child actor component.
...
#jira UE-117132
#jira UE-117332
#jira UE-117327
#jira UE-117329
#rb marc.audy
#rnx
#preflight 60d48296925f1400010bb909
[CL 16773601 by ben hoffman in ue5-main branch]
2021-06-24 10:55:53 -04:00
ben hoffman
ff3b233df8
Use CopyPropertiesForUnrelatedObjects instead of a basic ObjectWriter/Reader combo when duplicating components to properly handle subobjects.
...
#jira UE-68780
#rb marc.audy
#rnx
[CL 16751102 by ben hoffman in ue5-main branch]
2021-06-22 19:04:02 -04:00
ben hoffman
435dcc7d82
Correctly set the module path when creating a C++ class from the subobject data subsystem. This will correctly set the module path so that the error messages are correct from GameProjectUtils::AddCodeToProject. This will make the module selection the same as how the SNewClassDialog handles it for a more consistent and correct experience.
...
#jira UE-116994
#rnx
#rb phillip.kavan
[CL 16748591 by ben hoffman in ue5-main branch]
2021-06-22 16:23:15 -04:00
Jamie Dale
ac95fa3168
Fixed subobject editor not honoring the requested post-delete selection
...
#rb Ben.Hoffman
[CL 16747272 by Jamie Dale in ue5-main branch]
2021-06-22 15:19:31 -04:00
ben hoffman
fb9dde0359
Notify the level editor that a subobject has been changed when adding or deleting a subobject. This ensures that if there is a selected actor instance in the level that it will have it's subobjects properly updated
...
#jira UE-116645
#rb justin.hare
#rnx
#preflight 60cba56378c3b0000138e856
[CL 16711849 by ben hoffman in ue5-main branch]
2021-06-17 17:11:39 -04:00
ben hoffman
b6365aba67
Attach a dupliucated component to the source's parent instead of the source directly
...
#jira UE-118043
#rb trivial
#rnx
[CL 16709163 by ben hoffman in ue5-main branch]
2021-06-17 15:06:40 -04:00
ben hoffman
1ee7ce31ff
Check if a subobject is allowed to be deleted before allowing the subsystem to delete it. This solves the problem where a BP script may not be doing the same validation when calling DeleteSubobjects that the Subobject Editor does.
...
Add logging when a subobject can't be deleted
#jira UE-117853
#rb michael.noland
#rnx
#preflight 60c8def586ce760001d8de51
[CL 16678061 by ben hoffman in ue5-main branch]
2021-06-15 15:39:14 -04:00
ben hoffman
2c4b1df587
Added logging when a blueprint component cannot be deleted when called from blueprints
...
#jira UE-117855
#rb trivial
#rnx
[CL 16665192 by ben hoffman in ue5-main branch]
2021-06-14 17:50:08 -04:00
ben hoffman
e8e72270fb
Remove an unnecessary check from the deletion of subobjects. This check was originally there to confirm that the SCS node being deleted is from the current subobject tree, but is not a valid check anymore when you can call this function from Blueprints as well.
...
#jira UE-117836
#rb trivial
#rnx
[CL 16661733 by ben hoffman in ue5-main branch]
2021-06-14 14:35:04 -04:00
ben hoffman
1dba26f55d
Automatically select a new component for rename upon duplication.
...
#jira UE-117759
#rb phillip.kavan
#rnx
#preflight 60c2bc6c1264df0001bc76ee
[CL 16635347 by ben hoffman in ue5-main branch]
2021-06-10 22:27:25 -04:00
ben hoffman
388f3db4a7
Fix duplication of an inherited blueprint variables in the subobject instance editor by using the correct ComponentInstanceInActor instead of the SCS node
...
#jira UE-117371
#rb marc.audy
#rnx
[CL 16625879 by ben hoffman in ue5-main branch]
2021-06-10 13:52:23 -04:00
ben hoffman
74ba7a83b6
Fix SA warning with NewSCSNode in PasteSubobjects
...
#jira none
#rb trivial
#rnx
[CL 16623623 by ben hoffman in ue5-main branch]
2021-06-10 11:05:53 -04:00
ben hoffman
dbe9a24a9a
Add clearer logging when creating a new BP component
...
#jira UE-117725
#rb trivial
#rnx
#preflight 60c161b8b68c700001b51b83
[CL 16617905 by ben hoffman in ue5-main branch]
2021-06-09 22:01:11 -04:00
ben hoffman
3fb10ffe8f
Fix a crash when deleteing instances of subobjects if the component template is null
...
#jira UE-117672
#rn trivial
#rnx
[CL 16615637 by ben hoffman in ue5-main branch]
2021-06-09 19:25:32 -04:00
