aurel cordonnier
e3f7878676
Merge from Release-Engine-Test @ 17462327 to UE5/Main
...
This represents UE4/Main @17430120 and Dev-PerfTest @17437669
[CL 17463546 by aurel cordonnier in ue5-main branch]
2021-09-08 16:42:26 -04:00
ben hoffman
2fe2bdb404
Set the parent of non-scene components correctly when converting an instance to a blueprint
...
#jira UE-120632
#rb todo
#rnx
#p4v-preflight-copy 17105167
[CL 17107844 by ben hoffman in ue5-main branch]
2021-08-09 17:12:37 -04:00
ben hoffman
9d769cba98
Do not allow copying or duplicating subobjects with the name of "DefaultSceneRoot". This will prevent confusing renaming situations where the DefaultSceneRoot could be deleted, but still be preventing other subobjects from being named that
...
#jira UE-119104
#rb todo
#rnx
#preflight 60ff101a47c93a00010d9d2e
[CL 16961027 by ben hoffman in ue5-main branch]
2021-07-26 16:56:28 -04:00
ben hoffman
cf73c15be0
When pasting a subobject, check to see if the desired parent is a scene component before allowing it to be the target of the paste. This prevents the incorrect parenting to the Actor root in the case of copy/pasting the default scene root.
...
#jira UE-119104
#rb trivial
#rnx
[CL 16960122 by ben hoffman in ue5-main branch]
2021-07-26 15:37:36 -04:00
Jamie Dale
a82da56223
Fixed some more places incorrectly testing against NAME_SIZE (as it includes the null terminator)
...
#rb none
#rnx
[CL 16938866 by Jamie Dale in ue5-main branch]
2021-07-23 13:16:52 -04:00
ben hoffman
6e803aa366
Change the behavior when pasting subobjects to attach to the selected subobject's parent instead of the subobject itself. This makes the pasting behavior between the blueprint and level instance editor the same.
...
#jira UE-118256
#rb trivial
#rnx
[CL 16901336 by ben hoffman in ue5-main branch]
2021-07-20 15:59:06 -04:00
ben hoffman
a034d8253a
Only try to find a scene component target to attach to if the pasted component is a scene component. Non-Scene components can only be attached to the root actor. This solves an issue where a pasted non-scene component could be incorrectly attached to the default scene root.
...
#jira UE-117883
#jira UE-118250
#rb justin.hare
#rnx
[CL 16900194 by ben hoffman in ue5-main branch]
2021-07-20 15:06:37 -04:00
Zousar Shaker
9abf3ef937
Wrapped ObjectPtr upgrade refresh for Engine + ShooterGame
...
#rb none
#preflight 60f6411c35476b00018dd12c
[CL 16892864 by Zousar Shaker in ue5-main branch]
2021-07-20 00:21:34 -04:00
ben hoffman
8db01bec86
Add a fallback method of determining the instanced component to use as an asset override in the event that a subobjec thas been added but is not a part of the generated class yet. Do this by checking if the archetype of the GEN_VARIABLE subobject and one on the instance are the same.
...
#jira UE-119138
#rb trivial
#rnx
#preflight 60f0b58a57b3020001337e09
[CL 16869367 by ben hoffman in ue5-main branch]
2021-07-15 19:42:26 -04:00
ben hoffman
03ec155896
Check not only the SimpleConstructionScript's DefaultSceneRootNode, but also the SceneRootComponentTemplate when determining if a subobject is the default scene root. This handles cases where the DefaultSceneRoot node has been updated (like when you drag/drop a new scene component onto it in the Subobject Editor)
...
#jira UE-117876
#rb marc.audy
#rnx
[CL 16854920 by ben hoffman in ue5-main branch]
2021-07-14 16:37:36 -04:00
ben hoffman
1dbcb0df0c
Check if the old scene root was the default scene root that is generated by every BP to determine if it should be deleted or not. This makes the behavior consistent with the old SCS Editor
...
#jira UE-117876
#rb trivial
#rnx
[CL 16854709 by ben hoffman in ue5-main branch]
2021-07-14 16:24:16 -04:00
ben hoffman
5bd5f2561c
CIS fix. Remove ParentObjData from an if statement because there is already a "check" on the variable above. Having it in the if statement was causing other uses of it to flag PVS
...
#jira none
#rb trivial
#rnx
[CL 16854427 by ben hoffman in ue5-main branch]
2021-07-14 16:06:13 -04:00
ben hoffman
51603fdd01
Add an additional check when determining the default scene root to see if a native subobject is the root of it's owning actor.
...
#jira UE-117126
#rb trivial
#rnx
#preflight 60ee0c9119a00600011f491a
[CL 16844692 by ben hoffman in ue5-main branch]
2021-07-13 19:29:01 -04:00
ben hoffman
a38ca94c2d
Add a flag to force deletion on subobjects so that when making a new scene root the CanDelete check will be bypassed.
...
This is needed because when the user drags a new scene component over the existing one, the old one should be deleted but is still marked as the SceneRoot (and cannot be deleted because we have to update the instances of the archetypes)
#jira UE-119151
#rb trivial
#rnx
#preflight 60edf5d0ef22fa000176acdf
[CL 16843507 by ben hoffman in ue5-main branch]
2021-07-13 17:56:24 -04:00
ben hoffman
e467c4e6f6
Fix some spelling mistakes in comments
...
#rb trivial
#rnx
#jira none
[CL 16840894 by ben hoffman in ue5-main branch]
2021-07-13 15:03:42 -04:00
ben hoffman
60c7ca432f
Replace an incorrect check for a child actor with a check for a child actor subtree object.
...
#jira none
#rb trivial
#rnx
[CL 16840124 by ben hoffman in ue5-main branch]
2021-07-13 14:22:17 -04:00
ben hoffman
188d3e325d
If the attachment point is a BP inherited subobject then find the correct archetype attachment point when adding subobjects to an instance
...
#rb marc.audy
#jira UE-117457
#jira UE-119112
#rnx
#preflight 60ec6955ef22fa000150f693
[CL 16837795 by ben hoffman in ue5-main branch]
2021-07-13 11:21:36 -04:00
ben hoffman
a7da155db0
Correctly check if a component is inherited before allowing it to be reparented
...
#jira UE-118270
#rb trivial
#rnx
[CL 16837483 by ben hoffman in ue5-main branch]
2021-07-13 10:53:46 -04:00
ben hoffman
2d93fed50e
Instead of checking if something is a child actor component when attempting to maniuplate it, check if its owner is a CAC instead. If it's owner is a CAC, then it cannot be removed because it is determined by the owning CAC. Before, the code was incorrectly checking if something was just a plain old child actor component, resulting in being unable to delete, reparent, or attach to a child actor component.
...
#jira UE-117132
#jira UE-117332
#jira UE-117327
#jira UE-117329
#rb marc.audy
#rnx
#preflight 60d48296925f1400010bb909
[CL 16773601 by ben hoffman in ue5-main branch]
2021-06-24 10:55:53 -04:00
ben hoffman
ff3b233df8
Use CopyPropertiesForUnrelatedObjects instead of a basic ObjectWriter/Reader combo when duplicating components to properly handle subobjects.
...
#jira UE-68780
#rb marc.audy
#rnx
[CL 16751102 by ben hoffman in ue5-main branch]
2021-06-22 19:04:02 -04:00
ben hoffman
435dcc7d82
Correctly set the module path when creating a C++ class from the subobject data subsystem. This will correctly set the module path so that the error messages are correct from GameProjectUtils::AddCodeToProject. This will make the module selection the same as how the SNewClassDialog handles it for a more consistent and correct experience.
...
#jira UE-116994
#rnx
#rb phillip.kavan
[CL 16748591 by ben hoffman in ue5-main branch]
2021-06-22 16:23:15 -04:00
Jamie Dale
ac95fa3168
Fixed subobject editor not honoring the requested post-delete selection
...
#rb Ben.Hoffman
[CL 16747272 by Jamie Dale in ue5-main branch]
2021-06-22 15:19:31 -04:00
ben hoffman
fb9dde0359
Notify the level editor that a subobject has been changed when adding or deleting a subobject. This ensures that if there is a selected actor instance in the level that it will have it's subobjects properly updated
...
#jira UE-116645
#rb justin.hare
#rnx
#preflight 60cba56378c3b0000138e856
[CL 16711849 by ben hoffman in ue5-main branch]
2021-06-17 17:11:39 -04:00
ben hoffman
b6365aba67
Attach a dupliucated component to the source's parent instead of the source directly
...
#jira UE-118043
#rb trivial
#rnx
[CL 16709163 by ben hoffman in ue5-main branch]
2021-06-17 15:06:40 -04:00
ben hoffman
43f96dd3a6
Fix typo in comment
...
#jira none
#rb trivial
#rnx
[CL 16679627 by ben hoffman in ue5-main branch]
2021-06-15 17:11:10 -04:00
