Commit Graph

251 Commits

Author SHA1 Message Date
Yoan StAmant
166f970337 [DebugDrawDelegate]
Update registration flow since CreateRenderState_Concurrent can't be used to register our delegate since it needs to be initialized first (CreateSceneProxy) and in some code paths for loaded actors the call order might be different since primitive registration gets deferred (i.e. FRegisterComponentContext != nullptr).
In that case initialization won't called and an ensure will fire in UnregisterDebugDrawDelegate since registration failed (was not initialized).
Case 1: FRegisterComponentContext == nullptr  ==> Super::CreateRenderState_Concurrent + sync CreateSceneProxy (init) + RegisterDebugDrawDelegate ==> works fine
Case 2: FRegisterComponentContext != nullptr  ==> Super::CreateRenderState_Concurrent + deferred CreateSceneProxy + RegisterDebugDrawDelegate (skipped since not init) + CreateSceneProxy ==> ensures in UnregisterDebugDrawDelegate

Bonus:
- some code analysis fixes
- removed some 'CoreMinimal.h' includes
- exported log category 'LogVisual'
- fixed some uninitialized properties (FNavTestDebugDrawDelegateHelper, UNavMeshRenderingComponent, FNavMeshSceneProxyData)
- fixed some methods hiding non-virtual from base class (GetAllocatedSize)
- fixed FGameplayDebuggerCompositeSceneProxy::GetMemoryFootprint that was not considering base class allocations

#rnx
#jira UE-125097
#preflight 614362684778fa00016a8cad
#rb mieszko.zielinski

[CL 17544171 by Yoan StAmant in ue5-main branch]
2021-09-16 16:47:25 -04:00
Yoan StAmant
9fa9fd9f92 [AI] Merging 17468937: GameplayDebugger: Support separate alpha on text
#preflight 6140d2073c7c670001621c73

[CL 17508455 by Yoan StAmant in ue5-main branch]
2021-09-14 15:19:36 -04:00
mikko mononen
d8e21c151a GameplayDebugger: Fixed color on circle shape
#preflight 612497e98ff5540001386ff5


#ROBOMERGE-SOURCE: CL 17282179
#ROBOMERGE-BOT: (v858-17259218)

[CL 17282211 by mikko mononen in ue5-main branch]
2021-08-24 03:47:40 -04:00
mikko mononen
83b143641d GameplayDebugger: Added arrow and circle shape.
#preflight 611cdca25e73720001cc817b


#ROBOMERGE-SOURCE: CL 17212936
#ROBOMERGE-BOT: (v855-17104924)

[CL 17212982 by mikko mononen in ue5-main branch]
2021-08-18 06:36:50 -04:00
yoan stamant
af88a23dcd [FDebugDrawDelegateHelper] Allow calls to method InitDelegateHelper from Parallel For called from game thread (i.e. IsInParallelGameThread() || IsInGameThread() )
Removed previous hack added in UEQSRenderingComponent  and fixed some typos in method names.
#rb mikko.mononen mieszko.zielinski
#preflight 60c887272da7840001313475


#ROBOMERGE-SOURCE: CL 16672461
#ROBOMERGE-BOT: (v834-16658389)

[CL 16672469 by yoan stamant in ue5-main branch]
2021-06-15 08:21:00 -04:00
Steve Robb
bfddf3e267 TMethodPtr<U, ...> and TConstMethodPtr<U, ...> template aliases added to delegates to replace the T*Delegate_Const<U, ...>::FMethodPtr types.
#rb robert.manuszewski
#jira none

[CL 16092754 by Steve Robb in ue5-main branch]
2021-04-22 09:49:28 -04:00
Max Chen
9b73c0f152 Editor: Change to SLevelViewport
#jira UE-108941
#rb brooke.hubert

[CL 15520489 by Max Chen in ue5-main branch]
2021-02-24 16:03:09 -04:00
Yoan StAmant
ec8b03491b [GameplayDebugger] Extracted picking view point calculation to GetViewPoint exposed through GameplayDebuggerPlayerManager
#jira UE-105121
#review-15321294 @maxime.mercier
#rb maxime.mercier

[CL 15355736 by Yoan StAmant in ue5-main branch]
2021-02-08 07:46:38 -04:00
Zousar Shaker
3b4c8fc1c5 Automated wrapped object pointer upgrade for Engine + ShooterGame + ShooterGame referenced plugins
#rb none

[CL 15224650 by Zousar Shaker in ue5-main branch]
2021-01-27 17:40:25 -04:00
Marc Audy
bc88b73a29 Merge Release-Engine-Staging to Main @ CL# 15151250
Represents UE4/Main @ 15133763

[CL 15158774 by Marc Audy in ue5-main branch]
2021-01-21 16:22:06 -04:00
Marc Audy
bf80889353 UE5/Release-Engine-Staging to UE5/Main
This represents UE4/Main up to CL# 14958402

[CL 15028197 by Marc Audy in ue5-main branch]
2021-01-08 19:56:07 -04:00
Zousar Shaker
fc2ad21a5e Prototype Wrapped Object Pointers (ObjectHandle/ObjectPtr)
Call-site changes for non-scalar wrapped object pointer upgrades in Engine + Shootergame

#rb devin.doucette

[CL 14996467 by Zousar Shaker in ue5-main branch]
2021-01-05 19:16:25 -04:00
Marc Audy
ada7c144fa Merge //UE5/Release-Engine-Staging @14903491 to //UE5/Main
[CL 14906022 by Marc Audy in ue5-main branch]
2020-12-11 14:21:20 -04:00
Mieszko Zielinski
f99357086e A file missing from CL#14810194
#rb trivial

[CL 14812503 by Mieszko Zielinski in ue5-main branch]
2020-11-25 06:43:07 -04:00
Mieszko Zielinski
963c7e097e Made GameplayDebugger's availability in editor mode optional and cconfigured by per-user settings
I've also tabbified *.build.cs since I was modifying it anyway.

#review-14812433 @Mikko.Mononen, @Stephen.Holmes
#rb swarm
#rnx

[CL 14812500 by Mieszko Zielinski in ue5-main branch]
2020-11-25 06:42:17 -04:00
Mieszko Zielinski
0f0297d8db Fixed GameplayDebuggerCategoryReplicator unintentionally holding a reference to AActor being debugged which resulted in all sorts of undesired behaviors in editor mode (including fatal-level logs)..
#jira UE-103657
#review-14812437 @Mikko.Mononen, @Stephen.Holmes
#rb swarm
#rnx

[CL 14812499 by Mieszko Zielinski in ue5-main branch]
2020-11-25 06:42:02 -04:00
Mieszko Zielinski
a2abb8d078 Updated Fortnite's GameplayDebugger categories to not crash in pure-editor mode.
#review-14809849 @Maxime.Mercier, @Yoan.StAmant, @Guillaume.Guay
#rnx
#rb swarm

[CL 14810194 by Mieszko Zielinski in ue5-main branch]
2020-11-24 13:35:55 -04:00
Mieszko Zielinski
06d7f5395b Fixed a gameplay debugger tool crash on editor exit
#review-14809130 @Mikko.Mononen, @Stephen.Holmes
#rb swarm
#rnx

[CL 14809165 by Mieszko Zielinski in ue5-main branch]
2020-11-24 06:26:29 -04:00
Mieszko Zielinski
1fe6d03b53 GameplayDebugger CIS fixes
#rb trivial

[CL 14807508 by Mieszko Zielinski in ue5-main branch]
2020-11-23 15:48:43 -04:00
Mieszko Zielinski
f3635c4ead Made displaying GameplayDebugger's UI possible in pure editor-mode
#review-14806333 @Stephen.Holmes, @Aris.Theophanidis, @Maxime.Mercier, @Yoan.StAmant, @Mikko.Mononen
#rb swarm

[CL 14807157 by Mieszko Zielinski in ue5-main branch]
2020-11-23 14:16:46 -04:00
Marcus Wassmer
3b81cf8201 Merging using //UE5/Main_to_//UE5/Release-Engine-Staging @14384769
autoresolved files
#rb none

[CL 14384911 by Marcus Wassmer in ue5-main branch]
2020-09-24 00:43:27 -04:00
Marc Audy
7379fa99c5 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14229157
[CL 14233282 by Marc Audy in ue5-main branch]
2020-09-01 14:07:48 -04:00
brooke hubert
9fa4bf0f27 Move FEditorModeInfo and shared mode defines to EditorFramework module.
#rnx
#Jira UE-96448
#review-14071452
#rb jamie.dale lauren.barnes

[CL 14084099 by brooke hubert in ue5-main branch]
2020-08-11 16:46:17 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
Jamie Dale
70a54d23ca Moved USelection to UnrealEd
#rb Chris.Gagnon
#rnx

[CL 14037101 by Jamie Dale in ue5-main branch]
2020-08-05 10:28:16 -04:00