Commit Graph

5 Commits

Author SHA1 Message Date
Francis Hurteau
79415aabf8 Refix crash in http request batch when the batch contains both a head and get request for the same cache keys
Added a test that could reliably reproduce the problem to validate it is properly fixed

#rb Danny.Couture, Zousar.Shaker
#preflight 610010b247c93a0001335319


#ROBOMERGE-OWNER: Francis.Hurteau
#ROBOMERGE-AUTHOR: francis.hurteau
#ROBOMERGE-SOURCE: CL 16968978
#ROBOMERGE-BOT: (v838-16927207)
#ROBOMERGE-CONFLICT from-shelf

[CL 16972104 by Francis Hurteau in ue5-main branch]
2021-07-27 15:24:32 -04:00
danny couture
f283881ae0 Fix thread starvation for request in http backend by using a FIFO for thread waiting for a connection to be freed
Replace the sleep by a wait on an event triggered by the thread freeing the connection
Improve the test to output stats seen below and use the proper amount of threads on low core systems

Automation RunTests System.DerivedDataCache.HttpDerivedDataBackend.ConcurrentCachedDataProbablyExistsBatch

Before
   RPS: 238, AvgLatency: 90.09 ms, MaxLatency: 7.77 s
   RPS: 231, AvgLatency: 87.66 ms, MaxLatency: 7.77 s
   RPS: 245, AvgLatency: 139.07 ms, MaxLatency: 10.08 s

After
   RPS: 634, AvgLatency: 102.97 ms, MaxLatency: 0.26 s
   RPS: 653, AvgLatency: 102.51 ms, MaxLatency: 0.26 s
   RPS: 630, AvgLatency: 102.29 ms, MaxLatency: 0.26 s

#rnx
#rb Zousar.Shaker, Francis.Hurteau
#preflight 60ffe8317f21c90001f6116a

[CL 16968010 by danny couture in ue5-main branch]
2021-07-27 09:25:29 -04:00
francis hurteau
ed059fdb34 Undo changelist 16938823 until investigation of cook failures are done
[FYI] Zousar.Shaker
#rb trivial
#preflight skip
discussed with Zoursar.Shaker, undo to fix cook failure


#ROBOMERGE-SOURCE: CL 16941401
#ROBOMERGE-BOT: (v838-16927207)

[CL 16941404 by francis hurteau in ue5-main branch]
2021-07-23 16:16:08 -04:00
francis hurteau
c7436d7678 Fix crash in http request batch when the batch contains both a head and get request for the same cache keys
Added a test that could reliably reproduce the problem to validate it is properly fixed
#preflight 60faeafc1f926d000113425b


#ROBOMERGE-SOURCE: CL 16938823
#ROBOMERGE-BOT: (v838-16927207)

[CL 16938832 by francis hurteau in ue5-main branch]
2021-07-23 13:14:33 -04:00
Zousar Shaker
bd3886b31f Fix bug where queued batch request failure in HttpDerivedDataBackend would cause incorrect DDC output (erroneous cache misses).
Adding basic unit test for HttpDerivedDataBackend.

#rb devin.doucette

[CL 16885295 by Zousar Shaker in ue5-main branch]
2021-07-19 13:09:40 -04:00