Commit Graph

49 Commits

Author SHA1 Message Date
Rob Gay
6d8ed49d54 Renaming a MetaSound patch results in duplicates/crashes if MetaSound Editor is Open
#jira UE-225326, UE-225441
#rnx
#rb helen.yang
#fyi sondra.moyls, jon.huller, julien.marchand
#p4v-cherrypick 36654551

[CL 36655590 by Rob Gay in 5.5 branch]
2024-09-26 19:52:04 -04:00
helen yang
4f2194b04b Reenable MetaSound asset validation
#jira UE-216872
#rb helen.yang
#rnx

[CL 34622124 by helen yang in ue5-main branch]
2024-06-24 17:32:05 -04:00
helen yang
60fc7c9ce1 Temporarily disable MetaSound class name asset validation, add cvar
#rb rob.gay
#rnx

[CL 34580515 by helen yang in ue5-main branch]
2024-06-21 19:33:41 -04:00
helen yang
3303428716 Add MetaSound asset validation for assets with duplicate class names
- Move asset registration to engine module from editor
- Separate call for MetaSound asset manager prime and node class registry prime
- Fix bug causing MetaSound asset editor registration notification to close early
- Make editor asset registration async by default (remove au.MetaSound.Editor.AsyncRegistrationEnabled cvar)

#jira UE-216872
#rb rob.gay

[CL 34544373 by helen yang in ue5-main branch]
2024-06-20 16:42:12 -04:00
martin sevigny
15afa78dab Add test to make sure the module name in the IMPLEMENT_MODULE macros matches the name declared in the uproject, uplugin or the name of the folder for engine modules.
A mismatch for Runtime module results in a error in FModuleManager::LoadModuleWithFailureReason because it can't find the ModuleInitializerPtr

See ModuleManager.h for the actual change. The rest are fixes of wrong names.
#rb Steve.Robb
#jira UE-215245

[CL 33938229 by martin sevigny in ue5-main branch]
2024-05-28 08:46:41 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
rob gay
39d0de55b1 Fix for AudioUnitTest build break caused by added Engine & AudioMixer dependencies in MetaSound Frontend
#rb rob.gay
#rnx
[FYI] pete.bliss, phil.popp
#jira UE-213147

[CL 33282525 by rob gay in ue5-main branch]
2024-04-26 18:28:12 -04:00
pete bliss
bc4a3bdfc5 Fix for pin audio inspector oscilloscope data dropouts.
#jira UE-196333
#rb Rob.Gay

[CL 33136245 by pete bliss in ue5-main branch]
2024-04-22 08:43:37 -04:00
ericdrobinson
cb02c831f5 Update MetaSound FTime accessiblity from MetaSound outputs.
#10697
#10663
#jira UE-190586, UE-190587
#rb charlie.huguenard

[CL 31388305 by ericdrobinson in ue5-main branch]
2024-02-12 12:36:57 -05:00
phil popp
5e47ca80e9 Avoid registering unused send/receive nodes
#jira UE-204391, UE-204393, UE-190886
#rb Rob.Gay

[CL 30889682 by phil popp in ue5-main branch]
2024-01-25 11:51:49 -05:00
jake burga
9ece99f921 Delete AudioCodecEngineModule
[REVIEW] [at]jimmy.smith
#rb jimmy.smith
#tests PIE

[CL 30194479 by jake burga in ue5-main branch]
2023-12-07 17:48:14 -05:00
phil popp
e631780063 Register metasound graphs asynchronously
#jira UE-185834, FORT-658630
#rb Rob.Gay, Helen.Yang

[CL 28149471 by phil popp in ue5-main branch]
2023-09-22 15:01:07 -04:00
alex perez
edd108109f [MetasoundEditor] (Experimental code!) Show oscilloscope when doing mouse over in audio connections
#jira none
#rb none
#fyi aaron.mcleran
#rnx

[CL 27642622 by alex perez in ue5-main branch]
2023-09-06 13:34:36 -04:00
charlie huguenard
7b12ccaeae [Metasound] Get history of output changes instead of last value
#preflight 64513fbb4d593c0b42b03cc8
#rb phil.popp

[CL 25320519 by charlie huguenard in ue5-main branch]
2023-05-03 13:43:51 -04:00
charlie huguenard
fb1959d641 [Metasound] Fix races in UMetasoundOutputSubsystem
The generator created/destroyed events get called on the audio thread, so avoid manipulating containers used on the game thread in the event.

#rnx
#rb phil.popp, aaron.mcleran
#preflight 642db4d71d19c0312a39ab12

[CL 24937556 by charlie huguenard in ue5-main branch]
2023-04-05 17:42:36 -04:00
rob gay
1de499ef8e More MetaSound Interface registry clean-up
- Move bIsDefault/bCanEdit(renamed bIsModifiable) from InterfaceRegistryEntry to Interface data definition
- Add checks in builder to disallow mutation of interfaces that shouldn't be via editor or document builder (ex. SourceInterface which is default and then never changed)
- Optimize SearchEngine query for finding default interfaces
- Tweak MetaSoundUObjectRegistry to support non MetasoundAssetBase classes and add UMetaSoundBuilderDocument. Update iterator w/optional param to only return asset types (true by default for back compat)
- Move FName class name comparitors to use new TopLevelAssetPath
#rb phil.popp
#jira UE-181360
#rnx
#p4v-preflight-copy 24658328
#preflight 642b10834d26bcd1eb0e566c

[CL 24920763 by rob gay in ue5-main branch]
2023-04-04 19:14:26 -04:00
charlie huguenard
3c8efcca93 [Metasound] Blueprint access to watch outputs on a playing Metasound source
#rb ryan.mangin, rob.gay, phil.popp
#preflight 6418bfb2691c5ebc15931d3e

[CL 24731517 by charlie huguenard in ue5-main branch]
2023-03-21 10:01:25 -04:00
charlie huguenard
4fdfbdf806 [Metasound] Watch outputs on a FMetasoundGenerator
#rb rob.gay, phil.popp
#preflight 6414cabd345ab08524fc9542

[CL 24723801 by charlie huguenard in ue5-main branch]
2023-03-20 17:13:25 -04:00
rob gay
cff304e9da Interface Registry Tidying
1.) Move Bindings to own registry
2.) Nuke source files & left over cruft relating to archetypes
3.) Move deprecated interface registration next to respective interfaces for clarity
4.) Rename "FMetasoundFrontendInterfaceBindingConnections" to "FMetasoundFrontendInterfaceVertexBindings"
#rb phil.popp
#preflight 640f6852d778f889752a5bd1

[CL 24622079 by rob gay in ue5-main branch]
2023-03-13 17:23:05 -04:00
rob gay
aeb25bb49d - Add Runtime MetaSound Builder support
- Add MetaSound Patch Interface support
- Add MetaSound Interface Bindings
#rb phil.popp
#preflight 640783bd5515f4f57b4b1268
[FYI] Sondra.Moyls
[FYI] Dan.Reynolds

[CL 24548617 by rob gay in ue5-main branch]
2023-03-07 17:01:52 -05:00
Rob Gay
d5645c2286 Split MetaSound DataType "IsArrayType()" function into bIsArrayParseable & bIsArrayType members, deprecating function in favor of caching booleans on DataType registration
Enforce single UObject class --> MetaSound Frontend class & fix-up callsites relying on ArrayObject type/literals using cached proxy type. This lead to confusion WRT what registered type is directly associated with a given UObject & possible bugs therein.
#rb phil.popp
#rnx
#jira none
#preflight 62c890fb2823f28cf281a8f1

[CL 21100292 by Rob Gay in ue5-main branch]
2022-07-14 17:51:07 -04:00
phil popp
2f19544e46 Increased audio LLM tag coverage
#jira UE-148592
#rb  Helen.Yang
#preflight 62cc51f31961b487b39e9478

[CL 21042573 by phil popp in ue5-main branch]
2022-07-11 12:49:10 -04:00
Aaron McLeran
e8e0cb865a Adding MetaSound bus type to metasounds
#rb Rob.Gay
#jira 20811065
#preflight 62b5fb0b3646551b113a0065

[CL 20879926 by Aaron McLeran in ue5-main branch]
2022-06-29 15:01:54 -04:00
Rob Gay
e894af4d0c Checkpoint - WaveTable Integration w/Modulation & MetaSounds
- Removed duplicate implementation of ModPatch editor stuff now that WT Plugin covers it
- Add UWaveTableBank asset & WaveTable MetaSound DataType
- Add Full Sin as curve type
- Fix-up ability to make WaveTable assets bipolar but leave Modulation Patches unipolar
- Inherit ModulationTransform from new WaveTableTransform for extensibility to WT implementation
- Move ModulationCurve --> WaveTableCurve
- FastSin to Sin implementation in now WaveTableCurve (no reason to use fast implementation when using WT or interpolating curve key implementation at block rate)
#rb helen.yang
#jira UE-156634
#jira UE-156635
#jira UE-156874
#preflight 62b9cf61de2c0f4cf8774a9a

[CL 20832273 by Rob Gay in ue5-main branch]
2022-06-27 12:00:38 -04:00
Rob Gay
f2f944d64f MetaSound Analyzer Frontend/Graph Core Checkpoint
- Add ability to track all internal data references to a core graph
- Add AnalyzerRegistry & first pass at value/envelope analyzers
- Add support for enabling analyzing from MetaSound Generator
- Add ability for tracking colorized bounds for edges as literal-color array
#rb phil.popp
#jira UE-147027
#jira UE-147028
#jira UE-147026
#preflight 627acbae10766ef8c112264c

[CL 20129340 by Rob Gay in ue5-main branch]
2022-05-10 16:51:39 -04:00