Commit Graph

8809 Commits

Author SHA1 Message Date
aditya ravichandran
fad168c6e5 Updated Message Log to the new style guidelines and added a console command for testing Message Log
#okfforgithub public

#jira UETOOL-2468

#rb lauren.barnes

#preflight 60f9b6d3d3905c0001c644ff

[CL 16930439 by aditya ravichandran in ue5-main branch]
2021-07-22 16:16:57 -04:00
mark lintott
d790fa8c84 Updated DDC Widget
Added detailed resource and cache backend information.
Added new indicators for Busy, Upload, Download, LocalCache and RemoteCache
Minor modifications to StudioAnalytics to re-use the stats gathering code
#rb francis.hurteau
[FYI] jeff.farris


#ROBOMERGE-SOURCE: CL 16929122
#ROBOMERGE-BOT: (v838-16927207)

[CL 16929180 by mark lintott in ue5-main branch]
2021-07-22 15:09:44 -04:00
Zousar Shaker
f37090919d Undo CL16853912 now that CL16922241 fixes the deadlock properly.
#rb none

[CL 16926361 by Zousar Shaker in ue5-main branch]
2021-07-22 13:00:15 -04:00
ionut matasaru
1f5aa9a837 [TraceServices]
- Added virtual destructor to all Provider classes.
  - Added "explicit" to several constructors of Provider classes.

#rb Catalin.Dragoiu

[CL 16924223 by ionut matasaru in ue5-main branch]
2021-07-22 11:24:09 -04:00
Chris Varnsverry
e4b43d1efd - Fix some unnecessary string copies when calling FPaths::FileExists
#jira FORT-392314
#review-16922341 @Michael.Kirzinger @Marc.Audy @Rob.Cannaday @Sam.Zamani

[CL 16923987 by Chris Varnsverry in ue5-main branch]
2021-07-22 11:10:51 -04:00
Helge Mathee
b8bf981376 Control Rig: Guard against nullptr crash when reading orphan pins
#rb trivial
#jira UE-119884

[CL 16921857 by Helge Mathee in ue5-main branch]
2021-07-22 05:56:57 -04:00
paul chipchase
16af40bc9f Improve error handling and logging in the file and jupiter Mirage backends.
#rb Per.Larsson
#rnx
#preflight 60f9212d1f926d0001d41223

* VirtualizationJupiterBackend
- When pulling a payload we should assume that a 400 error response when trying to GET the payload header means that the payload is not in Jupiter.
-- Not being able to find the payload should not log an error, instead we can make a note of it in the verbose log (similar to the file system backend)

* VirtualizationFileBackend
- Moved the formatting of system errors to it's own function.
- Log the system error when failing to write a payload during a push as well as a pull.
- We now check that the FileArchive wrote correctly to disk and delete the output file and fail the push if it did not.
-- A future piece of work will change the logic to write to a tmp file at the root of the file store and them move the file to the final location to cut down on the potential of leaving corrupted files around (similar to the process when we save packages)

* Perforce
- The FDownloadFile command now takes an optional parameter EVerbosity that can allow the caller to choose the level of logging output that the command will generate.
- The source control backend for Mirage now opts to supress the logging of the full perforce command when we are pulling payloads as we can generate many hundreds or thousands of requests and the info is not useful to users.
-- We continue to log the command when validating the depot as this is the most likely command to fail so having the info in the log may prove useful.

[CL 16921815 by paul chipchase in ue5-main branch]
2021-07-22 05:43:20 -04:00
sara schvartzman
bb53a05fb4 Control Rig: Print python commands when removing and renaming functions
#jira UE-119790
#rb helge.mathee

[CL 16921734 by sara schvartzman in ue5-main branch]
2021-07-22 05:00:08 -04:00
sara schvartzman
43e3159d39 Control Rig: Print python commands when variables are added/renamed/retyped/deleted
#jira UE-119789
#rb helge.mathee

[CL 16921634 by sara schvartzman in ue5-main branch]
2021-07-22 04:19:14 -04:00
sebastien lussier
e16a51bf54 DDC backends - removed speed class tests in implementations of TryToPrefetch()
#rb danny.couture, devin.doucette


#ROBOMERGE-SOURCE: CL 16900182
#ROBOMERGE-BOT: (v836-16769935)

[CL 16917763 by sebastien lussier in ue5-main branch]
2021-07-21 19:08:29 -04:00
krzysztof narkowicz
a97e163405 Lumen - fixed a bug, where incorrect card direction could be serialized causing an assert to fire at rumtime
#ROBOMERGE-SOURCE: CL 16900162
#ROBOMERGE-BOT: (v836-16769935)

[CL 16917756 by krzysztof narkowicz in ue5-main branch]
2021-07-21 19:08:22 -04:00
Zousar Shaker
5f008b55ed Add build worker discovery mechanism using target receipt files.
#rb matt.peters

[CL 16917716 by Zousar Shaker in ue5-main branch]
2021-07-21 19:06:57 -04:00
krzysztof narkowicz
eed0fc3bed New Lumen surface cache card generation:
* Generate surfels directly from the triangles instead of relying on ray tracing, to fix coverage issues on some meshes
* Surfels which are inside meshes (surrounded by back faces) or are too close to geometry are discarded
* New surfel clustering algorithm, which inserts one seed after another and tries to iteratively grow clusters in order to find the best set of seeds. Final step is to reset all clusters and grow all simultaneously from previously selected seeds.
* Cluster growing is based on normal, distance and surfel visibility (don�t cluster surfels near geometry first, as it can cause algorithm to be stuck in a local minimum)
* Runtime sampling has strict culling based on the angle and card AABB. Additionally, the tri-planar blending zone was tightened. This improves performance. 0.62-0.5 ms.
* Added various visualizations and CVars for card generation debugging
* Fixed card visibility bug, where card could influence outside of it�s range due to negative shadow map visibility

[FYI] Daniel.Wright, Patrick.Kelly


#ROBOMERGE-SOURCE: CL 16897632
#ROBOMERGE-BOT: (v836-16769935)

[CL 16916104 by krzysztof narkowicz in ue5-main branch]
2021-07-21 17:57:42 -04:00
Lukas Hermanns
0f58a3008d Added 'precise' qualifier to fix Z-fighting with World Position Offset (WPO) in MaterialTemplate.ush. Only affects D3D11/DXBC shaders on Windows.
#rb Kevin.Ortegren
#fyi Mihnea.Balta
#jira UE-102725
#rnx

[CL 16911422 by Lukas Hermanns in ue5-main branch]
2021-07-21 13:01:39 -04:00
Devin Doucette
bea14d56ce DDC: Changed TRequest to cast to IRequest before invoking its functions
This allows the request type to make its functions on IRequest protected or private, or allows use with a request type that hides its IRequest behind an implicit conversion.

Also disabled operator-> and operator* for the base IRequest because it is preferred to use the functions on TRequest to the IRequest interface.

#rb Matt.Peters
#rnx

[CL 16911217 by Devin Doucette in ue5-main branch]
2021-07-21 12:42:51 -04:00
ionut matasaru
f4f2913a3a [Insights]
- Timing Insights: Added more switches related to context switches:
      * Overlays - Extend the visualisation of context switches over the cpu timing tracks. (Shift+O)
      * Extended Lines - Show/hide the extended vertical lines at edges of each context switch event. (Shift+L)
  - Moved all options into a "Context Switches" sub-menu in the Tracks menu.
  - Added placeholder code for the Cpu Core tracks.

#rb Catalin.Dragoiu

[CL 16910128 by ionut matasaru in ue5-main branch]
2021-07-21 11:28:03 -04:00
charles bloom
eb51becbdb Compression Flags add ForPackaging to differentiate packaging compression usage
add OodleDataCompression CommonUsage to translate Flags

#rb dan.thompson

[CL 16908872 by charles bloom in ue5-main branch]
2021-07-21 09:52:19 -04:00
ionut matasaru
3a12a16172 [Insights] Removed unused IdleAreaBrush member and the DashedBrush style.
#rb none

[CL 16908337 by ionut matasaru in ue5-main branch]
2021-07-21 08:32:41 -04:00
ionut matasaru
6f56d6b461 [Insights] Disabled striped brush for context switches.
#rb none

[CL 16908315 by ionut matasaru in ue5-main branch]
2021-07-21 08:26:39 -04:00
ionut matasaru
33d5d7a348 [Insights]
- Improved struct packing for FTraceViewModel, FStoreBrowserTraceInfo and FLogMessageRecord.
  - Log View: Limited the height of "Category Filter" menu to height of the Log View panel.

#rb Catalin.Dragoiu

[CL 16906839 by ionut matasaru in ue5-main branch]
2021-07-21 05:10:35 -04:00
sara schvartzman
d52e900d02 Control Rig: Fix Fornite compilation errors
#rb na

[CL 16906554 by sara schvartzman in ue5-main branch]
2021-07-21 03:35:10 -04:00
paul chipchase
dffdc8a417 Add a cpu trace when pulling payloads for the source control backend.
#rb trivial
#rnx
#preflight 60f6ceaa8da1560001eed8d4

[CL 16896436 by paul chipchase in ue5-main branch]
2021-07-20 10:18:27 -04:00
danny couture
989c3cb117 Fix behavior of CachedDataProbablyExists so it can reach the slow cache to avoid always recompiling stuff that exists in Jupiter but not locally
#rnx
#rb Devin.Doucette, Sebastien.Lussier

[CL 16893978 by danny couture in ue5-main branch]
2021-07-20 05:56:37 -04:00
Zousar Shaker
9abf3ef937 Wrapped ObjectPtr upgrade refresh for Engine + ShooterGame
#rb none
#preflight 60f6411c35476b00018dd12c

[CL 16892864 by Zousar Shaker in ue5-main branch]
2021-07-20 00:21:34 -04:00
Zousar Shaker
1571c9f36e Fix linux compile error and bug with my last submits related to function version iteration for build functions.
#rb none

[CL 16889472 by Zousar Shaker in ue5-main branch]
2021-07-19 17:40:45 -04:00