Commit Graph

154 Commits

Author SHA1 Message Date
gerard martin
33756018dd [Mutable] Removed invalid TODOs.
#rnx

[CL 30040188 by gerard martin in ue5-main branch]
2023-12-01 10:03:28 -05:00
max garcia
db0a3bdd25 [mutable] Fixed mesh update not calling callbacks when changing graphic settings.
#rb gerard.martin
#rnx

[CL 30014839 by max garcia in ue5-main branch]
2023-11-30 10:15:51 -05:00
gerard martin
e2bb595be5 [Mutable] Remove COE private dependencies 2/3.
- Moved required files to the Internal directory.
- Moved private structs to UCustomizableObjectSystemPrivate or its own source files.
- Moved public static functions outside of the private.

#jira UE-193739
[REVIEW] [at]alexei.lebedev
#rnx
#rb alexei.lebedev

[CL 30013823 by gerard martin in ue5-main branch]
2023-11-30 09:17:22 -05:00
jordi rovira
0020d752b2 [mutable] Improved documentation of blueprint-exposed functions.
Cleanup old projection mask and coverage query code.
[REVIEW] [at]alexei.lebedev
#rb alexei.lebedev
#rnx

[CL 29885051 by jordi rovira in ue5-main branch]
2023-11-22 05:11:56 -05:00
gerard martin
7bfa46d186 [Mutable] Mutable Benchmark improvements.
- Fixed Task_Game_Callbacks timer scope not reporting correctly.
- Added Queue time.
- Added Task_Mutable_UpdateImage time.
- Added Update result.
- Removed unused CVarBenchmarkFilePath.
- Moved incorrect Enqueued UpdateSkeletalMesh Async log.

[REVIEW] [at]alexei.lebedev, [at]daniel.moreno
#rnx
#rb alexei.lebedev, daniel.moreno

[CL 29865370 by gerard martin in ue5-main branch]
2023-11-21 10:47:27 -05:00
alexei lebedev
3a76501fe1 #rnx
#tests PIE

[CL 29591872 by alexei lebedev in ue5-main branch]
2023-11-09 06:25:16 -05:00
alexei lebedev
aa19acdf9b [Mutable] Fix constant updates triggered in-between the SetModel and the Unlock of the CO.
- Check the participating object if the CO is compiled. Prevent discarding compilations when running the Game in standalone.
#rnx
#rb alexei.lebedev, gerard.martin, pere.rifa
#tests PIE
#localization none

[CL 29558498 by alexei lebedev in ue5-main branch]
2023-11-08 08:42:39 -05:00
marc audy
59f0feb3e4 Fix warning V595: The pointer was utilized before it was verified against nullptr.
#rnx

[CL 29459035 by marc audy in ue5-main branch]
2023-11-04 01:30:32 -04:00
gerard martin
af9cc08041 [Mutable] Mesh Cache. Enable the reuse of USkeletalMeshes between CO.
Minimum changes to enable the reuse of USkeletalMeshes. CVar toggleable.

[REVIEW] [at]pere.rifa, [at]alexei.lebedev
#rnx

[CL 29414369 by gerard martin in ue5-main branch]
2023-11-03 14:21:25 -04:00
gerard martin
dec4d1c634 [Mutable] Added CO option to force generating only the MaxLOD on initial generation.
- Fixed InstanceDescriptorRuntimeHash not being updated.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
[FYI] [at]aaron.eady, [at]bhavan.vaishnav
#rnx

[CL 29404120 by gerard martin in ue5-main branch]
2023-11-03 09:34:38 -04:00
alexei lebedev
0226d8d187 #rnx
[FYI] gerard.martin

[CL 29403987 by alexei lebedev in ue5-main branch]
2023-11-03 09:30:32 -04:00
jordi rovira
c86004ea2c [mutable] Separate "DisableTextureStream" option into its own state flag instead of deducing it from other enums.
Add option to override this flag at compile time.
Force "None" optimization to disable streaming.
#rnx
[REVIEW] [at]alexei.lebedev [at]pere.rifa
#rb pere.rifa, alexei.lebedev

[CL 29403177 by jordi rovira in ue5-main branch]
2023-11-03 09:03:29 -04:00
gerard martin
f36771cccf [Mutable] Fix FScopeTimer class naming collision.
#tests non-unity build
#rnx

[CL 29084235 by gerard martin in ue5-main branch]
2023-10-25 07:05:08 -04:00
gerard martin
97b833d9e2 [Mutable] Added Update stats.
- Updated FLogBenchmarkUitl class to output only used stats.
- Corrected some wrongly reported stats.
- FLogBenchmarkUtil now also reports stats on csv files.
- Moved FinishUpdateGlobal from outside UpdateSkeletalMesh.
- Fixed GetNumSkeletalMeshes.
- Fixed a case where UE_MUTABLE_UPDATE_REGION region would never end.

[REVIEW] [at]daniel.moreno, [at]alexei.lebedev
[FYI] [at]pere.rifa
#rnx

[CL 29083968 by gerard martin in ue5-main branch]
2023-10-25 06:41:33 -04:00
alexei lebedev
6f012aec32 #rnx
#rb gerard.martin, pere.rifa
[FYI] Aaron.Eady

[CL 29043824 by alexei lebedev in ue5-main branch]
2023-10-24 08:17:10 -04:00
gerard martin
520199da65 [Mutable] Added Descriptor Debug Print.
Allows to see the state of the parameters when enqueuing an update. Useful when analyzing why there are more updates than they should. CVar toggable.

[REVIEW] [at]max.garcia, [at]alexei.lebedev
#rnx

[CL 28872105 by gerard martin in ue5-main branch]
2023-10-18 04:56:12 -04:00
gerard martin
29a834959a [Mutable] Created a single Update Context.
This update context is maintain through the full lifecycle of the update.

- Merged FMutableOperation and FMutableOperationData into the the new FUpdateContextPrivate.
- Renaming of the Operation and OperationData varaibles will come in a future submit.
- Moved header implementations to the source due to delcaration order issues.

[REVIEW] [at]pere.rifa, [at]alexei.lebedev
#tests PIE Jumpsuit, Village Infinite
#rnx

[CL 28833454 by gerard martin in ue5-main branch]
2023-10-17 03:57:37 -04:00
jordi rovira
98d87f1679 [mutable] Ensure images are reduced at compile time if we know the platform-specific maximum size they can be used in.
Add section-based insights tracing for mutable updates.
[REVIEW] [at]pere.rifa
#rnx

[CL 28800986 by jordi rovira in ue5-main branch]
2023-10-16 12:05:17 -04:00
pere rifa
3a156a970e [Mutable] Remove bReuseMesh and related code to simplify the generation of meshes to ease the implementation of mesh streaming.
* Remove LastUpdateData
* Remove CopySockets and CopySkeletonData

#rnx
#rb alexei.lebedev

[CL 28496343 by pere rifa in ue5-main branch]
2023-10-05 09:01:56 -04:00
pere rifa
4ce6b212f9 [Mutable] Attach a callback to the PostCompileDelegate to update the state of the CustomizableObjectInstance after compiling the CO.
On execution, It will invalidate all generated data and re-initialize the ComponentsData to match the state of the compiled model.
* Remove InstanceUpdateFlags and Private::ReloadParameters methods.
* Move the Code to set the AssetUserData from the COSystem to the CustomizableInstancePrivateData
* Add PostDuplicate override to the CustomizableInstancePrivateData to invalidate generated data after duplicating an instance in the editor

#rnx
#rb alexei.lebedev
#rb gerard.martin

[CL 28410905 by pere rifa in ue5-main branch]
2023-10-03 08:47:48 -04:00
alexei lebedev
73dd3d9afa #rnx
[CL 28378755 by alexei lebedev in ue5-main branch]
2023-10-02 11:10:38 -04:00
gerard martin
221e2f65ab [Mutable] Fix SkeletalMeshStatus flags.
- Removed Updating flag.
- Added Error16BitBoneIndex Update error.
- Created Update starting point StartUpdateSkeletalMesh.
- Removed unused functions.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 28371606 by gerard martin in ue5-main branch]
2023-10-02 05:40:58 -04:00
alexei lebedev
7df9f5afdf #rnx
[CL 28269879 by alexei lebedev in ue5-main branch]
2023-09-27 07:44:07 -04:00
gerard martin
b4bcad6227 [Mutable] Fix incorrect Update flow result code.
[REVIEW] [at]pere.rifa, [at]alexei.lebedev
#rnx

[CL 28220980 by gerard martin in ue5-main branch]
2023-09-26 06:57:49 -04:00
jordi rovira
fb9c334844 [mutable] Remove most of the legacy string usage in favor of FString and FName.
Renamed some legacy structs to use the proper convention.
Removed some unnecessary boilerplate get and set methods.
Optimize mesh extract operation with switches and conditionals.
#rnx
[REVIEW] [at]max.garcia

[CL 28219048 by jordi rovira in ue5-main branch]
2023-09-26 04:43:37 -04:00