Commit Graph

101 Commits

Author SHA1 Message Date
patrick boutot
324bfb142b MVVM: Display the correct name in the detail view for the source and destination property. Use the correct property, as filter, for the mode direction.
#rb sebastien.nordgren

[CL 22802844 by patrick boutot in ue5-main branch]
2022-10-26 22:18:51 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
patrick boutot
c4672ea708 MVVM: ViewModel Panel display all the "notify" properties.
#rb none
[FYI] sebastian.nordgren

[CL 22509556 by patrick boutot in ue5-main branch]
2022-10-13 14:56:44 -04:00
sebastian nordgren
3fdafe9997 MVVM - Replaced all user-facing FStrings with FText. This includes all compiler error messages.
Binding display names now take into account complex conversion functions.

Complex conversion functions now compile correctly.

#rb patrick.boutot
#rnx
#preflight 633ebda6d910a076839e3ddf
#preflight 633ec514a712a61df1354aec

[CL 22388782 by sebastian nordgren in ue5-main branch]
2022-10-06 20:08:12 -04:00
sebastian nordgren
dd8a8abeb6 MVVM - Field selector can now display long paths, eg. Slot > Margin > Left.
Field selector now maintains conversion function selection after searching.

#rb patrick.boutot
#rnx
#preflight 633eb382d910a076839a324b

[CL 22388757 by sebastian nordgren in ue5-main branch]
2022-10-06 20:07:21 -04:00
sebastian nordgren
1fb1577293 MVVM - Bindings now have a GUID for identification purposes instead of using the index.
Display name is now more readable when conversion functions are involved.

Moved some conversion function code from MVVMEditorSubsystem to ConversionFunctionHelper so that it can be reused in the compiler.

#rb patrick.boutot
#rnx
#preflight 633d7020164ef40c2e3f308d

[CL 22362227 by sebastian nordgren in ue5-main branch]
2022-10-05 16:05:24 -04:00
sebastian nordgren
0ea0e80d62 MVVM - It is now possible to delete bindings by pressing Delete in the Bindings view.
Added missing Binding Mode tooltip.

[REVIEW] [at]patrick.boutot
#rnx
#preflight 633c256df91bb7615bc333eb

[CL 22331014 by sebastian nordgren in ue5-main branch]
2022-10-04 11:05:35 -04:00
sebastian nordgren
d1d3c1f6b9 MVVM - Details panel is now initially collapsed.
#rb trivial
#rnx
#preflight 633ae131ef77394565030de3

[CL 22322160 by sebastian nordgren in ue5-main branch]
2022-10-03 20:36:01 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
sebastian nordgren
88b9e3139e MVVM - SFieldSelector now displays conversion functions for widget properties again.
Conversion function entries are now sorted.

Conversion function categories display how many functions are inside of them.

The current selection of the field is now correctly displayed in the menu.

[REVIEW] [at]patrick.boutot
#rnx
#preflight 6331b14cd747fe52c8a10e65

[CL 22191652 by sebastian nordgren in ue5-main branch]
2022-09-26 15:15:38 -04:00
sebastian nordgren
fab14d01e8 MVVM - The visibility of the details panel in the Bindings panel is now togglable.
[REVIEW] [at]patrick.boutot
#rnx
#preflight 633195bab4515b7e22b6429d

[CL 22188623 by sebastian nordgren in ue5-main branch]
2022-09-26 13:33:49 -04:00
sebastian nordgren
fbca9e3e99 Added missing FMemMark.
#rb patrick.boutot
#rnx

[CL 22188395 by sebastian nordgren in ue5-main branch]
2022-09-26 13:23:43 -04:00
sebastian nordgren
168fa49b33 CIS fix. Added parentheses to disambiguate "&& inside ||" as reported by Clang.
#rb trivial
#rnx

[CL 22188372 by sebastian nordgren in ue5-main branch]
2022-09-26 13:22:53 -04:00
sebastian nordgren
26b9a3e58c MVVM - Added SSourceBindingList::SetSelectedProperty().
Renamed SSourceBindingList::Clear() to ClearSources().

[REVIEW] [at]patrick.boutot
#rnx

[CL 22188337 by sebastian nordgren in ue5-main branch]
2022-09-26 13:21:29 -04:00
patrick boutot
bf56fd9f4f MVVM: Use WeakObjectPtr to save UObject reference. Display the widget current slot properties. Confirm that the selected property can be assign or read before returning it. Created project setting. Filter property that can be display in the FieldSelector.
#rb sebastian.nordren
#preflight 632b6876e23e50651bf79d06, 632df2c7d51603c54898b28b

[CL 22165378 by patrick boutot in ue5-main branch]
2022-09-23 20:46:19 -04:00
sebastian nordgren
955918a4c3 MVVM - Simple conversion functions do not allow you to enter a single hardcoded value into the function parameter anymore.
[REVIEW] [at]patrick.boutot
#rnx
#preflight 632d735be23e50651b7ff147

[CL 22163625 by sebastian nordgren in ue5-main branch]
2022-09-23 20:02:08 -04:00
sebastian nordgren
1b7a5c4bd3 MVVM - Function parameters of simple conversion functions no longer clear their property.
#rb patrick.boutot
#rnx

[CL 22118988 by sebastian nordgren in ue5-main branch]
2022-09-21 14:41:39 -04:00
patrick boutot
9609b38905 MVVM: Add BP binding event to Viewmodel. Fix FieldVariant::IsEmpty now check if the pointer is nullptr (the function or property is not valid anymore). GetAvailableConversionFunctions now check for the widget parent class.
#rb sebastian.nordgren

[CL 22084831 by patrick boutot in ue5-main branch]
2022-09-19 19:56:19 -04:00
sebastian nordgren
952dbf828e MVVM - Field selector now displays valid conversion functions in the same dropdown menu as properties.
#jira UE-161689
[REVIEW] [at]patrick.boutot
#rnx
#preflight 63243e003752284a31722a6a

[CL 22050372 by sebastian nordgren in ue5-main branch]
2022-09-16 11:36:30 -04:00
sebastian nordgren
1f1ebd7b0b CIS - Fixed SMVVMFunctionParameter::OnSelectionChanged() taking a value instead of a const& due to changes in SMVVMFieldSelector which haven't gone in yet.
#rb trivial
#rnx

[CL 22039954 by sebastian nordgren in ue5-main branch]
2022-09-15 18:08:02 -04:00
sebastian nordgren
dc0b62bd17 CIS - Fixed SMVVMFunctionParameter calling OnFieldSelectionChanged, which has not yet been submitted.
#rb trivial
#rnx

[CL 22039943 by sebastian nordgren in ue5-main branch]
2022-09-15 18:06:54 -04:00
sebastian nordgren
acad8958a0 Removed fully commented-out MVVMPropertyAccess files.
#rb patrick.boutot
#rnx
#preflight 63231d8a5d5184f71e32f6e5

[CL 22039915 by sebastian nordgren in ue5-main branch]
2022-09-15 18:05:42 -04:00
sebastian nordgren
e53b08b744 MVVM - SFunctionParameter now correctly handles simple conversion function arguments.
#jira UE-161689
#rb patrick.boutot
#rnx
#preflight 632318455d5184f71e317233

[CL 22039904 by sebastian nordgren in ue5-main branch]
2022-09-15 18:05:15 -04:00
sebastian nordgren
2a7abd1c45 MVVM - Editor subsystem now correctly handles calls for simple conversion functions that don't create a wrapper UEdGraph.
#jira UE-161689
[REVIEW] [at]patrick.boutot
#rnx
#preflight 6323188ae872d7da0394014c

[CL 22039890 by sebastian nordgren in ue5-main branch]
2022-09-15 18:04:15 -04:00
sebastian nordgren
a24fc2361a Missed new files from previous submit.
#jira UE-161689
#rb patrick.boutot
#rnx

[CL 21862827 by sebastian nordgren in ue5-main branch]
2022-09-07 17:15:14 -04:00