Commit Graph

10774 Commits

Author SHA1 Message Date
Helge Mathee
324bb1ec00 RigVM: Reroute to inherit template node
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/625fc59035680893eee448a1

[CL 19826939 by Helge Mathee in ue5-main branch]
2022-04-20 05:02:39 -04:00
sara schvartzman
115ebab38c Control Rig: Fix reroutes incorrectly identifying cycles
#jira UE-149621
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/625eff23034d8924cdd001c2

[CL 19826928 by sara schvartzman in ue5-main branch]
2022-04-20 05:00:04 -04:00
eric mcdaniel
bf7658a0f6 [Backout] - CL19813742
- backing out due to assertions in Vulkan shader compiler
  - constant buffer renaming causes failures to lookup parameter name

#preflight 625f6ed5e239763df51ba585
#fyi christopher.waters

Original CL Desc
-----------------------------------------------------------------
Migrating back to using UniformBuffer structs.
Since the cbuffer uses the same name as the struct, we have to rename the cbuffer using a consistent prefix. The reflection handling also needs to reinterpret the renamed cbuffer as the correct UniformBuffer.

#jira none
#rb kenzo.terelst
#preflight 625edc5f034d8924cdcc35e2

[CL 19825755 by eric mcdaniel in ue5-main branch]
2022-04-19 22:40:31 -04:00
Rune Stubbe
bcb274c90e Got rid of VectorReciprocalSqrtAccurate in the Nanite builder to get consistent results between Intel and AMD
Converted SIMD calculations from double back to float
#rb brian.karis
#preflight 625f5478dd47b4ad214ff78b

[CL 19824539 by Rune Stubbe in ue5-main branch]
2022-04-19 21:16:13 -04:00
jeff newquist
30920a0b36 Prevent UnrealFrontend crash if platform DDPI lookup fails, using an empty icon instead
#jira UE-145707
#rb Louise.Rasmussen
#preflight 625ef6f7db15ac92dba08054

#ROBOMERGE-AUTHOR: jeff.newquist
#ROBOMERGE-SOURCE: CL 19813881 in //UE5/Release-5.0/... via CL 19820430
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19821927 by jeff newquist in ue5-main branch]
2022-04-19 19:28:38 -04:00
christopher waters
5c395bb058 Migrating back to using UniformBuffer structs.
Since the cbuffer uses the same name as the struct, we have to rename the cbuffer using a consistent prefix. The reflection handling also needs to reinterpret the renamed cbuffer as the correct UniformBuffer.

#jira none
#rb kenzo.terelst
#preflight 625edc5f034d8924cdcc35e2

[CL 19813742 by christopher waters in ue5-main branch]
2022-04-19 14:32:30 -04:00
helge mathee
8524f271b6 RigVM: When renaming a function update the build data
#rb sara.schvartzman
#jira UE-148063
#preflight https://horde.devtools.epicgames.com/job/625ea44c3e0f6f80adac7886

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 19808282 in //UE5/Release-5.0/... via CL 19809218
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19812201 by helge mathee in ue5-main branch]
2022-04-19 13:31:33 -04:00
helge mathee
674c08cfd4 RigVM: Respect name map during import from text
#rb sara.schvartzman
#jira UE-147996
#preflight https://horde.devtools.epicgames.com/job/625e94569c09ef439d90f535

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 19806989 in //UE5/Release-5.0/... via CL 19807506
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19811950 by helge mathee in ue5-main branch]
2022-04-19 13:21:52 -04:00
sara schvartzman
60e57fa0a8 Control Rig: FIx ensure after undoing a variable deletion
#jira UE-146402
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6239a63edb0f61c79259dc23

#ROBOMERGE-OWNER: sara.schvartzman
#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 19805508 in //UE5/Release-5.0/... via CL 19806184
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19811752 by sara schvartzman in ue5-main branch]
2022-04-19 13:16:50 -04:00
Rune Stubbe
3bf4f5080e Updated ParallelFors in NaniteEncode with more descriptive names and better default values for MinBatchSize.
#rb jamie.hayes
#fyi graham.wihlidal
#preflight 625eceaf034d8924cdcaea20

[CL 19809685 by Rune Stubbe in ue5-main branch]
2022-04-19 11:39:30 -04:00
Helge Mathee
1475be6205 RigVM: Change inheritance order - make UnitNode inherit from TemplateNode
Also implement a way to register external / auxiliary templates to the registry + unit test

#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/625847a0946114248dbaa7d9

[CL 19806894 by Helge Mathee in ue5-main branch]
2022-04-19 08:39:16 -04:00
CarlMagnus Nordin
e754071792 IoStore:
Preparation for optional package data support
Some cleanup of the cooked file stat map
Fixed package bulkdata size not being calculated correctly when staging from Zen
#rnx
#preflight 625e5884d412434587d7a51a
#rb pj.kack

[CL 19805462 by CarlMagnus Nordin in ue5-main branch]
2022-04-19 04:49:18 -04:00
Per Larsson
ddbf9eb5d2 Zen - cook to custom project/oplog ID with -ZenStoreProject=<ProjectId> and -ZenStorePlatform=<OplogId>
#rb none
#rnx
#preflight 19755222

[CL 19804798 by Per Larsson in ue5-main branch]
2022-04-19 02:37:06 -04:00
jason stasik
3ce9c775a2 Allow separate permission lists for viewing and creating assets
#rb rex.hill
#preflight 62574684667d4516642224fa

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19760664 via CL 19762141 via CL 19762160 via CL 19762168
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19802156 by jason stasik in ue5-main branch]
2022-04-18 23:31:34 -04:00
vlad golovan
9a0c0dad75 Source control operation to get file from depot. Users can now pull a shelfed changelist files.
#rb Patrick.Laflamme
[REVIEW] [at]marshall.beachy, [at]jay.Nakai

#ROBOMERGE-OWNER: vlad.golovan
#ROBOMERGE-AUTHOR: vlad.golovan
#ROBOMERGE-SOURCE: CL 19745483 via CL 19747037 via CL 19747055
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19801743 by vlad golovan in ue5-main branch]
2022-04-18 23:23:28 -04:00
Dan Thompson
adcd4a2208 Updating iostore asset registry writeback to use new cleaner functions and use the chunk listing on the asset registry.
#rb fabian.giesen
#preflight 625dacb2691f49969eaff227

[CL 19795732 by Dan Thompson in ue5-main branch]
2022-04-18 17:41:41 -04:00
Laura Hermanns
8559b47f2f Allow environment variable FXC to be used with shader debugging batch scripts to avoid hardcoded system path.
#rb Arciel.Rekman
#fyi Christopher.Waters, Rolando.Caloca
#jira none
#rnx
#preflight 6230dc44fc4d442f893619c1

[CL 19793860 by Laura Hermanns in ue5-main branch]
2022-04-18 16:37:06 -04:00
Devin Doucette
fa8f3dbe82 DDC: Fixed duplicate puts caused by the in-flight memory cache
Without using StopGetStore, get hits on the in-flight cache would propagate as puts to subsequent nodes in the hierarchy. Since the in-flight cache is only used as temporary storage while a put is in flight, this caused duplicates of the in-flight puts, which manifests as move collision log spam from the file system cache store.

#preflight 625d772d691f49969ea93249
#rb Zousar.Shaker
#rnx

[CL 19785647 by Devin Doucette in ue5-main branch]
2022-04-18 11:06:05 -04:00
Devin Doucette
b74b8b9227 DDC: Fixed incorrect cache store flags on dynamically mounted pak files
#preflight 625d771248670f31a61f0def
#rb Zousar.Shaker
#rnx

[CL 19785545 by Devin Doucette in ue5-main branch]
2022-04-18 10:57:14 -04:00
chris constantinescu
054a91e666 Introduce global setup for the LowLevelTests project.
Motivation: CoreUObject, taskgraph and threads are global constructs and need to be initialized as such and are expensive to setup/teardown before/after multiple single tests.

Introduced --global-setup and --no-global-setup to control execution of global test setup.
Unit tests that rely heavily on mocking and are designed to run without any global context should use --no-global-setup

Other: Removed CoreTestFixture and applied minor fixes wherever things didn't make sense.
One particular CoreUObject test was converted but had always failed to run on non-desktop platforms. It needs to be addressed ASAP.

#preflight 625873c7e304a95465fc148e
#rb Devin.Doucette, Zousar.Shaker

[CL 19769262 by chris constantinescu in ue5-main branch]
2022-04-15 07:21:27 -04:00
Devin Doucette
14583c8432 DDC: Back out 19757142 because it broke cache puts
#preflight skip
#rb none
#rnx

[CL 19763306 by Devin Doucette in ue5-main branch]
2022-04-14 17:05:38 -04:00
christopher waters
46d39f296a Reorganizing reflection handling to funnel through common functions.
This is a prerequisite for upcoming bindless changes as it centralizes key points where we register the different binding types.

#jira none
#rb jason.nadro, eric.mcdaniel, jeannoe.morissette
#preflight 62574453f7476d662c8dd2fe

[CL 19761676 by christopher waters in ue5-main branch]
2022-04-14 15:46:20 -04:00
ionut matasaru
45a1aef30f [Insights]
- Added "Auto Open Live Trace" toggle option in the main menu. If enabled, the analysis starts automatically for each new live trace session, replacing the current analysis session.
  - Moved the two "Open Trace File" options (from the main menu) into a sub-menu. Also added folder-open icon for these actions.

#jira UE-149129
#rb Catalin.Dragoiu
#preflight 62583459c738207d0320c02a

[CL 19758255 by ionut matasaru in ue5-main branch]
2022-04-14 12:03:02 -04:00
Devin Doucette
e35dc9fd40 DDC: Fixed duplicate puts caused by the in-flight memory cache
Without using StopStore, get hits on the in-flight cache would propagate as puts to subsequent nodes in the hierarchy. Since the in-flight cache is only used as temporary storage while a put is in flight, this caused duplicates of the in-flight puts, which manifests as move collision log spam from the file system cache store.

#preflight 625835d97f628a9018d8acf6
#rb Zousar.Shaker
#rnx

[CL 19757142 by Devin Doucette in ue5-main branch]
2022-04-14 11:06:11 -04:00
Devin Doucette
83f49f7dce DDC: Changed FileSystem PutValue to match Put
Except when replacing an existing value, load the existing value and check for determinism, and replace the existing value in the presence of an invalid value or non-deterministic value with missing content. This resolves move collisions being reported when a value existed without its content.

#preflight 62582c69946114248db5561f
#rb Zousar.Shaker
#rnx

[CL 19756384 by Devin Doucette in ue5-main branch]
2022-04-14 10:32:14 -04:00