Commit Graph

122 Commits

Author SHA1 Message Date
chris tchou
4c181f3489 Fix potential overflow security issue importing landscape PNG files
#rb don.boogert, jonathan.bard
#jira UE-172842, UE-172835

[CL 25833042 by chris tchou in ue5-main branch]
2023-06-06 19:46:33 -04:00
charles bloom
833b42c326 JpegImageWrapper : remove unnecessary serializing critsec; libjpeg-turbo is now thread safe
fix error state was being retained in tjhandles, make new ones for each encode
fix InterchangeJPGTranslator using deprecated ImageWrapper code style

#rb dan.thompson,fabian.giesen
#rnx

[CL 25798648 by charles bloom in ue5-main branch]
2023-06-05 14:19:07 -04:00
charles bloom
e1fab21a75 IcnsImageWrapper fix Mac non-unity compile
#rb none
#rnx

[CL 25794186 by charles bloom in ue5-main branch]
2023-06-05 12:04:04 -04:00
charles bloom
152edc496d ImageCoreUtils::IsImageImportPossible can be checked before image import instead of after
#rb none
#rnx

[CL 25792081 by charles bloom in ue5-main branch]
2023-06-05 10:47:00 -04:00
charles bloom
9cd4768d6a [Backout] - CL25773063
[FYI] charles.bloom
Original CL Desc
-----------------------------------------------------------------
ExrImageWrapper : corrupt import should not be fatal, just an error
use runtime_exception for throws
fix return value of read function, though it seems not to be used

#preflight https://horde.devtools.epicgames.com/job/647a465ce75a226391b559bb
#rb none
#rnx

[CL 25782083 by charles bloom in ue5-main branch]
2023-06-03 12:43:06 -04:00
charles bloom
ec364946ec TiffImageWrapper : fix missing Reset function so state carried over in multiple uses of Wrapper
#preflight none
#rb none
#rnx

[CL 25775444 by charles bloom in ue5-main branch]
2023-06-02 18:04:40 -04:00
charles bloom
928b53aec3 Tga image importer cleanups and robustination
#preflight yes
#rb fabian.giesen
#rnx

[CL 25774569 by charles bloom in ue5-main branch]
2023-06-02 17:28:34 -04:00
charles bloom
4fd634eb54 ExrImageWrapper : corrupt import should not be fatal, just an error
use runtime_exception for throws
fix return value of read function, though it seems not to be used

#preflight https://horde.devtools.epicgames.com/job/647a465ce75a226391b559bb
#rb none
#rnx

[CL 25773157 by charles bloom in ue5-main branch]
2023-06-02 16:45:31 -04:00
charles bloom
225939ffcf ImageWrapperModule StressDecompressImage for automated corrupt image import testing
#preflight https://horde.devtools.epicgames.com/job/647a3c2f5e71ee4db65b19f3
#rb none
#rnx

[CL 25771464 by charles bloom in ue5-main branch]
2023-06-02 15:45:17 -04:00
charles bloom
dde5ea7405 fix image import crashes in Ico and Tga
#preflight https://horde.devtools.epicgames.com/job/6478cd4fe319748a834211e4
#rb fabian.giesen
#jira UE-187448,UE-187445
#rnx

[CL 25763310 by charles bloom in ue5-main branch]
2023-06-02 11:50:02 -04:00
dan thompson
824ce41544 EXR invalid file protection - now using std::exception instead of std::overflow_error to prevent weird linker issues.
#rb fabian.giesen
#jira UE-187447
#preflight 647911df8417d792592a2b01

[CL 25748215 by dan thompson in ue5-main branch]
2023-06-01 19:28:11 -04:00
joe kirchoff
e028621825 [Backout] - CL25715182
[FYI] Dan.Thompson
Original CL Desc
-----------------------------------------------------------------
EXR invalid file protection.
#rb fabian.giesen
#jira UE-187447
#preflight 6477b63d7f02573726aa9885

[CL 25737430 by joe kirchoff in ue5-main branch]
2023-06-01 15:42:37 -04:00
charles bloom
678329a3b3 fix crash in TiffImageWrapper, Tasks were still running after "this" was deleted
#jira UE-187438
#preflight https://horde.devtools.epicgames.com/job/6477ef670d55081f54b90465
#rb fabian.giesen
#rnx

[CL 25725378 by charles bloom in ue5-main branch]
2023-06-01 10:00:01 -04:00
dan thompson
87e71ce499 EXR invalid file protection.
#rb fabian.giesen
#jira UE-187447
#preflight 6477b63d7f02573726aa9885

[CL 25715204 by dan thompson in ue5-main branch]
2023-05-31 17:26:47 -04:00
dan thompson
2e2dcf14d9 Security updates for PngImageWrapper
#jira UE-172869
#rb fabian.giesen
#preflight 646bcca1b82cb3fe6771b1b6

[CL 25572214 by dan thompson in ue5-main branch]
2023-05-22 19:17:13 -04:00
dan thompson
5f360661f3 Move GuardedInt.h to Core as it's about to be needed elsewhere.
#rb devin.doucette
#preflight 6467a9a52c0a5da0dcd0afa9

[CL 25553319 by dan thompson in ue5-main branch]
2023-05-19 17:51:45 -04:00
dan thompson
827daef19f Bounds checking for Tiff importing.
#jira UE-172862
#jira UE-172527
#rb fabian.giesen
#rb martins.mozeiko
#preflight 6466606d743f7c995bccfcde

[CL 25534731 by dan thompson in ue5-main branch]
2023-05-18 17:53:48 -04:00
dan thompson
743e09bba2 Force "up" PNG filter when we are uncompressed for speed (and oddly, size too)
#rb fabian.giesen
#preflight 645187ea1c2846595cc6eb33

[CL 25327841 by dan thompson in ue5-main branch]
2023-05-03 18:12:19 -04:00
charles bloom
aa956df38a fix many texture and image int64 issues
can now successfully import over 32K textures to VT

#preflight https://horde.devtools.epicgames.com/job/6435ab7900398d6f88e8e808
#rb fabian.giesen
#jira none

[CL 24996140 by charles bloom in ue5-main branch]
2023-04-11 15:18:46 -04:00
charles bloom
197dfb19e6 nop just comments, clean up some todo Oodle marks
#rb none
#preflight none

[CL 24950141 by charles bloom in ue5-main branch]
2023-04-06 14:21:41 -04:00
charles bloom
4696059e9d nop comments only better description of EImageCompressionQuality
#rb none
#preflight none

[CL 24938671 by charles bloom in ue5-main branch]
2023-04-05 18:40:36 -04:00
Jack Porter
48cbc592ad Resave PNG files with incorrect sRGB profile
Log PNG filename during warnings and errors
#jira UE-167980
#jira UE-169864
#rb Florin.Pascu
#review-24281768
#preflight 63f223ae90198dffba8a2927

[CL 24308896 by Jack Porter in ue5-main branch]
2023-02-19 20:38:08 -05:00
charles bloom
51467ca1b0 Exr import : don't promote 1 channel exr to 4 channel in the TSF uasset
not needed any more

#jira https://jira.it.epicgames.com/browse/UE-176077
#rb alexander.suvorov
#preflight none

[CL 24120894 by charles bloom in ue5-main branch]
2023-02-10 11:31:49 -05:00
charles bloom
15a954cc6c ExrImageWrapper : fix importing exr's with channel names other than RGBA
should use the channel names found in the file

#jira https://jira.it.epicgames.com/browse/UE-175918
#preflight https://horde.devtools.epicgames.com/job/63dd77f9af610ffb8b4ce447
#rb alexander.suvorov

[CL 24104681 by charles bloom in ue5-main branch]
2023-02-09 15:16:36 -05:00
charles bloom
87f1b32bad fix TGA not exporting UDIM
change the TGA exporter to use the Generic path
make TgaImageWrapper write 24 or 32 bit like the legacy exporter
delete the legacy exporter

#jira https://jira.it.epicgames.com/browse/UE-176541
#preflight https://horde.devtools.epicgames.com/job/63e43e2c9910415ae2319a38
#rb fabian.giesen

[CL 24104640 by charles bloom in ue5-main branch]
2023-02-09 15:14:48 -05:00