Commit Graph

2151 Commits

Author SHA1 Message Date
steve robb
67d6d682bc FAutomationTestAttemptToFindUninitializedScriptStructMembers test skipped when running automation tests under UHT, as it requires a NoExportType which doesn't exist in that config.
#rb none
#jira none

#ROBOMERGE-SOURCE: CL 17063106 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v850-17047176)

[CL 17063114 by steve robb in ue5-release-engine-test branch]
2021-08-04 21:23:32 -04:00
francis hurteau
f320ee96e7 Fix fatal log error during cook when referencing an unsaveable dependency
#jira UE-120870
#rb Matt.Peters

#ROBOMERGE-SOURCE: CL 17044668 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v848-17036448)

[CL 17044745 by francis hurteau in ue5-release-engine-test branch]
2021-08-03 21:39:46 -04:00
matt peters
64eb24ccec SavePackage PackageStoreWriter with EditorDomain: fix offsets written into the BulkDatas to be relative to the end of the Linker's archive as expected, rather than relative to some number of bytes before the end of the archive because we were copying Linker->Tell at a point before AppendAdditionalData and the Package Post Tag were written to the archive.
Also add the writing of AppendAdditionalData to a callback on the PackageStoreWriter, so that FVirtualizedUntypedBulkDatas can be separated out into separate archives in the same way FUntypedBaseData are.

#rnx
#rb Paul.Chipchase

#ROBOMERGE-SOURCE: CL 17015164 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v839-17012307)

[CL 17015166 by matt peters in ue5-release-engine-test branch]
2021-08-02 08:36:21 -04:00
ben zeigler
00091e9c02 Fix issue where SavePackage2 warns about a deprecated and unreferenced object being unsaveable, in SavePackage1 this would be silently ignored
This version changes both the logic and comment to handle abstract and deprecated outers, but not warn for the base object
It may be more theoretically correct to try and warn for directly referenced deprecated base objects, but that is not easy to detect in SavePackage 2 and this change matches the historical behavior
#rb francis.hurteau

#ROBOMERGE-SOURCE: CL 16959548 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16959570 by ben zeigler in ue5-release-engine-test branch]
2021-07-26 15:02:24 -04:00
tim smith
daa6dac524 Replacing the UClass::StaticRegistrationInfo method with a extern function that won't be exported from the DLL if the class is marked as exported.
#rb trivial
#rnx
#preflight 60fc2bc324804700014eda57

#ROBOMERGE-SOURCE: CL 16949953 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)
#ROBOMERGE[bot1]: Dev-EngineMerge

[CL 16949956 by tim smith in ue5-release-engine-test branch]
2021-07-24 11:56:31 -04:00
matt peters
dba8fe135c IPackageStoreWriter: Update SavePackage to allow saving non-cooked packages into a PackageStoreWriter.
#rb Per.Larsson, Paul.Chipchase
#rnx

#ROBOMERGE-SOURCE: CL 16922549 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16922796 by matt peters in ue5-release-engine-test branch]
2021-07-22 09:55:34 -04:00
tim smith
b28ff61e27 1) Removed the need to create a UScriptStruct to test to see if it has a NoOp constructor.
2) Added a quick method to query the deferred CppStructOps until we decide on a long term solution
3) Added method to test to see if a source file is the NoExports include file.

#rb none
#rnx
#preflight 60f6c42f25c166000152cbdc

#ROBOMERGE-SOURCE: CL 16895867 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16895873 by tim smith in ue5-release-engine-test branch]
2021-07-20 09:30:31 -04:00
ben zeigler
9c84f7d677 #jira UE-119853 Fix issue where Untracked metadata would not work on arrays of soft pointers
Fix similar issue with IncludeAssetBundlesName
Original fix from Roubert.Rouhani via UDN
#rb none

#ROBOMERGE-SOURCE: CL 16887122 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16887133 by ben zeigler in ue5-release-engine-test branch]
2021-07-19 14:51:08 -04:00
jamie dale
7d6c0c56c0 Fixed single-property config updates failing to remove entries that were no longer needed as they matched the CDO
The UObject would write the correct config state, but UpdateSinglePropertyInSection would fail to remove the data for the updated key as it (correctly) wasn't present in the config being applied. This change has it remove the key from the config section if it exists.

#jira UE-119534
#rb Brooke.Hubert, Matt.Peters

#ROBOMERGE-SOURCE: CL 16884096 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16884120 by jamie dale in ue5-release-engine-test branch]
2021-07-19 11:31:33 -04:00
matt peters
a1e506797a Generalize IPackageResourceManager::OnEndLoad into FCoreUObjectDelegates::OnEndLoadPackage for use by the BulkDataRegistry, and add UPackage::bHasBeenEndLoaded for BulkDataRegistry to know when a package has finished its initial load serialization.
Add OnEndLoad calls for Async loaded packages, since the editor sometimes uses async loads.
#rb Francis.Hurteau
#rnx

#ROBOMERGE-SOURCE: CL 16861817 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16861829 by matt peters in ue5-release-engine-test branch]
2021-07-15 09:49:49 -04:00
steve robb
e85e8f9950 Fix for optimized map and set properties serialization when there are no defaults and the container is already populated.
#jira UE-118822
#rb none
[FYI] johan.torp

#ROBOMERGE-SOURCE: CL 16843259 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16843265 by steve robb in ue5-release-engine-test branch]
2021-07-13 17:45:30 -04:00
jordan hoffmann
4d2a9e5f33 Fix: The 'const' checkbox should not be visible in the Details tab for Blueprint Library functions.
#jira UE-39711
#rb mark.audy

#ROBOMERGE-SOURCE: CL 16838997 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16839004 by jordan hoffmann in ue5-release-engine-test branch]
2021-07-13 13:03:22 -04:00
michael noland
ed82778544 Core: Made the verbosity of the unintialized reflected property check configurable via ini
- Issues with UObject* properties are upgraded from Warning to Error
- Other types remain the same for both engine and project modules (Display), but engine will soon change to Error as well

Settings can be overridden for either project or engine modules in DefaultEngine.ini (engine defaults are in BaseEngine.ini), e.g.,

[CoreUObject.UninitializedScriptStructMembersCheck]
EngineModuleReflectedUninitializedPropertyVerbosity=Error
ProjectModuleReflectedUninitializedPropertyVerbosity=Warning

#rb marc.audy

#ROBOMERGE-SOURCE: CL 16826159 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16826182 by michael noland in ue5-release-engine-test branch]
2021-07-12 11:49:57 -04:00
ionut matasaru
c0495f965d [Insights]
- Fixed the trace of scope cycle counters for UObject to be enabled everywhere where FScopeCycleCounterUObject is used switced by Stats::IsThreadCollectingData().
  - Fixed UObject::CallFunction to trace UObject name for Insights only when GVerboseScriptStats is on.

#rb Catalin.Dragoiu
[FYI] Johan.Berg, Jeff.Farris

#ROBOMERGE-SOURCE: CL 16824659 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16824668 by ionut matasaru in ue5-release-engine-test branch]
2021-07-12 09:25:05 -04:00
jeanfrancois dube
9a74d7789f Backout CL16728888 as it doesn't properly handle the ECoreRedirectFlags::Option_MatchSubstring flag, found by running the CoreRedirects unit tests.
#jira UE-118831
#rb none

#ROBOMERGE-SOURCE: CL 16819857 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16819858 by jeanfrancois dube in ue5-release-engine-test branch]
2021-07-10 17:00:49 -04:00
ben woodhouse
498a7b6a26 Back out 16780416 for now since it's causing cook failures
[FYI] Michael.Noland

#ROBOMERGE-SOURCE: CL 16783107 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16783117 by ben woodhouse in ue5-release-engine-test branch]
2021-06-25 10:07:08 -04:00
michael noland
5465c7984d Core: Changed the verbosity of the unintialized reflected property check to an error for types in engine modules or UObject* properties
[CODEREVIEW] nick.darnell
#preflight 60d50948925f140001249b76

#ROBOMERGE-SOURCE: CL 16780416 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16780421 by michael noland in ue5-release-engine-test branch]
2021-06-24 20:04:37 -04:00
francis hurteau
7885790bd3 Remove the usage of modal message dialog in package saving
Always try to find the likely culprit in case of illegal references

#rb Matt.Peters
#jira UE-115971

#ROBOMERGE-SOURCE: CL 16774967 via CL 16774971
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16774975 by francis hurteau in ue5-release-engine-test branch]
2021-06-24 12:05:49 -04:00
danny couture
4be0185d91 Optimize the ddc fill job
- Avoid redundant iterations and processing of UPackages by implementing a listener instead
  - Process many packages asynchronously (not just one) by keeping them in memory longer and finishing them later
  - Make the ddc fill job wait for async tasks properly
  - Fix texture always being single threaded by allowing async at all time for ddc fill jobs
  - Avoid calling IsCachedCookedPlatformDataLoaded too often on objects still being compiled
  - Use a more sensible max memory usage in WorldPartitionHelpers to avoid calling the GC too often

  - 30m16s to 7m44s when running -run=DerivedDataCache -fill -map=P_Construct_WP -mapsonly -projectonly with hot cache
  - 2h30m to 1h11s when running -run=DerivedDataCache -fill -map=P_Construct_WP -mapsonly -projectonly with cold cache

#rb Zousar.Shaker, Devin.Doucette
#preflight 60d1fd5571002f0001b8880e

#ROBOMERGE-SOURCE: CL 16745009 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16745019 by danny couture in ue5-release-engine-test branch]
2021-06-22 12:50:30 -04:00
aurel cordonnier
02c0f425e8 Copy up from Release-Engine-Staging @ 16738359
This represents UE4/Main @ 16738161 and Dev-PerfTest @ 16737719

[CL 16738582 by aurel cordonnier in ue5-release-engine-test branch]
2021-06-22 00:27:54 -04:00
jeanfrancois dube
5a454e2041 Bring back 16574112 with proper fix:
Implement fast path for FCoreRedirects::GetMatchingRedirects when looking for a single redirect type.
Saves ~18% of the time spent in FLinkerLoad::FixupImportMap, which is time sliced in a 5ms window in PIE.

#rb francis.hurteau

#ROBOMERGE-SOURCE: CL 16728888 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16728893 by jeanfrancois dube in ue5-release-engine-test branch]
2021-06-21 11:46:40 -04:00
jurre debaare
ccaed4b3f9 Launch on to platform crashes on open Assertion failed: IsAligned(PropertyDest, TheCppStructOps->GetAlignment())
#fix actually allow for 32-byte aligned UObject allocations, allocate by size and aligment rather than aligned size and added development/debug build verification of resulting mem adress
#jira UE-117778
#rb Johan.Torp
[FYI] Andrew.Davidson, Zak.Middleton
#preflight 60cb32e79ecd3e000199a396

#ROBOMERGE-SOURCE: CL 16703994 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16704019 by jurre debaare in ue5-release-engine-test branch]
2021-06-17 09:48:14 -04:00
zousar shaker
c27625b056 Integrating //UE5/Dev-Cooker [at] 16678003 to //UE5/Main (Zousar.Shaker-YEG-0943-Quaternary)
Non-DevIteration_ShooterGame


#ROBOMERGE-SOURCE: CL 16678907 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16678928 by zousar shaker in ue5-release-engine-test branch]
2021-06-15 16:38:03 -04:00
ionut matasaru
11690154ef [Insights]
- Fixed tracing of UObject names and function names (UObject::CallFunction, FScopeCycleCounterUObject) when "stat named events" toggle is enabled (-statnamedevents, "stat NamedEvents" console command).
  - Added FCpuProfilerTrace::OutputBeginDynamicEvent(const FName), in addition to existing API that receives const ANSICHAR*  or const TCHAR*. It uses a separate DynamicFNameScopeNamesMap.

#rb Johan.Berg
[FYI] Jeff.Farris

#ROBOMERGE-SOURCE: CL 16657504 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v833-16641396)

[CL 16657509 by ionut matasaru in ue5-release-engine-test branch]
2021-06-14 08:51:25 -04:00
marc audy
aa79e9b291 Shrink FObjectImport
#rb Michael.Noland

#ROBOMERGE-SOURCE: CL 16644166 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v833-16641396)

[CL 16644176 by marc audy in ue5-release-engine-test branch]
2021-06-11 13:49:57 -04:00