Commit Graph

518 Commits

Author SHA1 Message Date
David Corral
70e2623a31 [PoseDriver]
- Removed bOnlyDriveSelectedBones bool. Now checks if OnlyDriveBones list has items.
- Fixed issue with OnlyDriveBones with None entry.
- Fixed indentations and improved comments.
#preflight 642b43731d19c0312a6d301c

[CL 24901507 by David Corral in ue5-main branch]
2023-04-03 17:36:03 -04:00
David Corral
dac5a5fa27 [PoseDriver]
- Added EditConditions for OnlyDriveBones, bOnlyDriveSelectedBones and Median properties.
- Rearranged Properties

#jira UE-181415, UE-181411
#preflight 64231547051bec41cda13799

[CL 24821515 by David Corral in ue5-main branch]
2023-03-28 12:49:06 -04:00
justin hare
4f2df46e79 Allow PlayMontageCallbackProxy to be derived from, to support plugins that want to provide customized versions of playing montages without duplicating existing code
#jira UE-177863
#rb roland.munguia aaron.cox
#preflight 6414aa183f3d31c94a9d5aa7

[CL 24754967 by justin hare in ue5-main branch]
2023-03-22 17:41:18 -04:00
frederick lupien
2fb8af746d Remove empty display name from UBlendListBaseLibrary
#rnx

[CL 24593066 by frederick lupien in ue5-main branch]
2023-03-10 11:59:53 -05:00
frederick lupien
cd5ba4641b Add anim node library function for blend list base
Add an anim node function to reset blend lists


[REVIEW] [at]Thomas.Sarkanen
[FYI] Paul.McLaurin

[CL 24577496 by frederick lupien in ue5-main branch]
2023-03-09 12:02:01 -05:00
Max Chen
3b95ddaf05 Sequencer: Remove deprecated at 5.0 and below from movie scene and level sequence
#preflight 6407e62cc13b7130d2811d09
#jira none
#rb matt.hoffman
#rnx

[CL 24567160 by Max Chen in ue5-main branch]
2023-03-08 16:33:59 -05:00
Thomas Sarkanen
0d0a030aa5 Curve refactor fixes: Pose Assets, Pose Driver and more
Addresses curves all being set to NAME_None for pose assets saved between CLs 3002109 and 3026802.
Fixes curve extraction in pose assets.
Fixes pose driver not setting curves unless they already exist.
Fixes instances where TBaseBlendedCurve::Set was being used incorrectly - this now inserts the element if it wasnt present before, potentially causing a re-sort but at least not behaving un unexpected ways compared to the old use case.

#jira UE-179096
#preflight 640615ad0c7df1967f08e090
#rb Jurre.deBaare
#preflight 640723e28c0039bbf79e25f3

[CL 24538171 by Thomas Sarkanen in ue5-main branch]
2023-03-07 06:58:13 -05:00
Thomas Sarkanen
502797ca50 Animation Curve Runtime & Editor Improvements
Runtime notes:
- Removes 'smart name' usage across the animation systems.
- Changed curve blending from a uniform array (sized per skeleton) to a sparse array of sorted named values. Blends and other combiners are performed using a dual iteration 'tape merge'.
- Skeleton curves are no longer guaranteed to cover all curve names that can be found at runtime.

Editor notes:
- Curve metadata (flags, bone links etc.) is still present on the skeleton, but can also now exist on a skeletal mesh
- Curve metadata (for morph targets) is still populated on import
- Curves can now be used arbitrarily at runtime

New features:
- New Find/Replace dialog that allows for batch-replacing curves and notifies across all of a project's assets
- New curve debugger tab in various Persona editors that allows for viewing curve values live. This also now allows viewing curves for specific pose watches.
- Pose watches now output curve tracks to the Rewind Debugger

#rb Jurre.deBaare,Nicholas.Frechette,Sara.Schvartzman,Helge.Mathee,Kiaran.Ritchie,Jaime.Cifuentes,Martin.Wilson,Keith.Yerex,Andrean.Franc (and more!)
#jira UE-167776
#jira UE-173716
#jira UE-110407
#preflight 63fc98c81206d91a2bc3ab90
#preflight 63f3ad4f81646f1f24c240c2

[CL 24421496 by Thomas Sarkanen in ue5-main branch]
2023-02-27 07:20:58 -05:00
jurre debaare
620b5d6fb1 Fixed bone index handling in UE::Anim::Attributes::MirrorAttributes
#misc handle deprecation path
#ushell-cherrypick of 23897026 by David.Bollo
#jira UE-175745
#preflight 63dbb97eba4fadeef04e9df2
#rb thomas.sarkanen

[CL 24053916 by jurre debaare in ue5-main branch]
2023-02-07 13:42:31 -05:00
halfdan ingvarsson
5a824b0c77 Pose Driver: Fix a crash when trying to dereference with an invalid bone id.
#jira UE-175830
#rb kiaran.ritchie
#preflight https://horde.devtools.epicgames.com/job/63dae2794965eb8c33d0e575

[CL 23984132 by halfdan ingvarsson in ue5-main branch]
2023-02-02 18:45:11 -05:00
bob tellez
f27f2bd3d5 #UE Add a little info to a warning to help identify which AnimNode_LookAt has an invalid axis
[CL 23888382 by bob tellez in ue5-main branch]
2023-01-27 14:14:53 -05:00
nick brett
c339d7a6be [UE] Add ECVF_Scalability flag to p.RigidBodyNode and p.ClothPhysics CVars
- This will allow the ''Preview Rendering Level' setting in editor to set the CVars to the values defined in platform device profiles.

#rb [at]Benn.Gallagher, [at]Ben.Woodhouse

[CL 23741214 by nick brett in ue5-main branch]
2023-01-17 13:13:07 -05:00
lucas dower
754b4db91d Disabled 'resync to sync group' for sequence and blend space evaluators as they generally want to be driven with explicit time
#jira UE-170739
#rb thomas.sarkanen
#preflight 63beab6c68068a8bd6a85251

[CL 23644177 by lucas dower in ue5-main branch]
2023-01-11 07:43:54 -05:00
jaime cifuentes
65b892d517 Fix for CIS LocText at AnimNode_SkeletalControlBase
#jira UE-173721
#rb trivial
#preflight 63bd9123577437afe6528ae8

[CL 23628016 by jaime cifuentes in ue5-main branch]
2023-01-10 11:41:38 -05:00
jaime cifuentes
a20a6e0027 Added validation and visual error functionality to AnimNode_SkeletalControlBase, which can be used to check referenced bones and show errors on the AnimGraph nodes that use them (so it is clear if the setup does not work due to a bone missing)
#rb thomas.sarkanen
#jira UE-160111
#preflight 63b85453c927e34482895de4

[CL 23599353 by jaime cifuentes in ue5-main branch]
2023-01-06 12:16:12 -05:00
Bryan sefcik
80f80e7a25 Updated the underlying types for regular and namespaced enums.
#jira
#preflight 638e6d479549ddaa2822be9a

[CL 23421568 by Bryan sefcik in ue5-main branch]
2022-12-06 19:43:59 -05:00
thomas sarkanen
50e0c0e527 Fixed graph based sync not working correctly when a sync point does not specify a sync group name
Even with a name of 'None', a sync point (FAnimSyncGroupScope - such as that on a blend space graph) would forward for syncing to the proxy, bypassing any other valid rootwards sync scopes.
This change prevents adding the sync messages completely if their name is 'None', ensuring that outer scopes correctly receive the tick record.

#jira UE-170408
#rb Jurre.deBaare
#preflight 63877bed7b4bd3f057134e25

[CL 23352692 by thomas sarkanen in ue5-main branch]
2022-12-01 10:33:57 -05:00
chris caulfield
cd0fbfbe92 Chaos - fix RBAN SimulationSpace force transfer when using Bone-Space mode and scaling to zero
[FYI] frederick.lupien
#rb none
#preflight 637d5681815e4b9b7578ee75

[CL 23244705 by chris caulfield in ue5-main branch]
2022-11-22 20:28:51 -05:00
bryan sefcik
4b8a83790a Updated to use UE_INLINE_GENERATED_CPP_BY_NAME.
#jira
#preflight 637c388f170bc34a93587526

[CL 23244381 by bryan sefcik in ue5-main branch]
2022-11-22 20:17:33 -05:00
Nicholas Frechette
e97561501f Add warning and bind pose when mirroring additive animations
#jira UE-169357
#rb Thomas.Sarkanen
#preflight 637cf12f4004f73f62b31f5d

[CL 23236215 by Nicholas Frechette in ue5-main branch]
2022-11-22 11:03:35 -05:00
Chris Caulfield
2f240b0614 Fix RBAN TeleportPhysics handling
This fixes a character movement related issue where walking into a moving kinematic object would stop the RBAN nodes from simulating altogether because the moving kinematic moves the movement component which triggers a TeleportPhysics.

#rb benn.gallagher, satchit.subramanian
#jira none
#preflight 6376a411fa348e8480775c8b

[CL 23184228 by Chris Caulfield in ue5-main branch]
2022-11-17 16:47:48 -05:00
thomas sarkanen
a897f0439a Skeleton compatibility improvements
Skeleton compatibility is now bi-directional. Specifying a compatible skeleton A -> B now implies B -> A.
Skeleton compatibility is now an editor-only concern. The runtime will attempt to do the 'best it can' via name -> name mappings. Only the editor will prevent assigning incompatible skeletons in (e.g.) asset pickers etc.
Skeleton compatibility checks in editor can now be disabled in the editor preferences (and each asset picker now has a checkbox option in its view settings that allows for quick access to this).

Moves FSkeletonRemapping to its own file (which is now private).
Skeleton remappings are now generated on demand on worker threads just before animation decompression and stored in a registry, guarded by FRWScopeLock for thread-safety.

Fixed some anim BP compiler edge cases where asset references on pins were not getting preloaded correctly, causing skeletons to be erroneously reported as missing.

Exposed the current asset registry filter in SAssetView so that menu extensions can access it (and use it to provide context)

#jira UE-166054
#jira UE-167355
#rb Jurre.deBaare,John.vanderBerg
#preflight 635902602e6690262afa86f9
#preflight 6372ad7a0c74adb48b472b38
#p4v-cherrypick 22878911
#preflight 6374b3c51d25fe8b931b8d7b

[CL 23152671 by thomas sarkanen in ue5-main branch]
2022-11-16 07:21:38 -05:00
henrik karlsson
d5026d4d83 Strategical submit which adds includes in preparation for coming change which removes includes in headers
#preflight 636531a1581dc906bce283d1
#rb none

[CL 22994620 by henrik karlsson in ue5-main branch]
2022-11-04 16:37:48 -04:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
Mike Zyracki
891737c14e Manual Merge of Sequencer: NLA Fixes. Default to transform the start transform offset in local bone space and not in root space, this will make the manipulation of the offset much more predictible, changed the edit mode to handle this coordinate space change.
When use the first child option we now find the first child with animation, FN rigs and 3rd party rigs may not have the animation on the first child of the root.
Don't draw virtual bones when drawing skeleton and use default bone rendering.
Just dirty root motion cache on changes.
Passing in the PreviousTransform to the anim proxy, this is just wip for the refactor to remove the root motion caching.
#jira UE-167374
#jira UE-167371
#jira UE-167991
#preflight 63603b41d13ad22d722ee5b4
#rb max.chen

[CL 22889771 by Mike Zyracki in ue5-main branch]
2022-11-01 15:48:30 -04:00