Commit Graph

861 Commits

Author SHA1 Message Date
patrick boutot
7b306e0840 MVVM: Add the FieldNotify pattern to the base Blueprint. The pattern will be removed from the Widget and from the ViewmodelBase class. A BP variable that has the FieldNotify flag will use a different setter. If the variable is replicated, the OnRep function will broadcast the FieldNotification event. FieldNotify variables cannot be used as a ref argument.
#rb dan.oconnor, leon.huang
#jira UE-182297
#preflight 6436d2cef12d5de7056ef8d9

[CL 25026926 by patrick boutot in ue5-main branch]
2023-04-13 11:55:18 -04:00
sara schvartzman
ec292c5aa9 Fix crash when undoing node creation
#jira UE-181748
#rb trivial
#preflight https://horde.devtools.epicgames.com/job/642af8dfc6769c6082c41f15

[CL 24894240 by sara schvartzman in ue5-main branch]
2023-04-03 12:14:12 -04:00
dan oconnor
d2f5aa0de2 Optimize async blueprint context menu building by avoiding resorting and inserting nodes in the desired order
#rb Phillip.Kavan
#jira UE-167392
#preflight 6419ef73ec01de1664d727e3

[CL 24742868 by dan oconnor in ue5-main branch]
2023-03-21 19:49:22 -04:00
dan oconnor
0310413299 Make sure we don't dereference GraphPinObj after GraphData has been invalidated
#rb Phillip.Kavan
#preflight

[CL 24665416 by dan oconnor in ue5-main branch]
2023-03-15 19:45:45 -04:00
sara schvartzman
bc153f9e5e Control Rig: Fix crash when removing dot nodes
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/640f5610af3fc35292bf6d43

[CL 24632731 by sara schvartzman in ue5-main branch]
2023-03-14 06:43:16 -04:00
dan oconnor
2534a73014 Remove needless BroadcastChanged calls, which refresh the entire graph of a blueprint, from various nodes. Add GRAPHACTION_EditNode to synchronously update a node's SGraphNode after a change is made.
Also requires 24595399

#jira UE-158391
#preflight 640f706e0e1f02786bf205d8
#rb Ben.Hoffman

[CL 24623042 by dan oconnor in ue5-main branch]
2023-03-13 17:52:48 -04:00
dan oconnor
d3cf046ac7 Lay groundwork for avoiding SGraphPanel refreshes after making a change to a single node by adding a NotifyNodeChanged routine to UEdGraph, currently implemented to just invoke NotifyGraphChanged with no additional context
#rb Justin.Hare, Andrew.Davidson
#preflight 640a9da7d778f88975ed4702
#jira UE-158391

[CL 24601445 by dan oconnor in ue5-main branch]
2023-03-10 20:03:26 -05:00
sara schvartzman
d0e09f3102 Control Rig: Spline from transforms
#jira UE-173015
#preflight https://horde.devtools.epicgames.com/job/6408cb216c1b9295b9b72053

[CL 24573223 by sara schvartzman in ue5-main branch]
2023-03-09 05:29:59 -05:00
helge mathee
2979d9163a GraphEditor: Guard against trashed UEdGraphPins
#rb sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/64076c682559570cc7e26bc4

[CL 24556125 by helge mathee in ue5-main branch]
2023-03-08 04:19:40 -05:00
fpwong
6e286d50d6 PR #10182: Fixed issue where disconnecting an orphan pin would cause ensure to trigger due to invalidated graph pin (Contributed by fpwong)
#rb daren.cheng
#preflight 63ffd09ac00784bee2613638
#jira UE-178491

[CL 24472445 by fpwong in ue5-main branch]
2023-03-01 17:38:58 -05:00
halfdan ingvarsson
a233962e1e Control Rig: Link creation performance improvements
[FYI] benoit.gadreau
#rb sara.schvartzman
#preflight 63ef951f977ceed9151fad2e

[CL 24309702 by halfdan ingvarsson in ue5-main branch]
2023-02-20 02:18:32 -05:00
christopher waters
cad10136bf Removing dependencies on GraphEditor Private by moving GraphActionNode.h to its Public folder.
#preflight 63e159aacf24c08f2c924fb2

[CL 24040429 by christopher waters in ue5-main branch]
2023-02-06 18:06:48 -05:00
christopher waters
fc59298fcd Removing GraphEditor private includes via moving SGraphPinEnum.h to the Public folder.
#preflight 63dd804b1b44ee7cb1851048

[CL 24035653 by christopher waters in ue5-main branch]
2023-02-06 14:21:12 -05:00
Patrick Enfedaque
1ddda77ee7 SGraphNode::PopulateMetaTag : use GetOutermostObject (fixes use case with OFPA Outers)
#jira UE-149481
#rb jeanfrancois.dube, ryan.mangin
#preflight 63c93d868168e8b2529797a8

[CL 23774276 by Patrick Enfedaque in ue5-main branch]
2023-01-19 11:05:15 -05:00
Patrick Boutot
6a2863234b Deprecate arrays from SColorPicker. Memstomp was fixed with 23672712. This CL removed the posibility of creating a new memstomp
#jira UE-173303
#rb daren.cheng
#preflight 63c6034bd040694ab82f3970

[CL 23736262 by Patrick Boutot in ue5-main branch]
2023-01-17 07:24:54 -05:00
Patrick Boutot
6e02de5817 Fix memstomp with color picker. Prepare SColorPicker for API change. Update AssetViewUtilis::PathColors to use FLinearColor instead of shared pointer. The shared pointer was only needed for the SColorPicker.
#jira UE-173303, UE-173454
#review-23672715 23617361,23611673
#rb daren.cheng
#preflight 63c0b12b1a06fc61059f2fa3

[CL 23672712 by Patrick Boutot in ue5-main branch]
2023-01-12 20:33:08 -05:00
phillip kavan
f67d259b19 CIS non-unity fix.
#rb None (trivial)

[CL 23671984 by phillip kavan in ue5-main branch]
2023-01-12 19:09:47 -05:00
phillip kavan
0507c05d34 Extend SGraphActionMenu to allow owners to directly provide the action menu source list at refresh time.
#jira UE-167392
#rb Lauren.Barnes
#preflight 63c075b20225f00e14ab8664

[CL 23671671 by phillip kavan in ue5-main branch]
2023-01-12 18:36:13 -05:00
Andrew Rodham
4ff7bab147 Slate: Initial phase of FVector2D deprecation
- Expanded FDeprecateSlateVector2D to provide structs for parameters, return types and member variables that use FVector2f, while still allowing conversion to/from FVector2d with optional per-module deprecation mechanisms.
  - Many of the high-traffic SlateCore types like FSlateBrush, FGeometry and FSlateLayoutTransform have been converted to use these deprecation mechanisms.
  - Some legacy FGeometry::ToPaintGeometry and MakeChild overloads have been explicitly deprecated since they cause ambiguous overloads with FSlateLayoutTransform if it were to support implicit construction.
  - Deprecated ULocalPlayer::GetPixelBoundingBox and GetPixelPoint to prefer FVector2f for OptionalAllotedSize parameter since this parameter is expected to come from FGeometry
  - Exposed FVector2f members to blueprints

#jira none
#rb Andy.Davidson, Dave.Jones, Vincent.Gauthier, Patrick.Boutot
#preflight 63bc6fd068068a8bd6027c9f

[CL 23631073 by Andrew Rodham in ue5-main branch]
2023-01-10 14:46:43 -05:00
jaime cifuentes
a20a6e0027 Added validation and visual error functionality to AnimNode_SkeletalControlBase, which can be used to check referenced bones and show errors on the AnimGraph nodes that use them (so it is clear if the setup does not work due to a bone missing)
#rb thomas.sarkanen
#jira UE-160111
#preflight 63b85453c927e34482895de4

[CL 23599353 by jaime cifuentes in ue5-main branch]
2023-01-06 12:16:12 -05:00
henrik karlsson
b5164ac775 Fixes to make modules compile with IWYU. We've added to IWYU toolchain so it compiles "orphaned" headers which does not have a owning cpp file. This identified lots of headers that couldn't be compiled by themselves (or if they were to included first)
Change consist of only forward declaration and additional includes

#preflight 63789c1de30d438849c48188
#rb none

[CL 23218412 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:23 -05:00
Dominik Peacock
67b77e36d6 Added replaced hardcoded in SGraphNodeSwitchStatement::IsAddPinButtonVisible with a overridable UK2Node_Switch::SupportsAddPinButton function
Intention: allow us to inherit from UK2Node_Switch and hide the "Add Pin" button

#jira UE-170007
#rb Phillip.Kavan
#preflight 6372321d5368a3230a41e6ec

[CL 23116465 by Dominik Peacock in ue5-main branch]
2022-11-14 07:27:13 -05:00
benjamin jillich
d549c737b8 [UE-169576] Can't insert reroute nodes via double click
#preflight 636ccad97c2b5051905401d1

[CL 23073713 by benjamin jillich in ue5-main branch]
2022-11-10 05:06:04 -05:00
benjamin jillich
a6ef0d5b7f [UE-136096] Relinking transitions in anim graph state machines
[UE-168360] User can create a transition from a state into the entry state

* Relinking multiple transitions (transition nodes at once) when none of the transition nodes is selected.
* Selective relinking in case a subset of the transition nodes on a transitions are selected.
* Special case handling for transitions from entry state (they don't have a transition node connected).
* Drawing circle indicator around the arrow head in case the mouse cursor is approaching the transition.
* Hovering the arrow head of a transition highlights it by filling the circle with solid orange color and turning the arrow black.
* Ending the relink operation in empty space or the entry node will cancel the relink operation.
* Fixed bug that prevents creating new transitions ending in an entry state.

#jira https://jira.it.epicgames.com/browse/UE-136096
#jira https://jira.it.epicgames.com/browse/UE-168360
#preflight 636a169963037c10262bc421

[CL 23025287 by benjamin jillich in ue5-main branch]
2022-11-08 04:09:22 -05:00
Helge Mathee
5867d63b99 Control Rig: Visual representation of casts on connection lines
#rb sara.schvartzman
#jira UE-158186
#preflight https://horde.devtools.epicgames.com/job/63511d888176062ea72f4494

[CL 22653714 by Helge Mathee in ue5-main branch]
2022-10-20 08:55:17 -04:00