#rb dan.oconnor
#preflight 63d83f963656ea96dc2a0a4c
#jira UE-173747
"Crash occurs when scrolling down through files in Review Changelist window upon loading of asset"
- certain widget blueprints were crashing the review tool because we were working around the inability to diff against nullptr by constructing temprorary empty objects. This approach circumvents that problem entirely
#jira UE-173231
"Changelist Review tool allows diffing against previous revision for Deletion changes"
- while this jira suggests that the ability to diff deletion changes is a bug, it was actually an intended feature. The real bug was that it would crash or fail to work in many cases. This has been fixed by either asset diffing against nullptr or text diffing against an empty file (depending on circumstance)
#jira UE-174610
"Reviewing Changelist with Deletion Changes results in LogLinker warnings & LoadErrors"
- deletion changes were trying to load the new revision of files but obviously it doesn't exist because it's a deletion. Fixed by only loading the previous revision
note: since the review tool is going to be "Production Ready" in 5.2, these changes are neccesary for stability
[CL 23924072 by jordan hoffmann in ue5-main branch]
To use that behavior by default you need to set
[/Script/AIModule.AISystem]
bBlackboardKeyDecoratorAllowsNoneAsValue=true
in the configuration file.
#jira UE-104969
#rb mieszko.zielinski
#preflight 63c5775cd040694ab806f6b1
[CL 23729979 by Yoan StAmant in ue5-main branch]
Fix BlackboardDecoratorDetails and BlackboardSelectorDetails
#tests Test FBlackboardDecoratorDetails in editor, rebuild projects
#rb mieszko.zielinski, maxime.mercier
[CL 23020972 by charles lefebvre in ue5-main branch]
Also added none as a selectable option when nones are allowed for blackboard key selectors.
[REVIEW] [at]Nathan.Green, [at]Josh.May, [at]Cory.Kolek, [at]Kris.Pelley, [at]Guillaume.Guay, [at]Guillaume.Morreel, [at]Qian.He
#jira: FORT-505945
[CL 22088577 by jacob dodson in ue5-main branch]
- now using 'StringValue' property instead of 'IntValue' to store value for enum based keys to better support enumeration modifications (e.g. adding/removing values). 'IntValue' is kept in sync since still used for runtime evaluation.
- now using 'IntValue' to store enum value instead of index since runtime arithtmetic operation expects to compare values (bugfix). Also added validation for enumerations with values that could not be properly stored in enum based keys at runtime.
- improved Editor refresh on live UserDefinedEnum modifications
- current approach is to refresh only nodes displayed in the editor and not all loaded nodes. For the other we rely on the initialization when loaded to refresh all descriptions (i.e. InitializeFromAsset). Note that custom version serialization was not possible since we need related types to be loaded and keys to be resolved.
- fixed uninitialized properties in case an enum key is not fully setup (i.e. not pointing to a valid enumeration)
#jira UE-138786
#rb mieszko.zielinski, maxime.mercier
#preflight 62cc48f7604402cc47e56797
#ROBOMERGE-AUTHOR: yoan.stamant
#ROBOMERGE-SOURCE: CL 21043351 via CL 21043388 via CL 21043841
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
[CL 21075275 by yoan stamant in ue5-main branch]
- because the graphs were being diffed in two different ways - once to generate the list and once to determine how to render the nodes, there were some differences in the diff behavior that caused certain nodes to not render as diffed even though they showed up in the list. this change uses the same diff list for both now so there shouldn't be any differences anymore
- This also solves an issue that caused highlighted pins from Blueprint Diff to persist to the blueprint itself. Now all visual modifications made by the diff viewer only appear in the diff panels rather than the main graph
#jira UE-93061
#preflight 62a256ef2469f462fdd9c693
#rb daren.cheng
This change sets up for future style changes allowing for us to render nodes in the diff graph based on their diff type. There are no style changes in this CL however.
[CL 20584624 by jordan hoffmann in ue5-main branch]
