Commit Graph

724 Commits

Author SHA1 Message Date
zousar shaker
3bd034edf7 Add commandline option to enable the "repair" mode for UE Cloud DDC client so that blobs that are missing get re-populated.
#rb devin.doucette

[CL 25027230 by zousar shaker in ue5-main branch]
2023-04-13 12:15:21 -04:00
zousar shaker
3d140963d1 When a deactivation latency limit is defined, make the initial speed test executed by filesystem DDC time limited so we don't spend an inordinate amount of time speed testing if we're just going to deactivate it due to high latency.
#rb devin.doucette

[CL 24831864 by zousar shaker in ue5-main branch]
2023-03-29 02:28:27 -04:00
zousar shaker
2a4b4cdaf5 Change Zen DDC cache store to allow:
- Local storage flag to be inferred by whether the service is run locally or set explicitly in config.
- Remote storage flag to be inferred by whether the service is NOT run locally or set explicitly in config.
- ReadOnly storage flag to be set explicitly in config (defaults to true).

#rb devin.doucette

[CL 24822351 by zousar shaker in ue5-main branch]
2023-03-28 13:43:50 -04:00
devin doucette
72f0249b95 Replaced uses of FLazyEvent with FManualResetEvent
#rb none
#rnx

[CL 24810985 by devin doucette in ue5-main branch]
2023-03-27 18:26:53 -04:00
devin doucette
085d8cd57b Changed complex uses of events to use FEventCount
#rb Zousar.Shaker
#rnx

[CL 24810984 by devin doucette in ue5-main branch]
2023-03-27 18:26:44 -04:00
mark lintott
071272eb3f Formatting Changes to Cook Profiling Telemetry for Grafana. Replaced "." with "_". Bumped SchemaVersion of Cook Telemetry to 2.
Format changes will not have any impact on existing telemetry or analytics dashboards
#rb trivial
[FYI] devin.doucette, zousar.shaker
#preflight 64218253973e6096708e6714

[CL 24802042 by mark lintott in ue5-main branch]
2023-03-27 09:49:14 -04:00
devin doucette
9b540c4c54 Reverted use of FManualResetEvent while investigating an issue
#jira UE-181229
#rb none
#rnx

[CL 24781860 by devin doucette in ue5-main branch]
2023-03-24 12:55:38 -04:00
bob tellez
c248e6e469 [Backout] - CLs 24735827, 24746530, 24750104, 24751543, 24752787, 24753773
[FYI] Devin.Doucette
Original CL Desc
-----------------------------------------------------------------
Added PlatformManualResetEvent

This private abstraction is used to signal a single waiting thread to wake.
This first implementation is only specialized for Microsoft platforms. Other platforms will be specialized later.

#preflight 6418bc6a5d3e25354f1a2a5b
#rb Andriy.Tylychko, Zousar.Shaker

[CL 24773885 by bob tellez in ue5-main branch]
2023-03-23 23:28:45 -04:00
zousar shaker
90749b3b1a DDC: Restored the use of ManualResetEvent by HttpClient
#rb Zousar.Shaker
#rnx

[CL 24771744 by zousar shaker in ue5-main branch]
2023-03-23 20:59:56 -04:00
mark lintott
ad70d0d087 Fix up of Event Attribute names to support Grafana in StudioAnalytics, DerivedData, Zen, Virtualization and CookProfiling. Grafana does not like the . separator so these have been replaced by _. I have checked this with the DPE team ( and verified ) this is still compatible with Snowflake/Tableau telemetry and such will not requires any changes to Snowflake or exisitng Tableau dashboards.
[FYI] wes.hunt, eric.knapik, paul.chipchase, devin.doucette
#rb devin.doucette
#preflight 641c6e31c44ce895fc452a84

[CL 24764989 by mark lintott in ue5-main branch]
2023-03-23 13:43:00 -04:00
zousar shaker
886b2fe9cd Change HttpCacheStoreTest to pass access token rather than OAuth details to Zen intermediary instances. Also ensure that we don't overlap keys for Meta and NoMeta test data.
#rb joakim.lindqvist

[CL 24764335 by zousar shaker in ue5-main branch]
2023-03-23 13:05:19 -04:00
devin doucette
f52cece901 Reverted the conversion of FLazyEvent to FManualResetEvent while investigating an issue
#rb none
#rnx

[CL 24763649 by devin doucette in ue5-main branch]
2023-03-23 12:35:09 -04:00
nick edwards
723c5d5999 Fix C++20 compiler error. Add new equality operator for FCacheBucketOwner to avoid ambiguity when reversing arguments.
bool FCacheBucketOwner::operator==(const FCacheBucketOwner& Other) is new
bool FCacheBucketOwner::operator==(const FCacheBucket& Other) is what it would find ambiguous

#preflight 6419f58b25389270b78540dd
#jira none
#rb none

[CL 24759829 by nick edwards in ue5-main branch]
2023-03-23 06:59:24 -04:00
dan engelbrecht
85b808b153 Accept duplicated file handles in Zen RPC responses
#preflight 641c11bf76461c460b8eabb4
#rb stefan.boberg per.larsson

[CL 24759274 by dan engelbrecht in ue5-main branch]
2023-03-23 05:15:22 -04:00
devin doucette
a37ae60c3e Renamed Signal to Notify in new synchronization primitives
#rb Zousar.Shaker
#rnx

[CL 24756519 by devin doucette in ue5-main branch]
2023-03-22 19:47:20 -04:00
devin doucette
18dfce3eca Added FManualResetEvent
This is a one-byte manual-reset event that can replace that use case for the experimental FLazyEvent.

#rb Zousar.Shaker

[CL 24756514 by devin doucette in ue5-main branch]
2023-03-22 19:47:06 -04:00
devin doucette
b8e64bec92 Added EventCount
This is an event that provides a mechanism for avoiding a race between waiting and signaling through the use of a signal count token.

#preflight 641b44cabb1320be41aad497
#rb Zousar.Shaker

[CL 24756487 by devin doucette in ue5-main branch]
2023-03-22 19:46:13 -04:00
devin doucette
592c55ccc8 DDC: Removed deprecated code
#preflight 6410d4770e1f02786b69ac5a
#rb Zousar.Shaker
#rnx

[CL 24654027 by devin doucette in ue5-main branch]
2023-03-15 10:15:30 -04:00
devin doucette
1a688b31e2 DDC: Fixed Clang static analysis warnings
#jira none
#preflight 640f96f3482188d710688621
#rb Zousar.Shaker
#rnx
#lockdown zousar.shaker

[CL 24643936 by devin doucette in ue5-main branch]
2023-03-14 16:48:35 -04:00
devin doucette
672818b928 StringBuilder: Converted WriteToString from a type to a function
This was not possible on C++14 and is possible now due to guaranteed copy elision in C++17.
This will break backward compatibility when WriteToString was used as a type or in a context where it would be copied.

#preflight 640a0460af3fc3529234c216
#rb Matt.Peters

[CL 24583299 by devin doucette in ue5-main branch]
2023-03-09 17:06:55 -05:00
Dan Thompson
8f55b18fe5 Remove debug logging
#fyi devin.doucette
#rb none
#preflight 6408d546cf5fe1e28cea3c19

[CL 24563734 by Dan Thompson in ue5-main branch]
2023-03-08 13:46:10 -05:00
mark lintott
fe1ee99e15 Fix for DDC and Cook analytics event attributes not being transmitted as numbers to the backend. This allows us to correctly aggregate DDC/Cook values in Grafana.
[FYI] Devin.Doucette, Garry.Casey, Erik.Knapik
#rb trivial
#preflight 63fdf46fef1b24bf940111c1

[CL 24446536 by mark lintott in ue5-main branch]
2023-02-28 13:24:40 -05:00
devin doucette
d802756cf3 DDC: Added logging if legacy requests fail to copy the buffer
Includes a speculative workaround for check(Data.Num()) failing.

#rb Matt.Peters
#rnx

[CL 24412735 by devin doucette in ue5-main branch]
2023-02-24 19:01:05 -05:00
devin doucette
ee3c2bc2fd DDC: Initialized bGetResult in case the callback is somehow missed
#rb none

[CL 24408000 by devin doucette in ue5-main branch]
2023-02-24 15:48:03 -05:00
devin doucette
4b200b0c7f DDC: Added -DDC-VerifyFix to overwrite existing records and values that differ from newly generated records and values
#rb Zousar.Shaker

[CL 24287758 by devin doucette in ue5-main branch]
2023-02-17 14:18:34 -05:00