- Move asset registration to engine module from editor
- Separate call for MetaSound asset manager prime and node class registry prime
- Fix bug causing MetaSound asset editor registration notification to close early
- Make editor asset registration async by default (remove au.MetaSound.Editor.AsyncRegistrationEnabled cvar)
#jira UE-216872
#rb rob.gay
[CL 34544373 by helen yang in ue5-main branch]
- Fixed regression with referencing graphs not updating
#tests AudioQA -cook
[FYI] hilda.cruz
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL34112568 due to autotest error.
#rnx
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
More protections around accessing the wrong builder via the MetaSound builder registry by supplying the TopLevelPath of the asset if available when the registry has multiple conflicting entries due to bad content.
#rb helen.yang
#jira UE-216533
#rnx
[FYI] sondra.moyls
[CL 34125321 by rob gay in ue5-main branch]
#rnx
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
More protections around accessing the wrong builder via the MetaSound builder registry by supplying the TopLevelPath of the asset if available when the registry has multiple conflicting entries due to bad content.
#rb helen.yang
#jira UE-216533
#rnx
[FYI] sondra.moyls
[CL 34114022 by hilda cruz in ue5-main branch]
- Fix-ups for MS AssetManager leaking asset names if not registered by moving to MultiMap
- Fix-up for ResetBuilder call passing off initial delegates properly
- Make builders map mutation thread safe when loading assets async
#rnx
#tests -game, AudioQA, Unit Tests, Automated Tests
#rb phil.popp
#jira UE-194160
[CL 33983705 by rob gay in ue5-main branch]
- Distinguish executing finish call from removal of register's weak pointer entry to avoid leaking stale builder registry entries
- Fix for removal calls to asset registry entries leaking during cook (due to cook package data being stripped when BeginDestroy is called)
- Fix for removing an asset manager entry that hasn't been registered with the node registry not getting removed due to the RegistryGraphKey referenced not being set on AssetBase
- Remove AssetRegistry MetaSoundEditor delegate handlers during cook that aren't used
- Add thread checks for safety to MetaSoundAssetManager
- Add better logging around AssetManager/BuilderRegistry destruction if applied prior to underlying respective entry/entries destruction
#jira UE-212969
#rb phil.popp
#rnx
#tests local AudioQA cook, loading all assets in editor, PIE, -game, automated tests, loading all assets in editor, PIE, -game
[CL 33641926 by rob gay in ue5-main branch]
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls
[CL 33578794 by rob gay in ue5-main branch]
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
Round 2 w/registry validity check
[Backout] - CL33559423
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33551869
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls
[CL 33563652 by rob gay in ue5-main branch]
[Backout] - CL33559423
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33551869
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls
[CL 33560224 by rob gay in ue5-main branch]
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
- Fix for rename ensure regression from AssetManager refactor
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls
[CL 33559463 by rob gay in ue5-main branch]
- Add logging and track case when multiple assets are registered with the AssetManager with the same key for better debugging
- Add ability to force unregistration when request to finish building & utilize on destruction of MetaSound assets
#rb phil.popp
#jira UE-212969
#rnx
[FYI] sondra.moyls
[CL 33551886 by rob gay in ue5-main branch]
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang
#tests EngineTest & AudioQA Automation PIE Packaged Build -game
[CL 33522338 by rob gay in ue5-main branch]
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE
[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159
[CL 33102023 by rob gay in ue5-main branch]
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159
[CL 33096249 by bob tellez in ue5-main branch]
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159
[CL 33085078 by rob gay in ue5-main branch]
- Expose input descriptor so it can be used with future template notes.
- Minor clean-up/nullptr protection in MetaSound Editor
[FYI] phil.popp
#rb helen.yang
#jira UE-194160
[CL 31070520 by rob gay in ue5-main branch]
