Commit Graph

1691 Commits

Author SHA1 Message Date
krzysztof narkowicz
8293c58ceb Fixed crash when multiple views try to run editor selection mesh processor in parallel.
#jira UE-69816
#rb none

#ROBOMERGE-SOURCE: CL 4957050 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4968441 by krzysztof narkowicz in Main branch]
2019-02-12 09:39:53 -05:00
krzysztof narkowicz
6069158c03 Decrease amount of allocations inside mark relevance by prealocating a bit of memory for mesh draw commands.
#rb none
#jira UE-69545

#ROBOMERGE-SOURCE: CL 4949620 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4949624 by krzysztof narkowicz in Main branch]
2019-02-08 13:29:49 -05:00
guillaume abadie
b4f5bd6411 Removes a check() that was missing in 4721425
Repro steps -> disable DOF, and allow alpha channel through post processing in project settings.

#rb none
[FYI] simon.therriault
#jira none

#ROBOMERGE-SOURCE: CL 4948053 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4948054 by guillaume abadie in Main branch]
2019-02-08 11:04:32 -05:00
krzysztof narkowicz
8c40c13ad1 Added STAT_GatherShadowPrimitivesPacket into parallel for.
#rb none
#jira none
#rnx

#ROBOMERGE-SOURCE: CL 4938187 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4938192 by krzysztof narkowicz in Main branch]
2019-02-07 15:58:24 -05:00
krzysztof narkowicz
d705370edb Decrease priority of MeshDrawCommandPassSetupTask, so it doesn't block high priority game thread tasks.
#rb none
#jira UE-69545

#ROBOMERGE-SOURCE: CL 4938064 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4938065 by krzysztof narkowicz in Main branch]
2019-02-07 15:44:07 -05:00
Rolando Caloca
cea6ceff5a Unshelved from pending changelist '4932645':
#CodeReview: rolando.caloca,ben.marsh,cristina.riveron,nick.bullard,nick.penwarden

Merge conflict.
rolando.caloca, please merge this change by hand.
More info at https://robomerge.epicgames.net#RELEASE

/src/ROBOMERGE_RELEASE_Main/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraEmitterInstanceBatcher.cpp - merging //UE4/Release-4.22/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraEmitterInstanceBatcher.cpp#2


--------------------------------------
UE4.22 - Deprecate ENQUEUE_UNIQUE_RENDER_COMMAND_THREEPARAMETER
#rb none
#jira

#ROBOMERGE-SOURCE: CL 4932643 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4932685 by Rolando Caloca in Main branch]
2019-02-07 10:35:08 -05:00
krzysztof narkowicz
8fef79248e Fixed dynamic mesh elements revelance computation.
#rb none
#jira UE-69637

#ROBOMERGE-SOURCE: CL 4932536 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4932538 by krzysztof narkowicz in Main branch]
2019-02-07 10:18:33 -05:00
krzysztof narkowicz
592630c359 Fixed cpu skinning crash. CPU skinning was using a local vertex factory, but we were always providing a primitive uniform buffer for skinned meshes.
Repro:
* Open skeletal mesh in the editor.
* Pick a joint from skeleton tree window.
* Click mesh -> show selected bone weight option.
#rb none
#jira none

#ROBOMERGE-SOURCE: CL 4931518 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4931519 by krzysztof narkowicz in Main branch]
2019-02-07 07:54:45 -05:00
krzysztof narkowicz
10a61ae34f GPUScene update optimization - prevent from update same primitive multiple times.
#jira UE-69545
#rb none

#ROBOMERGE-SOURCE: CL 4924735 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4924737 by krzysztof narkowicz in Main branch]
2019-02-06 17:12:06 -05:00
krzysztof narkowicz
29dc45a193 Fixed out of bounds GPUScene GPU buffer write. PrimitivesToUpdate may contain a stale out of bounds index, as we don't remove update request on primitive removal from scene.
#jira UE-69353
#rb Daniel.Wright

#ROBOMERGE-SOURCE: CL 4923997 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4924001 by krzysztof narkowicz in Main branch]
2019-02-06 15:29:54 -05:00
Bob Tellez
65f5fbe9cf Back out changelist 4898418. Possible cause of Mac cook crash
[FYI] John.White
#rb John.White

#ROBOMERGE-SOURCE: CL 4917353 via CL 4918937

[CL 4921569 by Bob Tellez in Main branch]
2019-02-06 12:52:58 -05:00
Jian Ru
924462f628 Resolve robomerge conflicts
#jira none
#rb none
#fyi chris.bunner, jeff.williams

[CL 4920023 by Jian Ru in Main branch]
2019-02-06 09:46:41 -05:00
allan bentham
190869331d Enable cube scene captures for ES3.1 feature level
#jira UE-68919
#rb none

#ROBOMERGE-SOURCE: CL 4919271 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4919272 by allan bentham in Main branch]
2019-02-06 07:42:14 -05:00
krzysztof narkowicz
ca0d74c680 Added missing dynamic buffer commit when r.DoInitViewsLightingAfterPrepass 0.
#jira UE-68389
#rb none

#ROBOMERGE-SOURCE: CL 4917174 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4917175 by krzysztof narkowicz in Main branch]
2019-02-05 21:43:25 -05:00
zach bethel
595346a455 Fixed crash bug with translucent materials using the SceneDepth node.
#jira UE-69188
#rb krzysztof.narkowicz

#ROBOMERGE-SOURCE: CL 4906799 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4906802 by zach bethel in Main branch]
2019-02-05 18:15:44 -05:00
John White
43c770739d Post Process Histogram Optimizations provided by Sebastien Aaltonen.
#rb ben.woodhouse
#jira 57010

[CL 4906184 by John White in Main branch]
2019-02-05 18:06:21 -05:00
krzysztof narkowicz
75f48366ba InitView optimization. Removed DynamicMeshEndIndices array. This array was walked for every primitive in the scene, even through it was required only for a small subset of them. Namely mesh decals and volumetric density injection primitives. Replaced it with building directly two separate lists - one for mesh decals and one for volumetric primitives.
#jira UE-69545
#rb none

#ROBOMERGE-SOURCE: CL 4906105 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 4906106 by krzysztof narkowicz in Main branch]
2019-02-05 17:54:40 -05:00
Matt Collins
e2da4fd132 Fixes failing depth bounce. Can't bind the Gbuffer to a compute shader if it's bound for writing on the graphics pipe.
#jira UE-69506
#rb none

[CL 4896353 by Matt Collins in Main branch]
2019-02-04 22:44:05 -05:00
Krzysztof Narkowicz
7702bb3e89 Optimized dynamic mesh relevance computation.
#rb none

[CL 4883637 by Krzysztof Narkowicz in Main branch]
2019-02-04 11:15:17 -05:00
Krzysztof Narkowicz
10ee8def1f Fixed rendering corruption and crashes when r.DoInitViewsLightingAfterPrepass 1. This was caused by using FGlobalDynamic(Vertex/Index/Read)Buffer before it was committed (also commit was overlapping the parallel draw cmd list):
* IntiViews
* Dispatch prepass parallel cmd list (flickering, as global buffers weren't committed).
* InitShadows.
* Commit global buffers (race condition and potential crash).

This was fixed by:
* Renamed FNiagaraGlobalReadBuffer to FGlobalDynamicReadBuffer and moved it out from Niagara.
* Removed all global buffer singletons and placed them inside appropriate renderers as static members.
* They are also separated into two - one for InitViews and one for InitShadows, so we can dispatch prepass while writing to the shadow global buffers.
* All global buffers are now passed as a parameter and/or through mesh collector.

#jira UE-69167
#rb Rolando.Caloca
#rnx

[CL 4871865 by Krzysztof Narkowicz in Main branch]
2019-02-01 17:02:33 -05:00
Jules Blok
174f9b2696 Move the InstanceFactor to draw command submission rather than building
#jira UE-69272
#rb Daniel.Wright

[CL 4871742 by Jules Blok in Main branch]
2019-02-01 16:42:04 -05:00
Jules Blok
6a3dca8ac9 Downsampled translucent rendering now also sets the instanced view uniform buffer
#rb Ryan.Vance

[CL 4869192 by Jules Blok in Main branch]
2019-02-01 14:48:50 -05:00
Uriel Doyon
4c8308d1e4 Extended FFXSystemInterface framework to allow custom FX implementations.
NiagaraEmitterInstanceBatcher now derives from FFXSystemInterface and is hooked to the new implementation.
Removed the FComputeDispatcher framework (which was only used for Niagara hooks)
#jira UE-67618
#rb Matt.Collins

[CL 4869109 by Uriel Doyon in Main branch]
2019-02-01 14:31:45 -05:00
Krzysztof Narkowicz
d46e3057bc Removed unnecessary flush inside cascade shadow map rendering.
#rb none
#jira none

[CL 4860862 by Krzysztof Narkowicz in Main branch]
2019-01-31 16:38:46 -05:00
Krzysztof Narkowicz
e82409a4af Fixed FMeshDrawSingleShaderBindings static analysis warning.
#rb none
#jira UE-69378

[CL 4858284 by Krzysztof Narkowicz in Main branch]
2019-01-31 10:04:10 -05:00