#ROBOMERGE-SOURCE: CL 17407272 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)
[CL 17407290 by matt peters in ue5-release-engine-test branch]
#rb Per.Larsson
#rnx
#preflight 61306d9e804b7f00017efc05
- Previously the user requested a none existence graph we'd give an error message about being unable to find the 'LocalStorageHierarchy' entry in the graph, which was a bit misleading as it indicated that the graph existed but was malformed.
- Now we give a clear error message that the graph itself does not exist.
#ROBOMERGE-SOURCE: CL 17400989 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)
[CL 17400991 by paul chipchase in ue5-release-engine-test branch]
#rb Per.Larsson
#rnx
#preflight 612e3045423a8f0001651d93
- The large white space change in the cpp, is to fix a formatting issue introduced in Rev2. I am not sure how the file got so messed up which seems to have happened inbetween the review stage and the submit.
- The debug config option 'ValidateAfterPushOperation' now works when caching data locally inadditon to pushing data to persistent storage.
- Collect profiling data when caching payloads to local storage.
- Add caching statistics to the final log output and the Mirage editor widget although this widget is currently slated to be merged with the DDC widget in the near future.
#ROBOMERGE-SOURCE: CL 17384798 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)
[CL 17384801 by paul chipchase in ue5-release-engine-test branch]
* Adds Source Control Asset Data cache. Preventing Source Control Changelist Window to rebuild AssetData from scratch when UI refresh takes place
* Modifies Source Control beautification to async process, preventing crowded changelists to block the workflow. The filenames are now beautified when available.
* Parallelize AssetData information retrieval from SourceControl
* Updates message displayed when refreshing window's items
#rb Sebastien.Lussier, JeanFrancois.Dube
#jira UETOOL-3522
#changelist validated
#ROBOMERGE-SOURCE: CL 17375288 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)
[CL 17375337 by luc eygasier in ue5-release-engine-test branch]
Add the concept of pre-exploration of dependencies - searching assetregistry or target domain dependencies of the set of requested packages up front, to find all packages that will be cooked and allow us to do asynchronous and batch operations on them.
Convert FRequestCluster into an FPackageData container, holding packages in a substate of EPackageState::Request. This allows us to create a new RequestClusters when we encounter a package that was not found in the initial discovery.
Add hybriditerative mode for iterative cooks; this uses targetdomain keys to check for packages that exist from the previous cook, rather tracing the dependency graph to find all packages that transitively reference packages with modified guids.
Modify AssetRegistryGenerator to use a TMap of iteratively loaded packages that can be edied as packages cook, rather than using a const previous state; this supports hybrid iterative where we do not calculate the list of iterative packages until we encounter them in a request cluster.
#ROBOMERGE-SOURCE: CL 17373295 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)
[CL 17373304 by matt peters in ue5-release-engine-test branch]
#rb Per.Larsson
#rnx
#preflight 612e03f6677f0e000144b652
- Updated the comments to make the methods intent very clear (unload current payloads and prevent future payloads from being loaded from disk)
- Fix an inconsistency with BD2 running from IoStore, where calling ::RemoveBulkData was not preventing future loads in all cases. We now invalidate the PackageID when running from the IoStore in addition to unregistering the filepath token when running from pak files.
- No longer clear the flags when calling ::RemoveBulkData to be consistent with BD1.
- We might want to consider deprecating this method name and using something like ::Reset instead, but that would imply that we would reset all members and I do not see the value in making this much larger change if we do not need to do so.
#ROBOMERGE-SOURCE: CL 17366830 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)
[CL 17366843 by paul chipchase in ue5-release-engine-test branch]
#rb PJ.Kack
#rnx
#jira UE-122149
#preflight 612790e345848f000187730e
- PVS is claiming that delete is being called on a void* which is clearly incorrect (I have confirmed that the correct destructor is being called etc)
- Changing the type in the for loop to auto seems to clear up the confusion, so submitting this as a work around while we reach out to PVS about the false positive.
#ROBOMERGE-SOURCE: CL 17349166 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)
[CL 17349175 by paul chipchase in ue5-release-engine-test branch]
I also fixed it to not crash when just testing, but we could lower the fatal error to a normal/ensure if we want more safety
[CODEREVIEW] michael.noland
#ROBOMERGE-SOURCE: CL 17293185 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)
[CL 17293189 by ben zeigler in ue5-release-engine-test branch]