Commit Graph

3509 Commits

Author SHA1 Message Date
per larsson
de1f9a66f7 COTF: Better lock scope when handling cooked packages (server) and moved subscription to cook-on-the-fly messages (client) when package store is initializing
#rb none
#jira none
#rnx

#ROBOMERGE-AUTHOR: per.larsson
#ROBOMERGE-SOURCE: CL 17469520 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17469527 by per larsson in ue5-release-engine-test branch]
2021-09-09 05:14:16 -04:00
aurel cordonnier
1f5eed93a7 Fixing linux build
[FYI] Jamie.Dale
#rnx

#ROBOMERGE-AUTHOR: aurel.cordonnier
#ROBOMERGE-SOURCE: CL 17463825 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17463839 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-08 17:04:37 -04:00
JakobLarsson-Embark
e30e760271 PR #8378: Fix missing return value in PropertyAccessUtil.cpp, causing FEnumProperty copies to always fail (Contributed by JakobLarsson-Embark)
#jira UE-126142
#rb Jamie.Dale

#ROBOMERGE-AUTHOR: julien.stjean
#ROBOMERGE-SOURCE: CL 17460906 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17460933 by JakobLarsson-Embark in ue5-release-engine-test branch]
2021-09-08 13:43:17 -04:00
carlmagnus nordin
322068f3c8 Implemented FromLocalPath on slimmed down FPackagePath
#jira UE-126031
#rnx
#rb pj.kack

#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 17455754 via CL 17455882 via CL 17455888 via CL 17455889
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v870-17433530)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17455907 by carlmagnus nordin in ue5-release-engine-test branch]
2021-09-08 05:52:40 -04:00
carlmagnus nordin
4bdcc46a5b Undo change 17444582
#rnx

#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 17447855 via CL 17447867 via CL 17447871 via CL 17447872
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v870-17433530)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17447876 by carlmagnus nordin in ue5-release-engine-test branch]
2021-09-07 14:19:59 -04:00
carlmagnus nordin
69dc432e43 Strip unused names from package headers when cooking with unversioned property serialization
#rnx
#rb francis.hurteau

#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 17444582 via CL 17444611 via CL 17444612 via CL 17444613
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v870-17433530)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17444628 by carlmagnus nordin in ue5-release-engine-test branch]
2021-09-07 10:34:14 -04:00
josie yang
742d1c2a03 Morph target engine modifications for 3rd party plugin
[FYI] alexis.matte, brian.white, christopher.waters, mihnea.balta, rolando.caloca, will.damon, halfdan.ingvarsson, kevin.ortegren

#ROBOMERGE-AUTHOR: josie.yang
#ROBOMERGE-SOURCE: CL 17444191 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17444481 by josie yang in ue5-release-engine-test branch]
2021-09-07 10:20:14 -04:00
carlmagnus nordin
a846bdb5ed Fixed crash when trying to convert empty or invalid package paths to filenames
#rb pj.kack
#rnx

#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 17441512 via CL 17441520 via CL 17441525 via CL 17441528
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v870-17433530)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17441531 by carlmagnus nordin in ue5-release-engine-test branch]
2021-09-07 01:31:48 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00
matt peters
452aa4f778 FCoreUObjectDelegates::OnEndLoadPackage: Add broadcast from the early exits in LoadPackageInternal that were missing it.
#ROBOMERGE-SOURCE: CL 17407272 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17407290 by matt peters in ue5-release-engine-test branch]
2021-09-02 15:21:36 -04:00
devin doucette
3d262ca7f0 CompressedBuffer: Removed the FormatName functionality and update its last remaining callers
#rb Paul.Chipchase, Zousar.Shaker
#rnx
#preflight 612feb940380e700016fc8e5

#ROBOMERGE-SOURCE: CL 17403021 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17403035 by devin doucette in ue5-release-engine-test branch]
2021-09-02 10:30:25 -04:00
jeanfrancois dube
b5834e597c Cache all mounted roots in FLongPackagePathsSingleton instead of generating a string array on each calls from various functions in FPackageName.
Greatly reduce temporary memory allocations from callers (worst offender during editor loads was FPackageName::IsValidLongPackageName).

#rb matt.peters
#preflight none

#ROBOMERGE-SOURCE: CL 17401227 via CL 17402199
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17402247 by jeanfrancois dube in ue5-release-engine-test branch]
2021-09-02 09:09:58 -04:00
paul chipchase
a8343f3b85 Mirage will now check for the existence of the requested backend graph in the ini files before attempting to parse it.
#rb Per.Larsson
#rnx
#preflight 61306d9e804b7f00017efc05

- Previously the user requested a none existence graph we'd give an error message about being unable to find the 'LocalStorageHierarchy' entry in the graph, which was a bit misleading as it indicated that the graph existed but was malformed.
- Now we give a clear error message that the graph itself does not exist.

#ROBOMERGE-SOURCE: CL 17400989 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17400991 by paul chipchase in ue5-release-engine-test branch]
2021-09-02 07:43:20 -04:00
pj kack
1af448f9ed AsyncLoading2: Add back missing fileopenlog generation functionality (unintentionally removed in cl 16481564)
#rb carlmagnus.nordin
#preflight none
#rnx

#ROBOMERGE-SOURCE: CL 17399712 via CL 17400415
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17400426 by pj kack in ue5-release-engine-test branch]
2021-09-02 06:07:33 -04:00
paul chipchase
c8c1ad5665 Add profiling data to the Mirage local caching operation.
#rb Per.Larsson
#rnx
#preflight 612e3045423a8f0001651d93

- The large white space change in the cpp, is to fix a formatting issue introduced in Rev2. I am not sure how the file got so messed up which seems to have happened inbetween the review stage and the submit.
- The debug config option 'ValidateAfterPushOperation' now works when caching data locally inadditon to pushing data to persistent storage.
- Collect profiling data when caching payloads to local storage.
- Add caching statistics to the final log output and the Mirage editor widget although this widget is currently slated to be merged with the DDC widget in the near future.

#ROBOMERGE-SOURCE: CL 17384798 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17384801 by paul chipchase in ue5-release-engine-test branch]
2021-09-01 07:03:59 -04:00
matt peters
a5b45baaf7 Fix whitespace merge error.
#rnx
#rb None, trivial

#ROBOMERGE-SOURCE: CL 17376646 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17376685 by matt peters in ue5-release-engine-test branch]
2021-08-31 16:17:24 -04:00
luc eygasier
10d4800ede Rework Source Control Changelist Window?s Asset beautification:
* Adds Source Control Asset Data cache. Preventing Source Control Changelist Window to rebuild AssetData from scratch when UI refresh takes place
* Modifies Source Control beautification to async process, preventing crowded changelists to block the workflow. The filenames are now beautified when available.
* Parallelize AssetData information retrieval from SourceControl
* Updates message displayed when refreshing window's items

#rb Sebastien.Lussier, JeanFrancois.Dube
#jira UETOOL-3522

#changelist validated

#ROBOMERGE-SOURCE: CL 17375288 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17375337 by luc eygasier in ue5-release-engine-test branch]
2021-08-31 15:14:29 -04:00
matt peters
79b61a9d91 Cooker: Hybrid Iterative cooks
Add the concept of pre-exploration of dependencies - searching assetregistry or target domain dependencies of the set of requested packages up front, to find all packages that will be cooked and allow us to do asynchronous and batch operations on them.
Convert FRequestCluster into an FPackageData container, holding packages in a substate of EPackageState::Request. This allows us to create a new RequestClusters when we encounter a package that was not found in the initial discovery.
Add hybriditerative mode for iterative cooks; this uses targetdomain keys to check for packages that exist from the previous cook, rather tracing the dependency graph to find all packages that transitively reference packages with modified guids.
Modify AssetRegistryGenerator to use a TMap of iteratively loaded packages that can be edied as packages cook, rather than using a const previous state; this supports hybrid iterative where we do not calculate the list of iterative packages until we encounter them in a request cluster.

#ROBOMERGE-SOURCE: CL 17373295 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17373304 by matt peters in ue5-release-engine-test branch]
2021-08-31 14:20:48 -04:00
paul chipchase
89bdd7c0e5 Improve the documentation for the bulkdata method ::RemoveBulkData to make it clear that calling it will prevent the bulkdata object from reloading payloads from disk in future.
#rb Per.Larsson
#rnx
#preflight 612e03f6677f0e000144b652

- Updated the comments to make the methods intent very clear (unload current payloads and prevent future payloads from being loaded from disk)
- Fix an inconsistency with BD2 running from IoStore, where calling ::RemoveBulkData was not preventing future loads in all cases. We now invalidate the PackageID when running from the IoStore in addition to unregistering the filepath token when running from pak files.
- No longer clear the flags when calling ::RemoveBulkData to be consistent with BD1.
- We might want to consider deprecating this method name and using something like ::Reset instead, but that would imply that we would reset all members and I do not see the value in making this much larger change if we do not need to do so.

#ROBOMERGE-SOURCE: CL 17366830 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17366843 by paul chipchase in ue5-release-engine-test branch]
2021-08-31 09:00:11 -04:00
paul chipchase
53cdf037d1 CIS: Fix PVS warning in FFormatContainer.
#rb PJ.Kack
#rnx
#jira UE-122149
#preflight 612790e345848f000187730e

- PVS is claiming that delete is being called on a void* which is clearly incorrect (I have confirmed that the correct destructor is being called etc)
- Changing the type in the for loop to auto seems to clear up the confusion, so submitting this as a work around while we reach out to PVS about the false positive.

#ROBOMERGE-SOURCE: CL 17349166 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17349175 by paul chipchase in ue5-release-engine-test branch]
2021-08-30 02:25:55 -04:00
matt peters
6b09dfba92 EditorDomain: Save unversioned properties but not unversioned native.
#rb Francis.Hurteau
#rnx

#ROBOMERGE-SOURCE: CL 17335260 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17335266 by matt peters in ue5-release-engine-test branch]
2021-08-27 11:36:54 -04:00
alex koumandarakis
34f80e4a5a #7871 : PR : Support NetSerialization of FInterfaceProperty
#jira UE-115158, UE-2318
#rb john.barrett, jason.adcock

#ROBOMERGE-SOURCE: CL 17309032 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17309041 by alex koumandarakis in ue5-release-engine-test branch]
2021-08-25 16:37:33 -04:00
carlmagnus nordin
32e4a5213e Implemented a stripped down version of FPackagePath for use outside of the editor in order to save memory
#rnx
#jira UE-120698

#ROBOMERGE-SOURCE: CL 17300999 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17301011 by carlmagnus nordin in ue5-release-engine-test branch]
2021-08-25 08:02:24 -04:00
andrew davidson
ffa1d5ca26 LWC support for FQuat and FTransform
Merge Dev-LargeWorldCoordinates [at] 17289670

#preflight 6125fb6925057900014f2cd6

#ROBOMERGE-SOURCE: CL 17300515 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17300523 by andrew davidson in ue5-release-engine-test branch]
2021-08-25 06:26:44 -04:00
ben zeigler
6c48006477 #jira UE-121495 Don't crash the entire editor when moving a ClassWithin object inside the transient package halfway through cleanup
I also fixed it to not crash when just testing, but we could lower the fatal error to a normal/ensure if we want more safety
[CODEREVIEW] michael.noland

#ROBOMERGE-SOURCE: CL 17293185 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17293189 by ben zeigler in ue5-release-engine-test branch]
2021-08-24 16:42:02 -04:00