Commit Graph

691 Commits

Author SHA1 Message Date
Max Preussner
378b262253 BP: Fixed non-unity build
#CodeReview: jeff.farris

[CL 2499232 by Max Preussner in Main branch]
2015-04-01 18:16:42 -04:00
Max Preussner
b2fbac454d BP: Fixed non-unity build
#CodeReview: jeff.farris

[CL 2499229 by Max Preussner in Main branch]
2015-04-01 18:12:41 -04:00
Dan Oconnor
5ab2dd47de Fix for crash when creating a generic select node with no pin for context (just right click and create a select node)
[CL 2499225 by Dan Oconnor in Main branch]
2015-04-01 18:09:49 -04:00
Mike Beach
9b9b54f208 [UE-12898] Guarding against invalid BP action database objects (ones that were pending deletion) from being registered later with the database.
[CL 2499009 by Mike Beach in Main branch]
2015-04-01 15:47:23 -04:00
Jeff Farris
8f113f658f Added enum-inequality kismet node.
[CL 2498921 by Jeff Farris in Main branch]
2015-04-01 14:53:11 -04:00
Mike Fricker
114458bf0f Clang warning fixes: Fixed missing 'override' specifiers
- Also removed some unreferenced functions that adding 'override' revealed

PR #1002 -- Thank you, Omar007!

[CL 2498415 by Mike Fricker in Main branch]
2015-04-01 07:20:55 -04:00
Maciej Mroz
884dc2ed93 BP: skeletal class is recompiled after Event Node was added
[CL 2498071 by Maciej Mroz in Main branch]
2015-03-31 20:53:58 -04:00
PaulEremeeff
3d878d5a79 PR #996: Fixing PVS-Studio warnings (Contributed by PaulEremeeff)
I have reviewed each change carefully, but it is a large change and I could have missed something! Here is a summary of the types of changes in this CL:
 * Made nullptr checks consistent (the plurality of the changes are of this type)
 * Completed switch statements (IE, switch did not explicitly handle default case, but had unhandled enum entries - this is the second most popular type of fix)
 * Removed unused variables
 * Removed redundant initializations
 * WidgetNavigationCustomization.cpp was fixed by the owner
 * integers converted to floats where result was stored in a float
 * Removed redundent null checks (e.g. before delete statements)
 * Renamed variables to prevent non-obvious shadowing
 * Fixed use of bitwise & when checking for equality to an enum entry (which is often 0)
 * Fixes for some copy paste errors (e.g. FoliageEdMode.cpp)

[CL 2498053 by Dan Oconnor in Main branch]
2015-03-31 20:12:31 -04:00
Michael Schoell
5f3f433198 Can drag and drop pins onto a variety of K2Node_EditablePinBase nodes to add pins to them.
Shifted a lot of pin adding functionality from Blueprint Details customizion to the nodes themselves or BlueprintEditorUtils.

#jira UE-11334 - Dragging a pin to a node that can add pins (function entry/exit, custom events...) should add a pin of the type to the node.

[CL 2497224 by Michael Schoell in Main branch]
2015-03-31 10:32:10 -04:00
Maciej Mroz
57f43e8073 Better fix for UE-12990 Contains node connected to Enum Array value selection cleared on editor restart
[CL 2496601 by Maciej Mroz in Main branch]
2015-03-30 20:08:11 -04:00
Maciej Mroz
ce1e298b63 UE-12990 Contains node connected to Enum Array value selection cleared on editor restart
#codereview Mike.Beach

[CL 2496302 by Maciej Mroz in Main branch]
2015-03-30 17:56:55 -04:00
Michael Noland
6367c98d9f Prevented a few more uses of Pop() from shrinking
[CL 2494798 by Michael Noland in Main branch]
2015-03-27 20:23:08 -04:00
Maciej Mroz
1a22ee9081 UHT error when an property/parameter exposed to BP is not supported by blueprint.
#codereview Robert.Manuszewski, Steve.Robb

[CL 2494269 by Maciej Mroz in Main branch]
2015-03-27 15:02:56 -04:00
Mike Beach
f694f12c43 Making it so we don't drop split pins for array nodes when they're refreshed (which was breaking existing split pin connections).
[CL 2494257 by Mike Beach in Main branch]
2015-03-27 14:53:09 -04:00
Dan Oconnor
ae4723c838 [UE-12083] Fix for function used in async task that was not merged over. We can never compile this, but we shouldn't crash!
[CL 2494153 by Dan Oconnor in Main branch]
2015-03-27 14:07:28 -04:00
Mike Beach
b55ffd99ae Fixing various cook errors. No longer using a ranged for loop when the array node's pins can change during the loop.
[CL 2494148 by Mike Beach in Main branch]
2015-03-27 14:06:20 -04:00
Michael Schoell
ece860ea64 Blueprint Call Function nodes will now display localized function names.
FriendlyName metadata is now deprecated and all uses have been removed, a metadata redirector has been setup.

Changed most/all current instances of FriendlyName metadata over to DisplayName.

#jira UE-12048 - Ability to translate Blueprint node names (UFunction names)

[CL 2494033 by Michael Schoell in Main branch]
2015-03-27 12:54:58 -04:00
Maciej Mroz
60c81ec0fa #ue4 BP local variables are created for unconnected "AutoCreateRefTerm" pins, even when default value is empty.
UE-12595 A struct param marked with AutoCreateRefTerm crashes when running Blueprint

#codereview Mike.Beach

[CL 2493092 by Maciej Mroz in Main branch]
2015-03-26 21:41:40 -04:00
Dan Oconnor
f4d3d65662 PR #968: Fixing PVS-Studio warnings (Contributed by PaulEremeeff)
These can be generally described as removing redundant condition checks, using logical operators instead of bitwise operators, removal of redundant parenthesis, and consistent use of pragma push and pragma pop. There is very little observable behavior change in this CL.

Changes that required further review are pending in 2489753

[CL 2489804 by Dan Oconnor in Main branch]
2015-03-24 15:51:28 -04:00
Mike Beach
d7b2d5c1e2 #ue4 Fix for autocreaterefterm not being properly handled for lists
#codereview Nick.Whiting

[CL 2488349 by Mike Beach in Main branch]
2015-03-23 16:48:53 -04:00
Michael Noland
da5d18f983 Graph Editor: Add a shortcut to create reroute nodes by double-clicking on BP spline connections
[CL 2484035 by Michael Noland in Main branch]
2015-03-18 23:32:57 -04:00
Ben Cosh
601282e843 Added a new graph action filter that restricts level script blueprints properties and functions from being referenced in external blueprints.
#UE-10663 - Prevent creating references to external level functions in sub level and vice versa
#Branch UE4
#Proj BlueprintGraph

[CL 2482915 by Ben Cosh in Main branch]
2015-03-18 08:11:16 -04:00
Jaroslaw Palczynski
28fc7695a0 Missing chages for 2481343.
Some P4V problem with backing out large changelist missed some files.

#codereview Robert.Manuszewski

[CL 2481366 by Jaroslaw Palczynski in Main branch]
2015-03-17 06:17:32 -04:00
Jaroslaw Palczynski
f23f29257b Back out changelist 2481333
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.

#codereview Robert.Manuszewski

[CL 2481343 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:38:32 -04:00
Jaroslaw Palczynski
fa31560e2d Enabled UHT to digest GENERATED_BODY instead of GENERATED_UCLASS_BODY, GENERATED_USTRUCT_BODY, GENERATED_UINTERFACE_BODY or GENERATED_IINTERFACE_BODY, changed every occurence to the new syntax and fixed every warning that have fallen out of this change.
#codereview Robert.Manuszewski

[CL 2481333 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:19:11 -04:00