Commit Graph

4112 Commits

Author SHA1 Message Date
robert manuszewski
0bc5b8e794 Fixing an assert related to null FGCObjectInfo::Class caused by improperly initialized FGCObjectInfo instance
#jira UE-155652
[FYI] Rob.Millar
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20486553 via CL 20486581 via CL 20486606 via CL 20486668 via CL 20487079
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20489201 by robert manuszewski in ue5-main branch]
2022-06-03 13:39:17 -04:00
Per Larsson
3da8d7d7ab Bulk Data - fix bug when calling IBulkDataRequest::GetReadResult() before calling IBulkDataRequest::GetSize()
#jira UE-155629
#rb Paul.Chipchase
#preflight 6299b9cb9e46af6513cd8aa0
#rnx

[CL 20484034 by Per Larsson in ue5-main branch]
2022-06-03 03:57:02 -04:00
robert manuszewski
2ca3c010d9 Removing sizing arguments from format strings in logging macros (TRACE_LOG_MESSAGE inside of UE_LOG does not support them)
[FYI] Halfdan.Ingvarsson
#preflight 6298e7e68f4373181f34fd95
#rb trivial

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20483167 via CL 20483278 via CL 20483378 via CL 20483463
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20483792 by robert manuszewski in ue5-main branch]
2022-06-03 02:40:18 -04:00
matt peters
a630ec1103 AssetRegistry updating during cook: We call InitializeFromExisting on the AssetRegistryGenerator's state at the end of the cook to copy any updates to AssetDatas from loading the packages. When we do this, we need to update all data on the AssetData. Previously we were only updating the AssetData if the tags changed. But the AssetRegistry does not currently handle CoreRedirects, so it is possible for the ClassPath of the AssetData to change when the package loads. Failure to update the ClassPath was causing bugs when using class CoreRedirects.
#rb Johan.Torp, Bob.Tellez
#rnx
#preflight 6298ecee9e46af65139a2132

#ROBOMERGE-OWNER: matt.peters
#ROBOMERGE-AUTHOR: matt.peters
#ROBOMERGE-SOURCE: CL 20475135 via CL 20475141 via CL 20476549 via CL 20476795
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20478759 by matt peters in ue5-main branch]
2022-06-02 19:50:55 -04:00
Devin Doucette
c154ee9fbc DerivedData: Fixed the namespace of GetTypeHash
#jira UE-155447
#preflight 6298d94f5143e4aacd839eb9
#preflight 6298d9bf0360a10c349c2bf1
#rb none
#rnx

[CL 20471890 by Devin Doucette in ue5-main branch]
2022-06-02 13:14:45 -04:00
halfdan ingvarsson
df1d9e0c3d TRACE_LOG_MESSAGE inside of UE_LOG does not support extra sizing arguments for strings.
#jira none
#fyi robert.manuszewski
#preflight 6298db60f269bddede0b3027
#rnx

[CL 20470821 by halfdan ingvarsson in ue5-main branch]
2022-06-02 12:11:12 -04:00
Per Larsson
a97300da1f Bulk Data - remove checking the global GEventDrivenLoader and add support for loading from optional packages
#rb CarlMagnus.Nordin
#jira none
#preflight 62986a87a07cbdb4285b3699

[CL 20469669 by Per Larsson in ue5-main branch]
2022-06-02 10:53:10 -04:00
andrew scheidecker
8b077c03e7 Work around apparently spurious static analysis warning.
#rb Robert.Manuszewski
#preflight none

#ROBOMERGE-AUTHOR: andrew.scheidecker
#ROBOMERGE-SOURCE: CL 20468188 via CL 20468198 via CL 20468200 via CL 20468201
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20469469 by andrew scheidecker in ue5-main branch]
2022-06-02 10:39:45 -04:00
Jerome Delattre
521af3cf39 Avoid running Smoke Tests when running commandlet.
* + Update flags for UObject.Class AttemptToFindUninitializedScriptStructMembers to avoid running on commandlet anyway

#preflight 6297925a2a67820aa6df915a
#rnx
#jira none
#rb Chris.Constantinescu, Geoff.Evans

[CL 20468603 by Jerome Delattre in ue5-main branch]
2022-06-02 09:27:03 -04:00
paul chipchase
c035aeff9f Fix a trivial cast warning
#rb trivial
#rnx
#preflight 6298b09bf03d5783609bb4b8

- FScopedSlowTask expects a float for the amount of work.

[CL 20468216 by paul chipchase in ue5-main branch]
2022-06-02 08:50:17 -04:00
paul chipchase
6fc6b5edac Fix some trivial casting warnings
#rb trivial
#rnx
#preflight 6298ab19ec39fb75f611cead

- Might aswell just bump NumberOfDifferencesInPackages to int64 as ADD_COOK_STAT will turn it into a string and print it to the log as a string anyway.

[CL 20468122 by paul chipchase in ue5-main branch]
2022-06-02 08:33:35 -04:00
matt peters
82f63fe877 Fix thumbnails not loading in editor until the package is loaded. ThumbnailTools::FindCachedThumbnailInPackage and LoadThumbnailsFromPackage are sometimes called with AssetData.GetFullName, and that function has changed to describe the class as a ClassPath instead of a ShortClassName. But package thumbnails are stored by FullName with class described as a ShortClassName. Change Thumbnail tools to convert input to ShortClassName.
#jira UE-155486
#rb Robert.Manuszewski
#rnx
#preflight 6297d5ab7b033c7273aa2721

#ROBOMERGE-OWNER: matt.peters
#ROBOMERGE-AUTHOR: matt.peters
#ROBOMERGE-COMMAND: _robomerge[bot4] UE5-MAIN
#ROBOMERGE-SOURCE: CL 20459973 via CL 20459983 via CL 20460826 via CL 20461155
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v952-20449836)

[CL 20462645 by matt peters in ue5-main branch]
2022-06-01 19:34:37 -04:00
robert manuszewski
9c4e4851a7 Turning off logging when failing to convert short type names when running diff asset registries commandlet
#rb trivial
#preflight 62977312b5519e984b3c04b3

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20457343 via CL 20459049 via CL 20459627 via CL 20460042
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v952-20449836)

[CL 20462533 by robert manuszewski in ue5-main branch]
2022-06-01 19:23:29 -04:00
jeanfrancois dube
a3a212e732 SavePackage: allow generated packages to reference private exports from their source package.
This change is required so we can enable streamed objects having hard references to always loaded actors.

#rb francis.hurteau
#preflight none
#rnx

#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 20454950 via CL 20454986 via CL 20455002
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v952-20449836)

[CL 20460873 by jeanfrancois dube in ue5-main branch]
2022-06-01 18:13:33 -04:00
robert manuszewski
cd55f9a3c3 Per object config sections can now also contain class path names [ObjectName /Script/Module.ClassName] (ANY_PACKAGE removal related)
#rb Matt.Peters, Josh.Adams
#preflight 6297735cb5519e984b3c0cb5

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20453394 via CL 20453404 via CL 20453415 via CL 20453424
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v952-20449836)

[CL 20460740 by robert manuszewski in ue5-main branch]
2022-06-01 18:10:34 -04:00
robert manuszewski
d0867748a3 Fixing a crash when reporting ambiguous FindFirstObject results. The crash was a result of passing *Message.ToString() as ensureMsgf parameter. Also downgrading ambiguous message from an ensure to a warning (thus restoring pre-ANY_PACKAGE removal behavior) in ResolveName and when importing objects from text
#rb Matt.Peters, Francis.Hurteau
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20451914 via CL 20451921 via CL 20451923 via CL 20451924
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v952-20449836)

[CL 20460544 by robert manuszewski in ue5-main branch]
2022-06-01 18:06:26 -04:00
alexander suvorov
bb9dae5753 Do not mark package as dirty when editing CPF_SkipSerialization property.
#rb Marc.Audy
#fyi charles.bloom
#preflight none

[CL 20455565 by alexander suvorov in ue5-main branch]
2022-06-01 14:10:32 -04:00
Devin Doucette
7b4bbf54d4 Temporarily disabled a test on Mac because of issues on CI
#rb none
#rnx
#preflight 6297a73a7b033c7273a75a17

[CL 20455562 by Devin Doucette in ue5-main branch]
2022-06-01 14:09:45 -04:00
Per Larsson
1a72e611cf Bulk data - fix bug when loading bulk data referenced from the original .uasset file
- added additional check that the bulk data is not loading from a referenced .uasset file when using the attached archive
- reverted back to set default Offset value to INDEX_NONE
- removed setting SizeOnDisk when transacting

#rb Paul.Chipchase
#jira UE-155428
#preflight 629759c4e809e387be1a8fc3

[CL 20451384 by Per Larsson in ue5-main branch]
2022-06-01 08:52:47 -04:00
Matt Peters
3c2010d281 AppendToClassSchemaContext: Hide the use of FBlake3 behind an interface so we can easily change it.
#rb Steve.Robb
#rnx
#preflight 62975270a660a44a23b4ac94

[CL 20451128 by Matt Peters in ue5-main branch]
2022-06-01 08:05:42 -04:00
robert manuszewski
9bfc805d98 Fixing non-unity build
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20434539 via CL 20435531 via CL 20435614
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448541 by robert manuszewski in ue5-main branch]
2022-06-01 03:48:09 -04:00
robert manuszewski
08bd51c632 Fixing non unity build
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20434000 via CL 20435526 via CL 20435605
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448518 by robert manuszewski in ue5-main branch]
2022-06-01 03:47:38 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
CarlMagnus Nordin
3d5a2052dc AsyncLoading2: Add support for having multiple PackageStore backends
#preflight 6296fc872a1851b4ccae7e39
#rb pj.kack

[CL 20447121 by CarlMagnus Nordin in ue5-main branch]
2022-06-01 02:12:33 -04:00
Devin Doucette
87340081ea DerivedData: Added a new API in place of the use of IoDispatcher
#preflight 62961234e62c873b96c939d5
#rb Zousar.Shaker

[CL 20445536 by Devin Doucette in ue5-main branch]
2022-05-31 22:01:40 -04:00