Commit Graph

191 Commits

Author SHA1 Message Date
David Lesage
7975f1672f [CADKernel] Multithreading Apply Surface Criteria
#preflight 63e4c1ed7467a6960f88034f

[CL 24094355 by David Lesage in ue5-main branch]
2023-02-09 05:08:40 -05:00
bryan sefcik
16d68d7b4e Updated UHT to support parsing "#if WITH_COREUOBJECT" statements to resolve issues with generated.h includes not being found.
#[fyi] tim.smith

#ushell-cherrypick of 24060136 by bryan.sefcik
#preflight 63e2da35c2257e56f4157b7e

[CL 24062920 by bryan sefcik in ue5-main branch]
2023-02-07 18:40:43 -05:00
David Lesage
bbf78fed5d Refactor FParametricMesher::ApplyFaceCriteria
Move methods from FCriteriaGrid to FTopologicalFace as this is  FTopologicalFace that is updated
#preflight 63ce5ea4f2318350a2b5ac2e

[CL 23809223 by David Lesage in ue5-main branch]
2023-01-23 05:32:49 -05:00
David Lesage
249336b4f0 #jira UE-153614: Meshing of thin faces WIP
Preparatory work: Refactoring ApplyCriteria step by encapsulating all steps of ApplyCriteria in CriteriaGrid methods.
#rb jeanluc.corenthin
#preflight 63c901069f0d23c15ab2e799

[CL 23770894 by David Lesage in ue5-main branch]
2023-01-19 03:48:07 -05:00
David Lesage
615b8fdc18 #jira UE-172956: Meshing of huge face with "Max Edge Length" criterion
In the case of CAD file with huge face, if the file is imported with "Max Edge Length" criterion set, the resulting mesh can be too big. For example, a face of 100,000 mm x 100,000 mm with a "Max Edge Length" of 10 mm will generate a mesh with 2e8 triangles.

A rule is added to disable the "Max Edge Length" criterion if the resulting mesh will be too huge.
#preflight 63c587f80b358b97d13ee660

[CL 23730557 by David Lesage in ue5-main branch]
2023-01-16 12:36:37 -05:00
David Lesage
3aa31eba6e #jira UE-172788 Improve meshing across Iso
Fix Build an optimal InnerToOuterSegmentsIntersectionTool
#rb jeanluc.corenthin
#preflight 63c4fd392e714f64adc8f90a

[CL 23727221 by David Lesage in ue5-main branch]
2023-01-16 02:39:20 -05:00
David Lesage
777c951238 #jira UE-172758 [Topo] Remove duplicated faces
#preflight 63c050b2305002c64179aa6d

[CL 23666484 by David Lesage in ue5-main branch]
2023-01-12 13:37:21 -05:00
David Lesage
65da77f5e2 #jira UE-172758 [Topo] Remove duplicated faces WIP: Add usefull methods in TopologicalEdge and TopologicalFace
#rb jeanluc.corenthin
#preflight 63bf17d9de27f9bc45e4d191

[CL 23652812 by David Lesage in ue5-main branch]
2023-01-11 15:25:37 -05:00
David Lesage
2f62e57cc1 #jira UE-172788 Improve meshing along face loop.
To avoid to create triangle crossing natural iso line (a line carrying iso edges), a test is added to create triangle minimizing the number of intersection with these lines
#rb jeanluc.corenthin
#preflight 63bf0cd56e6e8d46620a4491

[CL 23652042 by David Lesage in ue5-main branch]
2023-01-11 14:56:04 -05:00
David Lesage
b0c054c7bb #jira UE-172788 WIP: Preparatory work allowing to have a suitable tool to check intersection between mesh edges and iso lines of the grid (Step 3): small improvements
#rb trivial
#preflight 63beef34de27f9bc45cff1b8

[CL 23647864 by David Lesage in ue5-main branch]
2023-01-11 12:24:20 -05:00
David Lesage
5f609917e0 #jira UE-172788 WIP: Preparatory work allowing to have a suitable tool to check intersection between mesh edges and iso lines of the grid (Step 2).
- Improve Grid's Nodes typing
- Improve build of InnerToOuterSegmentsIntersectionTool
#rb jeanluc.corenthin
#preflight 63bed656c543a64b7d3d57c8

[CL 23645670 by David Lesage in ue5-main branch]
2023-01-11 10:46:24 -05:00
David Lesage
355ef276ab #jira UE-172788 WIP: Preparatory work allowing to have a suitable tool to check intersection between mesh edges and iso lines of the grid:
- Improve IntersectionSegmentTool
#preflight 63be829768068a8bd69fe120

[CL 23643367 by David Lesage in ue5-main branch]
2023-01-11 04:49:35 -05:00
christopher waters
625952f82e Fixing compile errors from running IWYU on the entire engine.
#preflight 63bdd7d60b7fcef8b01058bd
#lockdown marc.audy

[CL 23635962 by christopher waters in ue5-main branch]
2023-01-10 19:06:13 -05:00
David Lesage
01f5878bc9 Fix typo in variable names
#preflight 63b3edcc8c5081ee9ab40da1

[CL 23564347 by David Lesage in ue5-main branch]
2023-01-03 04:05:15 -05:00
david lesage
1ea371c86e Fix Topomaker
#jira UE-172259
#preflight 6391c22ac709c727569ab9e4
#lockdown jeanmichel.dignard
#rb jeanluc.corenthin

[CL 23448035 by david lesage in ue5-main branch]
2022-12-08 11:49:46 -05:00
Charles deRousiers
9f9607a23f Add IsThinSurface on root node for flagging surface with thin shell (i.e., hollow interrior).
The defines a clear semantic for how thickness of a bottom layer should be handled with Strata. This CL only pipes the data for the various parts. A following CL will add a thickness property on the root node.

#rb none
#jira none
#preflight 638672dd4004f73f62ea9600
#fyi sebastien.hillaire

[CL 23324261 by Charles deRousiers in ue5-main branch]
2022-11-30 02:10:42 -05:00
david lesage
b803246e9a CAD Kernel: Fix crash due to allocation with negative size of TArray
#jira UE-157085
#rb jeanluc.corenthin
#preflight 637f8eb64004f73f627eb724
#lockdown jeanmichel.dignard

[CL 23260355 by david lesage in ue5-main branch]
2022-11-24 11:17:52 -05:00
david lesage
838e10fd88 Empty or Deleted CADKernel Bodies are no more convert into StaticMeshActor
#jira UE-168396
#rb jeanluc.corenthin
#preflight 637ce424170bc34a9385a762
#lockdown jeanmichel.dignard

robomerge[FN_EngineMerge] -UE5-RES

[CL 23243809 by david lesage in ue5-main branch]
2022-11-22 19:50:28 -05:00
Johan Duparc
2395827b7c DatasmithCloth: import Sewing info
- fix reimport data keeping old patterns
- fix usage of reference skeleton API
- skip import of empty clothes (with no patterns) as it causes crashes on asset build
#preflight 6374f53f953c19d435f8f48b

[CL 23153779 by Johan Duparc in ue5-main branch]
2022-11-16 09:54:57 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
david lesage
4c17331d84 [CADKernel] Improve topological welding:
- to try to fix large crack, a second step could be perform with a larger tolerance
- to prevent the meshing failure of thin surface,  and consequently the presence of a crack in the mesh, thin surface can be removed and replaced by a topological weld.
3 new CVar are added to drive this new process:
- ds.CADTranslator.Stitching.ForceSew
- ds.CADTranslator.Stitching.ForceFactor
- ds.CADTranslator.Stitching.RemoveThinFaces

Fix crashes, fix HD leak, fix RAM usage

#jira UE-154019, UE-157085
#rb jeanluc.corenthin
#preflight 6356cd17f92c325024f48f6e
#lockdown jeanmichel.dignard

#preflight 635a9bb00b08a07d8a4310d7

[CL 22810471 by david lesage in ue5-main branch]
2022-10-27 11:07:42 -04:00
Balazs Toereki
eaa943e54b Deleting entities with sub components in revit leaves "ghost" entities fix,
Revit - Deleting array elements will not be synchronized via direct link fix,
Revit - Deleting multiple objects isn't auto synced on Unreal side

#jira UE-166972 UE-166387 UE-165951
#rb JeanLuc.Corenthin
#preflight 6357e0159e14ee3c799c597e

[CL 22752672 by Balazs Toereki in ue5-main branch]
2022-10-25 12:17:13 -04:00
aurel cordonnier
8ed670cea0 [Backout] - CL22695017
[FYI] David.Lesage
Original CL Desc
-----------------------------------------------------------------
[CADKernel] Improve topological welding:
- to try to fix large crack, a second step could be perform with a larger tolerance
- to prevent the meshing failure of thin surface,  and consequently the presence of a crack in the mesh, thin surface can be removed and replaced by a topological weld.
3 new CVar are added to drive this new process:
- ds.CADTranslator.Stitching.ForceSew
- ds.CADTranslator.Stitching.ForceFactor
- ds.CADTranslator.Stitching.RemoveThinFaces

Fix crashes, fix HD leak, fix RAM usage

#jira UE-154019, UE-157085
#rb jeanluc.corenthin
#preflight 6352c5ef7261e565c47ca046
#lockdown jeanmichel.dignard

[CL 22713056 by aurel cordonnier in ue5-main branch]
2022-10-22 17:31:47 -04:00
marc audy
15a4c73b0d [CADKernel] Improve topological welding:
- to try to fix large crack, a second step could be perform with a larger tolerance
- to prevent the meshing failure of thin surface,  and consequently the presence of a crack in the mesh, thin surface can be removed and replaced by a topological weld.
3 new CVar are added to drive this new process:
- ds.CADTranslator.Stitching.ForceSew
- ds.CADTranslator.Stitching.ForceFactor
- ds.CADTranslator.Stitching.RemoveThinFaces

Fix crashes, fix HD leak, fix RAM usage

#jira UE-154019, UE-157085
#rb jeanluc.corenthin
#preflight 6352c5ef7261e565c47ca046
#lockdown jeanmichel.dignard

[CL 22711547 by marc audy in ue5-main branch]
2022-10-22 14:38:08 -04:00
marc audy
927adb79be Correct deprecation versions
#preflight trivial
#rnx

[CL 22573046 by marc audy in ue5-main branch]
2022-10-17 15:13:35 -04:00