Commit Graph

510 Commits

Author SHA1 Message Date
jurre debaare
620b5d6fb1 Fixed bone index handling in UE::Anim::Attributes::MirrorAttributes
#misc handle deprecation path
#ushell-cherrypick of 23897026 by David.Bollo
#jira UE-175745
#preflight 63dbb97eba4fadeef04e9df2
#rb thomas.sarkanen

[CL 24053916 by jurre debaare in ue5-main branch]
2023-02-07 13:42:31 -05:00
halfdan ingvarsson
5a824b0c77 Pose Driver: Fix a crash when trying to dereference with an invalid bone id.
#jira UE-175830
#rb kiaran.ritchie
#preflight https://horde.devtools.epicgames.com/job/63dae2794965eb8c33d0e575

[CL 23984132 by halfdan ingvarsson in ue5-main branch]
2023-02-02 18:45:11 -05:00
bob tellez
f27f2bd3d5 #UE Add a little info to a warning to help identify which AnimNode_LookAt has an invalid axis
[CL 23888382 by bob tellez in ue5-main branch]
2023-01-27 14:14:53 -05:00
nick brett
c339d7a6be [UE] Add ECVF_Scalability flag to p.RigidBodyNode and p.ClothPhysics CVars
- This will allow the ''Preview Rendering Level' setting in editor to set the CVars to the values defined in platform device profiles.

#rb [at]Benn.Gallagher, [at]Ben.Woodhouse

[CL 23741214 by nick brett in ue5-main branch]
2023-01-17 13:13:07 -05:00
lucas dower
754b4db91d Disabled 'resync to sync group' for sequence and blend space evaluators as they generally want to be driven with explicit time
#jira UE-170739
#rb thomas.sarkanen
#preflight 63beab6c68068a8bd6a85251

[CL 23644177 by lucas dower in ue5-main branch]
2023-01-11 07:43:54 -05:00
jaime cifuentes
65b892d517 Fix for CIS LocText at AnimNode_SkeletalControlBase
#jira UE-173721
#rb trivial
#preflight 63bd9123577437afe6528ae8

[CL 23628016 by jaime cifuentes in ue5-main branch]
2023-01-10 11:41:38 -05:00
jaime cifuentes
a20a6e0027 Added validation and visual error functionality to AnimNode_SkeletalControlBase, which can be used to check referenced bones and show errors on the AnimGraph nodes that use them (so it is clear if the setup does not work due to a bone missing)
#rb thomas.sarkanen
#jira UE-160111
#preflight 63b85453c927e34482895de4

[CL 23599353 by jaime cifuentes in ue5-main branch]
2023-01-06 12:16:12 -05:00
Bryan sefcik
80f80e7a25 Updated the underlying types for regular and namespaced enums.
#jira
#preflight 638e6d479549ddaa2822be9a

[CL 23421568 by Bryan sefcik in ue5-main branch]
2022-12-06 19:43:59 -05:00
thomas sarkanen
50e0c0e527 Fixed graph based sync not working correctly when a sync point does not specify a sync group name
Even with a name of 'None', a sync point (FAnimSyncGroupScope - such as that on a blend space graph) would forward for syncing to the proxy, bypassing any other valid rootwards sync scopes.
This change prevents adding the sync messages completely if their name is 'None', ensuring that outer scopes correctly receive the tick record.

#jira UE-170408
#rb Jurre.deBaare
#preflight 63877bed7b4bd3f057134e25

[CL 23352692 by thomas sarkanen in ue5-main branch]
2022-12-01 10:33:57 -05:00
chris caulfield
cd0fbfbe92 Chaos - fix RBAN SimulationSpace force transfer when using Bone-Space mode and scaling to zero
[FYI] frederick.lupien
#rb none
#preflight 637d5681815e4b9b7578ee75

[CL 23244705 by chris caulfield in ue5-main branch]
2022-11-22 20:28:51 -05:00
bryan sefcik
4b8a83790a Updated to use UE_INLINE_GENERATED_CPP_BY_NAME.
#jira
#preflight 637c388f170bc34a93587526

[CL 23244381 by bryan sefcik in ue5-main branch]
2022-11-22 20:17:33 -05:00
Nicholas Frechette
e97561501f Add warning and bind pose when mirroring additive animations
#jira UE-169357
#rb Thomas.Sarkanen
#preflight 637cf12f4004f73f62b31f5d

[CL 23236215 by Nicholas Frechette in ue5-main branch]
2022-11-22 11:03:35 -05:00
Chris Caulfield
2f240b0614 Fix RBAN TeleportPhysics handling
This fixes a character movement related issue where walking into a moving kinematic object would stop the RBAN nodes from simulating altogether because the moving kinematic moves the movement component which triggers a TeleportPhysics.

#rb benn.gallagher, satchit.subramanian
#jira none
#preflight 6376a411fa348e8480775c8b

[CL 23184228 by Chris Caulfield in ue5-main branch]
2022-11-17 16:47:48 -05:00
thomas sarkanen
a897f0439a Skeleton compatibility improvements
Skeleton compatibility is now bi-directional. Specifying a compatible skeleton A -> B now implies B -> A.
Skeleton compatibility is now an editor-only concern. The runtime will attempt to do the 'best it can' via name -> name mappings. Only the editor will prevent assigning incompatible skeletons in (e.g.) asset pickers etc.
Skeleton compatibility checks in editor can now be disabled in the editor preferences (and each asset picker now has a checkbox option in its view settings that allows for quick access to this).

Moves FSkeletonRemapping to its own file (which is now private).
Skeleton remappings are now generated on demand on worker threads just before animation decompression and stored in a registry, guarded by FRWScopeLock for thread-safety.

Fixed some anim BP compiler edge cases where asset references on pins were not getting preloaded correctly, causing skeletons to be erroneously reported as missing.

Exposed the current asset registry filter in SAssetView so that menu extensions can access it (and use it to provide context)

#jira UE-166054
#jira UE-167355
#rb Jurre.deBaare,John.vanderBerg
#preflight 635902602e6690262afa86f9
#preflight 6372ad7a0c74adb48b472b38
#p4v-cherrypick 22878911
#preflight 6374b3c51d25fe8b931b8d7b

[CL 23152671 by thomas sarkanen in ue5-main branch]
2022-11-16 07:21:38 -05:00
henrik karlsson
d5026d4d83 Strategical submit which adds includes in preparation for coming change which removes includes in headers
#preflight 636531a1581dc906bce283d1
#rb none

[CL 22994620 by henrik karlsson in ue5-main branch]
2022-11-04 16:37:48 -04:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
Mike Zyracki
891737c14e Manual Merge of Sequencer: NLA Fixes. Default to transform the start transform offset in local bone space and not in root space, this will make the manipulation of the offset much more predictible, changed the edit mode to handle this coordinate space change.
When use the first child option we now find the first child with animation, FN rigs and 3rd party rigs may not have the animation on the first child of the root.
Don't draw virtual bones when drawing skeleton and use default bone rendering.
Just dirty root motion cache on changes.
Passing in the PreviousTransform to the anim proxy, this is just wip for the refactor to remove the root motion caching.
#jira UE-167374
#jira UE-167371
#jira UE-167991
#preflight 63603b41d13ad22d722ee5b4
#rb max.chen

[CL 22889771 by Mike Zyracki in ue5-main branch]
2022-11-01 15:48:30 -04:00
daren cheng
f6c564b03b Address multiple typos for UEFN localization
#jira UE-166004 UE-168317
#rb Robb.Surridge
#preflight 6360165b7e083afb290e187f

[CL 22889284 by daren cheng in ue5-main branch]
2022-11-01 15:30:54 -04:00
Thomas Sarkanen
d9c2b172f7 Skeleton compatibility improvements
Skeleton compatibility is now bi-directional. Specifying a compatible skeleton A -> B now implies B -> A.
Skeleton compatibility is now an editor-only concern. The runtime will attempt to do the 'best it can' via name -> name mappings. Only the editor will prevent assigning incompatible skeletons in (e.g.) asset pickers etc.
Skeleton compatibility checks in editor can now be disabled in the editor preferences (and each asset picker now has a checkbox option in its view settings that allows for quick access to this).

Moves FSkeletonRemapping to its own file (which is now private).
Skeleton remappings are now generated on demand on worker threads just before animation decompression and stored in a registry, guarded by FRWScopeLock for thread-safety.

Fixed some anim BP compiler edge cases where asset references on pins were not getting preloaded correctly, causing skeletons to be erroneously reported as missing.

Exposed the current asset registry filter in SAssetView so that menu extensions can access it (and use it to provide context)

#jira UE-166054
#jira UE-167355
#rb Jurre.deBaare,John.vanderBerg
#preflight 635902602e6690262afa86f9

[CL 22878911 by Thomas Sarkanen in ue5-main branch]
2022-11-01 06:25:59 -04:00
danny chapman
db0ddc7121 Fixes for LookAt AimOffset:
* Lets" ShowDebug Animation" work
* Lets input filtering work
* Allows the source/pivot to be a bone or socket

#jira UE-168456
#rb thomas.sarkanen
#preflight 635be2d44710dd6af8a44d77

[CL 22828729 by danny chapman in ue5-main branch]
2022-10-28 11:00:57 -04:00
henrik karlsson
4a5e13525d Fixed non-unity non-pch compile errors
#preflight skipped
#rb none

[CL 22788359 by henrik karlsson in ue5-main branch]
2022-10-26 16:22:34 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
jaime cifuentes
39bb9b978b Truncation fixes for AnimationGraphRuntime module
#rb @thomas.sarkanen
#jira UE-166634
#preflight 63591a0a764df4711e65c76e

[CL 22776099 by jaime cifuentes in ue5-main branch]
2022-10-26 07:34:18 -04:00
halfdan ingvarsson
8db044c033 PoseDriver: Remove ensure() if a curve doesn't exist. This can happen when using compatible skeletons that don't have any of the curves needed by the pose driver. The othe Pose* anim nodes behave the same way, silently ignoring missing curves.
#rb mike.beach
#lockdown mike.beach
#rnx

[CL 22758951 by halfdan ingvarsson in ue5-main branch]
2022-10-25 15:36:27 -04:00
dbsigurd
2bda05bfbb PR #8537: exposing composite anim sequences to random player (Contributed by dbsigurd)
#jira UE-132756, UE-132483
#rb Thomas.Sarkanen
#preflight 63581ff10c6e894555b01b8f

[CL 22755729 by dbsigurd in ue5-main branch]
2022-10-25 13:54:36 -04:00