Commit Graph

58 Commits

Author SHA1 Message Date
sara schvartzman
9bb11b3acf Control Rig: Simplify template functionality
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/63ecc343f36e1a5ecea548a4

[CL 24228066 by sara schvartzman in ue5-main branch]
2023-02-15 07:03:25 -05:00
Helge Mathee
7eb666ee61 RigVM: Array Dispatches
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/639353040236bc17ce9f635f

[CL 23565632 by Helge Mathee in ue5-main branch]
2023-01-03 09:23:55 -05:00
Helge Mathee
757be16673 RigVM: New if and select dispatches
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6386265cd76995cb1446c8d7

[CL 23324649 by Helge Mathee in ue5-main branch]
2022-11-30 04:26:41 -05:00
Helge Mathee
b14a5a7e8b RigVM: deprecate branch node
#rb benoit.gadreau
#jira na
#preflight https://horde.devtools.epicgames.com/job/637e33cd8b12eb83a725c609

[CL 23250172 by Helge Mathee in ue5-main branch]
2022-11-23 11:09:03 -05:00
sara schvartzman
418995e257 Control Rig: Save public function access in model
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/637d0795fa348e8480e243b8

[CL 23246827 by sara schvartzman in ue5-main branch]
2022-11-23 04:49:43 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
sara schvartzman
6bdfee452f Control Rig: Fix undo delete select node fails
#jira UE-150210
#rb helge.mathee
#preflight 6332e99c1003050806d94067

[CL 22232136 by sara schvartzman in ue5-main branch]
2022-09-28 17:54:41 -04:00
bryan sefcik
0beee50b45 Updated ../Engine/Source/Developer/... to inline gen.cpp files
Before:
Total CPU Time: 53783.640625 s
Total time in Parallel executor: 558.66 seconds
After:
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

#jira

[CL 22173145 by bryan sefcik in ue5-main branch]
2022-09-24 13:31:25 -04:00
jamie dale
9f2519d7f3 Fixed non-unity build
#preflight skip
#rb none
#rnx

#ROBOMERGE-OWNER: jamie.dale
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21277722 via CL 21285961 via CL 21285981 via CL 21286112
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21290435 by jamie dale in ue5-main branch]
2022-08-09 12:16:16 -04:00
sara schvartzman
f0c793ff54 Control Rig: Fix crash when undo/redoing paste of library node with bounded variables
#jira UE-159285
#rb helge.mathee
#preflight 62d5a98aaf68cd745b23556b
#robomerge FNMain

[CL 21161253 by sara schvartzman in ue5-main branch]
2022-07-19 09:14:23 -04:00
sara schvartzman
eec59437e9 Control Rig: Collapse nodes with templates
#jira UE-146929
#rb helge.mathee
#preflight 62ced5dbd00f3c208e47c183

[CL 21089290 by sara schvartzman in ue5-main branch]
2022-07-14 06:53:37 -04:00
Helge Mathee
3d20407084 RigVM: Refactor template type system to rely on integers rather than string comparisons
* Switching the FRigVMTemplateArgumentType to be backed up by FName instead of FString for faster comparison
* Adding a "Types" storage under the RigVMRegistry of all of the known supported types
* Have the FRigVMTemplateArgument refer to type indices rather than full type structures
* Have the resolval comparison code rely on comparing type indices rather than type structures
* Store relationship between the bool and the TArray<bool> type as an array / element lookup within the registry - to avoid string operations when doing lookups from element to array to 2 dimensional array for a type.
* The preferred types list on the template node is now stored as pairs of argument name and type index <FName, int32> rather than FString.
* Also we no longer support all types for the untyped nodes (such as reroute, select, if etc) - but instead we support all user defined types (non-native structs and enums) as well as all types ever used as a template argument. The reasoning here is that supporting a type that's not used by any node is pointless. This reduced the type set from 9876 to 237.

#rb halfdan.ingvarsson
#jira na
#preflight https://horde.devtools.epicgames.com/job/62b9c666ba62f4498a345be2

[CL 20861728 by Helge Mathee in ue5-main branch]
2022-06-28 13:41:23 -04:00
sara schvartzman
d56d1f11b5 Control Rig: Fix unit test with undo/redo not passing
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629f56e085333f26644b81da

[CL 20537746 by sara schvartzman in ue5-main branch]
2022-06-07 10:33:38 -04:00
sara schvartzman
8759985e82 Control Rig: Fix undo deletion of template node not working
#jira UE-155296
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629e3b34ed51827842318c6b

[CL 20534600 by sara schvartzman in ue5-main branch]
2022-06-07 04:52:58 -04:00
Helge Mathee
0edf08d7f8 RigVM: Invoke Entry functionality for the model
#rb benoit.gadreau
#jira UE-153498
#preflight https://horde.devtools.epicgames.com/job/629733a2ed7762ca42de8245

[CL 20450402 by Helge Mathee in ue5-main branch]
2022-06-01 05:56:08 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Helge Mathee
d4934bf859 Control Rig: Allow change pin types on wildcard pins
#rb na
#jira na
#preflight skip

[CL 20430758 by Helge Mathee in ue5-main branch]
2022-05-30 10:01:57 -04:00
sara schvartzman
ed571628f5 Control Rig: Filtered permutations for template nodes
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62769cbe75268b4ace10dc69

[CL 20101111 by sara schvartzman in ue5-main branch]
2022-05-09 07:34:28 -04:00
Helge Mathee
0cb1b899f7 Control Rig: Fix crash during undo / redo
#rb sara.schvartzman
#jira UE-147278
#preflight https://horde.devtools.epicgames.com/job/6245e0fbf4217035fa8d02f0

[CL 19585547 by Helge Mathee in ue5-main branch]
2022-04-01 04:36:14 -04:00
sara schvartzman
4e0eb3f007 Control Rig: Do not allow functions with wildcards
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62449133c51908059aaf4652

[CL 19570679 by sara schvartzman in ue5-main branch]
2022-03-31 05:28:05 -04:00
sara schvartzman
c7b0e74c59 Controlr Rig: UI implementation of Aggregate nodes
#jira UE-146928
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62433ef7dc6183e3f5e500dc

[CL 19554694 by sara schvartzman in ue5-main branch]
2022-03-30 05:21:45 -04:00
sara schvartzman
256ad8d9ef Control Rig: Add aggregate node
#jira UE-146926
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/623b5f4ada56b5683a0b05b7

[CL 19524901 by sara schvartzman in ue5-main branch]
2022-03-28 05:56:56 -04:00
sara schvartzman
4080ae8f74 Control Rig: Deprecate URigVMGraph::GetVariableDescriptions
#jira UE-143286
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62336d5684667926da2830dc

[CL 19433944 by sara schvartzman in ue5-main branch]
2022-03-18 07:41:19 -04:00
Helge Mathee
63e119a364 Control Rig: Further template node workflows
Implemented unresolve as well as re-resolve node on already typed pins
Added UI in contextual menu to re-type pins

#rb sara.schvartzman
#jira UE-125892
#preflight https://horde.devtools.epicgames.com/job/622f488f505788e09ffffbe4

[CL 19372564 by Helge Mathee in ue5-main branch]
2022-03-14 10:19:31 -04:00
Helge Mathee
4cc75cf9a5 RigVM: Node upgrade functionality
As part of debugging the last unit test I've added functionality to support debugging of the ActionStack. The controller is now able to upgrade a node as per user interaction. next up I'll integrate this into the user interface.

#rb sara.schvartzman
#jira UE-141505
#preflight https://horde.devtools.epicgames.com/job/6226280ca71867308f24c641

[CL 19286305 by Helge Mathee in ue5-main branch]
2022-03-07 12:07:36 -05:00