Commit Graph

11869 Commits

Author SHA1 Message Date
yuriy odonnell 095c4ceee5 ShaderMinifier - Add experimental CFLAG_RemoveDeadCode to run shader rewriting step that removes unused functions and types from shader source before compilation to improve compile times
#rb Jason.Nadro
#preflight 632e0ecae23e50651ba4c5a0

#ushell-cherrypick of 21900443 by Yuriy.ODonnell
#ushell-cherrypick of 21931128 by Yuriy.ODonnell
#ushell-cherrypick of 22029907 by Yuriy.ODonnell
#ushell-cherrypick of 22036834 by Yuriy.ODonnell

[CL 22173105 by yuriy odonnell in ue5-main branch]
2022-09-24 13:27:11 -04:00
sebastien lussier 21dc3e393c Merge Actor: Fixed incorrect MeshDataIndex stored as the key to the MeshDataAwaitingResults map
#rb patrick.enfedaque

[CL 22165310 by sebastien lussier in ue5-main branch]
2022-09-23 20:45:24 -04:00
sebastien lussier 4c65a049b9 Detect failure of global UV remap and avoid a crash accessing the empty GlobalTextureCoordinates array
#rb patrick.enfedaque

[CL 22165253 by sebastien lussier in ue5-main branch]
2022-09-23 20:44:11 -04:00
zak middleton cab8a68724 #ue5 - Fix truncation warnings in modules: DeviceProfileServices, FieldSystemEngine, FontEditor, FunctionalTesting. Includes some related engine fixes as well.
#jira UE-160832
#rb Andrew.Davidson, Dave.Jones2
#preflight 632cbdc17b582f58ab6315ad

[CL 22164453 by zak middleton in ue5-main branch]
2022-09-23 20:23:56 -04:00
rob krajcarski 5e02132d25 Fixes to niagara VM bytecode generation for if blocks where a variable is assigned and then used within the same block
if (Condition)
{
  Foo = Bar;	// this would have been replaced with:	branch_flattened_temp0 = Bar;
  Foo2 = Foo;	// this would have been replaced with:	branch_flattened_temp1 = Foo; this should have been replaced by:
				branch_flattened_temp1 = branch_flattened_temp0;
}
#jira UE-164327
#rb simon.tovey
#preflight 632ddb75e23e50651b95cca4

[CL 22164425 by rob krajcarski in ue5-main branch]
2022-09-23 20:23:13 -04:00
paul chipchase 623ba6cc9e The source control settings for the VA source control connection are no longer saved to a local ini file.
#rb Per.Larsson
#jira UE-163834
#rnx
#preflight 632d98e4b4515b7e221654ec

### Virtualization
- At the moment there is no way in the editor UX to change the source control settings for the source control backend, so what ever settings are found in the global environment would be applied when the editor is first run and then saved to a config file under the <saved> directory. From this point onwards those settings would always be used when setting up the source control backend. If the settings were wrong, the first time that the editor was started, then we'd continue to use the incorrect settings even if the global enviroment was fixed. Making the backend work at that point would require that the user know about the local ini file and change the settings there.
- We cannot fix this by just ignoring the ini file as it has been requested that users can add their settings there in case they want to customize things, so we just need to avoid saving to it.
- Added documentation to the source control backends header file on how to set up the ini file if needed.

### Perforce
- FSourceControlInitSettings now accepts EConfigBehavior which describes how we want the source control provider to deal with its settings with regards to the ini file.
- Note that EConfigBehavior is not a bitfield as we do not wish to support only writing to the ini file, there is no point if it cannot be read from.
- When the source control provider is creatred we pass on the into from EConfigBehavior to the FPerforceSourceControlSettings to enable/disable saving and loading.

[CL 22163769 by paul chipchase in ue5-main branch]
2022-09-23 20:05:59 -04:00
sara schvartzman a41c9937d6 Control Rig: Fix add link between array and element of Select values does not resolve select pin correctly
#jira UE-164187
#rb jack.cai
#preflight 632c656cd747fe52c84bf0c4

[CL 22163592 by sara schvartzman in ue5-main branch]
2022-09-23 20:01:01 -04:00
Devin Doucette 6c0a4f9cc8 DDC: Added a check for non-zero size in the legacy cache
#jira UE-160573
#preflight 632dd4517b582f58abb80f63
#rb Zousar.Shaker
#rnx

[CL 22157364 by Devin Doucette in ue5-main branch]
2022-09-23 13:12:14 -04:00
Devin Doucette c9aa2452df DDC: Allow both OAuthProvider and OAuthProviderIdentifier to be used in the same configuration for HttpCacheStore
- At least one of OAuthProvider, OAuthProviderIdentifier, or OAuthAccessTokenEnvOverride must be set.
- If only OAuthAccessTokenEnvOverride is set, then the environment variable must be set too.
- If only OAuthProvider is set, then OAuthSecret must be set too.
- If OAuthProvider is set, then OAuthClientId must be set.

#preflight 632d2eab10030508069b36c8
#rb Zousar.Shaker

[CL 22155720 by Devin Doucette in ue5-main branch]
2022-09-23 11:32:36 -04:00
charles bloom b9e9f6f818 TextureCompressorModule.cpp fix incorrect check in MaxTextureResolution resize on nonpow2 textures
eg. triggered if source size = 2049 and you set MaxTextureResolution=2048

#rb none
#preflight none

[CL 22148359 by charles bloom in ue5-main branch]
2022-09-22 18:59:47 -04:00
alexis matte 227227d8d7 Make Interchange always on by default
#jira none
#rnx
#rb jeanmichel.dignard
#preflight 632ca990e23e50651b4caa08

[CL 22148323 by alexis matte in ue5-main branch]
2022-09-22 18:58:24 -04:00
paul chipchase 22846ad455 The VA changelist stamp should only be applied if the VA process actually ran and was not disabled.
#rb Sebastian.Nordgren
#jira UE-164748
#rnx
#preflight 632c54367b582f58ab34cc7f

[CL 22147082 by paul chipchase in ue5-main branch]
2022-09-22 18:06:58 -04:00
paul chipchase 7f9d6e3d01 Added cvar 'VA.AllowPkgVirtualization' which can dynamically enable/disable the virtualization process in the editor without restarting.
#rb Per.Larsson
#jira UE-164278
#rnx
#preflight 63284a248c3def91aa62bd83

- This replaces the old cvar 'VA.DisableVirtualization' which is being removed.
- We will log each time the value is switched to aid in future debugging.
- The name needed to be changed as we needed to invert how it worked, also "DiableVirtualization" was a bit misleading and made people think it turned the entire system off, not just the process of virtualizing packages on submit.
-- The member bEnablePayloadVirtualization was also renamed to bAllowPackageVirtualization to make its purpose clearer.
- The cmdline version was changed from 'VA-DisableVirtualization' to 'VA-SkipPkgVirtualization' for similar reasons.

[CL 22146910 by paul chipchase in ue5-main branch]
2022-09-22 18:02:50 -04:00
sebastien lussier eee3b3a139 Material Baking - Default initialize FMeshData::TextureCoordinateBox() to (0,0) (1,1)
#rb patrick.enfedaque
#preflight skip

[CL 22146075 by sebastien lussier in ue5-main branch]
2022-09-22 17:43:14 -04:00
thomas sarkanen 75fa129f4f Fix animation blueprint interface being displayed in asset creation menu instead of animation blueprints
Also rename animation blueprint interface to animation layer interface

#jira UE-164673
#rb Jurre.deBaare
#preflight 632c5cdeb4515b7e22c5f528

[CL 22145748 by thomas sarkanen in ue5-main branch]
2022-09-22 17:35:08 -04:00
Brandon Schaefer 3e98eb1e5e Prevent trying to remove output device while in a signal handling from this callback which is no longer logging during a crash anymore
#jira UE-149024
#rb Devin.Doucette
#preflight none

[CL 22144985 by Brandon Schaefer in ue5-main branch]
2022-09-22 17:08:12 -04:00
ionut matasaru e4428dbfc3 [Insights] Fixed ensure failing in ContextSwitches analyzer for server traces with -nothreading. When -nothreading is used, multiple fake threads (FFakeThread) are created from the game thread. These will have same trace ThreadId == 2 and different SystemThreadId.
#jira UE-159970
#rb Catalin.Dragoiu
#preflight 632c39ac7b582f58ab2e74b6

[CL 22144804 by ionut matasaru in ue5-main branch]
2022-09-22 16:57:46 -04:00
David Harvey 585d290ca0 remove warning about missing utoc files when generating patches.
- the default ordering is deterministic based on which packages are being imported so the warning is not appropriate for all circumstances.

#jira UE-164729
#rb CarlMagnus.Nordin
#rnx
#preflight 632c447b100305080652a7c0

[CL 22134373 by David Harvey in ue5-main branch]
2022-09-22 07:24:13 -04:00
Jurre deBaare 4c2ec2f4d1 Manual integration/reimplementation of CL 22091342:
Preinfintiy and Postinfinity settings within the Curve Editor of an Animation can not be changed from Constant
#feature added API for setting curve attributes (pre/post extrapolation)
#misc added tests for new API
#jira UE-163181
#preflight 632b346cd747fe52c8df8811
#rb none

[CL 22133564 by Jurre deBaare in ue5-main branch]
2022-09-22 04:50:26 -04:00
jason nadro 5ec1160356 Adding Total Thread Preprocess Time for shader compilation.
- Instrument how long shader preprocessing takes for each shader compilation job.
- Keep a running total in our shader stats per shader type.
- Add logging to track total thread preprocessing time for all shaders.
- Fixup local variable names to match the output log names.

#rb Dan.Elksnitis
#preflight 632a224ab40000c8f08c5815

[CL 22125080 by jason nadro in ue5-main branch]
2022-09-21 17:34:15 -04:00
paul chipchase 07d877448d The server address used by the source control VA backend can now be set when describing the backend graph in the config file.
#rb Per.Larsson
#jira UE-164284
#rnx
#preflight 632b182ffc7f1efbdf9638d9

- This is only useful if the entire team uses the same address for the perforce server
- When set, this will override the environment settings for P4PORT as well as override what ever is saved to SourceControlSettings.ini

[CL 22122737 by paul chipchase in ue5-main branch]
2022-09-21 16:29:44 -04:00
david lesage cfaf0bcd22 #jira UE-158017 - Cad import - Linux - Creo (.prt.1) file not visible in import browser
FDesktopPlatformWindows::OpenFileDialog based on FDesktopPlatformWindows::FileDialogShared manages natively extension like "prt.*"
but FDesktopPlatformLinux::OpenFileDialog uses FSlateFileDlgWindow that doesn't manage this kind of extension.
=> improvement of FSlateFileDialogVisitor::PassesFilterTest to fix it
#preflight 632b42fa7b582f58abce54fa

[CL 22119216 by david lesage in ue5-main branch]
2022-09-21 14:47:29 -04:00
sara schvartzman 68a76b92b9 Control Rig: Do not allow IO exposed pin type change to something other than execute context
#jira UE-164557
#rb jack.cai
#preflight 632b1aa4fc7f1efbdf9702d8

[CL 22119028 by sara schvartzman in ue5-main branch]
2022-09-21 14:42:45 -04:00
Devin Doucette 7f98c7fe6c DDC: Added functions to convert between derived data priority and queued work priority
#preflight 632b42d4b4515b7e226ffae8
#rb Zousar.Shaker
#rnx

[CL 22118431 by Devin Doucette in ue5-main branch]
2022-09-21 14:25:32 -04:00
Wojciech Krywult 036b741e80 Editor: DeviceOutputLog: Ensured the right destrubtion order between ITargetDeviceOutput and its owning SDeviceOutputLog.
Previously, ITargetDeviceOutput was automatically destroyed as part of destruction of SDeviceOutputLog. It means that if ITargetDeviceOutput tried to deference the owner during its own destruction it could potentially dereference members that have already been destroyed.

Resolved by manually clearing CurrentDeviceOutputPtr which triggers destruction of ITargetDeviceOutput a bit sooner when all the owners members are still valid.

#preflight 6329d973a236a029ded37af3
#rb David.Harvey
#rnx

[CL 22115300 by Wojciech Krywult in ue5-main branch]
2022-09-21 12:26:23 -04:00