Commit Graph

324 Commits

Author SHA1 Message Date
Max Preussner
9a852641c5 PropertyEditor: Fixed crash when unregistering details customizations on shutdown
#CodeReview: max.chen

[CL 2710265 by Max Preussner in Main branch]
2015-09-29 17:47:46 -04:00
Jamie Dale
3ee63fe31e Extended the structure detail view asset detection support to always treat "asset" properties as an asset
eg) Anything used by a TAssetPtr

[CL 2706013 by Jamie Dale in Main branch]
2015-09-25 07:50:59 -04:00
Matt Kuhlenschmidt
27632204eb Fix broken details panels caused by CL 2704872
[CL 2705734 by Matt Kuhlenschmidt in Main branch]
2015-09-24 23:25:13 -04:00
Cody Haskell
e1a26fbf66 [AUTOMERGE]
Crash fix for the details panel

#codereview Matt.Kuhlenschmidt

--------
Integrated using branch UE4-To-UE4-Orion (reversed) of change#2704869 by Cody.Haskell on 2015/09/24 14:35:41.

[CL 2704872 by Cody Haskell in Main branch]
2015-09-24 14:36:12 -04:00
Jamie Dale
2041b5f780 Fixed some places that were surrounding FName properties in quotes, but weren't providing the PPF_Delimited flag
UE-21078 - FBoneReference text import no longer works correctly.

Some property editing code used to forcibly surround FName properties in quotes, as UNameProperty::ImportText_Internal didn't handle the PPF_Delimited correctly prior to CL# 2682467, so this was the only way to ensure that names containing spaces would be imported.

This change removes those places that were forcibly adding quotes, as UNameProperty::ImportText_Internal will now do the correct thing as the default import flags do not contain PPF_Delimited.

#codereview Benn.Gallagher

[CL 2691572 by Jamie Dale in Main branch]
2015-09-15 07:42:10 -04:00
Richard Hinckley
6ceaa5aba7 Cleaning out programmer-only comments that were harvested by Doxygen.
#platformnotify Josh.Adams

[CL 2690143 by Richard Hinckley in Main branch]
2015-09-14 09:25:39 -04:00
Max Preussner
5cb95c10bd PropertyEditor: Exposing underlying details view from StructureDetailsView; cleanup pass.
[CL 2689640 by Max Preussner in Main branch]
2015-09-13 07:59:48 -04:00
Max Preussner
71c8b7770c PropertyEditor: Reverted previous padding change
[CL 2687472 by Max Preussner in Main branch]
2015-09-10 21:55:22 -04:00
Max Preussner
ad17b42eac PropertyEditor: Adjusted padding to prevent gap at top
[CL 2687468 by Max Preussner in Main branch]
2015-09-10 21:50:49 -04:00
Chris Wood
f3d902868f Fixed "Reset to Default" logic error (left from changes in UETOOL-125)
[UE-20444] - Reset to defaults icon is missing

[CL 2675640 by Chris Wood in Main branch]
2015-09-01 12:40:19 -04:00
Michael Schoell
cdbb2725a4 Duplicating, in a Property Tree, an array of instanced objects will correctly deep copy the objects instead of a shallow (referenced) copy.
#jira UE-19163 - Editing duplicated instanced sub-objects also edits other sub-objects

[CL 2670848 by Michael Schoell in Main branch]
2015-08-27 10:04:33 -04:00
Max Chen
5b02181bbb Sequencer: Add sequencer detail keyframe handler.
[CL 2668778 by Max Chen in Main branch]
2015-08-25 21:12:30 -04:00
Dmitry Rekman
a9221dfcb5 Matching LOCTEXT_NAMESPACE #def/#undef
- Also changed some #undef's to be more uniform

[CL 2665419 by Dmitry Rekman in Main branch]
2015-08-23 00:57:30 -04:00
Bob Tellez
7482b31243 [AUTOMERGE]
#UE4 Fixed a shadow variable warning in PropertyNode

--------
Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2654035 by Bob.Tellez on 2015/08/12 23:00:41.

[CL 2654043 by Bob Tellez in Main branch]
2015-08-12 23:05:42 -04:00
Ben Zeigler
3a8ca7f141 #UE4 Revert earlier change to make IPropertyHandle::IsValidHandle return false if the contained property was NULL, because the property table editor depended on that functionality
Rename HasValidProperty to HasValidPropertyNode to make the behavior match the name, and clean up some comments
Fix several details customizations that weren't correctly checking for property validity before derefencing GetProperty() or AccessRawData(). This fixes the original slate crash as well
#codereview matt.kuhlenschmidt

--------
Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2653955 by Ben.Zeigler on 2015/08/12 21:23:30.

[CL 2653956 by Ben Zeigler in Main branch]
2015-08-12 21:24:04 -04:00
Billy Bramer
4f46ddb309 [AUTOMERGE]
- Unshelved change from MattK to allow hooking into a delegate when a child property changes

--------
Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2653683 by Billy.Bramer on 2015/08/12 18:11:24.

#codereview Matt.Kuhlenschmidt

[CL 2653759 by Billy Bramer in Main branch]
2015-08-12 19:03:40 -04:00
Ben Zeigler
a446aa1604 #UE4 Change it so PropertyHandles do not acount as being valid if the UProperty they point to has been invalidated due to BP recompilation. This fixes some crashes in editor UI
#codereview matt.kuhlenschmidt

--------
Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2651439 by Ben.Zeigler on 2015/08/11 14:04:41.

[CL 2651446 by Ben Zeigler in Main branch]
2015-08-11 14:05:33 -04:00
Josh Markiewicz
f8d83447e1 #Integration FN->Main from CL#2642868
Engine Source changes

[CL 2645403 by Josh Markiewicz in Main branch]
2015-08-05 15:54:57 -04:00
Chris Wood
7b57b178f6 "Reset to default" on the Image Size property of a brush now uses the size of the texture if one is set.
[UETOOL-125] - Have the "return to defaults" arrow on a brush's texture actually go back to the size of the texture

#change Customization of property rows now supports passing reset to default customizations to child properties so that structs like vectors can have their components handled by the same custom handler as the parent. Properties identify themselves by passing their handle to the delegate.
#change Reset to default is now set on properties using FResetToDefaultOverride class containing the delegates and ovrride behaviors.
#change Slate brush customization sets custom reset behavior on the Image Size property and uses the texture size as the default size.

#codereview matt.kuhlenschmidt

[CL 2644978 by Chris Wood in Main branch]
2015-08-05 11:35:16 -04:00
Mikolaj Sieluzycki
019a8752c3 Fix UEnum issues with incorrect _MAX enum value.
#codereview Robert.Manuszewski

[CL 2644738 by Mikolaj Sieluzycki in Main branch]
2015-08-05 08:56:11 -04:00
Michael Schoell
343817568b Editing FText properties in the user defined struct editor and for local Blueprint function variables will no longer erase the inputed information upon closing and re-opening the editor.
Added FPropertyHandleBase::NotifyFinishedChangingProperties to handle generic calls to NotifyFinishedChangingProperties.

Text Customization will now NotifyFinishedChangingProperties so the data can properly be captured.

#jira UE-19368 - Structure text variable's default value lost on close

[CL 2639260 by Michael Schoell in Main branch]
2015-07-30 15:45:22 -04:00
Matt Kuhlenschmidt
731ee35c31 Allow detail panel categories to be dynamically shown or hidden. Added this to the material customization for primitive components. Fixes issue where material customization never appears if there was no valid material on a component when the details panel was created
[CL 2634999 by Matt Kuhlenschmidt in Main branch]
2015-07-27 23:38:36 -04:00
Bob Tellez
b3b6ef475f Checking in Mikolaj Sieluzycki's change to fix up callsites to ask for the value of an enum entry instead of the index. The value and the index are the same unless the enum specified element values in its declaration (i.e. enum MyEnum { FirstValue = 1 })
[CL 2634487 by Bob Tellez in Main branch]
2015-07-27 16:26:39 -04:00
Richard TalbotWatkin
a9d3cc261c Changes to remove the UCurve derived types from the Create Asset menu in the Content Browser, while still presenting it as an option in details panels.
#jira UE-19105 - Can create Float Curve through context menu 2 ways

[CL 2633727 by Richard TalbotWatkin in Main branch]
2015-07-27 07:44:14 -04:00
Matt Kuhlenschmidt
ac0982e1d0 Allow creation of default property value widgets to specify whether or not the default property buttons are displayed.
[CL 2627451 by Matt Kuhlenschmidt in Main branch]
2015-07-21 11:00:22 -04:00