Commit Graph

35 Commits

Author SHA1 Message Date
laura hermanns
3564d25726 [UBA] Add vertical cursor line to UbaVisualizer and zoom in/out at cursor position as anchor point.
- Zoom in/out with the horizontal cursor position as anchor point; Previously the anchor point was always the left corner of the window.
- Add a vertical line with the same color as the info text to visualize where the cursor is and where zooming in/out will take place (can be disabled).

#rnx
#rb henrik.karlsson, Joe.Kirchoff

[CL 33806005 by laura hermanns in ue5-main branch]
2024-05-21 15:37:45 -04:00
henrik karlsson
945f321b84 [UBA]
* Added placeholder icon to UbaVisualizer

[CL 33435766 by henrik karlsson in ue5-main branch]
2024-05-03 16:23:21 -04:00
henrik karlsson
2f5a10f057 [UBA]
* Fix crash in visualizer that can happen if box is selected when new build trigger a refresh of view

[CL 33290527 by henrik karlsson in ue5-main branch]
2024-04-27 20:06:34 -04:00
henrik karlsson
3f109dfb0e [UBA]
* Lots of fixes related to cache and prepared code for integration with UBT (ubt will provide input and output files for cache entries)

[CL 33209814 by henrik karlsson in ue5-main branch]
2024-04-24 15:26:58 -04:00
henrik karlsson
19f7cccff9 [UBA]
* Fixed serious bug related to child processes on helper machines getting process ids that collides with ids of root processes coming from server
* Fixed bug in trace reader causing reusable processes to get no stats
* Added good-to-have asserts

[CL 33064711 by henrik karlsson in ue5-main branch]
2024-04-18 01:10:16 -04:00
henrik karlsson
adfccca28f [UBA]
* Fixed bug in text normalization code.. was missing one character
* Fixed so cache processes are colored differently in visualizer
* Improved assert information when pressing ctrl-c during build and an assert triggers

[CL 32957554 by henrik karlsson in ue5-main branch]
2024-04-13 19:21:42 -04:00
henrik karlsson
c88d02914d [UBA]
* Implemented V1 of CompactPathTable which instead stores string segments separately.. Reduces the size table by ~30%.. slightly slower perf
* Added "RootPaths" which is a class that holds a list of root paths needed to normalize paths into non-environment dependent paths
* Added stats for cache that visualizes properly in visualizer
* Changed hash functions to have better quality
* Cleaned up code visualizing stats in visualizer.. now boxes popping up should have a nice matching size to strings
* Cleaned up UbaExports and formatted all functions the same way.. old are deprecated and will be removed once new binaries are in

[CL 32922089 by henrik karlsson in ue5-main branch]
2024-04-12 01:05:04 -04:00
henrik karlsson
3799cdb157 [UBA]
* Some minor fixes in uba visualizer

[CL 32232310 by henrik karlsson in ue5-main branch]
2024-03-13 18:45:42 -04:00
henrik karlsson
5dc54a8104 [UBA]
* Huge stability push... all (known) paths have been tested heavily on linux with tsan and every single found race condition report has been fixed. Lots of locks have been added/moved/changed and some instances of things have been leaked on purpose to prevent tsan reports during shutdown
* More efficient storage proxy implementation which immediately forward segments to clients once they are available in proxy
* Added UbaAgent -command=x which can be used to send commands to host. Supported commands are "status"which prints out status of all remote sessions. "abort/abortproxy/abortnonproxy" that can be used to abort remote sessions and "disableremote" to have host stop accepting more helpers
* Fixed scheduler::stop bug if remotes were still requesting processes
* Added support for process reuse on linux/macos
* Added support for Coordinator interface and dynamically load coordinator dll in UbaCli
* Restructured code a little bit to be able to queue up all writes in parallel
* Added Show create/write colors to visualizer (defaults to on)
* Fixed so write file times are visualized in visualizer
* Improved socket path for visualizer
* Improved a lot of error messages
* Fixed double close of memory handle in StorageServer
* Changed some ScopedWriteLock to SCOPED_WRITE_LOCK (same for read locks)
* Fixed some missing cleanup of trace view when starting a new trace view in visualizer

[CL 32137083 by henrik karlsson in ue5-main branch]
2024-03-08 18:31:48 -05:00
henrik karlsson
d394b4b515 [UBA]
* Added session notification message to be able to see why client is about to go away.. hopefully this will help us identify if there are crashes happening on remotes that we don't track
* Added ApplicationRules::AllowStorageProxy and changed so .obj files are never going through the storage proxy on fetch (they are only read by one process so no point feeding them through the proxy
* Fixed the file write-through code and gave the #if 0 a name (#if UBA_USE_WRITE_THROUGH).. still disabled since it didn't give any benefits enabling it

[CL 32025069 by henrik karlsson in ue5-main branch]
2024-03-05 12:41:52 -05:00
henrik karlsson
5e6dc44ec3 [UBA]
* Added PrefetchVirtualMemory function
* Fixed bug where code writing callstacks checks end of module to figure out if address belongs to module
* Changed so FileAccessor::CreateMemoryWrite set always allow read because you can't create file mappings that are write-only
* Added option to scheduler to force all runs to run native
* Fixed so bottleneck class has enter/leave function
* Added ScopedReadLock::Enter
* Moved LogWriter to its own file
* Visualizer - Fixed so when hovering over timeline time under pointer is showing
* Visualizer - Fixed so hovering over work records shows name, start and duration
* Visualizer - Added context menu item that can show/hide text of process bars
* Improved assert message
* Changed so lock is not on stack but is leaked to prevent shutdown warnings in debug
* Added missing includes

[CL 31981637 by henrik karlsson in ue5-main branch]
2024-03-03 20:42:41 -05:00
henrik karlsson
d9ce0963c2 [Uba]
* Fixed so visualizer does not crash with version 21 traces that contains log messages that have over 100 lines

[CL 31900281 by henrik karlsson in ue5-main branch]
2024-02-29 02:18:27 -05:00
henrik karlsson
2ba1550eba [Uba]
* Fixed bug in trace code where errors are more than 100 lines long

[CL 31855407 by henrik karlsson in ue5-main branch]
2024-02-27 17:34:12 -05:00
henrik karlsson
5c8c7121f1 [UBA]
* Fixed allocation to make sure it honors alignments
* Added error handling in trace code. It will stop writing when running out of shared mem

[CL 31533514 by henrik karlsson in ue5-main branch]
2024-02-15 15:36:01 -05:00
henrik karlsson
a33acc6f91 [UBA]
* Fixed crash in UbaVisualizer when jumping back and forth in traces hitting edge cases with multiple sessions. Code was not cleaning up after itself properly

[CL 31511180 by henrik karlsson in ue5-main branch]
2024-02-14 23:32:33 -05:00
henrik karlsson
34b52deafb [UBA]
* Added hint to unmapfileview to be able to add useful information to asserts on fails
* Added error handling for vsnprintf returning error
* Fixed memory stomp in unit test
* Removed usage of %hs on non-windows since asan complains about it
* Changed UBA_USE_MIMALLOC to always be defined and be 0 or 1 instead of using ifdef
* Enabled mimalloc on linux

[CL 31355077 by henrik karlsson in ue5-main branch]
2024-02-09 16:12:12 -05:00
henrik karlsson
cca66a4ea3 [UBA]
* Removed logging entries that was only added to make horde not timeout.. since this was implemented horde has added ping logic so this is not needed anymore
* Fixed bug in callstack logging on posix
* Changed a bunch of %hs to %s
* Added allocator debug code to try to figure out asan issues

[CL 31281576 by henrik karlsson in ue5-main branch]
2024-02-07 20:36:18 -05:00
henrik karlsson
625a953da9 [UBA]
* Fixed so include-what-you-use json output is working properly with uba. "puts" implementation is wrong but don't remember why it was added first place so didn't dare changing it too much.. current change only affect remote helpers running on wine
* Fixed ubavisualizer hittest logic when status lines are added
* Enabled remote log transfer by default in UbaCli



#changelist validated
#virtualized

[CL 31224327 by henrik karlsson in ue5-main branch]
2024-02-06 14:03:28 -05:00
henrik karlsson
35e9c13936 [UBA]
* Fixed up replay controls in visualizer

[CL 31148125 by henrik karlsson in ue5-main branch]
2024-02-02 18:30:47 -05:00
henrik karlsson
59cd3b1849 [UBA]
* Added support for custom text in trace/visualizer... can be used to report things like horde status etc

[CL 31118070 by henrik karlsson in ue5-main branch]
2024-02-02 00:30:28 -05:00
henrik karlsson
8a52cbe8fc [UBA]
* Added more context menu options in visualizer to navigate trace

[CL 30991881 by henrik karlsson in ue5-main branch]
2024-01-30 02:19:51 -05:00
henrik karlsson
11ed67aeed [UBA]
* Added log entries to trace file

[CL 30669670 by henrik karlsson in ue5-main branch]
2024-01-17 16:49:50 -05:00
henrik karlsson
fa2772e27d [UBA]
* Added so in-process proxy can use storage of client
* Fixed reset of trace reader
* Fixed annoying warnings when closing invalid sockets

[CL 30667316 by henrik karlsson in ue5-main branch]
2024-01-17 15:28:30 -05:00
zack neyland
c91ba1805b UBA: Fixes various small bugs.
[CL 30662921 by zack neyland in ue5-main branch]
2024-01-17 13:07:52 -05:00
henrik karlsson
cdfbe93014 [UBA]
* Fixed so -replay works again when viewing files

[CL 30643275 by henrik karlsson in ue5-main branch]
2024-01-16 15:35:42 -05:00