Commit Graph

962 Commits

Author SHA1 Message Date
projectgheist
36016d6a81 PR: [ContentBrowser] Store SContentBrowser::bIsLocked by instance in INI
#rb brooke.hubert
#jira UE-178354
#10168

[CL 33722769 by projectgheist in ue5-main branch]
2024-05-17 09:46:44 -04:00
andrea botti
9c1aa7d20b [ContentBrowser] When CTRL+C on an asset can we copy the Package Path instead of the Class Path
Added 2 new commmands to copy the ObjectPath and the PackageName.
Leaved the CTRL+C keybind mapped to the same behavior as before.
Added new commands to the keybind system so that users can re-bind them.
Cleaned up some hardcoded checks for keys in the OnKeyDown.

#rb aditya.ravichandran, sebastian.arleryd
#jira UE-155995

[CL 33684273 by andrea botti in ue5-main branch]
2024-05-16 08:31:50 -04:00
andrea botti
9a37df1b9d [ContentBrowser] PathView SplitterSlot should save its size when closing/re-opening
PathView SplitterSlot is resetting its size value when closed, should keep it saved.

#rb aditya.ravichandran
#jira UE-214993

[CL 33659463 by andrea botti in ue5-main branch]
2024-05-15 11:16:53 -04:00
andrea botti
ee3f41426e [ContentBrowser] Filter Splitter slot in AssetView should not resize itself while resizing the whole CB panel
#rb aditya.ravichandran
#jira UE-214182

[CL 33607007 by andrea botti in ue5-main branch]
2024-05-13 14:40:52 -04:00
julien stjean
05d6411024 Fixed a crash when closing the editor in FFilter_ShowOtherDevelopers::~FFilter_ShowOtherDevelopers.
#jira UE-214262
[FYI] Robert.Millar

[CL 33559433 by julien stjean in ue5-main branch]
2024-05-09 16:58:25 -04:00
andrea botti
423be8eac0 [ContentBrowser] Sources Panel in content browser should not resize itself
#rb aditya.ravichandran, brooke.hubert
#jira UE-204825

[CL 33481785 by andrea botti in ue5-main branch]
2024-05-07 08:27:28 -04:00
robert millar
d47b81efa6 Restore skipping of early published items (e.g. new items) in UpdateItemFiltering
[CL 33459740 by robert millar in ue5-main branch]
2024-05-06 12:30:54 -04:00
charles lefebvre
17964ec141 SAssetView: Replace checks by ensure to fix asset creation
#rb aditya.ravichandran
[FYI] robert.millar
#rnx

[CL 33454821 by charles lefebvre in ue5-main branch]
2024-05-06 09:27:58 -04:00
marc audy
094435d976 Fix shadowing error
#rnx
#jira

[CL 33441383 by marc audy in ue5-main branch]
2024-05-03 19:28:12 -04:00
robert millar
0b9ef9ee96 Fix reusing old node for multiple new content browser items, possible racing on modifying the object fields.
[CL 33440822 by robert millar in ue5-main branch]
2024-05-03 18:51:11 -04:00
robert millar
e4ba75d10b Fix use of compare_exchange_strong
[CL 33440697 by robert millar in ue5-main branch]
2024-05-03 18:45:06 -04:00
robert millar
70f86f2275 Add some checks against reusing an old asset item data multiple times
Change ItemsPendingPriorityFilter checks to use PublishProgress instead of FrontendFilterProgress.

[CL 33438269 by robert millar in ue5-main branch]
2024-05-03 17:25:34 -04:00
robert millar
30433fa927 Remove unnecessary assertion from priority filtering.
[CL 33431968 by robert millar in ue5-main branch]
2024-05-03 14:31:08 -04:00
robert millar
4a0d1e1991 Fix accessing removed items when rebuilding lookup.
[CL 33431326 by robert millar in ue5-main branch]
2024-05-03 14:17:20 -04:00
robert millar
40e0bc2163 Handle possible race condition between cancelling text filtering and spawning continuation.
[CL 33417207 by robert millar in ue5-main branch]
2024-05-02 19:52:19 -04:00
robert millar
a3be465520 Check removed flag in more Lookup searches.
[CL 33413923 by robert millar in ue5-main branch]
2024-05-02 18:26:51 -04:00
robert millar
fec5b746f0 Handle removed items properly in UpdateData
[CL 33406749 by robert millar in ue5-main branch]
2024-05-02 15:33:32 -04:00
robert millar
d85544d7d1 Fix deadlock caused by re-entrancy from collection manager -> collections view -> collection manager attempting to acquire non-recursive lock.
[CL 33397662 by robert millar in ue5-main branch]
2024-05-02 11:25:16 -04:00
robert millar
ccbf59717b Reimplement text filtering in the content browser to be performed asynchronously in parallel.
- FFrontendFilter_Text is deprecated in favor of FAssetTextFilter.
- FAssetTextFilter can be compiled and then the compiled filter cloned for use in parallel.
- Change FFrontendFilter_CustomText to work by merging its query with FAssetTextFilter instead.
- Deprecate UTextFilter*Handler classes and replace with an explicitly registered interface for thread safety.
Refactor item storage in SAssetView:
- FAssetViewItemCollection stores items and handles threading/updates
- Items are stored linearly in an array with an external lookup for simpler filter progress handling
- FHashTable used for lookup can be built & deduplicated in parallel
Other changes and optimizations
- Move AssetViewTypes.h header to private directory as it was had no DLL exported members anyway.
- When SAsset view receives a new backend filter, check if it's different before requesting a full refresh.

#rb aditya.ravichandran, Julien.StJean

[CL 33396639 by robert millar in ue5-main branch]
2024-05-02 10:54:03 -04:00
robert millar
844fa37942 Add comment
[CL 33385023 by robert millar in ue5-main branch]
2024-05-01 18:09:33 -04:00
robert millar
db19c32ca0 Additional path view logging.
[CL 33384736 by robert millar in ue5-main branch]
2024-05-01 18:03:58 -04:00
robert millar
496ccaa73a New "Show Other Developers" filter implemented as modification to backend query to avoid processing each item in time-sliced frontend filter.
Use path permission lists to hide developer folders other than the current user.

#rb Julien.StJean

[CL 33378078 by robert millar in ue5-main branch]
2024-05-01 14:18:12 -04:00
patrick boutot
a2b5613488 Slate: Deprecate SListView::ItemHeight and STreeViewItemHeight. ItemHeight and ItemWidth are only used when the panel is is as a tile or both value are assigned. With TreeView and ListView, you can't assigned both. The function are protected, a subclass of those could but it's up to them to expose the ItemHeight and ItemWidth. This behavior changed was introduced with CL 7634094.
#jira UE-210415
#rb editor-ui-systems

[CL 33370360 by patrick boutot in ue5-main branch]
2024-05-01 08:05:39 -04:00
robert millar
d5b3c88c3b Add additional logging for path view.
Add console command PathView.Repopulate to force rebuild of path view.

[CL 33352565 by robert millar in ue5-main branch]
2024-04-30 16:49:32 -04:00
robert millar
9413cd77c7 Content browser navigation bar updates:
- Ensure some empty space is available to click to edit
- Select all text at first when editing

[CL 33343924 by robert millar in ue5-main branch]
2024-04-30 13:25:29 -04:00