Commit Graph

4674 Commits

Author SHA1 Message Date
Sorin Gradinaru
21fdd3aa81 UE-72355 //Fortnite/Dev-EngineMerge - Package and Publish IOS - Failing "FortniteClient.entitlements" could not be opened"
#jira UE-72355
#4.22.1
#rb Jack.Porter
#lockdown cristina.riveron

Check if the entitlements file is present when packaging, creating it if is not

[CL 5809000 by Sorin Gradinaru in 4.22 branch]
2019-04-09 12:08:35 -04:00
Ben Marsh
616fc17ee9 Don't use a Visual Studio Express installation even if it's our preferred toolchain version.
#rb none
#jira UE-72305

[CL 5767591 by Ben Marsh in 4.22 branch]
2019-04-05 15:17:45 -04:00
Ben Marsh
97c11370f5 UBT: Always prefer 64-bit toolchains over 32-bit toolchains. Prevents Visual Studio Express versions being selected over Pro versions.
#rb none
#jira UE-72305

[CL 5766636 by Ben Marsh in 4.22 branch]
2019-04-05 13:41:41 -04:00
Ben Marsh
412f9e693d Add additional logging for Visual Studio version, to help track down problems with Visual Studio Express.
#rb none
#jira UE-72305

[CL 5749069 by Ben Marsh in 4.22 branch]
2019-04-04 16:40:18 -04:00
Ben Marsh
47e345cb8a UBT: Sort the installed versions of Visual Studio to weight against Express versions being chosen.
#rb none
#jira UE-72305

[CL 5746419 by Ben Marsh in 4.22 branch]
2019-04-04 14:36:33 -04:00
Ben Marsh
0b8abb31d2 Live Coding: Fixes issue linking patch DLLs with Visual Studio Express, due to PATH environment variable not including path to mspdb140.dll.
Now stores the linker environment block in the live coding manifest, and adds it to the cache before executing the linker.

#rb none
#jira UE-72324

[CL 5740602 by Ben Marsh in 4.22 branch]
2019-04-04 11:55:49 -04:00
Sorin Gradinaru
e339e9a6ab UE-71919 tvOS banner and App thumbnail do not appear on device
#jira UE-71919
#4.22.1
#tvOS
#rb Jack.Porter
#lockdown cristina.riveron

New structure for the tvOS assets (Build/TvOS/Resources) needs changes in the Unreal Build Tools

Note: This will also solve the errors when uploading shipping tvOS packages to Apple

[CL 5732170 by Sorin Gradinaru in 4.22 branch]
2019-04-04 07:00:21 -04:00
Sorin Gradinaru
b4f9aeb90c UE-72058 tvOS: Project Packaged with CloudKit Support Crashes on Launch Due to Malformed Value in the Entitlement
#jira UE-72058
#tvOS
#4.22.1
#rb Jack.Porter
#lockdown cristina.riveron

When building on Mac, the packaging &  signing rely on the entitlements file.

- the values should correspond to those in the entitlements (take into account syntax differences). Fixed problems related to icloud-container-identifiers, ubiquity-container-identifiers and com.apple.developer.icloud-services
- ICloudContainerIdentifier added to the tvOS plist (previously it was added on iOS)
- added com.apple.developer.icloud-container-environment to the entitlements file, needed when signing the package
- shipping build with CloudKit should also have the push notifications enabled
- fixed an issue with com.apple.developer.associated-domains when the value is a string, not an array
- addding CODE_SIGN_ENTITLEMENTS in the project file

[CL 5731997 by Sorin Gradinaru in 4.22 branch]
2019-04-04 06:50:15 -04:00
Nick Shin
b30521d713 HTML5 - 4.22.1 - update browser paths for launch on menu
#jira UE-71886  FireFox Quantum 67.0b3 fails to launch on correctly
#rnx
#rb none
#lockdown jack.porter

[CL 5710978 by Nick Shin in 4.22 branch]
2019-04-03 12:51:31 -04:00
Sorin Gradinaru
aafc9a64b4 UE-72058 tvOS: Project Packaged with CloudKit Support Crashes on Launch Due to Malformed Value in the Entitlement
#jira UE-72058
#4.22
#tvOS
#rb Peter.Sauerbrei
#fyi Jack.Porter
#lockdown cristina.riveron

Two issues found and fixed:
- com.apple.developer.icloud-services should have CloudDocuments ONLY on iOS
- com.apple.developer.icloud-container-environment should by a string not an array (unlike in the mobile provisioning)

[CL 5630800 by Sorin Gradinaru in 4.22 branch]
2019-03-28 12:21:36 -04:00
Cosmin Sulea
977009f7d0 UE-71953 - Blueprint iOS projects can't package For Distribution
#jira UE-71953
#rb Jack.Porter
#lockdown Nick.Penwarden

[CL 5630547 by Cosmin Sulea in 4.22 branch]
2019-03-28 11:37:02 -04:00
Sorin Gradinaru
d6856e9885 UE-52346 TM-Gameplay: Load Level Volume Fails to Read TestSlot.sav file
#jira UE-52346
#iOS
#tvOS
#4.22
#rb Jack.Porter
#lockdown cristina.riveron

On Mac the pList file is overriden before the final packaging. Adding iCloudContainerIdentifier.

[CL 5586835 by Sorin Gradinaru in 4.22 branch]
2019-03-27 04:03:07 -04:00
Sorin Gradinaru
e893f2076e UE-66204 iOS and tvOS errors in Application Loader to Apple: 'Invalid Code Signing Entitlements' with iCloud
#jira UE-66204
#4.22
#iOS
#rb Jack.Porter
#lockdown cristina.riveron


Fixed a problem with the order of values in the  com.apple.developer.icloud-container-environment array

Also modified parsing com.apple.developer.ubiquity-container-identifiers and com.apple.developer.ubiquity-kvstore-identifier in order to preserve the team id from the mobileprovisioning

Note:iPhonePacvkager needs to be recompiled + binaries uploaded on //UE4/Release-4.22/Engine/Binaries/DotNET/IOS

[CL 5533538 by Sorin Gradinaru in 4.22 branch]
2019-03-25 08:45:48 -04:00
Ben Marsh
114661048b Fix problems with HotReload on Mac.
* Linker arguments for each hot-reloaded module where only being patched with that module's new name (and not *all* the new module names). Windows was unaffected by this, since it uses response files (which were being handled correctly).
* Loop to rename modules in the manifest was terminating after the first modified module was found. This prevented other modules from being renamed.

#rb none
#fyi Steve.Robb, Michael.Trepka
#jira UE-62612

[CL 5503573 by Ben Marsh in 4.22 branch]
2019-03-22 14:04:39 -04:00
Sorin Gradinaru
78470bc42e UE-71596 iOS packaging error with CloudKit enabled - Provisioning profile <...> doesn't match the entitlements file's values
#jira UE-71596
#4.22
#iOS
#tvOS
#rb Jack.Porter
#lockdown cristina.riveron

Write the entitlements in PostBuldSync.
Target.bCreateStubIPA is false when building on mac, true on windows (using the -CreateStub argument)

[CL 5491331 by Sorin Gradinaru in 4.22 branch]
2019-03-21 05:11:42 -04:00
Graeme Thornton
2312b21673 Use accessor function on crypto settings in UAT to determine if signing is enabled, rather than reading the flag directly. Makes sure that signing is correctly disabled if the setting is enabled but no key was set
#rb ben.marsh
#jira UE-71803
#lockdown cristina.riveron

[CL 5487901 by Graeme Thornton in 4.22 branch]
2019-03-20 18:56:44 -04:00
Graeme Thornton
22b9615167 Add new config values to go alongside "PlatformRequiresDataCrypto" which can specifically disable signing or encryption. Allows selective disabling of signing OR encryption on some platforms, rather than the old config value which would disable both.
Disable signing on platforms that we wanted encryption enabled for by default (mobile mainly)
Add a warning if pak signing or encryption is enabled but there is no key, then disable the offending functionality for that build

#rb none
#jira UE-71811, UE-71806
#lockdown cristina.riveron

[CL 5487098 by Graeme Thornton in 4.22 branch]
2019-03-20 18:40:01 -04:00
Ben Marsh
ffd7f43d1d Fix exception when hot-reloading a module that contains an additional bundle resource. List of hot-reload build products for each module now only includes import library and DLL.
#rb none
#jira UE-71692

[CL 5458343 by Ben Marsh in 4.22 branch]
2019-03-19 15:05:55 -04:00
Sorin Gradinaru
451c4cc88d UE-52346 TM-Gameplay: Load Level Volume Fails to Read TestSlot.sav file
#jira UE-52346
#iOS
#tvOS
#rb Jack.Porter

Created a pList key named ICloudContainerIdentifier to be used at run-time when intializing the CloudKit services

[CL 5448858 by Sorin Gradinaru in 4.22 branch]
2019-03-19 11:31:59 -04:00
Graeme Thornton
02f173d785 Added a warning to UBT/UAT that an old unsecure signing key was found, and that keys should be regenerated
#jira UE-71377
#rb none
#robomerge deadend

[CL 5448497 by Graeme Thornton in 4.22 branch]
2019-03-19 10:35:51 -04:00
Ben Marsh
dc40d0964d UBT: Disable the "bAdaptiveUnityDisablesPCH" build flag by default. This significantly improves iteration times on individual files, at the risk of introducing missing headers. Will validate this in CIS instead.
#rb none
#jira

[CL 5447578 by Ben Marsh in 4.22 branch]
2019-03-19 08:47:06 -04:00
Graeme Thornton
1426faf9b3 Created a new interface to RSA functionality that is independent of key size (unlike the old TBigInt version). Internally, RSA functions are implemented by OpenSSL on Windows/Mac/Linux an falling back to the TBigInt implementation for other platforms
- Future plan would be not to use OpenSSL directly, but to go via PlatformCrypto or something like it which could provide platform specific RSA functionality if it exists
- Also contains some compensation code for platforms that are still stuck on an older version of OpenSSL (everything except windows)
- On platforms that use OpenSSL < 1.1.1, register a locking callback so we can provide mutexes and stop it crashing horribly when the same RSA key is used concurrently on different threads

Changed default key size in the CryptoKeys plugin to 4096 bits.

#jira UE-71377
#rb ian.fox, robert.manuszewski, ryan.gerleve

[CL 5447433 by Graeme Thornton in 4.22 branch]
2019-03-19 07:30:08 -04:00
Jules Blok
86373da314 Escape all paths when generating VS project filter files
#jira UE-71727
#rb Jack.Porter

[CL 5439949 by Jules Blok in 4.22 branch]
2019-03-18 20:15:37 -04:00
Jeff Fisher
b620c775dd Back out changelist 5417701
-This fix breaks the ddc build, which is more important.
#rb build
#jira UE-67120

[CL 5423419 by Jeff Fisher in 4.22 branch]
2019-03-16 13:39:10 -04:00
Sorin Gradinaru
10e4aa4ac2 UE-71596 iOS packaging error with CloudKit enabled - Provisioning profile <...> doesn't match the entitlements file's values
#jira UE-71596
#iOS
#tvOS
#4.22
#rb Jack.Porter

Moved the entitlements file generation from preinit to postbuild, so we can write the correct iCloud container settings

[CL 5419244 by Sorin Gradinaru in 4.22 branch]
2019-03-15 13:23:51 -04:00