Commit Graph

2990 Commits

Author SHA1 Message Date
Johan Torp
a2393b024d Fixed wrong return type of rarely used ExportTextPathToObjectPath() overload
#fyi JeanMichel.Dignard
#jira UE-90736
#rb none

[CL 12230876 by Johan Torp in 4.25 branch]
2020-03-17 04:08:05 -04:00
Robert Manuszewski
58f1148641 Fix for null access when verifying ScriptAndPropertyObjectReferences (fallout from 12192717)
#rb none
#jira UE-90698

[CL 12216874 by Robert Manuszewski in 4.25 branch]
2020-03-16 14:51:45 -04:00
Robert Manuszewski
88b779c80c Reducing the constant memory cost of keeping FProperty related references from 32 to 8 bytes per UStruct.
- Merged ScriptObjectReferences and PropertyObjectReferences into single ScriptAndPropertyObjectReferences array
- UnresolvedScriptProperties will now be a heap allocated array since it only needs to exist at load time

#rb Dan.OConnor
#jira UE-90698

[CL 12192717 by Robert Manuszewski in 4.25 branch]
2020-03-16 03:55:40 -04:00
Robert Manuszewski
321457eb31 Fix for UE-90683: You can no longer delete conflicting variables
Refactored FindField into FindUField and FindFProperty to avoid confusion caused by the fact that FindField<UField> will no longer return FProperties.

#jira UE-90683
#rb Steve.Robb
#tests Basic editor functionality test, cooked and ran PC client and server, bot soak tests for two hours

[CL 12190998 by Robert Manuszewski in 4.25 branch]
2020-03-15 10:08:50 -04:00
JeanMichel Dignard
5c2cbe76f3 Fixed soft object paths with a class name (export path). Replaced call to TStringView::Right with a call to TStringView::Mid as the parameter is a position in the string.
#jira none
#codereview Johan.Torp
#rb none

[CL 12154399 by JeanMichel Dignard in 4.25 branch]
2020-03-12 16:31:08 -04:00
Johan Torp
36f7fa0521 Various engine init optimizations and new string conversion paths
* Added some core string conversion paths
* Added FString::Append() and += overloads to avoid pointless temporaries when appending c strings and various other string types
* Added UTF32 <-> TCHAR string conversion macros
* Optimized QuotedString parsing
* Optimized property parsing
* PackageName optimizations
* SoftObjectPath optimizations

#jira none
#rb see original changelists
#ushell-cherrypick of 11932317 by Johan.Torp
#ushell-cherrypick of 11932319 by Johan.Torp
#ushell-cherrypick of 11932321 by Johan.Torp
#ushell-cherrypick of 11932322 by Johan.Torp
#ushell-cherrypick of 11932324 by Johan.Torp
#ushell-cherrypick of 11932462 by Johan.Torp
#ushell-cherrypick of 11934123 by Johan.Torp
#ushell-cherrypick of 12000177 by Johan.Torp
#ushell-cherrypick of 12000183 by Johan.Torp
#ushell-cherrypick of 12114232 by Johan.Torp

[CL 12147981 by Johan Torp in 4.25 branch]
2020-03-12 08:11:14 -04:00
Johan Torp
ae71e71723 Improved UnversionedPropertySerializationTest
Collect detailed information on roundtripping error to pinpoint problems much faster.

Implement Identical() for some movie scene evaluation types to fix UnversionedPropertySerializationTest

Previous Identical() implementation returned false since they were only compared to default value and was known to always differ from default. UPS test requires proper Identical() implementation.

#[fyi] andrew.rodham, austin.crismore
#jira none
#rb none
#ushell-cherrypick of 11443195 by Johan.Torp
#ushell-cherrypick of 11458738 by Johan.Torp

[CL 12147958 by Johan Torp in 4.25 branch]
2020-03-12 08:07:10 -04:00
Robert Manuszewski
8990a6f4ec FReferenceFinder will not use multithreading until all native classes have been registered to avoid asserts when assembling token streams for classes that haven't had it assembled yet.
#rb none
#jira UE-87699

[CL 12138322 by Robert Manuszewski in 4.25 branch]
2020-03-11 16:04:22 -04:00
Johan Torp
60086084d2 Fix StaticFindObject() search for any package with a package name that is only a substring of the full package name
#jira UE-90162, UE-90262
#rb robert.manuszewski

[CL 12099412 by Johan Torp in 4.25 branch]
2020-03-10 06:31:35 -04:00
Dan Oconnor
9bde6626d3 Edigrate 11689739
Set FlagsPrivate after loading our associated UProperty

#review-12049464 @robert.manuszewski
#rb robert.manuszewski
#jira FORT-263454

[CL 12049463 by Dan Oconnor in 4.25 branch]
2020-03-07 14:19:09 -05:00
Dan Oconnor
cd96cfef1d Edigrate 11986215
Track placeholder objects stored off in PropertyObjectReferences
#rb Michael.Noland
#jira FORT-266568

[CL 12019269 by Dan Oconnor in 4.25 branch]
2020-03-06 15:44:10 -05:00
ben zeigler
03a3d3263e Clear NeedPostLoadSubobjects in all the places that blueprint compilation clears NeedPostLoad
This prevents non-component subobjects that were trashed during compilation from sticking around forever with a bad AsyncLoading flag, causing corruption or crashes
Some of these fixes aren't currently needed because CDOs are hacked to never have NeedPostLoadSubobjects set on them, but this is safer in case we change that later

#jira UE-88129
#rb dan.oconnor

[CL 12010702 by ben zeigler in 4.25 branch]
2020-03-06 14:23:05 -05:00
Johan Torp
bcc5c26a27 Add GetTypeHash() support to TWeakObjectPtr properties.
#rb robert.manuszewski
#jira UE-86065, UE-88638
#ushell-cherrypick of 11386640 by Steve.Robb

[CL 11935438 by Johan Torp in 4.25 branch]
2020-03-05 08:59:19 -05:00
paul chipchase
eb2643cc94 Fix IoStore CIS tests.
There was a mismerge of the fix 11091798 when it was moved from dev-core to a private branch which reintroduced the exception for FBulkDataBase::CanLoadFromDisk, so that it would pass inlined data if it was running from IoStore. This would then quite rightly trigger issues in our automated tests.

Restored the original fix in 11091798.

#rnx
#rb none
#jira UE-90089, UE-90096

[CL 11934328 by paul chipchase in 4.25 branch]
2020-03-05 07:48:07 -05:00
ben hoffman
d65e13a0f1 Update ObjectMacros to include missing meta data specifiers to improve VAX/Visual studio search
#jira UE-87809
#rb michael.noland
#rnx

[CL 11847508 by ben hoffman in 4.25 branch]
2020-03-02 17:17:33 -05:00
Sebastien Lussier
e01cc45f6c Timed Input Monitor - Timecode Provider is not updated when changed from the Project Settings (needs restart)
Skip filterering of affected/changed archetype instances if no set is provided.
#jira UE-89619
#rb none
#rnx
#fyi marc.audy, simon.therriault

[CL 11726367 by Sebastien Lussier in 4.25 branch]
2020-02-28 06:52:40 -05:00
Robert Manuszewski
dbf3ab57db Adding missing include
#rb none
#jira none

[CL 11726260 by Robert Manuszewski in 4.25 branch]
2020-02-28 06:44:47 -05:00
Robert Manuszewski
782e863dc1 FieldPath property's ImportText will now properly support full path names (including the field type) as well as delimited strings
#rb Steve.Robb
#jira none

[CL 11725430 by Robert Manuszewski in 4.25 branch]
2020-02-28 05:54:13 -05:00
Phillip Kavan
4ec8250381 Fix BP nativization dependency gathering to collect script objects referenced by an FProperty.
#rnx
#jira UE-88714
#rb Dan.OConnor, Robert.Manuszewski

[CL 11636405 by Phillip Kavan in 4.25 branch]
2020-02-26 12:58:29 -05:00
Fred Kimberley
9dc7c2269a Back out changelist 11604440. This change is redundant due to CL 11317919.
#jira none
#fyi Robert.Manuszewski
#rb Ben.Hoffman

[CL 11605559 by Fred Kimberley in 4.25 branch]
2020-02-25 11:13:59 -05:00
Fred Kimberley
3e84c79f53 Fixes a bug where FieldPathProperties did not clear the old field path info before adding the new info. This resulted in bad data in the property and could result in lost work.
#rb Michael.Noland
#fyi Robert.Manuszewski
#jira UE-89468

[CL 11604440 by Fred Kimberley in 4.25 branch]
2020-02-25 10:51:17 -05:00
Robert Manuszewski
161be6608e FReferencerFinder will now properly find GGCObjectReferencer as one of the referencing objects
#jira none
#rb Steve.Robb
#fyi Dan.OConnor

[CL 11603753 by Robert Manuszewski in 4.25 branch]
2020-02-25 10:31:37 -05:00
phillip kavan
c86d61af68 Fix Find-in-Blueprint search thread deadlock caused by improper handling of unloaded LevelScript Blueprint assets.
#rnx
#jira UE-88780
#rb Ben.Hoffman

#ROBOMERGE-OWNER: phillip.kavan
#ROBOMERGE-AUTHOR: phillip.kavan
#ROBOMERGE-SOURCE: CL 11577288 via CL 11577289 via CL 11577291
#ROBOMERGE-BOT: RELEASE (Main -> Release-4.25Plus) (v654-11333218)
#ROBOMERGE[RELEASE]: Release-4.25

[CL 11577340 by phillip kavan in 4.25-Plus branch]
2020-02-21 13:51:50 -05:00
jamie dale
dd2af9acb9 Fixed incorrect behavior of FField::GetFullGroupName
This was inconsistent with the old behavior of the UField version.

#jira
[FYI] Robert.Manuszewski
#rb Robert.Manuszewski
#rnx

#ROBOMERGE-SOURCE: CL 11577105 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11577115 by jamie dale in 4.25-Plus branch]
2020-02-21 13:28:56 -05:00
johan torp
1d46dbd040 Make StaticFindObject handle nested subobjects when searching for any package without a package pointer
This has the exact same semantics as the original 4.22 implementation based on EndsWith(GetPathName()), except this implementation ignores the exact delimiter being used, i.e. dots  and colons can be swapped. Nobody should be searching for object paths with wrong delimiters though.

#rb robert.manuszewski
#jira UE-86055
#robomerge[core] -core
#ushell-cherrypick of 11279462 by Johan.Torp

#ROBOMERGE-SOURCE: CL 11575470 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11575677 by johan torp in 4.25-Plus branch]
2020-02-21 09:42:12 -05:00