Commit Graph

853 Commits

Author SHA1 Message Date
robb surridge
4db3abad42 Reword confirmation dialog for existing assets.
#jira UE-198862
#rb brooke.hubert

[CL 33238041 by robb surridge in ue5-main branch]
2024-04-25 13:54:24 -04:00
alexis matte
03ab547399 Interchange: If we discover we override an existing asset before starting the import, enqueue a real re-import.
#rb JeanLuc.Corenthin
#rnx

[CL 33180214 by alexis matte in ue5-main branch]
2024-04-23 17:13:02 -04:00
danny couture
a01131037f [ALT]
- Deprecate GIsEditorLoadingPackage global and use accessors instead so we can ensure thread-safety
 - Make GIsEditorLoadingPackage compatible with ALT
 - Prevent GIsEditorLoadingPackage from being misused

#jira UE-203917
#rb kevin.macaulayvacher

[CL 33165370 by danny couture in ue5-main branch]
2024-04-23 07:41:00 -04:00
robert millar
c07ec3f560 Fix use of deprecated method
[CL 33120692 by robert millar in ue5-main branch]
2024-04-19 18:31:08 -04:00
robert millar
f699103d4a Making collection manager thread safe to allow future work to run content browser search in parallel.
Deprecate GetLastError and replace with FText* output parameters on fallible methods.
Use hierarchy of guard types to document access requirements for internal methods.
Separate cache updates from cache access. Cache updates must be performed explicitly so that read->write lock update and possible preemption is clear.

#rb logan.buchy

[CL 33120048 by robert millar in ue5-main branch]
2024-04-19 18:17:59 -04:00
bob tellez
aa72a7b58b [Backout] - CL33009366
[FYI] robert.millar
Original CL Desc
-----------------------------------------------------------------
Fix use of deprecated method

[CL 33030136 by bob tellez in ue5-main branch]
2024-04-17 02:18:35 -04:00
bob tellez
b0bbbcd9bf [Backout] - CL33005160
[FYI] robert.millar
Original CL Desc
-----------------------------------------------------------------
Making collection manager thread safe to allow future work to run content browser search in parallel.
Deprecate GetLastError and replace with FText* output parameters on fallible methods.
Use hierarchy of guard types to document access requirements for internal methods.
Separate cache updates from cache access. Cache updates must be performed explicitly so that read->write lock update and possible preemption is clear.

#rb logan.buchy

[CL 33030091 by bob tellez in ue5-main branch]
2024-04-17 02:10:31 -04:00
robert millar
bef6cb4f15 Fix use of deprecated method
[CL 33009563 by robert millar in ue5-main branch]
2024-04-16 14:47:01 -04:00
robert millar
820b6c0952 Making collection manager thread safe to allow future work to run content browser search in parallel.
Deprecate GetLastError and replace with FText* output parameters on fallible methods.
Use hierarchy of guard types to document access requirements for internal methods.
Separate cache updates from cache access. Cache updates must be performed explicitly so that read->write lock update and possible preemption is clear.

#rb logan.buchy

[CL 33005243 by robert millar in ue5-main branch]
2024-04-16 12:54:49 -04:00
robert millar
afb65887a1 Optimizing path permission list checks in ContentBrowserAssetDataSource by optimizing the checks themselves and skipping checks for child paths where possible.
Store paths in permission lists in TDirectoryTree so that checks scale with path depth rather than number of paths.
Add PassesStartsWithFilterRecursive which can return whether a Fail/Pass result for a particular path can be followed by a Pass/Fail result for a child path. (e.g. a path is allowed and there are no explicit denials for any children of that path)
Deprecate GetDenyList and GetAllowList.
Add unit tests for FPathPermissionList.

#rb Julien.StJean, Rex.Hill

[CL 32868537 by robert millar in ue5-main branch]
2024-04-10 19:34:36 -04:00
robert millar
25a0122eb2 Workaround for crash serializing CDOs: Skip text properties
#rb Jamie.Dale

[CL 32837365 by robert millar in ue5-main branch]
2024-04-09 16:05:05 -04:00
julien stjean
c4d205f74f Removed the cause of the some warning in our asset mirgration test.
One was caused by the import validation not accounting for the package remapping when validating the class of the import in the linkerload.

The other was caused by some code in the open world tech that asked the asset registry to scan for a file that doesn't exist. This one is resolved by putting the flag to tell the engine that the instanced package from migration don't have on disk file.

#jira UE-209054

#rb JeanLuc.Corenthin, Francis.Hurteau

[CL 32792908 by julien stjean in ue5-main branch]
2024-04-08 10:46:56 -04:00
andrew phillips
22e4c49766 Fix for using Headerpatching issues when running LCW automated test.
Requires
Valkyrie.CopyProjectUsingAssetHeaderPatching true
Valkyrie.UseAssetToolsHeaderPatching true

There are 2 parts to the fix.
1. The header patcher now detects if the new string has the _$number, and uses the parsing constructor which sets the FNames number consistently. else it uses the original number in that particular FName.
2. The generation of the patching maps now look for sources that have the _$number, and create entries with those stripped.


#rb Francis.Hurteau

[CL 32502290 by andrew phillips in ue5-main branch]
2024-03-26 05:27:41 -04:00
richard malo
c9222edfdb Added new class UDeletedObjectPlaceholder to properly handle when an external package contains no more object.
- Ground work for full support of moving an actor from one External Data Layer to another
- Fixes the Save Package dialog not showing the last valid actor's display name (instead was showing the package name)
- Fixes empty packages not properly cleaned up by ULevel::CleanupLevel
- Changing level's bUseExternalActors from true to false and reloading the level without saving now properly works
#rb jeanfrancois.dube

[CL 32209376 by richard malo in ue5-main branch]
2024-03-13 08:01:53 -04:00
robert millar
c26ffc47ad Fix UE_PROJECTION with constructor.
[CL 32160192 by robert millar in ue5-main branch]
2024-03-11 14:04:23 -04:00
robert millar
7385ad9ece UX for updating redirectors
- Refactor AssetViewUtils::LoadAssetsIfNeeded to take settings struct and return enum code.
- Allow cancelling when loading redirectors or when loading referencers.
- Use AssetViewUtils::LoadAssetsIfNeeded in asset view context menu a well as folder tree to unify progress/cancellation for both

[CL 32159723 by robert millar in ue5-main branch]
2024-03-11 13:52:43 -04:00
aditya ravichandran
2bb9133247 AssetTools: Fix a bug where FAssetDefinitionProxy::GetIconBrush was calling AssetDefinition->GetThumbnailBrush instead of AssetDefinition->GetIconBrush
#rb JeanMichel.Dignard

[CL 31945684 by aditya ravichandran in ue5-main branch]
2024-03-01 11:36:04 -05:00
yafes sahin
8c78548e84 - IAssetTools.h expose bPrompt and create bIgnoreDependencies
- AssetTools.cpp add a case to only copy the selected assets and ignore the dependencies (usecase for automation)
- Added BP example that implements the scripted asset action with the new migrationOption

#rb Julien.StJean, Takashi.Kuribayashi
[FYI] Michael.Lentine
#tests

[CL 31930249 by yafes sahin in ue5-main branch]
2024-02-29 19:11:14 -05:00
robert millar
396fb96f1d Fix up redirectors flow update
- Rename menu entries to Update (Redirector) Referencers
- No separate options for fixup vs fixup and keep
- After fixup, prompt user to delete redirectors if project settings allow
- After fixup, show users what files could not be checked out/saved and what redirectors remain

#rb brooke.hubert

[CL 31699181 by robert millar in ue5-main branch]
2024-02-21 17:10:19 -05:00
alex kahn
4f00bd4dab [Backout] - CL31691763 - CIS Compile Error
#rnx
[FYI] robert.millar
Original CL Desc
-----------------------------------------------------------------
Fix up redirectors flow update
- Rename menu entries to Update (Redirector) Referencers
- No separate options for fixup vs fixup and keep
- After fixup, prompt user to delete redirectors if project settings allow
- After fixup, show users what files could not be checked out/saved and what redirectors remain

#rb brooke.hubert

[CL 31696448 by alex kahn in ue5-main branch]
2024-02-21 16:07:05 -05:00
robert millar
872b6adee6 Fix up redirectors flow update
- Rename menu entries to Update (Redirector) Referencers
- No separate options for fixup vs fixup and keep
- After fixup, prompt user to delete redirectors if project settings allow
- After fixup, show users what files could not be checked out/saved and what redirectors remain

#rb brooke.hubert

[CL 31691912 by robert millar in ue5-main branch]
2024-02-21 14:16:54 -05:00
julien stjean
ca34575235 Fix the blocked import of a folder when using the extension permissions.
Also I moved the permissions logic closer to the code that actually handle the import.

#rb Alexis.Matte

[CL 31685813 by julien stjean in ue5-main branch]
2024-02-21 11:41:24 -05:00
steve robb
f8d47335a4 Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).
[CL 31626444 by steve robb in ue5-main branch]
2024-02-19 16:51:58 -05:00
andrew phillips
88fb5f9039 Silencing warning about not copying Verse packages in advanced copy with header patching.
[CL 31257531 by andrew phillips in ue5-main branch]
2024-02-07 10:17:20 -05:00
jeanluc corenthin
1a38568642 Added logic to only disable FBX level import
#jira UE-205931
#rb Alexis.Matte

[FYI] flavien.picon

[CL 31187134 by jeanluc corenthin in ue5-main branch]
2024-02-05 15:28:45 -05:00