Commit Graph

171 Commits

Author SHA1 Message Date
maxwell hayes
1c89213cf7 [Metasounds] setting object arrays from bp not working (Fix fallout from UE-213913)
#jira UE-215523
#rb phil.popp
#rnx
#tests Metasound Blueprint Engine tests, AQ_Metasounds test map

[CL 33874514 by maxwell hayes in ue5-main branch]
2024-05-23 16:53:33 -04:00
maxwell hayes
2a6834cc22 [MetaSounds] Maintain object parameters set in blueprint after un-virtualization.
#jira UE-213913
#rb Rob.Gay
[FYI] Seth.Weedin, Helen.Yang

[CL 33781662 by maxwell hayes in ue5-main branch]
2024-05-20 18:08:51 -04:00
rob gay
711a973c73 - Move MetaSoundAssetSubsystem& BuilderSubsystem implementations to monolithics that are initialized at MetaSoundEngine module load for safety
- Avoids PreDefault vs Default module Init which can interact negatively and obscurely with EngineSubsystems not being loaded prior to certain builds/scenarios where serialized assets are loaded earlier
- Sunset existing Subsystem non-UFUNCTION calls not pertaining to direct Blueprint exposition
- Optimize AssetManager to use own key vs NodeRegistryKey and TopLevelPaths vs SoftObjectPaths
- Misc module clean-up
- Misc callsite refactors to use new monolithics
#rb phil.popp
[FYI] sondra.moyls, helen.yang

#tests EngineTest & AudioQA Automation PIE Packaged Build -game

[CL 33522338 by rob gay in ue5-main branch]
2024-05-08 14:53:53 -04:00
helen yang
e88cefd8c5 Refactor MetaSound Array Random Get Node shared state
- Add input for Shared State Behavior to share state between other array random nodes that are the same node, same node in composition, or same data
- Simplify behavior for reinitializing and updating state
- Add hidden friend GetHashType hash functions to MetaSound types
- Add output for chosen index
- Tooltip updates and debug logging

#jira UE-211778
#jira UE-172282
#rb phil.popp, aaron.mcleran

[CL 33495083 by helen yang in ue5-main branch]
2024-05-07 16:54:01 -04:00
aaron mcleran
25e7e03cdf Adding StartTime interface as an optional MetaSound Source interface.
StartTime used in BP API and Sequencer will now be forwarded to the MetaSound through this interface. The MetaSound can decide what to do with that information -- i.e. sound design what 'Start Time' means.

#rb Phil.Popp, Rob.Gay, Brian.Chrisman
#jira UE-211683

[CL 33272664 by aaron mcleran in ue5-main branch]
2024-04-26 14:51:16 -04:00
rob gay
e8e0c199a2 Remove dependency on MetaSound engine subsystems of any kind being required to register MetaSounds with frontend
#rb rob.gay
#rnx
[FYI] sondra.moyls, phil.popp, helen.yang

[CL 33199328 by rob gay in ue5-main branch]
2024-04-24 10:36:28 -04:00
rob gay
b3ab5744bf - Fix for attempting to access EngineSubsystem during MetaSound versioning (serialization), which can assert when apparently certain commands in certain contexts can attempt to preload assets prior to the init phase.
- Minor Fix for LocText duplication
#tests BuildCookRun, -game, version MetaSounds assets in editor, PIE

[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33102023 by rob gay in ue5-main branch]
2024-04-19 10:09:04 -04:00
bob tellez
416e6c17d8 [Backout] - CL33084850
[FYI] Rob.Gay
Original CL Desc
-----------------------------------------------------------------
Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33096249 by bob tellez in ue5-main branch]
2024-04-18 23:43:05 -04:00
rob gay
50a661b140 Reverting early return speculative fix for warnings and removing warning for now when attempting to cache MetaSound runtime data to fix sequencer warnings.
#rb rob.gay
[FYI] phil.popp, helen.yang
#jira UE-194159
#rnx

[CL 33089038 by rob gay in ue5-main branch]
2024-04-18 18:24:11 -04:00
rob gay
184db3803e Version Metasound Document to include all ed data and make all Metasound EdGraph data transient
- Add input template nodes
- Add comment node data to document
- Keep references to member literal data (i.e. knob/slider ranges) in document metadata to ensure continued serialization and flexibility to add more editor-only fields and literal metadata
- Misc builder API updates, bug fixes and migration of controllers to builder API in anticipation of pages
- Sunset non-deterministic guid cvar
#rb phil.popp, helen.yang
[FYI] sondra.moyls
#tests Standard Automated Audio Tests, EngineTests, Offline QA Smoke pass, CPR, etc., extensive MetaSound Editor use, -game MetaSound qa levels, AudioUnitTests
#jira UE-194159

[CL 33085078 by rob gay in ue5-main branch]
2024-04-18 16:50:48 -04:00
phil popp
f0941560d0 Fix ensure on retrieving quality settings from none-asset metasound.
#jira UE-210369, FORT-724365
#rb rob.gay

[CL 32448309 by phil popp in ue5-main branch]
2024-03-22 16:20:00 -04:00
jimmy smith
048f5a5a11 Fix for perf regression in Metasounds
#rb Maxwell.Hayes, phil.popp
#tests Local verification

[CL 32409889 by jimmy smith in ue5-main branch]
2024-03-21 15:21:31 -04:00
jimmy smith
0637da8f9e Fix non-cooked quality settings by adding a cook stage the MetasoundSource to correctly save them out per platform.
Previously the PerPlatformSettings was added to the MetasoundSettings, however as this is not a true asset they weren't being correctly cooked.
The code previously pulled the global settings, then allowed overrides upon this. This decision is now made during cook.
#rb jake.burga, Josh.Adams
#tests Shelve tested back and forth with Sondra Moyles
#jira UE-204075

[CL 32370815 by jimmy smith in ue5-main branch]
2024-03-20 12:42:32 -04:00
jimmy andrews
5e5d976da3 fix unreachable implicit "++iterator" in cases where a for-loop was used to just grab the first element of a set or map
#rb lonnie.li
#lockdown michael.balzer

[CL 31880424 by jimmy andrews in ue5-main branch]
2024-02-28 14:51:06 -05:00
steve robb
f8d47335a4 Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).
[CL 31626444 by steve robb in ue5-main branch]
2024-02-19 16:51:58 -05:00
maxwell hayes
bc39a66768 Cleaning up metasound experimental cvars
#rb Phil.Popp
#jira UE-205183
#rnx

[CL 31180968 by maxwell hayes in ue5-main branch]
2024-02-05 13:30:58 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
sarah noonan
63b9103240 Delay MetaSoundSource calling RegisterGraphWithFrontend if the MetaSoundAssetManager has not been set yet - to facilitate server preloading assets before the manager has been set.
#rb Rob.Gay

[CL 30655975 by sarah noonan in ue5-main branch]
2024-01-17 07:07:19 -05:00
rob gay
b7ecd11142 Remove and assert against registration/unregisteration calls of MetaSound graphs when cooking, and make all node unregistration calls synchronous when cooking
#rb helen.yang
#rnx
#tests AudioUnitTests, AudioQA -run=Cook -TargetPlatform=WindowsClient, rename asset, run Engine 'Audio' Automated Tests

[CL 30402526 by rob gay in ue5-main branch]
2023-12-19 15:55:04 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
rob gay
39b3a6f74c [MetaSounds] Report changes to transmitter and runtime input map when live edits are enabled during Builder audition
#rb charlie.huguenard
#rnx
#tests Audio Engine Tests including ConnectInputAfterAuditionAndThenSetParameter, Audio Unit Tests
#jira UE-201185
[FYI] sondra.moyls

[CL 30045928 by rob gay in ue5-main branch]
2023-12-01 12:57:59 -05:00
helen yang
af275bf607 CIS fix for MetaSound runtime data being created at cook
#rb jimmy.smith

[CL 29573194 by helen yang in ue5-main branch]
2023-11-08 16:09:39 -05:00
phil popp
af5147f91d Fix use of pooled metasounds using preset graph inflation and constructor inputs
#rnx
#rb Maxwell.Hayes

[CL 29431656 by phil popp in ue5-main branch]
2023-11-03 19:38:58 -04:00