Commit Graph

20 Commits

Author SHA1 Message Date
michael nicolella
b120e9ec4f [autortfm]
- fix Verse for loop semantics
- added some VM opcodes:
  - EX_NothingInt32: takes an int argument and is very handy for being a no-op that annotates the bytecode disassembly for debugging and breakpointing
  - EX_AutoRtfmTransact: takes a transaction id and list of expressions to run within an AutoRTFM transaction
  - EX_AutoRtfmStopTransact: takes a transaction id and ends that transaction if we are inside of it, otherwise is a no-op
  - EX_AutoRtfmAbortIfNot: causes a transaction abort if the boolean expression is false
#preflight 64640105d62884a78fe0472c

[CL 25503240 by michael nicolella in ue5-main branch]
2023-05-17 01:47:09 -04:00
dan oconnor
4624cd5c03 Fix memory scribble when constructing struct literals with bitfields
#jira UE-182822
#preflight 64505e7ce73c4d47c3dee33a
#rb Phillip.Kavan

[CL 25305731 by dan oconnor in ue5-main branch]
2023-05-02 14:43:26 -04:00
bryan sefcik
de1956f47b Ran IWYU on Public headers under Engine/Source/Developer/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21064294 by bryan.sefcik
#jira
#preflight 62d5c2111062f2e63015e598

#ROBOMERGE-OWNER: bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21155249 via CL 21158121 via CL 21161259
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21182053 by bryan sefcik in ue5-main branch]
2022-07-20 12:03:45 -04:00
dave jones2
bcadd23489 UE-151338 - Implement refactored implicit conversion for math types.
Removed container and struct conversions from the script VM. This introduced complexity that the VM doesn't need, nor did it scale for the various struct types that we want to implicitly convert in Blueprints. Instead, the script VM is *only* aware of float<->double conversion. Container and struct conversions have now been moved to BlueprintTypeConversions. Currently, only the existing FVector3f<->FVector3d conversion has been added, but the remaining LWC types will be added in a subsequent change.

During Blueprint compilation of container and struct conversions, we now inject a function call into the bytecode that performs the conversion, which is better suited to the task instead of burdening the VM with the work. One drawback to this technique is that containers are slightly more inefficient when it comes to conversions. They won't know their type(s) ahead of time, which requires dynamically looking up a conversion function at runtime. We can possibly optimize this further, but the generaly recommendation is to avoid implicit conversions of container types when possible.

Additionally, a couple of convenience functions were added to the KismetCastingUtils to help remove a fair amount of boilerplate code that was used for implicit casting in various node types. ScriptCastingUtils.h was also removed since the VM no longer needs to concern itself with complex conversions.

#jira UE-151338
#preflight 629a507fb42820769428c133
#rb phillip.kavan

[CL 20560449 by dave jones2 in ue5-main branch]
2022-06-08 13:50:57 -04:00
dave jones2
014e3f3a64 Fixed crash in the script disassembler.
We were still assuming that rotators and transforms were using floats, which is no longer the case with LWC.

#jira none
#preflight 6243573ef4217035fa711b74
#rb benjamin.fox

[CL 19559625 by dave jones2 in ue5-main branch]
2022-03-30 13:17:01 -04:00
fred kimberley
7fbfaf57c8 Require explicit constructors/casts when converting between FVector, FVector3d, and FVector3f.
#jira UE-122078
#rb Andrew.Davidson, Colin.McGinley
#preflight standard build

#ROBOMERGE-AUTHOR: fred.kimberley
#ROBOMERGE-SOURCE: CL 18817999 in //UE5/Release-5.0/... via CL 18818012 via CL 18822871
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824721 by fred kimberley in ue5-main branch]
2022-02-02 07:59:31 -05:00
dave jones2
c8574d3b74 Merging //UE5/Dev-LargeWorldCoordinates [at] 18802167 to //UE5/Release-5.0
Blueprint real number support.

This change deprecates the use the of "float" and "double" types in Blueprints in favor of a new "real". By default, "real" is back by a double precision floating point number. However, it can be single precision if the number is a native float property or function parameter. This distinction won't be visible to the Blueprint user: in both instances, they'll be represented by "real" pin types. During deserialization, we'll automatically convert Blueprint pin types to use real/doubles, unless they're used to represent native code (including delegate signatures).

One consequence of this change is that we need to perform implicit casts between single and double precision real numbers. During Blueprint compilation, the compiler will detect points in the graph for when either a widening or narrowing conversion needs to occur. Subsequently, the script bytecode will contain a new cast instruction that performs the conversion. This also works on container types, but each entry in the container will have to be converted. This can introduce unwanted overhead for large containers that are frequently passed between Blueprint and native code.

The scope of this change affects Blueprints used by Gameplay, Animation, Control Rig, and UMG.

#rb marc.audy (serialization changes)
#jira UE-116484
#preflight 61f8bdd5a2514ba12ff7bdfc

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18809077 in //UE5/Release-5.0/... via CL 18809455 via CL 18822548
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823569 by dave jones2 in ue5-main branch]
2022-02-02 05:50:50 -05:00
andrew davidson
a687bd02ed Merge //UE5/Dev-LWCRendering[at]18755967
LWC: Serialize LWC double types as double. Enable double bulk serialization for all bulk-serializable-as-float LWC types.
#lockdown marc.audy
#rb marc.audy
#preflight 61f83517114ec25fe0ad5f15

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18795077 in //UE5/Release-5.0/... via CL 18795472 via CL 18797572
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18798048 by andrew davidson in ue5-main branch]
2022-01-31 16:44:37 -05:00
Andrew Davidson
3ddc3a4da3 Merge up from //UE5/Dev-LargeWorldCoordinates
#rb none

[CL 16211417 by Andrew Davidson in ue5-main branch]
2021-05-05 15:07:25 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
ben hoffman
141ecb374b Double property support in blueprint for UFunctions, BP Variables, and conversions to floats
#jira UE-94120
#rb dan.oconnor
#fyi michael.noland

[CL 13648510 by ben hoffman in ue5-main branch]
2020-06-08 19:02:07 -04:00
tim tillotson
f2ccc5a4ed Merging using Dev-Solaris=>FN/Main CL#12453850
#rb none

#ROBOMERGE-OWNER: tim.tillotson
#ROBOMERGE-AUTHOR: tim.tillotson
#ROBOMERGE-SOURCE: CL 12479490 via CL 12479911 via CL 12479912
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12487295 by tim tillotson in Main branch]
2020-03-30 12:03:26 -04:00
ryan durand
471d972e62 Updating copyright for Engine Developer.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870584 by ryan durand in Main branch]
2019-12-26 15:32:37 -05:00
Robert Manuszewski
7b6f840f7f Copying //UE4/Dev-Core @ 10708550 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 10708666 by Robert Manuszewski in Main branch]
2019-12-13 11:07:03 -05:00
mike beach
47f28bcf22 Copy up from DS[at]10490711 to Main.
#rb copy.up


#ROBOMERGE-OWNER: mike.beach
#ROBOMERGE-AUTHOR: mike.beach
#ROBOMERGE-SOURCE: CL 10490877 via CL 10491146
#ROBOMERGE-BOT: (v606-10482310)

[CL 10491151 by mike beach in Main branch]
2019-12-02 17:55:36 -05:00
nick whiting
adef5d933e Back out changelist 10320278
#rb Merge

#ROBOMERGE-OWNER: nick.whiting
#ROBOMERGE-AUTHOR: nick.whiting
#ROBOMERGE-SOURCE: CL 10320789 via CL 10320914
#ROBOMERGE-BOT: (v593-10286020)

[CL 10321110 by nick whiting in Main branch]
2019-11-20 12:17:05 -05:00
nick whiting
de032726cd Copy up from DS to Main
#rb CopyUp


#ROBOMERGE-SOURCE: CL 10320278 via CL 10320294
#ROBOMERGE-BOT: (v593-10286020)

[CL 10320316 by nick whiting in Main branch]
2019-11-20 11:19:58 -05:00
marc audy
dbcf07a558 Use new inline versions of substring functions
Fix up nearby cases where ESearchCase::CaseSensitive should have been used
#jira
#rnx
#rb

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 10309793 via CL 10309818
#ROBOMERGE-BOT: (v593-10286020)

[CL 10309932 by marc audy in Main branch]
2019-11-19 13:27:07 -05:00
Marc Audy
5fb00d38a0 Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 8902520
#rb
#rnx

[CL 8914290 by Marc Audy in Dev-Framework branch]
2019-09-19 17:46:29 -04:00
Markus Breyer
1e5d083ed3 Moved Kismet ScriptDisassembler into separate module
#rb mike.beach
#rnx


#ROBOMERGE-OWNER: Markus.Breyer
#ROBOMERGE-AUTHOR: markus.breyer
#ROBOMERGE-SOURCE: CL 8852703 via CL 8853914 via CL 8868791
#ROBOMERGE-BOT: (v426-8886397)

[CL 8887873 by Markus Breyer in Main branch]
2019-09-19 10:57:39 -04:00