Commit Graph

105 Commits

Author SHA1 Message Date
alexei lebedev
086fada508 [mutable] Fixed projections permanently appearing as default textures when quickly changing between two options.
The problem was that an update was cancelled because it was a subset of the current descriptor of the instance, but didn't take into consideration that the current running operation was modifiying the descriptor of the instance.

[REVIEW] [at]jordi.rovira, [at]pere.rifa
#rnx

#localization none
#tests PIE Frontend

[CL 27070410 by alexei lebedev in ue5-main branch]
2023-08-14 10:47:31 -04:00
pere rifa
fc053a2c8a [Mutable] Fix missing texture parameters and skipped updates.
Texture parameters of the ongoing update were being uncached by incoming petitions if they had different parameters.
Asking for an update of the current instance being updated would sometimes skip it and mark it as successful.

#rnx

[CL 27000866 by pere rifa in ue5-main branch]
2023-08-10 14:14:20 -04:00
jordi rovira
163275047e [mutable] More compact packing of binary blobs for parameter values in generated resources keys.
Changed external image IDs to use FNames.
Single cache for all models.
[REVIEW] [at]gerard.martin
#rnx

[CL 26700249 by jordi rovira in ue5-main branch]
2023-07-31 03:24:06 -04:00
pere rifa
4309007ae5 [Mutable] Fix TextureParameters being removed from the ImageProvider's cache while still in use.
#rnx
#rb gerard.martin

[CL 26668136 by pere rifa in ue5-main branch]
2023-07-28 06:06:02 -04:00
max garcia
19f7e7aa24 [mutable] Changed table material functionality. Now a table material works as a real material swtch instead of creating a swtch for each modified parameter.
+ Now, if a node is linked to a texture parameter, the image pin mode would not be able to be modified.

#rnx
#rb alexei.lebedev, gerard.martin

[CL 26665521 by max garcia in ue5-main branch]
2023-07-28 02:20:23 -04:00
gerard martin
cc399ad32b [Mutable] Reduce MutableRuntime memory peak.
Forbidden to do an UpdateImage before releasing the resources from a generation update.

[REVIEW] [at]alexei.lebedev, [at]genis.sole
#rnx

[CL 26602495 by gerard martin in ue5-main branch]
2023-07-26 06:46:59 -04:00
gerard martin
df154c49a5 [Mutable] Fix "Failed to cache external image" warning.
- Some update paths where not adding reference the external images. Added an additional check to detect this kind of errors.
- Task_Game_Lock_Cache was removing old references before adding the new ones.
- Fix LOD updates completely skipping DoUpdateSkeletalMesh.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 26505990 by gerard martin in ue5-main branch]
2023-07-21 03:28:52 -04:00
pere rifa
2850573a87 [Mutable] Disable editor compilations and the CO system tick when the cook commandlet is running.
#rnx
#rb alexei.lebedev

[CL 26482178 by pere rifa in ue5-main branch]
2023-07-20 07:38:13 -04:00
keaton stewart
36aede7dca [Backout] - CL26456500 Main CIS AutoTest Cook Error
[FYI] gerard.martin
Original CL Desc
-----------------------------------------------------------------
[Mutable] Fix "Failed to cache external image" warning.

- Some update paths where not adding reference the external images. Added an additional check to detect this kind of errors.
- Task_Game_Lock_Cache was removing old references before adding the new ones.
- Fix LOD updates completely skipping DoUpdateSkeletalMesh.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 26468715 by keaton stewart in ue5-main branch]
2023-07-19 15:41:16 -04:00
keaton stewart
a03f5af231 [Backout] - CL26458820 Main CIS AutoTest Cook Error
[FYI] pere.rifa
Original CL Desc
-----------------------------------------------------------------
[Mutable] Fix missing material parameters when reusing surfaces between LODs.

#rnx
[REVIEW] gerard.martin

[CL 26468693 by keaton stewart in ue5-main branch]
2023-07-19 15:40:37 -04:00
pere rifa
eb57ea4a86 [Mutable] Fix missing material parameters when reusing surfaces between LODs.
#rnx
[REVIEW] gerard.martin

[CL 26458974 by pere rifa in ue5-main branch]
2023-07-19 09:25:52 -04:00
gerard martin
7323dfc2fc [Mutable] Fix "Failed to cache external image" warning.
- Some update paths where not adding reference the external images. Added an additional check to detect this kind of errors.
- Task_Game_Lock_Cache was removing old references before adding the new ones.
- Fix LOD updates completely skipping DoUpdateSkeletalMesh.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 26457560 by gerard martin in ue5-main branch]
2023-07-19 08:22:35 -04:00
pere rifa
32254df5af [Mutable] Fix incorrect implicit type conversion which resulted in released textures being kept in the generated textures cache.
#rnx
#rb alexei.lebedev

[CL 26432522 by pere rifa in ue5-main branch]
2023-07-18 09:36:44 -04:00
max garcia
b9259952d8 [mutable] Added support for Texture2DArrays (as passthrough textures) to table nodes.
#rnx
#rb pere.rifa

[CL 26282220 by max garcia in ue5-main branch]
2023-06-28 08:14:56 -04:00
pere rifa
058e021819 [Mutable] Replace BoneNames with BoneIds that point to an FName stored in the CO to eliminate strings in the core.
The resources affected by this change are the Meshes, Skeletons, PhysicsBodies, and the bytecode of related operations.
Clean up some commented code.

#rnx
#rb genis.sole
#rb jordi.rovira

[CL 26281283 by pere rifa in ue5-main branch]
2023-06-28 07:02:00 -04:00
pere rifa
06af222aa3 [Mutable] Fix automatic compilation infinite loop when a compilation fails.
Fix excessive logging spam when there's an uncompiled CO.
Fix crash when setting requested LODs.
Tweak some logs.

#rnx

[CL 26279565 by pere rifa in ue5-main branch]
2023-06-28 03:48:44 -04:00
gerard martin
9fbb534307 [Mutable] Fix crash with mutable.EnableImageCache 0.
Renamed CVar to make its purpose clear.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 26253639 by gerard martin in ue5-main branch]
2023-06-27 06:04:11 -04:00
jordi rovira
ad70584cc5 [mutable] Move resource key cache to the System instead of keeping in in every Model.
Add a CVar to control the size of the generated resource cache.
Modify the generated resource cache IDs to include the root address and save time and boilerplate on resource generation.
Cleanup streamers by splitting reader and writer.
[REVIEW] [at]pere.rifa
[REVIEW] [at]gerard.martin
#rnx

[CL 26229303 by jordi rovira in ue5-main branch]
2023-06-26 02:16:47 -04:00
jordi rovira
db4b160865 [mutable] Ensure more temporary image memory is tracked for the budget control.
Fix bug with image magnify on non-blank images.
#rnx
[REVIEW] [at]genis.sole

[CL 26206355 by jordi rovira in ue5-main branch]
2023-06-23 02:01:13 -04:00
alexei lebedev
0c08cd8f31 #rnx
[CL 26178600 by alexei lebedev in ue5-main branch]
2023-06-22 06:24:44 -04:00
alexei lebedev
6bb081518a #rnx
[CL 25929632 by alexei lebedev in ue5-main branch]
2023-06-12 11:06:50 -04:00
pere rifa
03f3c0022b [Mutable] Added logging to most API methods to get and set parameter values of the descriptor.
- Warn about uncompiled CO and missing parameters.
- Small changes in naming some variables to keep them consistent between methods.

#rnx
#rb alexei.lebedev
#rb gerard.martin
[FYI] [at]daniel.broder

[CL 25927467 by pere rifa in ue5-main branch]
2023-06-12 09:36:23 -04:00
gerard martin
efaaed02af [Mutable] Better Load/Save descriptor documentation.
- Changed API to make clear when bUseCompactDescriptor is true, and its implications.
- Improved documentation.

[REVIEW] [at]alexei.lebedev
#rnx

[CL 25868900 by gerard martin in ue5-main branch]
2023-06-08 08:38:29 -04:00
gerard martin
debfcc8050 [Mutable] Renamed TODOs.
#rnx

[CL 25761053 by gerard martin in ue5-main branch]
2023-06-02 10:39:09 -04:00
gerard martin
4347ffc886 [Mutable] Change ClearWorkingMemoryOnUpdateEnd CVar name.
[FYI] [at]alexei.lebedev
#rnx

[CL 25721620 by gerard martin in ue5-main branch]
2023-06-01 04:30:20 -04:00