Commit Graph

3435 Commits

Author SHA1 Message Date
ben zeigler
d02926553a #jira UE-119853 Fix issue where Untracked metadata would not work on arrays of soft pointers
Fix similar issue with IncludeAssetBundlesName
Original fix from Roubert.Rouhani via UDN
#rb none

[CL 16887122 by ben zeigler in ue5-main branch]
2021-07-19 14:50:26 -04:00
Zousar Shaker
47761e865d Changes to ifdef some TObjectPtr and FObjectHandle code to ensure we're not absorbing overhead in non-late-resolve and non-access-tracking builds.
#rb devin.doucette
#preflight 60f5a15beab3510001d5b691

[CL 16885563 by Zousar Shaker in ue5-main branch]
2021-07-19 13:35:01 -04:00
Jamie Dale
26ecf0e7b9 Fixed single-property config updates failing to remove entries that were no longer needed as they matched the CDO
The UObject would write the correct config state, but UpdateSinglePropertyInSection would fail to remove the data for the updated key as it (correctly) wasn't present in the config being applied. This change has it remove the key from the config section if it exists.

#jira UE-119534
#rb Brooke.Hubert, Matt.Peters

[CL 16884096 by Jamie Dale in ue5-main branch]
2021-07-19 11:29:39 -04:00
yangke li
0a48229025 add RGB555A1 texture format support(not supported on Mac)
useful for RVT on mobile platforms, to save the cost of runtime compression
#rb Dmitriy.Dyomin mihnea.balta

[CL 16872220 by yangke li in ue5-main branch]
2021-07-16 11:38:24 -04:00
Zousar Shaker
6305185e3d First pass header changes in support of Engine+ShooterGame TObjectPtr refresh.
#rb devin.doucette

[CL 16865811 by Zousar Shaker in ue5-main branch]
2021-07-15 15:16:50 -04:00
Matt Peters
686e35b862 Generalize IPackageResourceManager::OnEndLoad into FCoreUObjectDelegates::OnEndLoadPackage for use by the BulkDataRegistry, and add UPackage::bHasBeenEndLoaded for BulkDataRegistry to know when a package has finished its initial load serialization.
Add OnEndLoad calls for Async loaded packages, since the editor sometimes uses async loads.
#rb Francis.Hurteau
#rnx

[CL 16861817 by Matt Peters in ue5-main branch]
2021-07-15 09:48:56 -04:00
Steve Robb
0559bde41d Fix for optimized map and set properties serialization when there are no defaults and the container is already populated.
#jira UE-118822
#rb none
#fyi johan.torp

[CL 16843259 by Steve Robb in ue5-main branch]
2021-07-13 17:45:15 -04:00
jordan hoffmann
d14371e681 Fix: The 'const' checkbox should not be visible in the Details tab for Blueprint Library functions.
#jira UE-39711
#rb mark.audy

[CL 16838997 by jordan hoffmann in ue5-main branch]
2021-07-13 13:03:03 -04:00
Michael Noland
12c4b10e37 Core: Made the verbosity of the unintialized reflected property check configurable via ini
- Issues with UObject* properties are upgraded from Warning to Error
- Other types remain the same for both engine and project modules (Display), but engine will soon change to Error as well

Settings can be overridden for either project or engine modules in DefaultEngine.ini (engine defaults are in BaseEngine.ini), e.g.,

[CoreUObject.UninitializedScriptStructMembersCheck]
EngineModuleReflectedUninitializedPropertyVerbosity=Error
ProjectModuleReflectedUninitializedPropertyVerbosity=Warning

#rb marc.audy

[CL 16826159 by Michael Noland in ue5-main branch]
2021-07-12 11:49:03 -04:00
ionut matasaru
338b2dc613 [Insights]
- Fixed the trace of scope cycle counters for UObject to be enabled everywhere where FScopeCycleCounterUObject is used switced by Stats::IsThreadCollectingData().
  - Fixed UObject::CallFunction to trace UObject name for Insights only when GVerboseScriptStats is on.

#rb Catalin.Dragoiu
#fyi Johan.Berg, Jeff.Farris

[CL 16824659 by ionut matasaru in ue5-main branch]
2021-07-12 09:22:58 -04:00
JeanFrancois Dube
320eada9b3 Backout CL16728888 as it doesn't properly handle the ECoreRedirectFlags::Option_MatchSubstring flag, found by running the CoreRedirects unit tests.
#jira UE-118831
#rb none

[CL 16819857 by JeanFrancois Dube in ue5-main branch]
2021-07-10 16:57:55 -04:00
Ben Woodhouse
2e0be09d2f Back out 16780416 for now since it's causing cook failures
#fyi Michael.Noland

[CL 16783107 by Ben Woodhouse in ue5-main branch]
2021-06-25 10:06:21 -04:00
Michael Noland
9366100a2f Core: Changed the verbosity of the unintialized reflected property check to an error for types in engine modules or UObject* properties
#codereview nick.darnell
#preflight 60d50948925f140001249b76

[CL 16780416 by Michael Noland in ue5-main branch]
2021-06-24 20:03:03 -04:00
francis hurteau
c3bd55cb3d Remove the usage of modal message dialog in package saving
Always try to find the likely culprit in case of illegal references

#rb Matt.Peters
#jira UE-115971


#ROBOMERGE-SOURCE: CL 16774967
#ROBOMERGE-BOT: (v836-16769935)

[CL 16774971 by francis hurteau in ue5-main branch]
2021-06-24 12:05:25 -04:00
Matt Peters
07a0af0f5b BulkDataRegistry
Updating FVirtualizedUntypedBulkData and textures to use the BulkDataRegistry.
BulkDataRegistry: Add get/put accessors for the cached BulkDataList of packages.
EditorDomain: Move ClassDigests into a global variable that can be shared with BulkDataRegistry.
EditorDomain: Improve performance of GetFileSize by fetching metadata only.
Tickable Cook Objects, for systems used by the cooker that need to be ticked.
Implementation of the the BulkDataRegistry that uses the DDC cache for persistent storage of the BulkDataList.

#rb Devin.Doucette, Paul.Chipchase, Zousar.Shaker

[CL 16768772 by Matt Peters in ue5-main branch]
2021-06-24 00:50:53 -04:00
aurel cordonnier
d17d20ca36 Merge from Release-Engine-Test @ 16758890 to UE5/Main
This represents UE4/Main @ 16738161 and Dev-PerfTest @ 16737719 (and Release-17.00 @ 16658211)

[CL 16763350 by aurel cordonnier in ue5-main branch]
2021-06-23 17:51:32 -04:00
PJ Kack
93ab2dcb43 GarbageCollection: Improve GC reachability analysis wall time by letting the GT do work using a ParallelFor instead of waiting.
#jira UE-116567
#rb danny.couture
#rnx

[CL 16755950 by PJ Kack in ue5-main branch]
2021-06-23 08:53:57 -04:00
Matt Peters
c70c4d00f1 VirtualizedBulkData: fix incorrect serialized PayloadIds for editordomain versions of non-virtual payloads that virtualize on save; the incorrect paylodIds were noticeable by the "Failed to pull virtual data with guid" error when loading the saved package.
#rb Paul.Chipchase
#rnx

[CL 16754551 by Matt Peters in ue5-main branch]
2021-06-23 04:07:31 -04:00
danny couture
0c5673e3f3 Optimize the ddc fill job
- Avoid redundant iterations and processing of UPackages by implementing a listener instead
  - Process many packages asynchronously (not just one) by keeping them in memory longer and finishing them later
  - Make the ddc fill job wait for async tasks properly
  - Fix texture always being single threaded by allowing async at all time for ddc fill jobs
  - Avoid calling IsCachedCookedPlatformDataLoaded too often on objects still being compiled
  - Use a more sensible max memory usage in WorldPartitionHelpers to avoid calling the GC too often

  - 30m16s to 7m44s when running -run=DerivedDataCache -fill -map=P_Construct_WP -mapsonly -projectonly with hot cache
  - 2h30m to 1h11s when running -run=DerivedDataCache -fill -map=P_Construct_WP -mapsonly -projectonly with cold cache

#rb Zousar.Shaker, Devin.Doucette
#preflight 60d1fd5571002f0001b8880e

[CL 16745009 by danny couture in ue5-main branch]
2021-06-22 12:50:20 -04:00
JeanFrancois Dube
1774c44de3 Bring back 16574112 with proper fix:
Implement fast path for FCoreRedirects::GetMatchingRedirects when looking for a single redirect type.
Saves ~18% of the time spent in FLinkerLoad::FixupImportMap, which is time sliced in a 5ms window in PIE.

#rb francis.hurteau

[CL 16728888 by JeanFrancois Dube in ue5-main branch]
2021-06-21 11:45:54 -04:00
paul chipchase
1178d572e0 Remove UE_USE_VIRTUALBULKDATA and the associated code path, there is now no easy way to revert back to old bulkdata format for StaticMesh/Textures.
#rb Danny.Couture
#rnx
#preflight 60d0386978c3b00001d06c06

* Macro removal
- UE_USE_VIRTUALBULKDATA: Asssumed to be 1.
- UE_VBD_TO_OLD_BULKDATA_PATH: Assumed to be 0 and code paths entirely deleted.
- UE_VBD_CONST: Assumed to be'const'
- Now that these macros are no longer in use some includes of VirtualizationManager.h can be removed (or moved to the cpp).

*VirtualizedBulkData
- No longer need need to include VirtualizationManager.h in the bulkdata header file so that is moved to the cpp.
- Removed ::GetBulkDataSize which was only added to keep compatibility to older code paths. This method has not yet been released publicly(it's not in EA) so we don't need to worry that anyone is actually using it.
- Add a new method ::HasPayloadData that allows the caller to poll if the payload exists and if it has a valid data length rather than calling ::GetPayloadSize (I'd like to move away from the need for calling code to know how large the payload is until the payload is actually pulled as it will make eventual thread safety code easier to do in the future).
- Added a method ::SetCompressionFormat that allows the compression format to be changed. Normally this should only be done when ::UpdatePayload is called but we need a way to fix old textures that were saved with the wrong compression flags for a time and to do that we need to be able to 'reset' the compression format in some cases. The method is documented to try and make it clear that this is not really intended for general use. At some point in the future if the engine mandates that packages be resaved to a specific version we can look into deprecating this call.

*StaticMeshSourceData
- MESHDATAKEY_STATICMESH_DERIVEDDATA_VER is currently 1 character shorter than it should be, but that doesn't seem worth changing the key to fix.

*Texture
- When accessing data from IImageWrapper we can take the data pointer directly from the TArray and give it's ownership to the FSharedBuffer being returned rather than cloning it.
- Deprecated FTextureSource::LoadBulkDataWithFileReader as with VBD it will always return true.
- FMipAllocation cannot yet be deleted as it is still required for Lock/Unlock but we can remove the support for old style FByteBulkData for now. There is further clean up work to be done here but we would have to make bigger changes to the FTextureSource api.
- FMipData can now store the data in FSharedBuffer format. In the future we can allow people to access mips via views rather than always taking copies to reduce unnecessary data transfer. This also eliminates the need to pass in a lock.
- FTextureSource::InitLayered still supports the parameter 'NewData' potentially being nullptr (in which case we set the texture data to uninitialized memory) this is another candidate for a future code clean up.
- Added a ::HasPayloadData to use instead of ::GetSizeOnDisk as in many cases the calling code is only interested if there is data at all and not what the exact size is.

* Testing
- Ran benchmarks before/after for cold cooks of an internal project showing overall cook times going from 1:54:28 down to 1:49:36 on average.

[CL 16727381 by paul chipchase in ue5-main branch]
2021-06-21 08:53:20 -04:00
Per Larsson
03c092dbba Fix non unity Crash reporter compile error
#rb none
#rnx

[CL 16725383 by Per Larsson in ue5-main branch]
2021-06-21 03:37:23 -04:00
Per Larsson
c3b3499a99 Remove dependency to CookOnTheFly module from CoreUObject and Launch when compiling programs
#rb Paul.Chipchase

[CL 16725292 by Per Larsson in ue5-main branch]
2021-06-21 02:42:49 -04:00
Matt Hoffman
afdbbebef0 Matinee: Misc cleanup (code comment changes, etc.)
#jira UE-105313
#rb Trivial
#preflight 60cb86666092ba00014e413d

[CL 16708963 by Matt Hoffman in ue5-main branch]
2021-06-17 14:56:54 -04:00
paul chipchase
af7d850d37 Prevent -inf values from showing up for the MBps entries in Mirage stats logging code.
- If the time for the selection is 0.0 then just use 0.0 as the result, don't divide.

#rb trivial
#preflight 60cb73229f123700012ec005

[CL 16706893 by paul chipchase in ue5-main branch]
2021-06-17 13:41:27 -04:00