ben hoffman
8db01bec86
Add a fallback method of determining the instanced component to use as an asset override in the event that a subobjec thas been added but is not a part of the generated class yet. Do this by checking if the archetype of the GEN_VARIABLE subobject and one on the instance are the same.
...
#jira UE-119138
#rb trivial
#rnx
#preflight 60f0b58a57b3020001337e09
[CL 16869367 by ben hoffman in ue5-main branch]
2021-07-15 19:42:26 -04:00
ben hoffman
03ec155896
Check not only the SimpleConstructionScript's DefaultSceneRootNode, but also the SceneRootComponentTemplate when determining if a subobject is the default scene root. This handles cases where the DefaultSceneRoot node has been updated (like when you drag/drop a new scene component onto it in the Subobject Editor)
...
#jira UE-117876
#rb marc.audy
#rnx
[CL 16854920 by ben hoffman in ue5-main branch]
2021-07-14 16:37:36 -04:00
ben hoffman
1dbcb0df0c
Check if the old scene root was the default scene root that is generated by every BP to determine if it should be deleted or not. This makes the behavior consistent with the old SCS Editor
...
#jira UE-117876
#rb trivial
#rnx
[CL 16854709 by ben hoffman in ue5-main branch]
2021-07-14 16:24:16 -04:00
ben hoffman
5bd5f2561c
CIS fix. Remove ParentObjData from an if statement because there is already a "check" on the variable above. Having it in the if statement was causing other uses of it to flag PVS
...
#jira none
#rb trivial
#rnx
[CL 16854427 by ben hoffman in ue5-main branch]
2021-07-14 16:06:13 -04:00
ben hoffman
51603fdd01
Add an additional check when determining the default scene root to see if a native subobject is the root of it's owning actor.
...
#jira UE-117126
#rb trivial
#rnx
#preflight 60ee0c9119a00600011f491a
[CL 16844692 by ben hoffman in ue5-main branch]
2021-07-13 19:29:01 -04:00
ben hoffman
a38ca94c2d
Add a flag to force deletion on subobjects so that when making a new scene root the CanDelete check will be bypassed.
...
This is needed because when the user drags a new scene component over the existing one, the old one should be deleted but is still marked as the SceneRoot (and cannot be deleted because we have to update the instances of the archetypes)
#jira UE-119151
#rb trivial
#rnx
#preflight 60edf5d0ef22fa000176acdf
[CL 16843507 by ben hoffman in ue5-main branch]
2021-07-13 17:56:24 -04:00
ben hoffman
e467c4e6f6
Fix some spelling mistakes in comments
...
#rb trivial
#rnx
#jira none
[CL 16840894 by ben hoffman in ue5-main branch]
2021-07-13 15:03:42 -04:00
ben hoffman
60c7ca432f
Replace an incorrect check for a child actor with a check for a child actor subtree object.
...
#jira none
#rb trivial
#rnx
[CL 16840124 by ben hoffman in ue5-main branch]
2021-07-13 14:22:17 -04:00
ben hoffman
188d3e325d
If the attachment point is a BP inherited subobject then find the correct archetype attachment point when adding subobjects to an instance
...
#rb marc.audy
#jira UE-117457
#jira UE-119112
#rnx
#preflight 60ec6955ef22fa000150f693
[CL 16837795 by ben hoffman in ue5-main branch]
2021-07-13 11:21:36 -04:00
ben hoffman
a7da155db0
Correctly check if a component is inherited before allowing it to be reparented
...
#jira UE-118270
#rb trivial
#rnx
[CL 16837483 by ben hoffman in ue5-main branch]
2021-07-13 10:53:46 -04:00
ben hoffman
2d93fed50e
Instead of checking if something is a child actor component when attempting to maniuplate it, check if its owner is a CAC instead. If it's owner is a CAC, then it cannot be removed because it is determined by the owning CAC. Before, the code was incorrectly checking if something was just a plain old child actor component, resulting in being unable to delete, reparent, or attach to a child actor component.
...
#jira UE-117132
#jira UE-117332
#jira UE-117327
#jira UE-117329
#rb marc.audy
#rnx
#preflight 60d48296925f1400010bb909
[CL 16773601 by ben hoffman in ue5-main branch]
2021-06-24 10:55:53 -04:00
ben hoffman
ff3b233df8
Use CopyPropertiesForUnrelatedObjects instead of a basic ObjectWriter/Reader combo when duplicating components to properly handle subobjects.
...
#jira UE-68780
#rb marc.audy
#rnx
[CL 16751102 by ben hoffman in ue5-main branch]
2021-06-22 19:04:02 -04:00
ben hoffman
435dcc7d82
Correctly set the module path when creating a C++ class from the subobject data subsystem. This will correctly set the module path so that the error messages are correct from GameProjectUtils::AddCodeToProject. This will make the module selection the same as how the SNewClassDialog handles it for a more consistent and correct experience.
...
#jira UE-116994
#rnx
#rb phillip.kavan
[CL 16748591 by ben hoffman in ue5-main branch]
2021-06-22 16:23:15 -04:00
Jamie Dale
ac95fa3168
Fixed subobject editor not honoring the requested post-delete selection
...
#rb Ben.Hoffman
[CL 16747272 by Jamie Dale in ue5-main branch]
2021-06-22 15:19:31 -04:00
ben hoffman
fb9dde0359
Notify the level editor that a subobject has been changed when adding or deleting a subobject. This ensures that if there is a selected actor instance in the level that it will have it's subobjects properly updated
...
#jira UE-116645
#rb justin.hare
#rnx
#preflight 60cba56378c3b0000138e856
[CL 16711849 by ben hoffman in ue5-main branch]
2021-06-17 17:11:39 -04:00
ben hoffman
b6365aba67
Attach a dupliucated component to the source's parent instead of the source directly
...
#jira UE-118043
#rb trivial
#rnx
[CL 16709163 by ben hoffman in ue5-main branch]
2021-06-17 15:06:40 -04:00
ben hoffman
43f96dd3a6
Fix typo in comment
...
#jira none
#rb trivial
#rnx
[CL 16679627 by ben hoffman in ue5-main branch]
2021-06-15 17:11:10 -04:00
ben hoffman
1ee7ce31ff
Check if a subobject is allowed to be deleted before allowing the subsystem to delete it. This solves the problem where a BP script may not be doing the same validation when calling DeleteSubobjects that the Subobject Editor does.
...
Add logging when a subobject can't be deleted
#jira UE-117853
#rb michael.noland
#rnx
#preflight 60c8def586ce760001d8de51
[CL 16678061 by ben hoffman in ue5-main branch]
2021-06-15 15:39:14 -04:00
ben hoffman
2c4b1df587
Added logging when a blueprint component cannot be deleted when called from blueprints
...
#jira UE-117855
#rb trivial
#rnx
[CL 16665192 by ben hoffman in ue5-main branch]
2021-06-14 17:50:08 -04:00
ben hoffman
e8e72270fb
Remove an unnecessary check from the deletion of subobjects. This check was originally there to confirm that the SCS node being deleted is from the current subobject tree, but is not a valid check anymore when you can call this function from Blueprints as well.
...
#jira UE-117836
#rb trivial
#rnx
[CL 16661733 by ben hoffman in ue5-main branch]
2021-06-14 14:35:04 -04:00
ben hoffman
1dba26f55d
Automatically select a new component for rename upon duplication.
...
#jira UE-117759
#rb phillip.kavan
#rnx
#preflight 60c2bc6c1264df0001bc76ee
[CL 16635347 by ben hoffman in ue5-main branch]
2021-06-10 22:27:25 -04:00
ben hoffman
84329c50da
Add a GetDragDropDisplayText function to subobject data to allow for easier conversions to FText for drag/drop operations
...
#jira UE-117068
#rb trivial
#rnx
#preflight 60c2657279a7fe00017a3617
[CL 16629717 by ben hoffman in ue5-main branch]
2021-06-10 16:38:49 -04:00
ben hoffman
388f3db4a7
Fix duplication of an inherited blueprint variables in the subobject instance editor by using the correct ComponentInstanceInActor instead of the SCS node
...
#jira UE-117371
#rb marc.audy
#rnx
[CL 16625879 by ben hoffman in ue5-main branch]
2021-06-10 13:52:23 -04:00
ben hoffman
74ba7a83b6
Fix SA warning with NewSCSNode in PasteSubobjects
...
#jira none
#rb trivial
#rnx
[CL 16623623 by ben hoffman in ue5-main branch]
2021-06-10 11:05:53 -04:00
ben hoffman
dbe9a24a9a
Add clearer logging when creating a new BP component
...
#jira UE-117725
#rb trivial
#rnx
#preflight 60c161b8b68c700001b51b83
[CL 16617905 by ben hoffman in ue5-main branch]
2021-06-09 22:01:11 -04:00
