Commit Graph

132 Commits

Author SHA1 Message Date
phil popp
33b7b2a911 MetaSound Frontend Speedups
- Cached array indices for TAccessPtr point to an object in an array
- Reduced number of call sites to TAccessPtr::Get()
- Avoid creating registry keys when possible.
#jira UE-116999
#rb Rob.Gay


#ROBOMERGE-SOURCE: CL 16830765
#ROBOMERGE-BOT: (v836-16769935)

[CL 16830791 by phil popp in ue5-main branch]
2021-07-12 16:12:36 -04:00
phil popp
8641e46010 Fix missing set of MetaSound archetype version
#rb none


#ROBOMERGE-SOURCE: CL 16825219
#ROBOMERGE-BOT: (v836-16769935)

[CL 16825220 by phil popp in ue5-main branch]
2021-07-12 10:31:06 -04:00
rob gay
ade25fa5d3 Fix for ensure when attempting to mark package dirty when building generator/updating via AssetSubsystem
[FYI] phil.popp
#jira UE-118903
#rb trivial
#lockdown jeff.farris


#ROBOMERGE-SOURCE: CL 16775810
#ROBOMERGE-BOT: (v836-16769935)

[CL 16775845 by rob gay in ue5-main branch]
2021-06-24 13:29:50 -04:00
phil popp
4c942021ae Creating metasound archetype registry and upgrade path
#rb Rob.Gay


#ROBOMERGE-SOURCE: CL 16766481
#ROBOMERGE-BOT: (v835-16672529)

[CL 16766487 by phil popp in ue5-main branch]
2021-06-23 20:07:53 -04:00
ben zeigler
4a7692cc89 Fix compile error on older MSVC that can't handle defaulting class functions inside templates, no functional change
#rb phil.popp

[CL 16751058 by ben zeigler in ue5-main branch]
2021-06-22 18:58:13 -04:00
rob gay
4971cd6678 UX Scaffolding for MetaSound Composition/Presets Part 2
- Leverage AssetRegistry/Manager to only load data on MetaSounds required to register (disabled until frontend registry supports this)
- Drag-And-Drop assets on MetaSound Graph
- Move ConvertToPreset to toolbar (WIP, still need to properly hide when clicked instead of closing editor blindly, has issue with refresh)

#rb phil.popp
#preflight 60c9a0a83e1b3c0001335ee7


#ROBOMERGE-SOURCE: CL 16689213
#ROBOMERGE-BOT: (v835-16672529)

[CL 16689237 by rob gay in ue5-main branch]
2021-06-16 11:20:44 -04:00
phil popp
23b0cd8280 Fixing MetaSound use of FNodeClassInfo and FNodeRegsitryKey
#rb Rob.Gay
#preflight 60c7b1c5f7cffb0001188650


#ROBOMERGE-SOURCE: CL 16664021
#ROBOMERGE-BOT: (v834-16658389)

[CL 16664038 by phil popp in ue5-main branch]
2021-06-14 16:45:51 -04:00
phil popp
7832953e09 CIS fix for GetTypeHash scope
#rb none
#rnx


#ROBOMERGE-SOURCE: CL 16642853
#ROBOMERGE-BOT: (v833-16641396)

[CL 16642871 by phil popp in ue5-main branch]
2021-06-11 12:23:36 -04:00
phil popp
5e61f819c5 CIS fix for unintended recursive function call when GetTypeHash(int32) not visible to translation unit.
#rb none
#rnx
#preflight 60c208919e139d000103abca


#ROBOMERGE-SOURCE: CL 16622715
#ROBOMERGE-BOT: (v830-16605563)

[CL 16622728 by phil popp in ue5-main branch]
2021-06-10 10:02:57 -04:00
phil popp
dc31cc664a Adding dedup logic for subgraph node registration
#rb Rob.Gay
#preflight 60c122be44f42400015599c9


#ROBOMERGE-SOURCE: CL 16612856
#ROBOMERGE-BOT: (v828-16531559)

[CL 16614296 by phil popp in ue5-main branch]
2021-06-09 18:17:31 -04:00
rob gay
0e4f7a7c51 MetaSound UI/UX Composition/Preset Scaffolding
- Revive UMetaSound Asset type
- Revive MS Output generation
- Fix copy pasta'ed type name so MetaSound Source shows up properly in editor
- Clean-up to dynamic doc version reporting if required (show the new version number in log)
- Add versioning to update the RootGraphClass name & add DisplayName

MetaSound Registry Scaffolding Part 1 (From Phil Popp)

#rb phil.popp
#jira UE-117108
#jira UE-117109
#jira UE-117110
#preflight 60bf11780c76f90001db5f5f


#ROBOMERGE-SOURCE: CL 16587155
#ROBOMERGE-BOT: (v828-16531559)

[CL 16587204 by rob gay in ue5-main branch]
2021-06-08 10:52:31 -04:00
rob gay
1d95cce772 Fix for unserialized MetaSound version info reporting default value, which is higher version than actual version, causing document transform code to not execute for existing assets.
#rb trivial
#jira UE-117527
[FYI] mike.beach
[FYI] sondra.moyls


#ROBOMERGE-SOURCE: CL 16583168
#ROBOMERGE-BOT: (v828-16531559)

[CL 16583205 by rob gay in ue5-main branch]
2021-06-07 23:58:26 -04:00
rob gay
66786d5466 - Up default MetaSound Document Version to avoid running Version Transform on new Doc
- Add field for setting graph as editable (to be used for presets)
#jira none
#rb trivial
#preflight 60b7c7688e7ee10001cc79f6

#ROBOMERGE-SOURCE: CL 16538158 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v828-16531559)

[CL 16538194 by rob gay in ue5-main branch]
2021-06-02 15:41:32 -04:00
rob gay
4b67969932 - Fix for sticky MetaSound literals when more than one external node attempts to set literals for a vertex with the same ID
- Fix for not serializing MetaSound EdGraph (again...)
#rb aaron.mcleran
#jira UE-117041
#preflight 60b71e4f5719ca00015b604c

#ROBOMERGE-SOURCE: CL 16534985 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v828-16531559)

[CL 16535029 by rob gay in ue5-main branch]
2021-06-02 11:30:20 -04:00
rob gay
e26ac0345b - Migrate MetaSound InputLiterals to DefaultLiterals housed on FrontendNodes
- Add FrontendGraphBuilder support for generating VariableNodes for DefaultLiterals if no connection is provided on External/Output nodes
- Move node names to be guids (they're never seen by the user and this will be easier to migrate later)
- Fix DisplayName logic to be unique against one another SEPARATELY from node name logic
- Fix for MetaSounds not compiling if trigger outputs do not have input connected
- MetaSound Document Transform Support
- Fix for for MetaSound Generators not stopping source if failed to create generator due to build errors
#rb phil.popp
#jira UE-112951
#jira UE-116172
#jira UE-116174
#jira UE-116176
#jira UE-116178
#preflight 60b11e7b7e4e6a0001b81c21
#preflight 60b1292d072a1d000164b470

#ROBOMERGE-SOURCE: CL 16502735 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v826-16501804)

[CL 16502750 by rob gay in ue5-main branch]
2021-05-28 14:09:45 -04:00
phil popp
d71686bbee Add ability to incrementally update frontend queries.
#jira UEAU-792
#rb Rob.Gay
#preflight 60afc6b7493080000171898d

#ROBOMERGE-SOURCE: CL 16489196 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v823-16466674)

[CL 16489254 by phil popp in ue5-main branch]
2021-05-27 14:45:41 -04:00
phil popp
ab25da7ed8 MetaSound Graph Core Subgraph
#rb Rob.Gay
#jira UEAU-780
[FYI] Dan.Reynolds
#preflight 60a6af8629bb870001c7b53e

#ROBOMERGE-SOURCE: CL 16408345 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v804-16311228)

[CL 16412437 by phil popp in ue5-main branch]
2021-05-20 19:33:21 -04:00
phil popp
841cfbdd3e Cleanup TAccessPtr
- Moved TAccessPtr<> member accessors to their own implementation file.
- Implemented specific derived classes for TAccessPtr<> to metasound frontend document sturctures.
- Fixed broken unit test
#jira UEAU-780
#rb Rob.Gay
#preflight 6099b8030ab4b200016c89f7

[CL 16259814 by phil popp in ue5-main branch]
2021-05-10 19:52:56 -04:00
Rob Gay
e861882120 - Fix errors from cooking Editor-only content in MetaSounds by marking UMetasoundEditorGraphBase as IsEditorOnly() & !NeedsLoadForEditorGame()
- Make MetaSoundEdGraph transient (never serialized)
- Move FText::FromString calls to concrete FText definitions to avoid warnings while packaging
#rb phil.popp
#jira UE-114986
#preflight 609979f75b1a0b0001529285

[CL 16255509 by Rob Gay in ue5-main branch]
2021-05-10 16:56:43 -04:00
Rob Gay
7a7793e767 Deprecate more AlignedFloatBuffer callsites and use FAlignedFloatBuffer
#rb trivial
#rnx
#preflight 60918ea390631e0001d41516

[CL 16198391 by Rob Gay in ue5-main branch]
2021-05-04 16:05:46 -04:00
Rob Gay
26f0cdd32f Fix null deref
#rb trivial
#jira none
#rnx

[CL 16188981 by Rob Gay in ue5-main branch]
2021-05-04 00:03:58 -04:00
Rob Gay
12abad8cfb Metasound Class Validation & Versioning First Pass
#rb phil.popp
#jira UE-113416
#jira UE-113417
#jira UE-113419
#jira UEAU-781
#preflight 609065b7c4babe0001086600

[CL 16187219 by Rob Gay in ue5-main branch]
2021-05-03 17:52:04 -04:00
rob gay
2f174e3971 Disable MetaSound Trigger:Array type all together
#rb aaron.mcleran
#jira UE-112972
#lockdown nick.whiting

#ROBOMERGE-SOURCE: CL 15986365 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v787-15839533)

[CL 15991431 by rob gay in ue5-main branch]
2021-04-13 12:55:34 -04:00
maxwell hayes
033598badf Metasounds: GetWaveDuration node
#rb Aaron.McLeran
#lockdown nick.whiting
#jira UEAU-751
#preflight 606f2b9cee9b4c0001b81399

#ROBOMERGE-SOURCE: CL 15957520 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v787-15839533)

[CL 15975813 by maxwell hayes in ue5-main branch]
2021-04-12 03:48:54 -04:00
phil popp
5559fd6b97 Reseting send/receive nodes when nothing is hooked up.
#jira UE-111611
#rb rob.gay
#preflight 606dfec368f5bc000140eec0
#lockdown Nick.Whiting

#ROBOMERGE-SOURCE: CL 15945849 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v787-15839533)

[CL 15950053 by phil popp in ue5-main branch]
2021-04-07 22:12:28 -04:00