Commit Graph

114 Commits

Author SHA1 Message Date
aaron mcleran
6eb44a8a3d Fix for looping sounds w/ metasound wave player
#jira UE-119682
#rb rob.gay


#ROBOMERGE-SOURCE: CL 16857098
#ROBOMERGE-BOT: (v836-16769935)

[CL 16857109 by aaron mcleran in ue5-main branch]
2021-07-14 19:13:19 -04:00
rob gay
c21e95a413 IWYU Fix
#rb trivial
#preflight 60ec924b0123b70001bc5eab


#ROBOMERGE-SOURCE: CL 16830250
#ROBOMERGE-BOT: (v836-16769935)

[CL 16830282 by rob gay in ue5-main branch]
2021-07-12 15:44:20 -04:00
rob gay
ade25fa5d3 Fix for ensure when attempting to mark package dirty when building generator/updating via AssetSubsystem
[FYI] phil.popp
#jira UE-118903
#rb trivial
#lockdown jeff.farris


#ROBOMERGE-SOURCE: CL 16775810
#ROBOMERGE-BOT: (v836-16769935)

[CL 16775845 by rob gay in ue5-main branch]
2021-06-24 13:29:50 -04:00
phil popp
4c942021ae Creating metasound archetype registry and upgrade path
#rb Rob.Gay


#ROBOMERGE-SOURCE: CL 16766481
#ROBOMERGE-BOT: (v835-16672529)

[CL 16766487 by phil popp in ue5-main branch]
2021-06-23 20:07:53 -04:00
rob gay
22c4bdec1e IWYU fixes
#rb trivial
#rnx


#ROBOMERGE-SOURCE: CL 16692558
#ROBOMERGE-BOT: (v835-16672529)

[CL 16692587 by rob gay in ue5-main branch]
2021-06-16 14:10:59 -04:00
rob gay
e51ab7198d Minor comment fix-up
#rb trivial


#ROBOMERGE-SOURCE: CL 16689472
#ROBOMERGE-BOT: (v835-16672529)

[CL 16689479 by rob gay in ue5-main branch]
2021-06-16 11:33:28 -04:00
rob gay
4971cd6678 UX Scaffolding for MetaSound Composition/Presets Part 2
- Leverage AssetRegistry/Manager to only load data on MetaSounds required to register (disabled until frontend registry supports this)
- Drag-And-Drop assets on MetaSound Graph
- Move ConvertToPreset to toolbar (WIP, still need to properly hide when clicked instead of closing editor blindly, has issue with refresh)

#rb phil.popp
#preflight 60c9a0a83e1b3c0001335ee7


#ROBOMERGE-SOURCE: CL 16689213
#ROBOMERGE-BOT: (v835-16672529)

[CL 16689237 by rob gay in ue5-main branch]
2021-06-16 11:20:44 -04:00
rob gay
ae25a599f0 Fix for EngineTest caused by changes to UMetaSound/Source/AssetBase.
#rb trivial
[FYI] phil.popp


#ROBOMERGE-SOURCE: CL 16590493
#ROBOMERGE-BOT: (v828-16531559)

[CL 16590499 by rob gay in ue5-main branch]
2021-06-08 14:48:17 -04:00
rob gay
03bf315bff Disable MetaSound Graph Registration for now
#rb trivial
[FYI] phil.popp


#ROBOMERGE-SOURCE: CL 16587324
#ROBOMERGE-BOT: (v828-16531559)

[CL 16587339 by rob gay in ue5-main branch]
2021-06-08 10:57:27 -04:00
rob gay
0e4f7a7c51 MetaSound UI/UX Composition/Preset Scaffolding
- Revive UMetaSound Asset type
- Revive MS Output generation
- Fix copy pasta'ed type name so MetaSound Source shows up properly in editor
- Clean-up to dynamic doc version reporting if required (show the new version number in log)
- Add versioning to update the RootGraphClass name & add DisplayName

MetaSound Registry Scaffolding Part 1 (From Phil Popp)

#rb phil.popp
#jira UE-117108
#jira UE-117109
#jira UE-117110
#preflight 60bf11780c76f90001db5f5f


#ROBOMERGE-SOURCE: CL 16587155
#ROBOMERGE-BOT: (v828-16531559)

[CL 16587204 by rob gay in ue5-main branch]
2021-06-08 10:52:31 -04:00
rob gay
243f360c91 Execute versioning when attempting to build ISoundGenerator from MetaSoundSource in case asset hasn't been versioned & resaved.
#rb trivial
#jira none
[FYI] Phil.Popp

#ROBOMERGE-SOURCE: CL 16503317 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v826-16501804)

[CL 16503321 by rob gay in ue5-main branch]
2021-05-28 16:17:48 -04:00
rob gay
e26ac0345b - Migrate MetaSound InputLiterals to DefaultLiterals housed on FrontendNodes
- Add FrontendGraphBuilder support for generating VariableNodes for DefaultLiterals if no connection is provided on External/Output nodes
- Move node names to be guids (they're never seen by the user and this will be easier to migrate later)
- Fix DisplayName logic to be unique against one another SEPARATELY from node name logic
- Fix for MetaSounds not compiling if trigger outputs do not have input connected
- MetaSound Document Transform Support
- Fix for for MetaSound Generators not stopping source if failed to create generator due to build errors
#rb phil.popp
#jira UE-112951
#jira UE-116172
#jira UE-116174
#jira UE-116176
#jira UE-116178
#preflight 60b11e7b7e4e6a0001b81c21
#preflight 60b1292d072a1d000164b470

#ROBOMERGE-SOURCE: CL 16502735 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v826-16501804)

[CL 16502750 by rob gay in ue5-main branch]
2021-05-28 14:09:45 -04:00
phil popp
ab25da7ed8 MetaSound Graph Core Subgraph
#rb Rob.Gay
#jira UEAU-780
[FYI] Dan.Reynolds
#preflight 60a6af8629bb870001c7b53e

#ROBOMERGE-SOURCE: CL 16408345 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v804-16311228)

[CL 16412437 by phil popp in ue5-main branch]
2021-05-20 19:33:21 -04:00
Rob Gay
5a6f0d0780 Unfortunately, not serializing MetaSound EdGraph member on MetaSound assets is not quite ready for prime time. Reasons:
1. Bug in the synchronization location data
2. Need a representation of comment nodes in Frontend (or subset of editor only data that *is* serialized somehow)
3. Need a representation of how visual input nodes are connected (as there are multiple representations of them) so sync code properly hooks up
#rb trivial

[CL 16330330 by Rob Gay in ue5-main branch]
2021-05-14 11:31:26 -04:00
phil popp
841cfbdd3e Cleanup TAccessPtr
- Moved TAccessPtr<> member accessors to their own implementation file.
- Implemented specific derived classes for TAccessPtr<> to metasound frontend document sturctures.
- Fixed broken unit test
#jira UEAU-780
#rb Rob.Gay
#preflight 6099b8030ab4b200016c89f7

[CL 16259814 by phil popp in ue5-main branch]
2021-05-10 19:52:56 -04:00
Rob Gay
e861882120 - Fix errors from cooking Editor-only content in MetaSounds by marking UMetasoundEditorGraphBase as IsEditorOnly() & !NeedsLoadForEditorGame()
- Make MetaSoundEdGraph transient (never serialized)
- Move FText::FromString calls to concrete FText definitions to avoid warnings while packaging
#rb phil.popp
#jira UE-114986
#preflight 609979f75b1a0b0001529285

[CL 16255509 by Rob Gay in ue5-main branch]
2021-05-10 16:56:43 -04:00
Rob Gay
12abad8cfb Metasound Class Validation & Versioning First Pass
#rb phil.popp
#jira UE-113416
#jira UE-113417
#jira UE-113419
#jira UEAU-781
#preflight 609065b7c4babe0001086600

[CL 16187219 by Rob Gay in ue5-main branch]
2021-05-03 17:52:04 -04:00
phil popp
46ae18b8f3 Fixing missed samples in linear interpolation resampler
#jira UE-113298
#rb Max.Hayes
#lockdown Nick.Whiting

#ROBOMERGE-SOURCE: CL 16014506 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v789-15992632)

[CL 16021833 by phil popp in ue5-main branch]
2021-04-15 11:24:11 -04:00
aaron mcleran
d29f67d7d3 Fix for two sources of NaNs which caused audio dropouts once the NaNs infected reverb and pops in other cases.
#rb Phil.Popp, Maxwell.Hayes
[FYI] Dan.Reynolds
#lockdown Nick.Whiting
#jira UETOP-1052

#ROBOMERGE-SOURCE: CL 15985685 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v787-15839533)

[CL 15989782 by aaron mcleran in ue5-main branch]
2021-04-13 10:35:04 -04:00
nick whiting
7217b8abdd Metasound Waveplayer crash fix.
Attempting to access missing chunk
#jira UE-113190
#lockdown Nick.Whiting

#ROBOMERGE-SOURCE: CL 15970517 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v787-15839533)

[CL 15988786 by nick whiting in ue5-main branch]
2021-04-13 09:38:56 -04:00
phil popp
6dcd8ac785 Only warm cache if wave is streaming
#jira UE-113190
#lockdown Nick.Whiting
#rb Maxwell.Hayes
#preflight 6070c3b807ad160001ecb32a

#ROBOMERGE-SOURCE: CL 15969298 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v787-15839533)

[CL 15988689 by phil popp in ue5-main branch]
2021-04-13 09:32:31 -04:00
phil popp
c78e597994 Looping metasound wave pop fixes
#jira UE-112985
#lockdown Nick.Whiting
[FYI] Sondra.Moyls
#rb Rob.Gay
#preflight 606f7f3ef4a8770001b02b90

#ROBOMERGE-SOURCE: CL 15961683 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v787-15839533)

[CL 15979473 by phil popp in ue5-main branch]
2021-04-12 13:08:39 -04:00
phil popp
7f76e47a04 Fix Metasound pop when looping audio
#jira UE-112985
#lockdown Nick.Whiting
#rb Maxwell.Hayes
#preflight 606f364c812f1500016c558a

#ROBOMERGE-SOURCE: CL 15957930 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v787-15839533)

[CL 15975821 by phil popp in ue5-main branch]
2021-04-12 03:49:32 -04:00
maxwell hayes
033598badf Metasounds: GetWaveDuration node
#rb Aaron.McLeran
#lockdown nick.whiting
#jira UEAU-751
#preflight 606f2b9cee9b4c0001b81399

#ROBOMERGE-SOURCE: CL 15957520 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v787-15839533)

[CL 15975813 by maxwell hayes in ue5-main branch]
2021-04-12 03:48:54 -04:00
aaron mcleran
2cdd4bd23d Fixing metasound waveplayer
- Changing "On Done" and "On Nearly Done" to "On Finished" and "On Nearly Finished" to be consistent with the metasound output trigger. IMO "Done" is better, but it's even better to be consistent.

- Fixed playback progress

- Fixed missed On PLay output trigger

#jira
UE-112564, UE-112565
#rb none
[FYI] Sondra.Moyls
#preflight 6068ea1a086e0a0001703547

#ROBOMERGE-SOURCE: CL 15910753 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15910754 by aaron mcleran in ue5-main branch]
2021-04-03 19:59:23 -04:00