Update to make IsSymlink() return an enum which allows callers to identify whether or not it is implemented for the calling PlatformFile. Also, added appropriate implementation for FPakPlatformFile which was the cause of ensure's on previous submission which was backed-out.
(see review https://p4-swarm.epicgames.net/reviews/23757906 for usage in SolarisEditorModule.cpp)
#rnx
#rb yiliang.siew
#rb brandon.schaefer
#rb calvin.zheng
#rb zack.neyland
#preflight 63d186e0ef20a5272dba95ae
[CL 23863390 by jared cotton in ue5-main branch]
- Creates the UnrealArchitectures class, which wraps a list of UnrealArch objects
- UnrealArch is a single architecture, expandable enum-like struct
- There is no more concept of "no/default architecture", there is always a valid active architecture when building
- Most uses of "string Architecture" are replaced with one of the two above, depending if multiple architectures are supported or not
- UnrealArch has some platform-extensions for platform-specific naming (like Linux adds in LinuxName that turns, for instance, Arm64 -> aarch64-unknown-linux-gnueabi, which is used in folder names, etc)
- UnrealArch has bIsX64 which can be used determine intel instruction set (as opposed to arm)
- TargetRules class has an "Architecture" accessor that will return a single architecture if the active architectures is a single architecture, or throw an exception if multiple. This is useful in a majority of the cases where a paltform can only have a single architecture active in TargetRules (microsoft platforms, for instance, will create separate targets when compiling multiple architectures at once)
- Added UnrealArchitectureConfig class, which contains all the architecture information for a platform (what architectures are supported, what ones are currently active for given project, etc)
#preflight 63c81fb5b065224750a1759e
#rb mike.fricker,roman.dzieciol,joe.kirchoff,dmytro.vovk,brandon.schaefer [various parts]
#p4v-preflight-copy 23562471
[CL 23829977 by josh adams in ue5-main branch]
Addition of 'IsSymlink' to Windows/Unix/Apple platforms. For use case of checking whether installed VSCode Verse-extension is a symlink which is a 'developer' installed version.
(These changes are split out from review 23666969 for review)
#rnx
#rb yiliang.siew
#rb calvin.zheng
#rb brandon.schaefer
#preflight 63c6dcca2e714f64ad4133f8
[CL 23747953 by jared cotton in ue5-main branch]
* UnixCriticalSection - Removed UnrealString include to match windows critical section. Since IWYU is using linux path we don't want unix files to include more than windows files
#preflight 63c1b087b065224750c93fff
#rb Chris.Waters
[CL 23688209 by henrik karlsson in ue5-main branch]
Switch Unix from runtime to compile time cache line constant to avoid loading a value for every PrefetchBlock and allow the compiler to unroll the loop.
#rb josh.adams,arciel.rekman,dmytro.vovk,steve.robb
#preflight 63bed66a577437afe6c44c91
[CL 23660061 by johan torp in ue5-main branch]
#preflight 63b859fc68068a8bd62e9d32
#rb jeff.roberts
#rb fabian.giesen
#rb halfdan.ingvarsson
Tried to run automation tests but it's basically a red board right now. I ran two, one with these changes and one without, and they seem to be basically the same errors, however there are so many and I can't really cross compare easily.
base automation tests: 63b8a5dcaf3ebedd990b7dfe
preflight automation tests: 63b87801221aab21e08d5973
#preflight 63bc93e9577437afe6fbe45a
[CL 23621334 by Dan Thompson in ue5-main branch]
This will cause any syscall *not* in the allow list to cause SIGSYS and then we will exit from our signal handler (unless our signal handler uses a syscall that is not supported in which case we will crash, though a core dump will need to be checked)
Requires explicitly calling this function where you want to actually *setup* the filters:
FPlatformMisc::SetupSyscallFilters();
To use:
-allowsyscallfilterfile=<path/to/allow_filter_file.txt>
Example of file:
read
write
open
mprotect 2 4 0 1
There are only two supported rules for the file:
<syscall_name>
<syscall_name> <syscall_arg_number_zero_based_index> <value> <allow> <check bit only>
#jira UE-169652
#rb Josh.Adams, Robert.Seiver, Calvin.Zheng
#preflight 636d44e81c14fe450503f5cf
[CL 23091532 by brandon schaefer in ue5-main branch]
*Make FPlatformMemory::GetStats cache memory stats per frame to prevent multiple costly platform calls per frame ( by default, has option to request non-cached values ).
*Update some calls to FPlatformMemory::GetStats to specifically request non-cached values.
[REVIEW] [at]evgenii.babinets [at]andrew.ladenberger
#preflight 634a04c0907f4749392d75d0
[CL 22545788 by evgenii babinets in ue5-main branch]
- Implemented priority control on Unix platform
- Refactored RunnableThreadUnix implementation
- Bump resource limits for process scheduling priority (nice) if possible
#rb LouisPhilippe.Seguin, Brandon.Schaefer
[FYI] anrew.ladenberger
[CL 22087348 by anton dunchev in ue5-main branch]
Headers are updated to contain any missing #includes needed to compile and #includes are sorted. Nothing is removed.
#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira
#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf
[CL 21181076 by Bryan sefcik in ue5-main branch]
Updated Core code to not use CoreMinimal.h when possible.
Core public headers still will contain CoreMinimal.h if any included it before my IWYU changes.
#preflight 62c74ed0324817d81488b7ee
[CL 20993420 by bryan sefcik in ue5-main branch]
Core public headers still will contain CoreMinimal.h if any included it before my IWYU changes.
#preflight 62c73594756222ced4e48707
[CL 20991367 by bryan sefcik in ue5-main branch]
Things to note regarding this pass:
* No includes are currently being removed from public headers.
* Any private file that has a #if is currently not being updated.
#preflight 62c703bbd13fac04f11da948
[CL 20985655 by bryan sefcik in ue5-main branch]
### Features
This change enables the StallDetector watchdog in Editor to submit reports to crashreporter about threads violating instrumented deadlines in the source code. This feature was available prior on Windows, and this change adds Linux support.
### Notes
New APIs:
ReportStall()
CaptureThreadPortableCallStack()
Many APIs are updated from purely "Ensure" naming to more general naming. Stalls are more like Ensures than crashes, and so the appropriate renames to make the code readable and clear have been made. In some places Ensure is replaced with the clearer: Continuable Event nomenclature.
### Testing
I synthesized an ensure on Linux, and did the same for a stall. I then compared crash report XML file to make sure they contain accurate data in the callstack, portable callstack, and other fields in the report. I also noted that the stall information was showing as expected in the crash reporter.
#rb brandon.schaefer, francis.hurteau
#jira UETOOL-3336
#preflight 625e20d2804460ab0fea3277
[CL 19911608 by geoff evans in ue5-main branch]
